Re: [PATCH 0/3] Handling DOS drives in mountmgr (try 2)

2009-11-02 Thread Charles Davis
Charles Davis wrote: > Alexandre Julliard wrote: >> Charles Davis writes: >> >>> I thought I fixed all the issues. What's wrong with my patches now? >> Many things, it's a lot more complicated than that. For instance you >> can't just kill the fstab support, this needs to be preserved somehow, >>

Re: mshtml/tests: Fix events test when pointer is on a corner.

2009-11-02 Thread Nicolas Le Cam
2009/10/30 Jacek Caban : > Hi Nicolas, > > Nicolas Le Cam wrote: >> >> Hi Jacek, >> >> Thanks for feedback. >> It should handle pointer in every corners IMHO, the left corner can >> cause failures in winetest. >> >> I'll try to find a better solution. Do you have any hints ? >> > > The test in line

Re: eventlog tests and writing/clearing the logs

2009-11-02 Thread Paul Vriens
On 11/02/2009 05:51 PM, mellery wrote: Hi, Will this involve implementing advapi:RegisterTraceGuidsW, and can I help at all? Thanks, Mike Event tracing is totally different from event logging. Be my guest to pick that up ;) Maybe it's a good idea to split the advapi32/eventlog.c into event

Re: eventlog tests and writing/clearing the logs

2009-11-02 Thread Paul Vriens
On 11/02/2009 05:39 PM, Nikolay Sivov wrote: On Mon, Nov 2, 2009 at 7:35 PM, Paul Vriens wrote: Any thoughts on this? Correct approach? Do you plan to implement a real logging or what all of this is for? If you mean, get functional event logging into Wine, the answer is yes. -- Cheers,

Re: gdi32: add testcases for copying an EMF from a NULL bitmap

2009-11-02 Thread Austin English
On Mon, Nov 2, 2009 at 10:09 AM, Nikolay Sivov wrote: > On Mon, Nov 2, 2009 at 8:27 AM, Austin English > wrote: >> Testcase for bug 4553 > > Are you sure? I don't see any related patches here. > >> >> -- >> -Austin >> > > Why there's no wine failure in this test? Apparently part of the problem

Re: eventlog tests and writing/clearing the logs

2009-11-02 Thread Nikolay Sivov
On Mon, Nov 2, 2009 at 7:35 PM, Paul Vriens wrote: > > Any thoughts on this? Correct approach? > Do you plan to implement a real logging or what all of this is for? > -- > Cheers, > > Paul. >

eventlog tests and writing/clearing the logs

2009-11-02 Thread Paul Vriens
Hi, I'm mostly done with the parameter tests and I'm starting to look what functional tests I can add. The biggest issues I have are: - Writing events needs to go a registered event source - Clearing an eventlog has to be with a registered event source - Registering our own event source can b

Re: gdi32: add testcases for copying an EMF from a NULL bitmap

2009-11-02 Thread Nikolay Sivov
On Mon, Nov 2, 2009 at 8:27 AM, Austin English wrote: > Testcase for bug 4553 Are you sure? I don't see any related patches here. > > -- > -Austin > Why there's no wine failure in this test?

Re: [PATCH 0/3] Handling DOS drives in mountmgr (try 2)

2009-11-02 Thread Charles Davis
Alexandre Julliard wrote: > Charles Davis writes: > >> I thought I fixed all the issues. What's wrong with my patches now? > > Many things, it's a lot more complicated than that. For instance you > can't just kill the fstab support, this needs to be preserved somehow, > probably on the mountmgr

Re: [PATCH 0/3] Handling DOS drives in mountmgr (try 2)

2009-11-02 Thread Charles Davis
Alexandre Julliard wrote: > Charles Davis writes: > >> I thought I fixed all the issues. What's wrong with my patches now? > > Many things, it's a lot more complicated than that. For instance you > can't just kill the fstab support, this needs to be preserved somehow, > probably on the mountmgr

Re: mciwave: Fix copy&paste errors and remove superfluous log.

2009-11-02 Thread Paul Vriens
On 11/02/2009 02:56 PM, joerg-cyril.hoe...@t-systems.com wrote: Hi, - shareable is neither supported nor implemented by waveaudio (other MCIxyz support it); Let mciOpen supply the same error code as MS-Windows. - volatile dwPosition is recommended as the recorder thread callback updates it