Re: msvcrt: do not overlap in strcpy (valgrind) (try 2)

2009-10-30 Thread Vitaliy Margolen
André Hentschel wrote: > > diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c > index 010e1a6..08eaf73 100644 > --- a/dlls/msvcrt/math.c > +++ b/dlls/msvcrt/math.c > @@ -856,7 +856,7 @@ char * CDECL _ecvt( double number, int ndigits, int > *decpt, int *sign ) > snprintf(data->efcvt_buffer,

Re: comctl32/tests: make v6 functions inline

2009-10-30 Thread Nikolay Sivov
2009/10/31 André Hentschel : > So that there are no warnings if tests only use the constant variables in > that header. > --- >  dlls/comctl32/tests/v6util.h |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/comctl32/tests/v6util.h b/dlls/comctl32/tests/v6util.h

Re: [PATCH 0/3] Handling DOS drives in mountmgr (try 2)

2009-10-30 Thread Charles Davis
Charles Davis wrote: > Hi, > > This patch series moves drive handling over to mountmgr. Mountmgr will > now associate UNIX device files directly to its created devices instead > of having ntdll handle converting something like \??\D: to > $WINEPREFIX/dosdevices/d::. This way, we can implement stor

Re: Implement source alpha plus SourceConstantAlpha combined transparency.

2009-10-30 Thread Andrew Eikum
Jaime Rave wrote: Anything wrong with this patch?? It helps a lot in MSN Messenger and some other programs. http://www.winehq.org/pipermail/wine-patches/2009-October/080539.html Jaime Rave Torrres It looks like your patch does two separate things. You should always break your patches up to

Implement source alpha plus SourceConstantAlpha combined transparency.

2009-10-30 Thread Jaime Rave
Anything wrong with this patch?? It helps a lot in MSN Messenger and some other programs. http://www.winehq.org/pipermail/wine-patches/2009-October/080539.html Jaime Rave Torrres

Re: [PATCH] MSI: Shedule rename operation also for ERROR_USER_MAPPED_FILE.

2009-10-30 Thread Hans Leidekker
On Friday 30 October 2009 14:10:27 Michael Martin wrote: > Add check for ERROR_USER_MAPPED_FILE in addition to ERROR_SHARING_VIOLATION > when scheduling a rename operation. ERROR_USER_MAPPED_FILE can be set when > trying to overwrite true type fonts in windows. > For more info see http://support.m

Re: Order of setting audio Play/Pause state and device opening

2009-10-30 Thread Ken Thomases
On Oct 29, 2009, at 9:18 AM, > wrote: In audio.c/wodPause: /* The order of the following operations is important since we can't hold * the mutex while we make an Audio Unit call. Stop the Audio Unit before * setting the PAUSED state. That's indeed what the code below does.

Re: wined3d: recognize Nvidia 8500 GT

2009-10-30 Thread Austin English
On Fri, Oct 30, 2009 at 3:35 AM, Roderick Colenbrander wrote: > We use this mechanism on purpose. We can't have hundreds of cards in > the database. The real name isn't that important it is mostly > cosmetic, so it is not a real bug. It's not that important to me. It seems to me that the reason f

Re: mshtml/tests: Fix events test when pointer is on a corner.

2009-10-30 Thread Jacek Caban
Hi Nicolas, Nicolas Le Cam wrote: Hi Jacek, Thanks for feedback. It should handle pointer in every corners IMHO, the left corner can cause failures in winetest. I'll try to find a better solution. Do you have any hints ? The test in line 472 is invalid. It looks like all we can do is chec

Re: mshtml/tests: Fix events test when pointer is on a corner.

2009-10-30 Thread Nicolas Le Cam
2009/10/30 Jacek Caban : > Hi Nicolas, > > Nicolas Le Cam wrote: >> >> Hi, >> >> Since commit 8272ecd3f2235b923f2ec67bb51d051bdfbf466f I'm having >> errors on events tests. >> >> I just found that it only fails if pointer is on any corner. As I'm >> always putting it on upper right corner when runn

Re: mshtml/tests: Fix events test when pointer is on a corner.

2009-10-30 Thread Jacek Caban
Hi Nicolas, Nicolas Le Cam wrote: Hi, Since commit 8272ecd3f2235b923f2ec67bb51d051bdfbf466f I'm having errors on events tests. I just found that it only fails if pointer is on any corner. As I'm always putting it on upper right corner when running winetest it was always failing for me. Minimi

Re: kernel32/tests: add more tests for Formatmessage{A,W} (try 2)

2009-10-30 Thread Louis Lenders
Hi Louis, These new tests introduce some test failures on several platforms: http://test.winehq.org/data/tests/kernel32:format_msg.html On Win9x/WinMe it seems like just another last error. There seems to be an issue with a particular test when run on a Windows box with no English locale

Re: libsmbclient and wine?

2009-10-30 Thread Kai Blin
On Friday 23 October 2009 22:26:49 Dan Kegel wrote: > Hi folks, > it's often been said that wine can't use libsmbclient because > of license problems. I'd like to look at that assumption a bit. > > - What would wine like to use libsmbclient for, if it could? Reading files from remote systems vi

Re: kernel32/tests: add more tests for Formatmessage{A,W} (try 2)

2009-10-30 Thread Nicolas Le Cam
2009/10/30 Paul Vriens : > On 10/29/2009 01:09 AM, Louis Lenders wrote: >> >> changes: >> >> -fixed typo in ok-call >> -removed FormatMessageW-tests (W behaves same as A) >> -removed useless test for GetLastError in case FormatMessageA succeeds >> >> > > Hi Louis, > > These new tests introduce some

Re: wined3d: recognize Nvidia 8500 GT

2009-10-30 Thread Roderick Colenbrander
We use this mechanism on purpose. We can't have hundreds of cards in the database. The real name isn't that important it is mostly cosmetic, so it is not a real bug. Roderick

Re: kernel32/tests: add more tests for Formatmessage{A,W} (try 2)

2009-10-30 Thread Paul Vriens
On 10/29/2009 01:09 AM, Louis Lenders wrote: changes: -fixed typo in ok-call -removed FormatMessageW-tests (W behaves same as A) -removed useless test for GetLastError in case FormatMessageA succeeds Hi Louis, These new tests introduce some test failures on several platforms: http://test.w