Re: [PATCH 2/5] ddraw/tests: Check some more return values (LLVM/Clang).

2009-10-20 Thread Paul Vriens
On 10/16/2009 10:38 AM, Henri Verbeet wrote: diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c index d9b1c72..9104147 100644 --- a/dlls/ddraw/tests/d3d.c +++ b/dlls/ddraw/tests/d3d.c @@ -961,6 +961,7 @@ static BOOL D3D1_createObjects(void) ddsd.dwWidth = 256; ddsd.dwHeight

valgrind results for 20 October 2009, take 2

2009-10-20 Thread Dan Kegel
This time with today's commits, and skipping ole32/marshal, since that hangs. Results at http://kegel.com/wine/valgrind/logs/2009-10-20-09.31/ There are a few very common errors that I need to file bugs for and then suppress... but there are also quite a large number of valid-looking problems.

Re: comctl32: Scroll listview when performing a marquee selection

2009-10-20 Thread Nikolay Sivov
Owen Rudge wrote: Hi Nikolay, I don't think you need such duplication. Why not to use a single rectangle? Looks like you always offset it to listview origin, so these rectangle differ in offset only, that's why you introduced another iterator_* helper. If I'm right about that it's better to ad

Re: comctl32: Scroll listview when performing a marquee selection

2009-10-20 Thread Owen Rudge
Hi Nikolay, I don't think you need such duplication. Why not to use a single rectangle? Looks like you always offset it to listview origin, so these rectangle differ in offset only, that's why you introduced another iterator_* helper. If I'm right about that it's better to add another OffsetRec

Re: comctl32: Scroll listview when performing a marquee selection

2009-10-20 Thread Nikolay Sivov
Owen Rudge wrote: This patch adds support for scrolling a listview when performing a marquee selection. In Windows, a listview will scroll around when dragging and highlighting icons, picking up speed as you move the mouse further past the window. Hi, Owen. This patch is rather large, so fe

Re: [6/7] ole32: Don't use IEnumSTATSTGImpl to search in CreateStream.

2009-10-20 Thread Vincent Povirk
DOH, looks like I mistitled this one. Should be OpenStream. On Tue, Oct 20, 2009 at 2:51 PM, Vincent Povirk wrote: > > > > > > -- Vincent Povirk

Re: valgrind results for 20 October 2009

2009-10-20 Thread Dan Kegel
On Tue, Oct 20, 2009 at 11:35 AM, Nikolay Sivov wrote: > Unfortunately it seems I don't have --track-origins parameter using 3.3.1. Life is much more fun with that option. I'll post instructions for building valgrind from svn tonight or so. > Do I need any kind of special build with valgrind s

Re: valgrind results for 20 October 2009

2009-10-20 Thread Nikolay Sivov
Dan Kegel wrote: On Tue, Oct 20, 2009 at 7:59 AM, Nikolay Sivov wrote: Could you provide a whole valgrind command line you're using, assuming that I have 3.3.1 not svn build. Try something like cd dlls/ole32/tests valgrind --trace-children=yes --workaround-gcc296-bugs=yes --track-ori

uninitialized memory errors in JScriptParse_ParseScriptText ?

2009-10-20 Thread Dan Kegel
Hi Jacek! Please have a look at http://kegel.com/wine/valgrind/logs/2009-10-20-01.09/vg-jscript_run.txt There are a few interesting errors there. The first one (with a little context from http://kegel.com/wine/valgrind/logs/2009-10-20-01.09.log) is: valgrind ... wine jscript_test.exe.so run.c ..

RFC: Implement CDROM_GetInterfaceInfo() on Mac OS.

2009-10-20 Thread Charles Davis
Hi, This patch will implement CDROM_GetInterfaceInfo() (and its associated IOCTL) on Mac OS X. The problem is that it's big, it's complicated, and it uses I/O Kit. From what I've seen, Alexandre doesn't exactly like I/O Kit that much. Anyway, I want someone to review the patch. No, I could not fi

ws2_32: Use the routing table information for gethostbyname('self') if the magic IP would otherwise be returned. [Try 2]

2009-10-20 Thread Erich Hoover
After looking over my second attempt at this patch I see that I failed to gracefully handle the case when no routes are found. Am I missing anything else here? http://www.winehq.org/pipermail/wine-patches/2009-October/079872.html http://www.winehq.org/pipermail/wine-patches/2009-October/079873.htm

Re: valgrind results for 20 October 2009

2009-10-20 Thread Dan Kegel
On Tue, Oct 20, 2009 at 7:59 AM, Nikolay Sivov wrote: > Could you provide a whole valgrind command line > you're using, assuming that I have 3.3.1 not svn build. Try something like cd dlls/ole32/tests valgrind --trace-children=yes --workaround-gcc296-bugs=yes --track-origins=yes -q ../../../wine

Re: valgrind results for 20 October 2009

2009-10-20 Thread Nikolay Sivov
Austin English wrote: On Tue, Oct 20, 2009 at 9:59 AM, Nikolay Sivov wrote: Dan Kegel wrote: Are you intentionally dropped user32 tests? "ole32/marshal.c hung, so I don't have any results from past that." Ah, sorry. I thought it's separate, each run.

Re: valgrind results for 20 October 2009

2009-10-20 Thread Austin English
On Tue, Oct 20, 2009 at 9:59 AM, Nikolay Sivov wrote: > Dan Kegel wrote: > Are you intentionally dropped user32 tests? "ole32/marshal.c hung, so I don't have any results from past that." -- -Austin

Re: valgrind results for 20 October 2009

2009-10-20 Thread Nikolay Sivov
Dan Kegel wrote: Fresh Valgrind results for the wine conformance tests are available at http://kegel.com/wine/valgrind/logs/2009-10-20-01.09/ This is from about six hours ago, so it doesn't include Alexandre's coming commits for the day. The code was compiled with -O0 -g to give detailed st

valgrind results for 20 October 2009

2009-10-20 Thread Dan Kegel
Fresh Valgrind results for the wine conformance tests are available at http://kegel.com/wine/valgrind/logs/2009-10-20-01.09/ This is from about six hours ago, so it doesn't include Alexandre's coming commits for the day. The code was compiled with -O0 -g to give detailed stacks. The run uses

Re: [PATCH 4/8] msi: Fix merging string type checks.

2009-10-20 Thread Andrew Eikum
Hib Eris wrote: On Tue, Oct 20, 2009 at 3:06 PM, Alexandre Julliard wrote: Surely you don't need StrCmpNW to compare one character... I guess not. This may sound as a stupid question to you, but how should I do it? Can I just do if (type[0] == 's') ? I am a bit worried that this comparison

Re: [PATCH 4/8] msi: Fix merging string type checks.

2009-10-20 Thread Hib Eris
On Tue, Oct 20, 2009 at 3:06 PM, Alexandre Julliard wrote: > Hib Eris writes: > >> +static BOOL merge_type_match(LPCWSTR type1, LPCWSTR type2) >> +{ >> +    const WCHAR szl[] = {'l', 0}; >> +    const WCHAR szs[] = {'s', 0}; >> +    const WCHAR szL[] = {'L', 0}; >> +    const WCHAR szS[] = {'S',

Re: [PATCH 4/8] msi: Fix merging string type checks.

2009-10-20 Thread Alexandre Julliard
Hib Eris writes: > +static BOOL merge_type_match(LPCWSTR type1, LPCWSTR type2) > +{ > +const WCHAR szl[] = {'l', 0}; > +const WCHAR szs[] = {'s', 0}; > +const WCHAR szL[] = {'L', 0}; > +const WCHAR szS[] = {'S', 0}; > + > +if ((!StrCmpNW(type1, szl, 1) || !StrCmpNW(type1, szs,

Re: dlls/winex11.drv/dib.c: initialize two warnings (RESEND)

2009-10-20 Thread Alexandre Julliard
Gerald Pfeifer writes: > I verified that I still need this patch originally sent on May 31st > to address to compiler warings with current versions of GCC 4.5.0. > > This seems to be the only invocation of DIB_GetBitmapInfo which > requires this kind of extra initialization. I expect you can avo

Re: [PATCH 2/2] Moving wprocs.dll16 out of winedos

2009-10-20 Thread Alexandre Julliard
Eric Pouech writes: > .gitignore |1 > configure | 15 > configure.ac|1 > dlls/Makefile.in|6 > dlls/winedos/Makefile.in|3 > dlls/winedos/vxd.c | 1

Re: [PATCH 2/2] hlink: Use HLINKSETF flags in Hlink::fnSetMonikerReference

2009-10-20 Thread Alexandre Julliard
Andrew Eikum writes: > --- > dlls/hlink/hlink_main.c |4 +- > dlls/hlink/link.c| 37 +++--- > dlls/hlink/tests/hlink.c | 98 > ++ > 3 files changed, 123 insertions(+), 16 deletions(-) It breaks the tests: ../../../tools/r

Re: gdi32/font: Prevent possible buffer overrun

2009-10-20 Thread Nikolay Sivov
Dmitry Timoshkov wrote: "Nikolay Sivov" wrote: Reported as http://bugs.winehq.org/show_bug.cgi?id=19819 Changelog: - prevent possible buffer overrun - while (!(*lpSrc>>index & 0x0001) && index>index & 0x0001)) index++; 'index >= MAXTCIINDEX' won't trigger in that case: if (index >=

Re: [4/9] WineD3D: Use the shader backend reported constant limit outside the shader backend

2009-10-20 Thread Henri Verbeet
2009/10/20 Stefan Dösinger : > -static void stateblock_savedstates_set_all(SAVEDSTATES *states, const struct > wined3d_gl_info *gl_info) > +static void stateblock_savedstates_set_all(SAVEDSTATES *states, const > IWineD3DDeviceImpl *device) Please don't do that.

Re: Trying to fix some setupapi tests on Win9x/WinMe

2009-10-20 Thread Paul Vriens
On 10/20/2009 10:37 AM, Hans Leidekker wrote: On Tuesday 20 October 2009 10:07:07 am Paul Vriens wrote: In an effort to get everything green I'm trying to fix some long standing setupapi test failures. In one of the tests, test_SetupDecompressOrCopyFile() in misc.c, we call SetupDecompressOrCo

mciwave: need to serialize record and play

2009-10-20 Thread Joerg-Cyril.Hoehle
Eric, I've not yet tested your patches but I thought to additionaly use STATUS_NOT_READY as an intermittent marker for work in progress, so other threads know something is going on and don't pull the carpet under the feet. What do you think? E.g. play; play from 0; play from 1000; play from 0; se

[PATCH 16/14] winmm: MCI Close all causes one notification per open driver.

2009-10-20 Thread Joerg-Cyril.Hoehle
Paul Vriens asked: >Do all you previous patches still apply after several commits (patches >from Eric)? >I see that for now only "winecoreaudio: Move ERR&WARN out of OSSpinLock >sections" is applied. I don't know. They applied on git as it was over the week end. If there's a problem, I'll not be

Re: Trying to fix some setupapi tests on Win9x/WinMe

2009-10-20 Thread Hans Leidekker
On Tuesday 20 October 2009 10:07:07 am Paul Vriens wrote: > In an effort to get everything green I'm trying to fix some long > standing setupapi test failures. > > In one of the tests, test_SetupDecompressOrCopyFile() in misc.c, we call > SetupDecompressOrCopyFileA a few times. One of them fail

Trying to fix some setupapi tests on Win9x/WinMe

2009-10-20 Thread Paul Vriens
Hi, In an effort to get everything green I'm trying to fix some long standing setupapi test failures. In one of the tests, test_SetupDecompressOrCopyFile() in misc.c, we call SetupDecompressOrCopyFileA a few times. One of them fails as the target file is still open and doesn't allow reading

Re: Playing ULAW sample correctly?

2009-10-20 Thread Joerg-Cyril.Hoehle
Hi, >IIRC, I never tested µ-law wave file, so it may well be that the ACM >converter is broken What is the policy for including sample multimedia files in Wine? E.g., I remember tests being skipped because msrle.avi is not present: http://www.winehq.org/pipermail/wine-devel/2008-October/070112.h