Re: winecoreaudio: Move ERR&WARN out of OSSpinLock sections.

2009-10-19 Thread Vitaliy Margolen
joerg-cyril.hoe...@t-systems.com wrote: > Still a few occurances left in wid* functions. > Also, HeapFree occurs in such sections (which may also cause logging). > This is not unsafe as it is no requirement that spinlock sections should be > quick. It's just adequate when contention is presumed lo

Re: dinput: Fix counting non maped axis as pov [try 2]

2009-10-19 Thread Vitaliy Margolen
Ričardas Barkauskas wrote: > This time with patch. Sorry. > Fixes crash with dinput joystick test and pcsx2 lilypad plugin on my system.. > > -else if (tokens < 15) > +else if (tokens >=8 && tokens < 15) Nice catch, this is indeed a bug when token == -1. Vitaliy.

Re: gdi32/font: Prevent possible buffer overrun

2009-10-19 Thread Dmitry Timoshkov
"Nikolay Sivov" wrote: Reported as http://bugs.winehq.org/show_bug.cgi?id=19819 Changelog: - prevent possible buffer overrun - while (!(*lpSrc>>index & 0x0001) && index>index & 0x0001)) index++; 'index >= MAXTCIINDEX' won't trigger in that case: if (index >= MAXTCIINDEX || FONT_tci[i

Re: [PATCH 3/5] [WinMM]: allow 32-bit mciLoadCommandResource to load out of 16 bit module

2009-10-19 Thread Alexandre Julliard
Eric Pouech writes: > Alexandre Julliard a écrit : >> Eric Pouech writes: >> >> >>> @@ -1566,7 +1554,41 @@ UINT WINAPI mciLoadCommandResource(HINSTANCE hInst, >>> LPCWSTR resNameW, UINT type) >>> if (!(hRsrc = FindResourceW(hInst, resNameW, (LPWSTR)RT_RCDATA))) { >>> WARN("No comman

CPPCheck for Monday October 19th

2009-10-19 Thread chris ahrendt
Errors: [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd Tools Errors: [/home/cahrendt/wine-

Re: Playing ULAW sample correctly?

2009-10-19 Thread Eric Pouech
joerg-cyril.hoe...@t-systems.com a écrit : Hi, Using the MCI, I've successfully played an ADPCM sample from Wikipedia, except at the very end of IMA ADPCM play: fixme:wavemap:wodWrite Not all src buffer has been written, expect bogus sound After play status length increased from 13813 to 13826!

Re: [PATCH 3/5] [WinMM]: allow 32-bit mciLoadCommandResource to load out of 16 bit module

2009-10-19 Thread Eric Pouech
Alexandre Julliard a écrit : Eric Pouech writes: @@ -1566,7 +1554,41 @@ UINT WINAPI mciLoadCommandResource(HINSTANCE hInst, LPCWSTR resNameW, UINT type) if (!(hRsrc = FindResourceW(hInst, resNameW, (LPWSTR)RT_RCDATA))) { WARN("No command table found in resource\n"); } els

Playing ULAW sample correctly?

2009-10-19 Thread Joerg-Cyril.Hoehle
Hi, Using the MCI, I've successfully played an ADPCM sample from Wikipedia, except at the very end of IMA ADPCM play: fixme:wavemap:wodWrite Not all src buffer has been written, expect bogus sound After play status length increased from 13813 to 13826! How comes? However, playing an ULAW sample,

Re: [PATCH 03/14] mciwave: Do not lie about state when winmm fails in Pause or Resume.

2009-10-19 Thread Christian Gmeiner
Patch is missing -- Christian Gmeiner, MSc

PATCH 0/14 mciwave aka. waveaudio patches

2009-10-19 Thread Joerg-Cyril.Hoehle
Hi, Here's a series of patches to fix various bugs and increase compatibility. Alas, it is only yesterday night that I discovered that mciwave will only record samples in multiples of 333 milliseconds (from using 3 buffers / second). Thus in my testsuite, the comparisons against 2000ms give fl

Re: Make RenderTextureEmulation configurable

2009-10-19 Thread Roderick Colenbrander
On Mon, Oct 19, 2009 at 1:08 PM, Ove Kaaven wrote: > Roderick Colenbrander skrev: >> On Mon, Oct 19, 2009 at 12:45 AM, Austin English >> wrote: >>> On Sun, Oct 18, 2009 at 1:50 PM, James McKenzie >>> wrote: Ove Kaaven wrote: > This makes it possible to work around bug 10080 without havi

Re: Make RenderTextureEmulation configurable

2009-10-19 Thread Ove Kaaven
Roderick Colenbrander skrev: > On Mon, Oct 19, 2009 at 12:45 AM, Austin English > wrote: >> On Sun, Oct 18, 2009 at 1:50 PM, James McKenzie >> wrote: >>> Ove Kaaven wrote: This makes it possible to work around bug 10080 without having to patch the source code. >>> This is a hack to

Re: [PATCH 1/4] comctl32/tooltips: Fix an obviously wrong structure size check (try2)

2009-10-19 Thread Nikolay Sivov
Paul Vriens wrote: On 10/15/2009 12:59 PM, Nikolay Sivov wrote: Changelog: - try2: fixed usage of W calls in tests, fixed some typos - fix an obviously wrong structure size check Hi Nikolay, I have been checking the failures for these tests. At first I just wanted to add some brok

Re: Make RenderTextureEmulation configurable

2009-10-19 Thread Roderick Colenbrander
On Mon, Oct 19, 2009 at 10:03 AM, Roderick Colenbrander wrote: > On Mon, Oct 19, 2009 at 12:45 AM, Austin English > wrote: >> On Sun, Oct 18, 2009 at 1:50 PM, James McKenzie >> wrote: >>> Ove Kaaven wrote: This makes it possible to work around bug 10080 without having to patch the sour

Re: [PATCH 3/5] [WinMM]: allow 32-bit mciLoadCommandResource to load out of 16 bit module

2009-10-19 Thread Alexandre Julliard
Eric Pouech writes: > @@ -1566,7 +1554,41 @@ UINT WINAPI mciLoadCommandResource(HINSTANCE hInst, > LPCWSTR resNameW, UINT type) > if (!(hRsrc = FindResourceW(hInst, resNameW, (LPWSTR)RT_RCDATA))) { > WARN("No command table found in resource\n"); > } else if ((hMem = LoadResource(

Re: [PATCH 1/4] comctl32/tooltips: Fix an obviously wrong structure size check (try2)

2009-10-19 Thread Paul Vriens
On 10/15/2009 12:59 PM, Nikolay Sivov wrote: Changelog: - try2: fixed usage of W calls in tests, fixed some typos - fix an obviously wrong structure size check Hi Nikolay, I have been checking the failures for these tests. At first I just wanted to add some broken() statements. L

Re: Patch for bug 20227: msi: Table Join on two tables that have same (non-join) column name...

2009-10-19 Thread Hans Leidekker
On Monday 19 October 2009 04:19:07 Nathan Gallaher wrote: > Resubmit of patch. > > Patch separated into test and fix components. > Patch rebased. > tableName variable --> table_name > Commented code removed. > Unused variables removed > Unnecessary debug printf's removed. Looks good, please subm

Re: Make RenderTextureEmulation configurable

2009-10-19 Thread Roderick Colenbrander
On Mon, Oct 19, 2009 at 12:45 AM, Austin English wrote: > On Sun, Oct 18, 2009 at 1:50 PM, James McKenzie > wrote: >> Ove Kaaven wrote: >>> This makes it possible to work around bug 10080 without having to patch >>> the source code. >>> >> This is a hack to allow a work around to function.  Much

wine-devel@winehq.org

2009-10-19 Thread Markus Stockhausen
Hi, maybe someone with deeper ACM knowledge can help me out. If I understand the above call correctly it should give the size of the largest WAVEFORMATEX structure of any driver. This should be more or less the maximum number of each second DWORD in the registry in the key Software \Microsoft\Audi