Re: Patch for bug 20227: msi: Table Join on two tables that have same (non-join) column name...

2009-10-18 Thread Nathan Gallaher
Resubmit of patch. Patch separated into test and fix components. Patch rebased. tableName variable --> table_name Commented code removed. Unused variables removed Unnecessary debug printf's removed. Thanks for the review, ~Nate On Thu, 1 Oct 2009, Hans Leidekker wrote: Hi Nate, Your patch a

Have a feeling that the alsa cheese has been moved

2009-10-18 Thread Susan Cragin
After using alsa very happily for several days or weeks, it no longer works for me. Changes I have noticed between the daily builds of 10/1 and 10/13 indicate that Ubuntu is working on alsa, and making changes. In the past, with my program, here's what happened. When sound didn't work, winecf

Re: Make RenderTextureEmulation configurable

2009-10-18 Thread Austin English
On Sun, Oct 18, 2009 at 1:50 PM, James McKenzie wrote: > Ove Kaaven wrote: >> This makes it possible to work around bug 10080 without having to patch >> the source code. >> > This is a hack to allow a work around to function.  Much better to > actually fix the problem permanently. This is direct3

Re: Make RenderTextureEmulation configurable

2009-10-18 Thread James McKenzie
Ove Kaaven wrote: > This makes it possible to work around bug 10080 without having to patch > the source code. > This is a hack to allow a work around to function. Much better to actually fix the problem permanently. Also, it is preferred to preface your patch with the affected area like this

Re: [1/1]oleaut32: Fix Testcases on NT4 and lower

2009-10-18 Thread Wilfried Pasquazzo
2009/10/16 Nikolay Sivov : > Wilfried Pasquazzo wrote: >> >> A fix for my testcases of IPicture_Render method. >> >> affected files: oleaut32/tests/olepicture.c >> >> On older OS than Win2000 the testcase produces different results. >> The method IPicture_Render isn't officially supported on those

Re: Debugging Xfire: need help

2009-10-18 Thread Stefan Dösinger
Am 18.10.2009 um 16:24 schrieb Warren Dumortier: I don't think it's worth to be tested, because if Xfire doesn't crash (simply by not interacting with it) games are detected. However i will try it, who knows! ;) An easier way to test is probably to disable Xfire In-Game, if you find out how

Re: Debugging Xfire: need help

2009-10-18 Thread Stefan Dösinger
Am 18.10.2009 um 15:02 schrieb Warren Dumortier: Xfire was working until version 1.104, but since then it crashed on every Wine version, so the Xfire update broke it under Wine. Here's the problem: Xfire crashes every time you interact with it's GUI, well most of the time... When using the

Debugging Xfire: need help

2009-10-18 Thread Warren Dumortier
Xfire was working until version 1.104, but since then it crashed on every Wine version, so the Xfire update broke it under Wine. Here's the problem: Xfire crashes every time you interact with it's GUI, well most of the time... When using the keyboard it crashes sometimes, but when using the mouse

RE: Towards leveraging app build and unit tests as a way to test wine

2009-10-18 Thread Nicklas Börjesson
> The name's not that important,though, tbh... In my experience, good names and structures are really important, since stuff like this inevitably grows. And confused newbies needs more explanations than necessary. And other people gets confused too. :-) Anyway, something like this, perhaps? w

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-18 Thread Alexandre Julliard
Jeremy White writes: > Alexandre Julliard wrote: >> Yes, and even that may not be enough, it may have to be limited further >> to some very specific cases. >> > How do we go about identifying those specific cases? Should > we start with a list of dlls (with one entry in the list - riched20)?

Re: SCSITaskDevice vs our own driver

2009-10-18 Thread Alexandre Julliard
Steven Edwards writes: > On Sat, Oct 17, 2009 at 12:39 PM, Alexandre Julliard > wrote: >>> 1. Use the SCSITaskDevice interface. This is a CFPlugIn object provided >>> by the driver (it's like a COM object). We have to get exclusive access >>> (this requires all the handles to all device files to