Re: Towards leveraging app build and unit tests as a way to test wine

2009-10-17 Thread Austin English
On Sat, Oct 17, 2009 at 10:24 AM, Dan Kegel wrote: > On Fri, Oct 16, 2009 at 10:30 PM, Austin English > wrote: >> On Sat, Oct 17, 2009 at 12:12 AM, Dan Kegel wrote: >>> If anyone's interested, I can provide precompiled versions >>> of more of Chromium's test suite.  Finding Wine bugs with >>> th

Re: SCSITaskDevice vs our own driver

2009-10-17 Thread Charles Davis
James McKenzie wrote: > Charles Davis wrote: >> Alexandre Julliard wrote: >> >>> Charles Davis writes: >>> >>> Eventually, I want to implement IOCTL_SCSI_PASS_THOROUGH on Mac OS. The way I see it, there are two ways to do this: 1. Use the SCSITaskDevice interface. This

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-17 Thread Jeremy White
Alexandre Julliard wrote: Dan Kegel writes: OK, so even on an absolute path, we need to do a version check, and only use the bundled copy if it's newer than builtin? (That's what I thought you meant earlier.) Yes, and even that may not be enough, it may have to be limited further to

Re: SCSITaskDevice vs our own driver

2009-10-17 Thread Charles Davis
Steven Edwards wrote: > On Sat, Oct 17, 2009 at 12:39 PM, Alexandre Julliard > wrote: >>> 1. Use the SCSITaskDevice interface. This is a CFPlugIn object provided >>> by the driver (it's like a COM object). We have to get exclusive access >>> (this requires all the handles to all device files to be

Re: SCSITaskDevice vs our own driver

2009-10-17 Thread Charles Davis
Alexandre Julliard wrote: > Charles Davis writes: > >> Eventually, I want to implement IOCTL_SCSI_PASS_THOROUGH on Mac OS. The >> way I see it, there are two ways to do this: >> >> 1. Use the SCSITaskDevice interface. This is a CFPlugIn object provided >> by the driver (it's like a COM object). W

Re: SCSITaskDevice vs our own driver

2009-10-17 Thread Steven Edwards
On Sat, Oct 17, 2009 at 12:39 PM, Alexandre Julliard wrote: >> 1. Use the SCSITaskDevice interface. This is a CFPlugIn object provided >> by the driver (it's like a COM object). We have to get exclusive access >> (this requires all the handles to all device files to be closed, and the >> disk unmo

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-17 Thread Dan Kegel
On Sat, Oct 17, 2009 at 12:12 PM, James McKenzie wrote: > Let's stick a fork in this conversation for a moment and think about > what we are saying here: > > Office 2007 comes with an 'improved' richedit handing set of files, > riched20.dll and riched32.dll which function drastically different fro

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-17 Thread James McKenzie
Dan Kegel wrote: > On Fri, Feb 27, 2009 at 3:02 PM, Dylan Smith wrote: > >>> Say, have we considered making riched20 prefer native? >>> That makes the app work, too. >>> >> A couple of things to note, in case they are relevant: >> 1. msftedit currently uses the native version by default

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-17 Thread Alexandre Julliard
Dan Kegel writes: > OK, so even on an absolute path, we need to do a version > check, and only use the bundled copy if it's newer > than builtin? (That's what I thought you meant earlier.) Yes, and even that may not be enough, it may have to be limited further to some very specific cases. --

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-17 Thread Dan Kegel
On Sat, Oct 17, 2009 at 9:35 AM, Alexandre Julliard wrote: >> I think if we get a loadlibrary on an explicit private path, we should load >> that dll natively, even if we have a builtin dll of the same name. > > No, you don't want that. There are cases of apps shipping with their own > copy of sys

Re: SCSITaskDevice vs our own driver

2009-10-17 Thread Alexandre Julliard
Charles Davis writes: > Eventually, I want to implement IOCTL_SCSI_PASS_THOROUGH on Mac OS. The > way I see it, there are two ways to do this: > > 1. Use the SCSITaskDevice interface. This is a CFPlugIn object provided > by the driver (it's like a COM object). We have to get exclusive access > (t

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-17 Thread Alexandre Julliard
Jeremy White writes: > Dan Kegel wrote: >> I think your approach is peachy, but Alexandre wanted a version >> check; look at his most recent post in this thread: >> > Alexandre wanted a version check when asked a different question. > That question > was when would we prefer an available nativ

Question -- Did Friday's git cause anyone sound problems on re-boot?

2009-10-17 Thread Susan Cragin
I built and installed Friday's git, installed DNS and ran it without a problem, then re-booted and my sound had vanished. It does not appear to be a problem with my sound modules loading, or a conflict with pulseaudio (which I kill anyway). Alsamixer settings have been adjusted to the proper l

Re: SCSITaskDevice vs our own driver

2009-10-17 Thread Ken Thomases
On Oct 16, 2009, at 6:01 PM, Charles Davis wrote: Eventually, I want to implement IOCTL_SCSI_PASS_THOROUGH on Mac OS. The way I see it, there are two ways to do this: 1. Use the SCSITaskDevice interface. This is a CFPlugIn object provided by the driver (it's like a COM object). We have to g

Re: winecoreaudio: Quiet a noisy FIXME.

2009-10-17 Thread Ken Thomases
On Oct 16, 2009, at 10:26 PM, Peter Dons Tychsen wrote: On Thu, 2009-10-15 at 19:19 -0500, Ken Thomases wrote: +static int once; + +if (!once++) FIXME("independent left/right volume not implemented (%f, %f)\n", left, right); I know it is a detail, but is it not a bit misleading hav

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-17 Thread Roderick Colenbrander
On Sat, Oct 17, 2009 at 5:22 PM, Dan Kegel wrote: > On Sat, Oct 17, 2009 at 6:31 AM, Jeremy White wrote: >> Alexandre wanted a version check when asked a different question.  That >> question >> was when would we prefer an available native Richedit over the builtin one. >> (i.e. in the LoadLibrar

Re: Towards leveraging app build and unit tests as a way to test wine

2009-10-17 Thread Dan Kegel
On Fri, Oct 16, 2009 at 10:30 PM, Austin English wrote: > On Sat, Oct 17, 2009 at 12:12 AM, Dan Kegel wrote: >> If anyone's interested, I can provide precompiled versions >> of more of Chromium's test suite.  Finding Wine bugs with >> these isn't quite like shooting fish in a barrel, but it's clo

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-17 Thread Dan Kegel
On Sat, Oct 17, 2009 at 6:31 AM, Jeremy White wrote: > Alexandre wanted a version check when asked a different question.  That > question > was when would we prefer an available native Richedit over the builtin one. > (i.e. in the LoadLibrary("riched20") case). Looking back at the bug, that one u

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-17 Thread Jeremy White
Dan Kegel wrote: I think your approach is peachy, but Alexandre wanted a version check; look at his most recent post in this thread: Alexandre wanted a version check when asked a different question. That question was when would we prefer an available native Richedit over the builtin one. (i

Re: winecoreaudio: Quiet a noisy FIXME.

2009-10-17 Thread Peter Dons Tychsen
On Thu, 2009-10-15 at 19:19 -0500, Ken Thomases wrote: > +static int once; > + > +if (!once++) FIXME("independent left/right volume not implemented > (%f, %f)\n", left, right); I know it is a detail, but is it not a bit misleading having a variable called "once" when it will trigger the co