Re: Bug 6971 in RedOrchestra Game.

2009-10-12 Thread James McKenzie
Loren Kraushar wrote: > Ok Just trying to put it out there I have seen endless sights for this > one problem and still no consistent fix. I was trying to see if you > geniuses could throw it in on the next fixed issues list. > > Thank you for the response master. Please keep the sarcasm to a mimim

Re: IsWindowUnicode() is always true after RegisterClassW

2009-10-12 Thread Dmitry Timoshkov
"Nikolay Sivov" wrote: Next question if you don't mind: IsWindowUnicode() for Wine created common controls window handles will always return TRUE, so I could easily drop such checks? Subclassing a window may change that. There is a bunch of IsWindowUnicode() tests in dlls/user32/tests/win.c

Re: IsWindowUnicode() is always true after RegisterClassW

2009-10-12 Thread Nikolay Sivov
Alexandre Julliard wrote: Nikolay Sivov writes: The question is how could I handle CB_GETLBTEXT properly for ComboEx? For Combobox it's obvious cause we know is it unicode or not, for Comboex caller should rely on IsWindowUnicode() for this control for buffer format or what? Any thoughts h

Re: Ballooning "dlls" folder

2009-10-12 Thread Alexandre Julliard
Erich Hoover writes: > With the separation of the 16-bit APIs recently, the "dlls" folder has > ballooned quite a bit. Is there any particular reason that the 16-bit and > 32-bit DLLs are not in separate folders? I don't think the number of dlls is an issue, it's a small fraction of the total a

Re: IsWindowUnicode() is always true after RegisterClassW

2009-10-12 Thread Alexandre Julliard
Nikolay Sivov writes: > The question is how could I handle CB_GETLBTEXT properly for ComboEx? > For Combobox it's obvious cause > we know is it unicode or not, for Comboex caller should rely on > IsWindowUnicode() for this control for buffer format or what? > > Any thoughts how to deal with this

Re: Help me get a patch into Wine

2009-10-12 Thread Charles Davis
Keith Muir wrote: > Charles Davis wrote: >> Damn it, I keep forgetting to reply all. >> >> Charles Davis wrote: >> >>> Vitaliy Margolen wrote: >>> Charles Davis wrote: > Hi, > > My name is Charles Davis, but you all can call me "Chip". > > I'm new to Win

Re: CPP Check 1.1.31

2009-10-12 Thread Michael Stefaniuc
On 10/12/2009 10:36 PM, James McKenzie wrote: Nikolay Sivov wrote: James McKenzie wrote: Nikolay Sivov wrote: James McKenzie wrote: Nikolay Sivov wrote: chris ahrendt wrote: [/home/cahrendt/wine-git/dlls/kernel32/resource.c:1279]: (error) Division by zero False positive I suppose: -

Re: CPP Check 1.1.31

2009-10-12 Thread James McKenzie
Nikolay Sivov wrote: > James McKenzie wrote: >> Nikolay Sivov wrote: >> >>> James McKenzie wrote: >>> Nikolay Sivov wrote: > chris ahrendt wrote: > >> [/home/cahrendt/wine-git/dlls/kernel32/resource.c:1279]: (error) >> Division by zero >>

Re: ddraw.c: avoid memory overwrite in GetDeviceIdentifier()

2009-10-12 Thread Stefan Dösinger
> diff --git a/dlls/ddraw/tests/visual.c b/dlls/ddraw/tests/visual.c > index 450d231..645fa8d 100644 > --- a/dlls/ddraw/tests/visual.c > +++ b/dlls/ddraw/tests/visual.c The visual.c file doesn't seem quite right for this test. There's no really matching file, but I think ddrawmodes.c is better,

Re: CPP Check 1.1.31

2009-10-12 Thread Nikolay Sivov
James McKenzie wrote: Nikolay Sivov wrote: James McKenzie wrote: Nikolay Sivov wrote: chris ahrendt wrote: [/home/cahrendt/wine-git/dlls/kernel32/resource.c:1279]: (error) Division by zero False positive I suppose: --- static const BYTE p

Re: CPP Check 1.1.31

2009-10-12 Thread Nikolay Sivov
James McKenzie wrote: Nikolay Sivov wrote: chris ahrendt wrote: [/home/cahrendt/wine-git/dlls/kernel32/resource.c:1279]: (error) Division by zero False positive I suppose: --- static const BYTE pad[] = { 'P','A','D','D','I','N','G','X','X','P','A','D','D','I','N','

IsWindowUnicode() is always true after RegisterClassW

2009-10-12 Thread Nikolay Sivov
Is it ok that IsWindowUnicode() returns 1 for windows created with -A calls? I've just another unrelated issue for Comboex and spotted then I'm apparently using unicode window (as reported by this call). But it was created with --- CreateWindowExA and class WC_COMBOBOXEXA --- Currently comboex

Re: Requesting comments on patchset to fix Bug 7929 (C&C 3 network does not work)

2009-10-12 Thread Alexandre Julliard
Erich Hoover writes: > Maybe I'm missing something, but the only case I found that required extra > wineserver work was for handling asynchronous ReadFile requests (since these > requests don't go through the ws2_32 path, see patch 6). Using ReadFile > like that is technically something you're n

Re: comctl32: Remove trailing spaces in propsheet.c

2009-10-12 Thread James McKenzie
Ričardas Barkauskas wrote: > Remove trailing spaces in comctl32's propsheet.c. > > These types of patches are highly discouraged unless this is causing a breakage with your compiler. If there is a breakage, file a bug with this patch attached for comments. Trailing spaces are not a problem wit

Re: Wine MSSQL VB

2009-10-12 Thread Nikolay Sivov
kumaresan c wrote: Thanks. You are right. As per that code there is no need to create DSN. But I can't access even by creating DSN under wine and modify the connection code as follows Db.open "DSN=ForLinux; User Id=sa; Password=kumaresan" Ok, How to check wheth

Re: Wine MSSQL VB

2009-10-12 Thread Nikolay Sivov
kumaresan c wrote: I have a program that accesses Mssql 2000 database from Windows 2003 server. Now I need to run this program in Linux. I setup wine, mdac28 etc. I can install the program with one error: ODBC's SQLRemoveDriverManager Failed. I can also create a sys

Re: ddraw.c: avoid memory overwrite in GetDeviceIdentifier()

2009-10-12 Thread Reece Dunn
+ * Fill result structure element by element to avoid memory overwrites + * du to size alignment. That should be "*due* to size alignment." - Reece

Re: Help me get a patch into Wine

2009-10-12 Thread Charles Davis
Damn it, I keep forgetting to reply all. Charles Davis wrote: > Vitaliy Margolen wrote: >> Charles Davis wrote: >>> Hi, >>> >>> My name is Charles Davis, but you all can call me "Chip". >>> >>> I'm new to Wine development, and frankly, I'm kinda scared because I've >>> heard and read that getting

Re: Help me get a patch into Wine

2009-10-12 Thread Charles Davis
Oops, forgot to reply all. Charles Davis wrote: > James McKenzie wrote: >> Charles Davis wrote: >>> Hi, >>> >>> My name is Charles Davis, but you all can call me "Chip". >>> >>> I'm new to Wine development, and frankly, I'm kinda scared because I've >>> heard and read that getting patches into Win

Wine MSSQL VB

2009-10-12 Thread kumaresan c
I have a program that accesses Mssql 2000 database from Windows 2003 server. Now I need to run this program in Linux. I setup wine, mdac28 etc. I can install the program with one error: ODBC's SQLRemoveDriverManager Failed. I can also create a system DSN in Linux using

Re: [PATCH 07/11] Revert "winmm: Test opening the same device twice."

2009-10-12 Thread Robert Reif
Alexandre Julliard wrote: Ken Thomases writes: This reverts commit 6a7127bfc201ff7a218795c239d5b2571ea413d7 and part of 9f32c0d9d60662ac8e00ce5cbd4aebd4fdf8dc89. It turns out that the issue isn't a limitation of winmm. It's just individual low-level drivers that may fail to support openin

Re: help with native test: GetDeviceIdentifier() memory overwrite

2009-10-12 Thread Dmitry Timoshkov
"Markus Stockhausen" wrote: Thanks to Dimitry I have changed the test. Maybe someone could check if the attached one works in native while it fails in my Wine environment. New test passes under XP. -- Dmitry.

help with native test: GetDeviceIdentifier() memory overwrite

2009-10-12 Thread Markus Stockhausen
Thanks to Dimitry I have changed the test. Maybe someone could check if the attached one works in native while it fails in my Wine environment. Thanks a lot in advance. Markus diff --git a/dlls/ddraw/tests/visual.c b/dlls/ddraw/tests/visual.c index 450d231..650f4ba 100644 --- a/dlls/ddraw/tests/

Re: [PATCH] (resubmit) winegcc: free link_args (Coverity)

2009-10-12 Thread Alexandre Julliard
Marcus Meissner writes: > Coverity spotted we do not free link_args, so just free them. > > (I know its a small cleanup issue, just to get this off my and > coveritys radar ;) The program is exiting at that point, freeing memory is a waste of time. -- Alexandre Julliard julli...@winehq.org

Re: msadp32: Do not enumerate 8bit PCM formats, they cannot be converted.

2009-10-12 Thread Joerg-Cyril.Hoehle
>> I found it illogical to advertise unusable 8bit formats. But >>I did not cross check whether MS-Windows would do so. Indeed, MS-Windows advertises both 8 and 16 bit formats. Jeff Zaroyko kindly supplied me with winetest results ran with WINETEST_INTERACTIVE=1 on MS-Windows Vista. The msacm te

Re: d3dx11_42: Stub implementation

2009-10-12 Thread Nikolay Sivov
Ričardas Barkauskas wrote: Allows pcsx2 r1888 gsdx plugin to start and try to execute in dx9 mode. Ričardas Barkauskas REalm + * Direct3D X 10 main file Eleventh maybe?

Re: [PATCH 07/11] Revert "winmm: Test opening the same device twice."

2009-10-12 Thread Alexandre Julliard
Ken Thomases writes: > This reverts commit 6a7127bfc201ff7a218795c239d5b2571ea413d7 and part of > 9f32c0d9d60662ac8e00ce5cbd4aebd4fdf8dc89. > > It turns out that the issue isn't a limitation of winmm. It's just > individual low-level drivers that may fail to support opening the device > twice.

Re: Bug 6971 in RedOrchestra Game.

2009-10-12 Thread Roderick Colenbrander
No, it won't break OSX and other systems since we have to support both xinput 1.2 and the legacy code. Roderick On Mon, Oct 12, 2009 at 4:00 AM, James McKenzie wrote: > Roderick Colenbrander wrote: >> Hi, >> >> First of all wine-patches is the list to which patches are submitted >> for inclusion