Re: Help me get a patch into Wine

2009-10-11 Thread Vitaliy Margolen
Charles Davis wrote: > Hi, > > My name is Charles Davis, but you all can call me "Chip". > > I'm new to Wine development, and frankly, I'm kinda scared because I've > heard and read that getting patches into Wine is very difficult. In > fact, every time I got ready to send this first patch, I chi

Re: Bug 6971 in RedOrchestra Game.

2009-10-11 Thread James McKenzie
Roderick Colenbrander wrote: > Hi, > > First of all wine-patches is the list to which patches are submitted > for inclusion in Wine, it is not meant as a user discussion list. > Questions like the one you asked belong on wine-devel. > > Bug 6971 is an old Wine bug and is hard to fix. Now that xserv

Re: Help me get a patch into Wine

2009-10-11 Thread Nikolay Sivov
Charles Davis wrote: Hi, My name is Charles Davis, but you all can call me "Chip". I'm new to Wine development, and frankly, I'm kinda scared because I've heard and read that getting patches into Wine is very difficult. Lie. First of all avoid looking at native dumps, disasms, decompiled outpu

Help me get a patch into Wine

2009-10-11 Thread Charles Davis
Hi, My name is Charles Davis, but you all can call me "Chip". I'm new to Wine development, and frankly, I'm kinda scared because I've heard and read that getting patches into Wine is very difficult. In fact, every time I got ready to send this first patch, I chickened out and couldn't do it. So,

Re: ws2_32: Use the routing table information for gethostbyname('self') if the magic IP would otherwise be returned.

2009-10-11 Thread Erich Hoover
On Sun, Oct 11, 2009 at 6:01 PM, Vitaliy Margolen wrote: > Kai Blin wrote: > > On Saturday 10 October 2009 22:52:48 Vitaliy Margolen wrote: > > > >>> Changelog: > >>> ws2_32: Use the routing table information for > >>> gethostbyname('self') if the magic IP would otherwise be returned. > >> Tha

Re: ws2_32: Use the routing table information for gethostbyname('self') if the magic IP would otherwise be returned.

2009-10-11 Thread Vitaliy Margolen
Kai Blin wrote: > On Saturday 10 October 2009 22:52:48 Vitaliy Margolen wrote: > >>> Changelog: >>> ws2_32: Use the routing table information for >>> gethostbyname('self') if the magic IP would otherwise be returned. >> Thanks for the patch, however there are few issues with it. >> >> Why do y

Localized date names

2009-10-11 Thread Nikolay Sivov
Hi. I'm trying to figure out the best way for adding genitive month names support for locales. After some tests I've got the following: - GetLocaleInfo doesn't return such names, only nominative names is returned; - GetDateFormat returns genitive name both for "dd" and "dd" Looking d

Re: ddraw.h: disable DDEVICEIDENTIFIER size alignment

2009-10-11 Thread Markus Stockhausen
Am Montag, den 12.10.2009, 02:01 +0900 schrieb Dmitry Timoshkov: > I have compiled the test alone and it fails here: > > ddrawmodes.c:37: Test failed: DDDEVICEIDENTIFIER2 too large (misaligned) > > It's natural that the structure is 8-byte aligned since it has a > 64-bit member (LARGE_INTEGER). d

Re: ddraw.h: disable DDEVICEIDENTIFIER size alignment

2009-10-11 Thread Dmitry Timoshkov
"Markus Stockhausen" wrote: > Did you compile this test with MSVC and the Microsoft headers on > Windows? > I'm sorry but I have no Windows environment. Only Linux/GCC. I have compiled the test alone and it fails here: ddrawmodes.c:37: Test failed: DDDEVICEIDENTIFIER2 too large (misalign

Re: winex11: Send WM_SYSKEYDOWN and WM_SYSKEYUP when the 'F10' key is used.

2009-10-11 Thread Dmitry Timoshkov
"Erich Hoover" wrote: Is there even a test mechanism for simulating keystrokes? If so, where is it (winex11.drv has no tests)? It seems pretty clear from the documentation on MSDN that the 'F10' key is supposed to emit these window notifications. The best place for such a test is dlls/user3

Re: ddraw.h: disable DDEVICEIDENTIFIER size alignment

2009-10-11 Thread Markus Stockhausen
Am Sonntag, den 11.10.2009, 18:04 +0200 schrieb Stefan Dösinger: > Am 11.10.2009 um 17:44 schrieb Markus Stockhausen: > > > > > > Did you compile this test with MSVC and the Microsoft headers on > Windows? > I'm sorry but I have no Windows environment. Only Linux/GCC.

Re: ddraw.h: disable DDEVICEIDENTIFIER size alignment

2009-10-11 Thread Stefan Dösinger
Am 11.10.2009 um 17:44 schrieb Markus Stockhausen: Did you compile this test with MSVC and the Microsoft headers on Windows?

Re: winex11: Send WM_SYSKEYDOWN and WM_SYSKEYUP when the 'F10' key is used.

2009-10-11 Thread Andrew Eikum
Erich Hoover wrote: On Sun, Oct 11, 2009 at 12:43 AM, Dmitry Timoshkov wrote: "Erich Hoover" wrote: Real Name: Erich Hoover Description: The attached patch makes it so that the 'F10' key send a WM_SYSKEYDOWN window notification on press and WM_SYSKEYUP on release. This change fixes Bug

Re: ddraw.h structure alignment

2009-10-11 Thread Markus Stockhausen
Am Sonntag, den 11.10.2009, 17:15 +0200 schrieb Stefan Dösinger: > Does a pragma pack fix the issue? If yes, then that's probably the > correct fix. > > Its probably worth writing a test that allocates e.g. a char data[64], > then passes this to GetDeviceIdentifier, fill it with non-zero data,

Re: ddraw.h structure alignment

2009-10-11 Thread Stefan Dösinger
Am 11.10.2009 um 14:42 schrieb Markus Stockhausen: Am Sonntag, den 11.10.2009, 13:18 +0200 schrieb Markus Stockhausen: Then I'm somehow in trouble. How can one explain the following error: Application calls IDirectDraw GetDeviceIdentifier of DDRAW7 but only reserves memory with sizeof(DDEVICEI

Re: winex11: Send WM_SYSKEYDOWN and WM_SYSKEYUP when the 'F10' key is used.

2009-10-11 Thread Erich Hoover
On Sun, Oct 11, 2009 at 12:43 AM, Dmitry Timoshkov wrote: > "Erich Hoover" wrote: > > Real Name: >> Erich Hoover >> Description: >> The attached patch makes it so that the 'F10' key send a >> WM_SYSKEYDOWN window notification on press and WM_SYSKEYUP on release. >> This change fixes Bug 1938

Re: [1/2] comctl32/propsheet: Remove trailing spaces

2009-10-11 Thread Nikolay Sivov
Ričardas Barkauskas wrote: On Sun, Oct 11, 2009 at 12:20 PM, lats wrote: On 11/10/09 19:29, Ričardas Barkauskas wrote: Removes trailing spaces to have it clean for next patch I will be interested to see how you go with this one as the word has been that formatting only patches

Re: [1/2] comctl32/propsheet: Remove trailing spaces

2009-10-11 Thread Ričardas Barkauskas
On Sun, Oct 11, 2009 at 12:20 PM, lats wrote: > On 11/10/09 19:29, Ričardas Barkauskas wrote: >> >> Removes trailing spaces to have it clean for next patch > > I will be interested to see how you go with this one as the word has been > that formatting only patches are not accepted. > > > > Isn't

Re: Fixing bug #2181, standard EDIT class extra value

2009-10-11 Thread Julius Schwartzenberg
Dmitry Timoshkov wrote: "Dmitry Timoshkov" wrote: +#ifdef _WIN64 +ok(cls.cbWndExtra == 8, "expected 6, got %d\n", cls.cbWndExtra); +#else +ok(cls.cbWndExtra == 6, "expected 6, got %d\n", cls.cbWndExtra); +#endif +} +} You should check the return value of GetClassInfoEx()

ddraw.h structure alignment

2009-10-11 Thread Markus Stockhausen
Am Sonntag, den 11.10.2009, 13:18 +0200 schrieb Markus Stockhausen: > Then I'm somehow in trouble. How can one explain the following > error: Application calls IDirectDraw GetDeviceIdentifier of > DDRAW7 but only reserves memory with sizeof(DDEVICEIDENTIFIER) > instead of sizeof(DDEVICEIDENTIFIER

Re: Bug 6971 in RedOrchestra Game.

2009-10-11 Thread Roderick Colenbrander
Hi, First of all wine-patches is the list to which patches are submitted for inclusion in Wine, it is not meant as a user discussion list. Questions like the one you asked belong on wine-devel. Bug 6971 is an old Wine bug and is hard to fix. Now that xserver 1.7 is out, there is finally Xinput 1.

Re: [1/2] comctl32/propsheet: Remove trailing spaces

2009-10-11 Thread lats
On 11/10/09 19:29, Ričardas Barkauskas wrote: Removes trailing spaces to have it clean for next patch I will be interested to see how you go with this one as the word has been that formatting only patches are not accepted.

Re: use DDRAW4 instead of DDRAW7

2009-10-11 Thread Markus Stockhausen
Am Sonntag, den 11.10.2009, 12:47 +0200 schrieb Stefan Dösinger: > Which ddraw version an app uses isn't a setting you can change - its > hardcoded into the app, just like usually its hardcoded whether an app > uses opengl or d3d. > > Then I'm somehow in trouble. How can one explain the fol

Re: use DDRAW4 instead of DDRAW7

2009-10-11 Thread Stefan Dösinger
Am 11.10.2009 um 12:40 schrieb Markus Stockhausen: Hi, as I did not find anything in the Wiki maybe a stupid question: If I want an application to use DDRAW4 functions in Wine instead of DDRAW7, how can I accomplish that? You can't. Except if you have the sourcecode. In that case you have to

Re: use DDRAW4 instead of DDRAW7

2009-10-11 Thread Markus Stockhausen
Am Sonntag, den 11.10.2009, 12:40 +0200 schrieb Markus Stockhausen: > Hi, > > as I did not find anything in the Wiki maybe a stupid question: If I > want an application to use DDRAW4 functions in Wine instead of DDRAW7, > how can I accomplish that? > > Thanks in advance. > > Markus Sorry, wrong

use DDRAW4 instead of DDRAW7

2009-10-11 Thread Markus Stockhausen
Hi, as I did not find anything in the Wiki maybe a stupid question: If I want an application to use DDRAW4 functions in Wine instead of DDRAW7, how can I accomplish that? Thanks in advance. Markus

Re: [2/2] comctl32/propsheet: Fix PropSheet_IndexToHwnd to handle invalid handles

2009-10-11 Thread Paul Vriens
On 10/11/2009 10:33 AM, Ričardas Barkauskas wrote: Fixes crash with pcsx2 r1888 plugin. Ričardas Barkauskas REalm Hi, You forgot the patch. -- Cheers, Paul.