Re: Requesting comments on patchset to fix Bug 7929 (C&C 3 network does not work)

2009-10-09 Thread Kai Blin
On Saturday 10 October 2009 01:15:17 Juan Lang wrote: > Hi Eric, > > it seems to me that if this is the best we can do, we're fixing it at > the wrong layer. Surely putting the fix in the Linux kernel would be > much smaller in code size, and higher performing, as we wouldn't have > to filter pack

Re: Requesting comments on patchset to fix Bug 7929 (C&C 3 network does not work)

2009-10-09 Thread Juan Lang
> This is rather embarrasing, but apparently I left server/protocol.def out of > the patchset.  I could have sworn I tested these patches on a clean git, but > apparently I made a mistake.  Is there any chance that this mistake is the > reason for the rejection? It very well could be, but you'll h

Ballooning "dlls" folder

2009-10-09 Thread Erich Hoover
With the separation of the 16-bit APIs recently, the "dlls" folder has ballooned quite a bit. Is there any particular reason that the 16-bit and 32-bit DLLs are not in separate folders? Erich Hoover ehoo...@mines.edu

Re: Requesting comments on patchset to fix Bug 7929 (C&C 3 network does not work)

2009-10-09 Thread Erich Hoover
On Fri, Oct 9, 2009 at 5:15 PM, Juan Lang wrote: > Hi Eric, > > it seems to me that if this is the best we can do, we're fixing it at > the wrong layer. Surely putting the fix in the Linux kernel would be > much smaller in code size, and higher performing, as we wouldn't have > to filter packets

Re: Requesting comments on patchset to fix Bug 7929 (C&C 3 network does not work)

2009-10-09 Thread Juan Lang
Hi Eric, it seems to me that if this is the best we can do, we're fixing it at the wrong layer. Surely putting the fix in the Linux kernel would be much smaller in code size, and higher performing, as we wouldn't have to filter packets in user space. --Juan

Requesting comments on patchset to fix Bug 7929 (C&C 3 network does not work)

2009-10-09 Thread Erich Hoover
I've been a bit busy lately, but I sent in a patchset at the end of September to fix the C&C3 LAN networking bug. If I could get some feedback on these patches then I would greatly appreciate it: http://www.winehq.org/pipermail/wine-patches/2009-September/079193.html[1/6] http://www.winehq.org/pi

Re: [try 4] Add help message box to dxdiag implementation

2009-10-09 Thread Austin English
On Fri, Oct 9, 2009 at 7:32 AM, Joel Holdsworth wrote: > I'm just wondering how easy would it be to do something simple with a > proper dialog template. The reason I ask is that I've been working on an > icon for dxdiag (http://www.airwebreathe.org.uk/wine-icon/), and it'd be > nice if there was a

BSTR & Heap - a restart

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 15:44 +0200 schrieb Alexandre Julliard: > If the test case is based on observing internal behavior that's not > acceptable either. Even if someone else fixes it, the test would force > the fixer to replicate internal details. > Hi, I can see all of your concerns and t

Re: Help needed: BSTR cache testing

2009-10-09 Thread Alexandre Julliard
Michael Stefaniuc writes: > Roderick Colenbrander wrote: >> Blackbox reverse engineering is feeding test input to a function and >> looking at the output. A trace of calls made by the native MS dll >> while looking under Wine isn't blackbox. It is considered about the >> same as looking at disass

Re: Help needed: BSTR cache testing

2009-10-09 Thread Paul Vriens
On 10/09/2009 02:15 PM, Paul Vriens wrote: On 10/09/2009 02:07 PM, Markus Stockhausen wrote: Am Freitag, den 09.10.2009, 13:43 +0200 schrieb Paul Vriens: Hi Markus, Isn't there a way that you can change the tests to show this number (in some kind of loop by creating a larger second string on t

Re: Help needed: BSTR cache testing

2009-10-09 Thread Michael Stefaniuc
Roderick Colenbrander wrote: > On Fri, Oct 9, 2009 at 2:25 PM, Markus Stockhausen > wrote: >> Am Freitag, den 09.10.2009, 14:15 +0200 schrieb Paul Vriens: >> >>> If that sz99 (or now sz128) came from "looking at internal behaviour", >>> I'm not sure if that would raise some eyebrows. >>> >> As I s

Re: Help needed: BSTR cache testing

2009-10-09 Thread Roderick Colenbrander
On Fri, Oct 9, 2009 at 2:25 PM, Markus Stockhausen wrote: > Am Freitag, den 09.10.2009, 14:15 +0200 schrieb Paul Vriens: > >> If that sz99 (or now sz128) came from "looking at internal behaviour", >> I'm not sure if that would raise some eyebrows. >> > > As I said "looking at internal behaviour" a

Re: [try 4] Add help message box to dxdiag implementation

2009-10-09 Thread Joel Holdsworth
I'm just wondering how easy would it be to do something simple with a proper dialog template. The reason I ask is that I've been working on an icon for dxdiag (http://www.airwebreathe.org.uk/wine-icon/), and it'd be nice if there was a dialog ready to receive it. It's no big deal though. What do yo

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 14:15 +0200 schrieb Paul Vriens: > If that sz99 (or now sz128) came from "looking at internal behaviour", > I'm not sure if that would raise some eyebrows. > ... and I simply allocate a "very large" string to ensure that no reuse of the just freed small memory portion

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 14:15 +0200 schrieb Paul Vriens: > If that sz99 (or now sz128) came from "looking at internal behaviour", > I'm not sure if that would raise some eyebrows. > As I said "looking at internal behaviour" are debugging messages in the IMalloc routines of ifs.c. Simply som

Re: Help needed: BSTR cache testing

2009-10-09 Thread Paul Vriens
On 10/09/2009 02:07 PM, Markus Stockhausen wrote: Am Freitag, den 09.10.2009, 13:43 +0200 schrieb Paul Vriens: Hi Markus, Isn't there a way that you can change the tests to show this number (in some kind of loop by creating a larger second string on the go)? It simply boils down to this one

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 13:43 +0200 schrieb Paul Vriens: > Hi Markus, > > Isn't there a way that you can change the tests to show this number (in > some kind of loop by creating a larger second string on the go)? > It simply boils down to this one and only testcase. A SysFreeString will alw

Re: include/dwmapi.h: Add defenition of MIL_MATRIX3X2D

2009-10-09 Thread Nikolay Sivov
Louis. Lenders wrote: needed to add a stub for //DwmGetGraphicsStreamTransformHint later on // Hi, Louis. +typedef struct _MIL_MATRIX3X2D +{ +DOUBLE S_11; +DOUBLE S_12; +DOUBLE S_21; +DOUBLE S_22; +DOUBLE DX; +DOUBLE DY; +} MIL_MATRIX3X2D; + This is called MilMatri

Re: Help needed: BSTR cache testing

2009-10-09 Thread Paul Vriens
On 10/09/2009 10:12 AM, Markus Stockhausen wrote: Am Freitag, den 09.10.2009, 01:05 -0700 schrieb Dan Kegel: Also, how did you decide on the size of sz99? I do not want to explain this in detail, as it is the result of looking at internal behaviour (something that is not liked very much as I u

no LANG=C wine winecfg on Mac OS? (texts are always translated)

2009-10-09 Thread Joerg-Cyril.Hoehle
Hi, On Linux, I can toggle Wine's idea about the current language by starting with: LANG=C or =de_DE.UTF-8 or fr_... wine winecfg Winecfg then displays text in the chosen locale (english for C). This works well in Ubuntu for any locale with the language-pack-xyz packages installed (C always works)

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 01:05 -0700 schrieb Dan Kegel: > Also, how did you decide on the size of sz99? I do not want to explain this in detail, as it is the result of looking at internal behaviour (something that is not liked very much as I understand now). But to make a long story short: Thi

Re: Help needed: BSTR cache testing

2009-10-09 Thread Dan Kegel
Markus Stockhausen wrote: >> Please extend the test cases in >> dlls/oleaut32/tests to verify that oleaut32 is caching BSTRs >> properly, and make sure that test passes on Windows >> and is marked todo_wine. > > Already sent. Take a look here: > http://www.winehq.org/pipermail/wine-devel/2009-Octo

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 09:56 +0200 schrieb Paul Vriens: > On 10/09/2009 09:38 AM, Markus Stockhausen wrote: > > Am Freitag, den 09.10.2009, 00:27 -0700 schrieb Dan Kegel: > >> Hi Markus, > >> Wine development is driven by test cases checked in to the > >> Wine source tree. Please extend the t

Re: Help needed: BSTR cache testing

2009-10-09 Thread Paul Vriens
On 10/09/2009 09:38 AM, Markus Stockhausen wrote: Am Freitag, den 09.10.2009, 00:27 -0700 schrieb Dan Kegel: Hi Markus, Wine development is driven by test cases checked in to the Wine source tree. Please extend the test cases in dlls/oleaut32/tests to verify that oleaut32 is caching BSTRs prope

Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 00:27 -0700 schrieb Dan Kegel: > Hi Markus, > Wine development is driven by test cases checked in to the > Wine source tree. Please extend the test cases in > dlls/oleaut32/tests to verify that oleaut32 is caching BSTRs > properly, and make sure that test passes on Wind

re: BSTR caching

2009-10-09 Thread Dan Kegel
Hi Markus, Wine development is driven by test cases checked in to the Wine source tree. Please extend the test cases in dlls/oleaut32/tests to verify that oleaut32 is caching BSTRs properly, and make sure that test passes on Windows and is marked todo_wine. Once we have a test case like that check