Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-06 Thread Dan Kegel
On Sun, Oct 4, 2009 at 2:58 PM, Detlef Riekenberg wrote: > Code, which is called very often, should produce as less overhead as > possible. I suggest to use "static inline". I have 'static' already. The compiler's probably better at deciding when to use inline than we are, may as well leave in

Re: dlls/comctl32/monthcal.c fix

2009-10-06 Thread Nikolay Sivov
Gerald Pfeifer wrote: Looking at the code I'm 99.9% sure this should be a logical and here in this new code. Gerald ChangeLog: Use local and instead of bitwise and in MONTHCAL_SetDayFocus(). diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c index a35d261..cd8bd7f 100644 --- a/d

Re: Winamp disappears when you move it's location

2009-10-06 Thread Peter Dons Tychsen
On Tue, 2009-10-06 at 14:37 +0200, Peter Dons Tychsen wrote: > Hello, > > > You can do it at window creation time, but you can't > > change the window back and forth just because you want some move request > > to not be intercepted. > > > Eh? Did you read the xlib manual i linked to? This is *ex

Re: [ntdll] Move file attribute logic to new function DIR_get_attributes()

2009-10-06 Thread Dan Kegel
On Sun, Oct 4, 2009 at 9:21 AM, Juan Lang wrote: > +    TRACE("fd %d, name %s, attrib %x\n", fd, debugstr_a(unix_fname), > *pattrib); > +    *pattrib = attributes; > > Any reason you're tracing *pattrib before you set it? Fixed, thanks! > + * If unix_fname is not NULL, DIR_is_hidden_file is cal

Re: urlmon/protocol tests

2009-10-06 Thread Jacek Caban
Hi Paul, Paul Vriens wrote: Hi Jacek, I've been looking at the tests reports and we seem to have a few spurious errors: http://test.winehq.org/data/tests/urlmon:protocol.html The ones I mean are: protocol.c:2535: Testing http protocol (direct read)... protocol.c:497: Test failed: unexpecte

urlmon/protocol tests

2009-10-06 Thread Paul Vriens
Hi Jacek, I've been looking at the tests reports and we seem to have a few spurious errors: http://test.winehq.org/data/tests/urlmon:protocol.html The ones I mean are: protocol.c:2535: Testing http protocol (direct read)... protocol.c:497: Test failed: unexpected call Switch and protocol.c

Re: sti [2/2]: add aggregation tests for the IStillImageW interface

2009-10-06 Thread Juan Lang
> Which test fails on the other Windows versions? That's available if you follow the link Paul sent. The failing test is: sti.c:221: Test failed: CoCreateInstance unexpectedly succeeded when querying for IUnknown during aggregation and it's failing on Win98, XP, and 2003. --Juan

Re: sti [2/2]: add aggregation tests for the IStillImageW interface

2009-10-06 Thread Damjan Jovanovic
On Tue, Oct 6, 2009 at 6:30 PM, Paul Vriens wrote: > On 10/05/2009 09:07 PM, Damjan Jovanovic wrote: >> >> Changelog: >> * add aggregation tests for the IStillImageW interface >> >> Unchanged since last time. >> >> Damjan Jovanovic >> >> >> -

Re: sti [2/2]: add aggregation tests for the IStillImageW interface

2009-10-06 Thread Paul Vriens
On 10/05/2009 09:07 PM, Damjan Jovanovic wrote: Changelog: * add aggregation tests for the IStillImageW interface Unchanged since last time. Damjan Jovanovic Hi Damjan, This patch introduced a test failure on all Win

Re: Try to find out why "Unity3d (3D application)" doesn't work with Wine.

2009-10-06 Thread Mike Kaplinskiy
On Tue, Oct 6, 2009 at 12:10 PM, Roderick Colenbrander wrote: > Esstentially what happens is that using the SendMessage in > internal_SetPixelFormat we call 'set_win_format' in window.c. I can't > say why it fails perhaps no parent window is up yet.. > > Roderick > > > On Tue, Oct 6, 2009 at 6:02

Re: Try to find out why "Unity3d (3D application)" doesn't work with Wine.

2009-10-06 Thread Roderick Colenbrander
Esstentially what happens is that using the SendMessage in internal_SetPixelFormat we call 'set_win_format' in window.c. I can't say why it fails perhaps no parent window is up yet.. Roderick On Tue, Oct 6, 2009 at 6:02 PM, a qi wrote: > > Hi,All > > I try to run  a 3D application named  "Unity

Try to find out why "Unity3d (3D application)" doesn't work with Wine.

2009-10-06 Thread a qi
Hi,All I try to run a 3D application named "Unity 3d" with Wine, but failed. And there is already a bug report about that: Bug 18061 - Unity Indie Trial Editor window contents not drawn http://bugs.winehq.org/show_bug.cgi?id=18061 Now I try to find out the reason. So, I follow the error

Re: [user32/tests] Fix some test failures with 9x/Me on VMware (Resend)

2009-10-06 Thread Alexandre Julliard
Paul Vriens writes: > Looks like a time/timing issue. Putting a Sleep(100) after the > ScrollWindowEx makes the tests pass as well. > > Is that acceptable? Yes, though maybe a flush_events() would be better. -- Alexandre Julliard julli...@winehq.org

Re: [user32/tests] Fix some test failures with 9x/Me on VMware (Resend)

2009-10-06 Thread Paul Vriens
On 10/06/2009 12:54 PM, Alexandre Julliard wrote: Paul Vriens writes: On 10/06/2009 11:51 AM, Alexandre Julliard wrote: Paul Vriens writes: Hi, Resending as I didn't receive any comments. Apparently most Win9x and WinMe boxes running under VMware have this issue. Changelog Fix some

Re: Winamp disappears when you move it's location

2009-10-06 Thread Peter Dons Tychsen
Hello, > You can do it at window creation time, but you can't > change the window back and forth just because you want some move request > to not be intercepted. > Eh? Did you read the xlib manual i linked to? This is *exactly* what they recommend for this type of scenario: http://tronche.com/gu

Winamp disappears when you move it's location

2009-10-06 Thread Peter Dons Tychsen
I am posting your response, as you are not on CC in the bug. >>You can't do that sort of thing. If you really don't want the window manager to >>control the windows there's an option for it, but you can't have it both ways. I am not sure i agree. Everywhere i looked they referred to "override_red

Re: Winamp disappears when you move it's location

2009-10-06 Thread Alexandre Julliard
Peter Dons Tychsen writes: > I am posting your response, as you are not on CC in the bug. > >>>You can't do that sort of thing. If you really don't want the window > manager to >>>control the windows there's an option for it, but you can't have it both >>>ways. > > I am not sure i agree. Everywh

Re: d3d10core/tests: Add acceptable error code for Win7 device test (Resend)

2009-10-06 Thread Alexandre Julliard
Ge van Geldorp writes: > Changelog: > d3d10core/tests: Add acceptable error code for Win7 device test So why does it fail? -- Alexandre Julliard julli...@winehq.org

Re: dinput/tests: Add acceptable error code for Win7 mouse test (Resend)

2009-10-06 Thread Alexandre Julliard
Ge van Geldorp writes: > http://www.winehq.org/pipermail/wine-patches/2009-September/078113.html got > sucked into the wine-patches black hole. > > Changelog: >dinput/tests: Add acceptable error code for Win7 mouse test That's not an acceptable error for that test. Why does it fail? -- Ale

Re: [user32/tests] Fix some test failures with 9x/Me on VMware (Resend)

2009-10-06 Thread Alexandre Julliard
Paul Vriens writes: > Hi, > > Resending as I didn't receive any comments. > > Apparently most Win9x and WinMe boxes running under VMware have this issue. > > Changelog > Fix some test failures with 9x/Me on VMware That makes the test essentially useless. -- Alexandre Julliard julli...@winehq

Re: ntdll/tests: Fix exception test failure on Win7 (Resend)

2009-10-06 Thread Alexandre Julliard
Ge van Geldorp writes: > Changelog: > ntdll/tests: Fix exception test failure on Win7 That's way overkill for a single failure. You should figure out what's going on in this specific case and adapt the test. -- Alexandre Julliard julli...@winehq.org

Re: kernel32/tests: Check expected last error before calling lstrcmpA() since it may reset GLE (Resend)

2009-10-06 Thread Alexandre Julliard
Ge van Geldorp writes: > Changelog: > kernel32/tests: Check expected last error before calling lstrcmpA() since > it may reset GLE Then it doesn't make sense to print it either. You should split the check. -- Alexandre Julliard julli...@winehq.org

Re: kernel32/tests: Add acceptable error codes for Win7 resource test (Resend)

2009-10-06 Thread Alexandre Julliard
Ge van Geldorp writes: > Changelog: > kernel32/tests: Add acceptable error codes for Win7 resource test That defeats the purpose of the test. -- Alexandre Julliard julli...@winehq.org

Re: tools/winebuild: add FreeBSD support (1/2) (RESEND) (fwd)

2009-10-06 Thread Alexandre Julliard
Gerald Pfeifer writes: > If you prefer, I'll be happy to convert the code into a switch statement. > Just let me know! That would certainly be more elegant. -- Alexandre Julliard julli...@winehq.org