Re: [1/2] user32/tests/cursoricon.c: DrawState: New Testcase for correct drawing of Icons

2009-10-02 Thread Wilfried Pasquazzo
I had another patch in git, that accidentally made this test pass. I'll send a corrected version of test and fix in a moment. I'm sorry for any inconveniences. 2009/10/2 Alexandre Julliard : > Wilfried Pasquazzo writes: > >> [1/2] New Testcase to check if DrawState() behaves correctly when drawi

Re: [ntdll] Move file attribute logic to new function DIR_get_attributes()

2009-10-02 Thread Dan Kegel
http://bugs.winehq.org/show_bug.cgi?id=15679 has the latest draft of the patch. AJ's probably getting tired of reviewing it over and over again, so if anyone else can do a quick review I'd appreciate it. I'll probably send it in Sunday evening

Re: Image List tests for comctl32 v6

2009-10-02 Thread Roderick Colenbrander
On Fri, Oct 2, 2009 at 6:49 PM, Nikolay Sivov wrote: > Frank Richter wrote: >> >> On 02.10.2009 00:27, Joel Holdsworth wrote: >> >>> >>> Does anyone have any thoughts about what might be going on here, and >>> what I should do with my tests? >>> >> >> If the manifest is set up dynamically I would

Re: question about concurrent access to resources

2009-10-02 Thread Eric Pouech
joerg-cyril.hoe...@t-systems.com a écrit : Hi, I need some information about threads and callbacks. I already found out that: - SetEvent delivers "asynchronously" and can unblock threads WaitingForMultipleObjects. No callback is involved (which does not mean that the current thread cannot b

Re: comctl32: implement LISTVIEW_ApproximateViewRect for icon and small icon.

2009-10-02 Thread Nikolay Sivov
James Mckenzie wrote: Nikolay Sivov wrote at Oct 2, 2009 11:37 AM (PNT) Aric Stewart wrote: --- dlls/comctl32/listview.c | 39 ++- 1 files changed, 34 insertions(+), 5 deletions(-) Hi, Aric. Also this is unsafe: --- + row_count = wWidth

Re: comctl32: implement LISTVIEW_ApproximateViewRect for icon and small icon.

2009-10-02 Thread Nikolay Sivov
Aric Stewart wrote: --- dlls/comctl32/listview.c | 39 ++- 1 files changed, 34 insertions(+), 5 deletions(-) Hi, Aric. I don't think it's a right way: --- +if (infoPtr->nItemCount > 0) +{ + LISTVIEW_GetItemBox(infoPtr, 0, &rcBox); + if

Re: Image List tests for comctl32 v6

2009-10-02 Thread Nikolay Sivov
Frank Richter wrote: On 02.10.2009 00:27, Joel Holdsworth wrote: Does anyone have any thoughts about what might be going on here, and what I should do with my tests? If the manifest is set up dynamically I would expect that all symbols imported from comctl32.dll are done so _before_ th

Re: Image List tests for comctl32 v6

2009-10-02 Thread Frank Richter
On 02.10.2009 00:27, Joel Holdsworth wrote: > Does anyone have any thoughts about what might be going on here, and > what I should do with my tests? If the manifest is set up dynamically I would expect that all symbols imported from comctl32.dll are done so _before_ the manifest takes effect, ie a

Re: [1/2] user32/tests/cursoricon.c: DrawState: New Testcase for correct drawing of Icons

2009-10-02 Thread Alexandre Julliard
Wilfried Pasquazzo writes: > [1/2] New Testcase to check if DrawState() behaves correctly when drawing > Icons. It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so cursoricon.c && touch cursoricon.ok cursoricon.c:1290: Test failed: Drawing I

question about concurrent access to resources

2009-10-02 Thread Joerg-Cyril.Hoehle
Hi, I need some information about threads and callbacks. I already found out that: - SetEvent delivers "asynchronously" and can unblock threads WaitingForMultipleObjects. No callback is involved (which does not mean that the current thread cannot be preempted by another one awakening). Th

Re: oleaut - SysAllocString/SysFreeString

2009-10-02 Thread Michael Stefaniuc
Markus Stockhausen wrote: > Am Freitag, den 02.10.2009, 12:56 +0200 schrieb Michael Stefaniuc: >> The best thing is to write a test for this behavior and test it on >> different Windows versions. If even Windows 7 behaves that way I figure >> we'll have to provide that "feature" too. Else the appli

Re: oleaut - SysAllocString/SysFreeString

2009-10-02 Thread Louis Lenders
Markus Stockhausen collogia.de> writes: > > Hi, > > maybe this topic has discussed before but I did not find any threads in > the devel mailing list for the last months. Not sure, but maybe you could find some interesting related stuff in this bug:http://bugs.winehq.org/show_bug.cgi?id=3756

Re: oleaut - SysAllocString/SysFreeString

2009-10-02 Thread Markus Stockhausen
Am Freitag, den 02.10.2009, 12:56 +0200 schrieb Michael Stefaniuc: > The best thing is to write a test for this behavior and test it on > different Windows versions. If even Windows 7 behaves that way I figure > we'll have to provide that "feature" too. Else the application is buggy > and won't wor

Re: [5/9] wpp: Handle remaining memory allocation failures [try 2]

2009-10-02 Thread Matteo Bruni
2009/10/2 Alexandre Julliard : > Matteo Bruni writes: > >> @@ -82,8 +82,7 @@ void *pp_xmalloc(size_t size) >>      res = malloc(size); >>      if(res == NULL) >>      { >> -        fprintf(stderr, "Virtual memory exhausted.\n"); >> -        exit(2); >> +        pp_internal_error(__FILE__, __LINE__

Re: Image List tests for comctl32 v6

2009-10-02 Thread Nikolay Sivov
Joel Holdsworth wrote: On Fri, 2009-10-02 at 02:40 +0400, Nikolay Sivov wrote: Hi, Joel. It works for precreated manifest as a separate file (not compiled in), isn't it? If so you could do a trick that I spotted here http://www.winehq.org/pipermail/wine-patches/2009-September/078869.html f

Re: Image List tests for comctl32 v6

2009-10-02 Thread Joel Holdsworth
On Fri, 2009-10-02 at 02:40 +0400, Nikolay Sivov wrote: > Joel Holdsworth wrote: > > Hi All, > > > > I'm working on some tests to demonstrate some alpha-channel behaviour in > > comctl32 ImageLists. The problem is that this behaviour is only present > > in comctl32 v6, which of course you usually a

Re: oleaut - SysAllocString/SysFreeString

2009-10-02 Thread Michael Stefaniuc
Hello! Markus Stockhausen wrote: > maybe this topic has discussed before but I did not find any threads in > the devel mailing list for the last months. Additionally i followed wine > development for only a few weeks. So here we go ... > > oleaut.c in native Windows has some type of "heap reusage

Re: Image List tests for comctl32 v6

2009-10-02 Thread André Hentschel
Nikolay Sivov schrieb: > Joel Holdsworth wrote: >> Hi All, >> >> I'm working on some tests to demonstrate some alpha-channel behaviour in >> comctl32 ImageLists. The problem is that this behaviour is only present >> in comctl32 v6, which of course you usually activate with an xml >> manifest. For t

Re: [7/9] wpp: Remove the assumption pp_internal_error calls exit() [try 2]

2009-10-02 Thread Alexandre Julliard
Matteo Bruni writes: > From 79aebdb612334b9816375abce58c65b90130732a Mon Sep 17 00:00:00 2001 > From: Matteo Bruni > Date: Tue, 29 Sep 2009 12:10:24 +0200 > Subject: wpp: Remove the assumption pp_internal_error calls exit() Actually it's OK for it to exit(), though assert() would be a better ch

Re: [5/9] wpp: Handle remaining memory allocation failures [try 2]

2009-10-02 Thread Alexandre Julliard
Matteo Bruni writes: > @@ -82,8 +82,7 @@ void *pp_xmalloc(size_t size) > res = malloc(size); > if(res == NULL) > { > -fprintf(stderr, "Virtual memory exhausted.\n"); > -exit(2); > +pp_internal_error(__FILE__, __LINE__, "Virtual memory exhausted.\n"); >

Re: [2/5] d3d9: Test viewports that are bigger than the surface

2009-10-02 Thread Stefan Dösinger
Am 02.10.2009 um 10:43 schrieb Henri Verbeet: +/* Test a viewport with Width and Height bigger than the surface dimensions + * + * TODO: Test Width < surface.width, but X + Width > surface.width + * TODO: Test Width < surface.width, what happens with the height? + */

Re: [4/5] WineD3D: SetRenderTarget bypasses stateblock recording

2009-10-02 Thread Henri Verbeet
2009/10/2 Stefan Dösinger : > I haven't yet figured out how the stateblock event test machine works, I > wanted to hold off the test until I get them properly integrated, and fix > the bug in the meantime(since we already know what the correct behavior is) > Ok.

oleaut - SysAllocString/SysFreeString

2009-10-02 Thread Markus Stockhausen
Hi, maybe this topic has discussed before but I did not find any threads in the devel mailing list for the last months. Additionally i followed wine development for only a few weeks. So here we go ... oleaut.c in native Windows has some type of "heap reusage" when working with strings. This can b

Re: [4/5] WineD3D: SetRenderTarget bypasses stateblock recording

2009-10-02 Thread Stefan Dösinger
Am 02.10.2009 um 10:44 schrieb Henri Verbeet: 2009/10/1 Stefan Dösinger : +/* Finally, reset the viewport as the MSDN states. Tests show that stateblock recording is ignored. + * the change goes directly into the primary stateblock. + */ +This->stateBlock->vie

Re: [4/5] WineD3D: SetRenderTarget bypasses stateblock recording

2009-10-02 Thread Henri Verbeet
2009/10/1 Stefan Dösinger : > +/* Finally, reset the viewport as the MSDN states. Tests show that > stateblock recording is ignored. > + * the change goes directly into the primary stateblock. > + */ > +This->stateBlock->viewport.Height = ((IWineD3DSurfaceImpl > *)

Re: [2/5] d3d9: Test viewports that are bigger than the surface

2009-10-02 Thread Henri Verbeet
> +/* Test a viewport with Width and Height bigger than the surface > dimensions > + * > + * TODO: Test Width < surface.width, but X + Width > surface.width > + * TODO: Test Width < surface.width, what happens with the height? > + */ > +memset(&vp, 0, sizeof(vp)); > +vp

Re: [5/5] WineD3D: SetRenderTarget resets the scissor rect

2009-10-02 Thread Henri Verbeet
Please submit the tests for this one as well.