Re: [1/2] user32/tests/cursoricon.c: DrawState: New Testcase for correct drawing of Icons

2009-10-01 Thread Nicolas Le Cam
2009/10/1 Wilfried Pasquazzo : > [1/2] New Testcase to check if DrawState() behaves correctly when drawing > Icons. > > affected files: dlls/user32/tests/cursoricon.c > > Currently checks: > > - if the Icons are drawn at the correct size. Should always be the > original icon size, >  independent o

Re: Image List tests for comctl32 v6

2009-10-01 Thread Owen Rudge
It sounds like I need to investigate further, but no - I'm only talking about Windows. With crosstest, load_v6_module seems not to switch to v6 with regard to image lists. That's curious. What version of Windows are you using? Could you try applying my imagelist patches I linked to earlier and

Re: Image List tests for comctl32 v6

2009-10-01 Thread Joel Holdsworth
> Do you mean that the tests pass on Windows but not Wine when using > load_v6_module, or that they don't pass on either platform? I used > load_v6_module for some v6 imagelist tests (which may not yet be merged > into Wine actually; I should probably check that and resubmit) and they > worked

Re: Image List tests for comctl32 v6

2009-10-01 Thread Nikolay Sivov
Joel Holdsworth wrote: Hi All, I'm working on some tests to demonstrate some alpha-channel behaviour in comctl32 ImageLists. The problem is that this behaviour is only present in comctl32 v6, which of course you usually activate with an xml manifest. For the wine test suite we have a helper func

Re: Image List tests for comctl32 v6

2009-10-01 Thread Owen Rudge
Hi Joel, I'm working on some tests to demonstrate some alpha-channel behaviour in comctl32 ImageLists. The problem is that this behaviour is only present in comctl32 v6, which of course you usually activate with an xml manifest. For the wine test suite we have a helper function, load_v6_module,

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing

2009-10-01 Thread Ilya Shpigor
On Tuesday 29 September 2009 10:57:45 you wrote: > You should use SendMessageA instead of SendMessageW to make the test run > under Win9x as well. Testing the return value of SendMessage would be also > helpful. Hi, The TRY 5 of tests had beent sent. Is it correct or my test so bad that nobody

Image List tests for comctl32 v6

2009-10-01 Thread Joel Holdsworth
Hi All, I'm working on some tests to demonstrate some alpha-channel behaviour in comctl32 ImageLists. The problem is that this behaviour is only present in comctl32 v6, which of course you usually activate with an xml manifest. For the wine test suite we have a helper function, load_v6_module, tha

Re: [4/4] msi: Test installing over in-use files.

2009-10-01 Thread Hans Leidekker
On Thursday 01 October 2009 08:46:13 pm Paul Vriens wrote: > > +RegOpenKeyExA(HKEY_LOCAL_MACHINE, key, 0, KEY_ALL_ACCESS,&hkey); > > +if (!RegQueryValueExA(hkey, value, NULL, NULL, NULL,&size)) > > +{ > > +skip("Pending file rename operations, skipping test\n"); > > +re

Re: Wine and Intel 3D

2009-10-01 Thread Roderick Colenbrander
When the Xserver crashes the bug in question is a bug in the display drivers. Wine itself or any other X app won't bring the Xserver down (they can't). Though knowing what changes in Wine triggered this (probably glsl / fbo stuff) could help the intel developers fixing the issue but as I said the i

Re: Wine and Intel 3D

2009-10-01 Thread Erich Hoover
On Thu, Oct 1, 2009 at 12:30 PM, MD.IMAM HOSSAIN wrote: > Dear Developers, > > Latest wine is having problems with Intel UXA 2D driver. > Many games cause X server to restart. > > My system is UBUNTU 9.04. > Tested with Intel 2.8 graphics driver, 2.6.30 rc-4 linux kernel, Mesa > 7.5.2. > > WINE 1.

Re: [4/4] msi: Test installing over in-use files.

2009-10-01 Thread Paul Vriens
On 09/29/2009 02:57 PM, Hans Leidekker wrote: +static char key[] = "System\\CurrentControlSet\\Control\\Session Manager"; +static char value[] = "PendingFileRenameOperations"; + +RegOpenKeyExA(HKEY_LOCAL_MACHINE, key, 0, KEY_ALL_ACCESS,&hkey); +if (!RegQueryValueExA(hkey, valu

Wine and Intel 3D

2009-10-01 Thread MD.IMAM HOSSAIN
Dear Developers, Latest wine is having problems with Intel UXA 2D driver. Many games cause X server to restart. My system is UBUNTU 9.04. Tested with Intel 2.8 graphics driver, 2.6.30 rc-4 linux kernel, Mesa 7.5.2. WINE 1.1.29 = prolem WINE 1.1.18 = NO problem All Linux native games works wonde

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing

2009-10-01 Thread Alexandre Julliard
"Dmitry Timoshkov" writes: > "Ilya Shpigor" wrote: > >> The TRY 5 of tests had beent sent. Is it correct or my test so bad >> that nobody doesn't like to answer? :) > > Try 5 looks good to me (therefore the lack of the comment), not sure > why it wasn't committed. It's still using W functions,

Re: Patch for bug 20227: msi: Table Join on two tables that have same (non-join) column name...

2009-10-01 Thread Hans Leidekker
Hi Nate, Your patch applies with offsets, please rebase to current git. And get rid of this warning: db.c: In function ‘test_where_not_in_selected’: db.c:1576: warning: unused variable ‘count’ > +query = /*"Select IESTable.Action, IESTable.Condition from CATable, > IESTable where "*/ > +

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing

2009-10-01 Thread Dmitry Timoshkov
"Ilya Shpigor" wrote: The TRY 5 of tests had beent sent. Is it correct or my test so bad that nobody doesn't like to answer? :) Try 5 looks good to me (therefore the lack of the comment), not sure why it wasn't committed. -- Dmitry.

Re: Owen Rudge : comctl32: Implement highlighting (marquee) selection support in listview.

2009-10-01 Thread Owen Rudge
Hi Nikolay, Didn't test it much yet, but few issues from a start: I'll look into these issues and try to submit a fix as soon as possible. Cheers, -- Owen Rudge http://www.owenrudge.net/

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

2009-10-01 Thread Nikolay Sivov
Paul Vriens wrote: On 10/01/2009 09:58 AM, Nikolay Sivov wrote: P.S. how could I change a locale on my Debian system for particular Wine run? Could you help me with that? What I usually do is something like LC_ALL=nl_NL.UTF-8 wine or LC_ALL=nl_NL.UTF-8 make monthcal.ok More lang refere

Re: Owen Rudge : comctl32: Implement highlighting (marquee) selection support in listview.

2009-10-01 Thread Nikolay Sivov
Alexandre Julliard wrote: Module: wine Branch: master Commit: 69b76a18fb19bd4a6c83f4f05eb942513af970fd URL: http://source.winehq.org/git/wine.git/?a=commit;h=69b76a18fb19bd4a6c83f4f05eb942513af970fd Author: Owen Rudge Date: Wed Sep 30 16:41:23 2009 +0100 comctl32: Implement highlighting

Re: Peter Dons Tychsen : user32: Add exception handling for timer callbacks.

2009-10-01 Thread Peter Dons Tychsen
On Thu, 2009-10-01 at 12:33 +0200, Alexandre Julliard wrote: > Peter Dons Tychsen writes: > > > Just out of interest: You changed this to a write. Fine. > > But why the volatile? Can GCC assume predetermined results when writing > > to NULL? I don't see any reason to use volatile unless someone e

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Paul Vriens
On 10/01/2009 03:28 PM, Nikolay Sivov wrote: Paul Vriens wrote: On 10/01/2009 02:58 PM, Nikolay Sivov wrote: Yes, please. If a problem is only in rectangle orders it's very simple to fix (test for in returned locale data). I suggest not to drop tests yet, we'll probably want to drop them l

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Nikolay Sivov
Paul Vriens wrote: On 10/01/2009 03:12 PM, Paul Vriens wrote: On 10/01/2009 02:58 PM, Nikolay Sivov wrote: Yes, please. If a problem is only in rectangle orders it's very simple to fix (test for in returned locale data). I suggest not to drop tests yet, we'll probably want to drop them lat

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Nikolay Sivov
Paul Vriens wrote: On 10/01/2009 02:58 PM, Nikolay Sivov wrote: Yes, please. If a problem is only in rectangle orders it's very simple to fix (test for in returned locale data). I suggest not to drop tests yet, we'll probably want to drop them later when trying probable dpi-dependent failur

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Paul Vriens
On 10/01/2009 03:12 PM, Paul Vriens wrote: On 10/01/2009 02:58 PM, Nikolay Sivov wrote: Yes, please. If a problem is only in rectangle orders it's very simple to fix (test for in returned locale data). I suggest not to drop tests yet, we'll probably want to drop them later when trying proba

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Paul Vriens
On 10/01/2009 02:58 PM, Nikolay Sivov wrote: Yes, please. If a problem is only in rectangle orders it's very simple to fix (test for in returned locale data). I suggest not to drop tests yet, we'll probably want to drop them later when trying probable dpi-dependent failures. Well I need to

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Nikolay Sivov
Paul Vriens wrote: On 10/01/2009 02:03 PM, Nikolay Sivov wrote: The first and last character show up 'underneath' the prev/next buttons and the control is smaller than in US-English. This is because the day acronyms are only 2 characters. You're testing on Windows system? Yes, this was on Win

Re: [2/5] WineD3D: SetRenderTarget doesn't change the viewport in d3d7

2009-10-01 Thread Stefan Dösinger
Am 01.10.2009 um 13:47 schrieb Alexandre Julliard: Stefan Dösinger writes: Patches 2, 3 and 4 fix bug 19365. In the long run we want to get rid of the dxVersion parameter that is used in this patch, but we haven't agreed on a way to do this so far, so lets fix the bug first. It doesn't wor

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Paul Vriens
On 10/01/2009 02:03 PM, Nikolay Sivov wrote: Paul Vriens wrote: On 10/01/2009 01:32 PM, Nikolay Sivov wrote: Paul Vriens wrote: On 10/01/2009 12:29 PM, Paul Vriens wrote: Hi, Instead of checking fixed points in the title we now check for the order of items only. I didn't cater for locale di

Re: wininet(3/4): Set callbacks needed by OpenSSL for multithreaded use

2009-10-01 Thread Alexandre Julliard
Juan Lang writes: > +static HANDLE *ssl_locks; > + > +static unsigned long ssl_thread_id(void) > +{ > +return GetThreadId(GetCurrentThread()); > +} You want GetCurrentThreadId(); > +static void ssl_lock_callback(int mode, int type, const char *file, int line) > +{ > +if (mode & CRYPTO_L

Re: [2/9] include: Add MAPI_USE_DEFAULT and MDB_NO_DIALOG definitions to mapix.h

2009-10-01 Thread Alexandre Julliard
Owen Rudge writes: > @@ -51,6 +51,9 @@ typedef ULONG FLAGS; > #ifndef MAPI_EXTENDED > #define MAPI_EXTENDED 0x0020 > #endif > +#ifndef MAPI_USE_DEFAULT > +#define MAPI_USE_DEFAULT0x0040 > +#endif > #ifndef MAPI_FORCE_DOWNLOAD > #define MAPI_FORCE_D

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Nikolay Sivov
Paul Vriens wrote: On 10/01/2009 01:32 PM, Nikolay Sivov wrote: Paul Vriens wrote: On 10/01/2009 12:29 PM, Paul Vriens wrote: Hi, Instead of checking fixed points in the title we now check for the order of items only. I didn't cater for locale differences on Windows (as I don't have a way

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Paul Vriens
On 10/01/2009 01:32 PM, Nikolay Sivov wrote: Paul Vriens wrote: On 10/01/2009 12:29 PM, Paul Vriens wrote: Hi, Instead of checking fixed points in the title we now check for the order of items only. I didn't cater for locale differences on Windows (as I don't have a way to test), so I'm going

Re: [2/5] WineD3D: SetRenderTarget doesn't change the viewport in d3d7

2009-10-01 Thread Alexandre Julliard
Stefan Dösinger writes: > Patches 2, 3 and 4 fix bug 19365. In the long run we want to get rid > of the dxVersion parameter that is used in this patch, but we haven't > agreed on a way to do this so far, so lets fix the bug first. It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Nikolay Sivov
Paul Vriens wrote: On 10/01/2009 12:29 PM, Paul Vriens wrote: Hi, Instead of checking fixed points in the title we now check for the order of items only. I didn't cater for locale differences on Windows (as I don't have a way to test), so I'm going to rely on test.winehq.org after this patch h

Re: [comctl32/tests] Fix some test failures

2009-10-01 Thread Paul Vriens
On 10/01/2009 12:29 PM, Paul Vriens wrote: Hi, Instead of checking fixed points in the title we now check for the order of items only. I didn't cater for locale differences on Windows (as I don't have a way to test), so I'm going to rely on test.winehq.org after this patch has been applied (if,

Re: dwmapi: Add a stub for DwmGetGraphicsStreamTransformHint.

2009-10-01 Thread Alexandre Julliard
Łukasz Wojniłowicz writes: > --- > dlls/dwmapi/dwmapi.spec |2 +- > dlls/dwmapi/dwmapi_main.c |9 + > 2 files changed, 10 insertions(+), 1 deletions(-) Please build a proper numbered series, where each patch is relative to the previous one. -- Alexandre Julliard julli...@win

Re: tools/winebuild: add FreeBSD support (1/2) (RESEND) (fwd)

2009-10-01 Thread Alexandre Julliard
Gerald Pfeifer writes: > [ I'd like to ping this after three weeks. This fixes a real bug > that has reported by a user. Any chance to get it in, or do you > need to see this changed somehow? ] Looks ok but the patch doesn't apply. When resubmitting a patch you have to rebase on current g

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

2009-10-01 Thread Paul Vriens
On 10/01/2009 09:58 AM, Nikolay Sivov wrote: Paul Vriens wrote: On 09/30/2009 12:10 PM, Nikolay Sivov wrote: Paul Vriens wrote: On 09/29/2009 12:36 PM, Nikolay Sivov wrote: Changelog: - be sure we have a single view calendar for hittesting ---

Re: sti: add stubs for the IStillImageW interface (try 2)

2009-10-01 Thread Henri Verbeet
2009/9/30 Damjan Jovanovic : > Changelog: > * sti: add stubs for the IStillImageW interface (try 2) > This leaks, you need to return the internal IUnknown to the caller somehow. I think an explicit QueryInterface for IUnknown is supposed to return lpInternalUnkVtbl, and StiCreateInstanceW() probabl

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

2009-10-01 Thread Nikolay Sivov
Paul Vriens wrote: On 09/30/2009 12:10 PM, Nikolay Sivov wrote: Paul Vriens wrote: On 09/29/2009 12:36 PM, Nikolay Sivov wrote: Changelog: - be sure we have a single view calendar for hittesting Hi Nikolay, This

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

2009-10-01 Thread Paul Vriens
On 09/30/2009 12:10 PM, Nikolay Sivov wrote: Paul Vriens wrote: On 09/29/2009 12:36 PM, Nikolay Sivov wrote: Changelog: - be sure we have a single view calendar for hittesting Hi Nikolay, This one introduces a test f