Fixing shell32:shlexec

2009-09-30 Thread Greg Geldorp
Hi Damjan, > From: Damjan Jovanovic > > Can you not change the application type to GUI at runtime using > MSVCRT's __set_app_type() function? Or does that do something > different? No, unfortunately that won't work for two reasons. First, it only affects how MSVCRT displays error messages (messag

Re: Modifying Subsystem in Winelib executables

2009-09-30 Thread Damjan Jovanovic
On Tue, Sep 29, 2009 at 3:01 PM, Greg Geldorp wrote: >> From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] >> >> Can't we just compile shell32 tests as a GUI app? > > I don't think that will work, but I'll look into it. Wine tests expect > to have access to stdout. At the very least you won't s

Re: firefox build success on visual c++ 2005 on wine!

2009-09-30 Thread André Hentschel
Dan Kegel schrieb: > On Thu, Sep 24, 2009 at 9:46 PM, Dan Kegel wrote: >> Now that AJ fixed http://bugs.winehq.org/show_bug.cgi?id=19783, >> the firefox build procedure runs all the way through >> to the end (at least in release mode; debug builds still fail). > > And the resulting firefox works

Re: [2/5] WineD3D: Start replacing dxVersion with create flags

2009-09-30 Thread Henri Verbeet
009/9/30 Stefan Dösinger : > Are the patches ok with you in that case? Otherwise I'll just fix bug 19365 > with the old dxVersion hack and implement whatever properly designed setup > you prefer the next time I have a few hours to kill(read: On my 16 hour > flight to the google mentor summit later

Re: [2/5] WineD3D: Start replacing dxVersion with create flags

2009-09-30 Thread Stefan Dösinger
Am 30.09.2009 um 16:22 schrieb Henri Verbeet: I prefer that all d3d version specific behaviors in wined3d(ie, those that can't be handled by the client lib alone) are controlled by one wined3d parameter. I don't feel strongly about this though. I could as well make them a parameter of Crea

Re: [1/2] richedit: Added test to show that handle to parent is cached.

2009-09-30 Thread Paul Vriens
On 09/30/2009 03:56 PM, Dylan Smith wrote: --- dlls/riched20/tests/editor.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) Hi Dylan, Could you change SetWindowLongPtrW to the A-

Re: ws2_32: Ignore EINTR poll result code in WS_select

2009-09-30 Thread Alexandre Julliard
Dmitriy Anisimkov writes: > Changelog: > - Ignore EINTR result code from poll call in WS_select. Your timeout computation is still wrong. -- Alexandre Julliard julli...@winehq.org

Re: sti [2/2]: add stubs for the IStillImageW interface

2009-09-30 Thread Alexandre Julliard
Damjan Jovanovic writes: > I'm pretty sure you do need a separate IUnknown interface if the > object aggregates, which it does on Windows (tests will follow). > > IIRC msxml3 does the same in node.c ... I think it's nicer with a single table, but the COM book apparently recommends two, so I gues

Re: sti [2/2]: add stubs for the IStillImageW interface

2009-09-30 Thread Damjan Jovanovic
On Wed, Sep 30, 2009 at 2:21 PM, Alexandre Julliard wrote: > Damjan Jovanovic writes: > >> +static const struct IUnknownVtbl internal_unk_vtbl = >> +{ >> +    Internal_QueryInterface, >> +    Internal_AddRef, >> +    Internal_Release >> +}; >> + >> +static const struct IStillImageWVtbl stillimage

Re: [4/5] WineD3D: Add a create flag for addref in GetPrivateData

2009-09-30 Thread Henri Verbeet
2009/9/30 Stefan Dösinger : > This is hard to implement in the client lib - it would require to remove the > AddRef from wined3d altogether, and pass the priv data flags to the client, > and then AddRef in d3d8, d3d9 and dxgi/d3d10. I can't use a Release in ddraw > because we're calling application

Re: wininet(2/7): Separate loading libssl from loading libcrypto

2009-09-30 Thread Alexandre Julliard
Juan Lang writes: >> There's no reason to invent such complicated locking mechanisms. Just >> put the whole thing inside a critical section and be done with it. > > I already did, in yesterday's patch series. Would you like me to resend? That series is still trying to be too smart for its own g

Re: [2/5] WineD3D: Start replacing dxVersion with create flags

2009-09-30 Thread Henri Verbeet
2009/9/30 Stefan Dösinger : > Is there a real reason this (and the flag from the next patch) has to be set on the wined3d object? If there is, I think WINED3D_CREATE_BUFFER_NO_CONVERSION and WINED3D_CREATE_BUFFER_STATIC_FORMAT would be more appropriate names.

Re: [comctl32/tests] Fix a test failure on several platforms

2009-09-30 Thread Paul Vriens
On 09/30/2009 02:21 PM, Paul Vriens wrote: Hi, Positioning the point test a bit to the left makes this test succeed on more boxes. (Maybe we should add MCHT_TITLEYEAR to the possible outcomes but I'm not too sure about that). Changelog Fix a test failure on several platforms Just checked so

Re: sti [2/2]: add stubs for the IStillImageW interface

2009-09-30 Thread Alexandre Julliard
Damjan Jovanovic writes: > +static const struct IUnknownVtbl internal_unk_vtbl = > +{ > +Internal_QueryInterface, > +Internal_AddRef, > +Internal_Release > +}; > + > +static const struct IStillImageWVtbl stillimagew_vtbl = > +{ > +stillimagew_QueryInterface, > +stillimagew_Add

Re: wininet(2/7): Separate loading libssl from loading libcrypto

2009-09-30 Thread Juan Lang
> There's no reason to invent such complicated locking mechanisms. Just > put the whole thing inside a critical section and be done with it. I already did, in yesterday's patch series. Would you like me to resend? --Juan

Re: wininet(2/7): Separate loading libssl from loading libcrypto

2009-09-30 Thread Alexandre Julliard
Juan Lang writes: > This is a step toward relieving lock serialization, as the two > libraries can be loaded independently. (There is no lock yet, though, > and this still crashes in utorrent. Fixes in the next two patches.) There's no reason to invent such complicated locking mechanisms. Just

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

2009-09-30 Thread Nikolay Sivov
Paul Vriens wrote: On 09/29/2009 12:36 PM, Nikolay Sivov wrote: Changelog: - be sure we have a single view calendar for hittesting Hi Nikolay, This one introduces a test failure on several platforms: monthcal.c:1

Re: Compile error on current Git

2009-09-30 Thread Paul Vriens
On 09/30/2009 10:39 AM, Michael Stefaniuc wrote: Hello Paul, Paul Vriens wrote: Anyone else seeing this: yes, I have pinged Alexandre yesterdays about this and todays commit round will include the fixes. If you don't want to wait the fixes are: - system.drv16 and toolhelp.dll16 need an IMPORT

Re: Compile error on current Git

2009-09-30 Thread Michael Stefaniuc
Hello Paul, Paul Vriens wrote: > Anyone else seeing this: yes, I have pinged Alexandre yesterdays about this and todays commit round will include the fixes. If you don't want to wait the fixes are: - system.drv16 and toolhelp.dll16 need an IMPORT ntdll - ntdll/tests need a GetProcAddress on NtCurr

Compile error on current Git

2009-09-30 Thread Paul Vriens
Hi, Anyone else seeing this: make[2]: Entering directory `/wine/wine-git/dlls/system.drv16' ccache gcc -m32 -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-

Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

2009-09-30 Thread Paul Vriens
On 09/30/2009 09:41 AM, Mike Kaplinskiy wrote: On Wed, Sep 30, 2009 at 2:35 AM, Paul Vriens wrote: On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote: --- dlls/ws2_32/tests/sock.c | 46 +- 1 files changed, 37 insertions(+), 9 deletions(-)

Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

2009-09-30 Thread Mike Kaplinskiy
On Wed, Sep 30, 2009 at 2:35 AM, Paul Vriens wrote: > On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote: >> >> --- >>  dlls/ws2_32/tests/sock.c |   46 >> +- >>  1 files changed, 37 insertions(+), 9 deletions(-) >> >> >> --

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

2009-09-30 Thread Paul Vriens
On 09/29/2009 12:36 PM, Nikolay Sivov wrote: Changelog: - be sure we have a single view calendar for hittesting Hi Nikolay, This one introduces a test failure on several platforms: monthcal.c:1002: Test failed: Ex

Re: firefox build success on visual c++ 2005 on wine!

2009-09-30 Thread Dan Kegel
On Thu, Sep 24, 2009 at 9:46 PM, Dan Kegel wrote: > Now that AJ fixed http://bugs.winehq.org/show_bug.cgi?id=19783, > the firefox build procedure runs all the way through > to the end (at least in release mode; debug builds still fail). And the resulting firefox works in wine, too! I'm using it