On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote:
---
dlls/ws2_32/tests/sock.c | 46 +-
1 files changed, 37 insertions(+), 9 deletions(-)
Hi Mike,
This one has introduced a
On Monday 28 September 2009 19:36:05 you wrote:
> Could you please add a test for that?
Test for this patch has been sent:
comctl32/tests: Add test for setting the tooltips position by parent
--
Best regards,
Ilya Shpigor.
Am 29.09.2009 um 15:09 schrieb Markus Stockhausen:
Sorry for the incomplete topic of my first mail.
The patch looks ok to me
Hi Hans,
> The bug reporter sees long delays between torrents starting up after
> applying these patches, which makes we wonder if the ssl lock effectively
> serializes secure https requests?
There isn't a single SSL lock. There's an interlocked exchange for
assigning SSL_CTX, which should only
On 09/29/2009 03:33 PM, Markus Stockhausen wrote:
Am Dienstag, den 29.09.2009, 15:10 +0200 schrieb Paul Vriens:
On 09/29/2009 03:01 PM, Markus Stockhausen wrote:
Hi Markus,
Please stick to the coding style of the fil
Am Dienstag, den 29.09.2009, 15:10 +0200 schrieb Paul Vriens:
> On 09/29/2009 03:01 PM, Markus Stockhausen wrote:
> >
> >
> >
> >
> >
> Hi Markus,
>
> Please stick to the coding style of the file, or at least the
> surroundi
On Sa, 2009-09-26 at 22:15 -0500, Mike Ruprecht wrote:
> +if (lpszSearchPath)
> +HeapFree(GetProcessHeap(), 0, lpszSearchPath);
> +
Please remove the unneeded if(lpszSearchPath) before HeapFree.
--
By by ... Detlef
writes:
> @@ -1401,7 +1405,7 @@ static void test_getdatahere(void)
> hr = IDataObject_GetDataHere(get, &fmt, &med);
> ok(hr == S_OK, "got %08x\n", hr);
> ok(med.tymed == TYMED_HGLOBAL, "got %x\n", med.tymed);
> -ReleaseStgMedium(&med);
> +if(SUCCEEDED(hr)) ReleaseStgMedium(
Juan Lang writes:
> +static void set_process_affinity( struct process *process, affinity_t
> affinity )
> +{
> +struct thread *thread;
> +
> +process->affinity = affinity;
> +
> +suspend_process( process );
> +LIST_FOR_EACH_ENTRY( thread, &process->thread_list, struct thread,
>
On 09/29/2009 03:01 PM, Markus Stockhausen wrote:
Hi Markus,
Please stick to the coding style of the file, or at least the
surrounding code (implementation and test).
--
Cheers,
Paul.
> From: Paul Vriens [mailto:paul.vriens.w...@gmail.com]
>
> Can't we just compile shell32 tests as a GUI app?
I don't think that will work, but I'll look into it. Wine tests expect
to have access to stdout. At the very least you won't see output when
running the test manually on Windows. Not sure
On Di, 2009-09-29 at 13:27 +0200, Markus Stockhausen wrote:
> The test will fail in Windows and Wine to get the results in both
> cases.
> The result will show like this:
>
> dsurface.c:1264: Test failed: backbuffer surface has
> dwBackBufferCount==2
This is 0 here with ATI Radeon R100 on Win98se
Am Dienstag, den 29.09.2009, 13:42 +0200 schrieb Paul Vriens:
> Hi Markus,
>
> On fully up-to-date Windows XP Professional SP3:
>
> dsurface.c:1262: Test failed: backbuffer surface has dwBackBufferCount==0
>
>
Thanks to Jeff and Paul for your cross checks. The result makes me happy
and I will
On Tue, Sep 29, 2009 at 9:27 PM, Markus Stockhausen
wrote:
> Hi,
>
> currently I'm investigating bug 1660 and hopefully I found the reason
> for the misbehaviour. The only problem is, that I do not know what
> results I have to expect in windows. So it would be very helpful if
> someone can execut
On 09/29/2009 01:27 PM, Markus Stockhausen wrote:
Hi,
currently I'm investigating bug 1660 and hopefully I found the reason
for the misbehaviour. The only problem is, that I do not know what
results I have to expect in windows. So it would be very helpful if
someone can execute the attached test
Hi,
currently I'm investigating bug 1660 and hopefully I found the reason
for the misbehaviour. The only problem is, that I do not know what
results I have to expect in windows. So it would be very helpful if
someone can execute the attached testcase in a native environment so
that I can fix the e
Hi Juan,
> These patches collectively fix bug 18364, which was a crash in OpenSSL
> in a multithreaded app (utorrent.exe.)
The bug reporter sees long delays between torrents starting up after
applying these patches, which makes we wonder if the ssl lock effectively
serializes secure https request
On 09/29/2009 12:11 PM, Greg Geldorp wrote:
To fix one of the tests (shell32:shlexec) I'd like to copy the test executable
and change the Subsystem type from IMAGE_SUBSYSTEM_WINDOWS_CUI (console app) to
IMAGE_SUBSYSTEM_WINDOWS_GUI (GUI app) in the copy. Piece of cake for PE files,
get the IMAGE_D
Greg Geldorp writes:
> My limited understanding of the structure of Winelib executables makes doing
> the same for testing on Wine quite a bit harder. I assume there's still a
> IMAGE_NT_HEADERS structure in there somewhere and with some research I'll
> probably be able to locate it in Linux ELF
Peter Oberndorfer writes:
> +#define test_streamsize(stream, size) \
> +{ \
> +STATSTG stat; \
> +HRESULT result; \
> +result = IStream_Stat(stream, &stat, STATFLAG_NONAME); \
> +ok(result == S_OK, "IStream::Stat failed %08x\n", result); \
> +ok(stat.cbSize.QuadPart == size, "
Paul Vriens wrote:
On 09/27/2009 07:51 PM, Nikolay Sivov wrote:
Changelog:
- Inependent tests are always better and more scalable.
Hi Nikolay,
This one seems (there were more for monthcal.c) to have introduced 2
To fix one of the tests (shell32:shlexec) I'd like to copy the test executable
and change the Subsystem type from IMAGE_SUBSYSTEM_WINDOWS_CUI (console app) to
IMAGE_SUBSYSTEM_WINDOWS_GUI (GUI app) in the copy. Piece of cake for PE files,
get the IMAGE_DOS_HEADER, follow it to the IMAGE_NT_HEADERS a
On 09/27/2009 07:51 PM, Nikolay Sivov wrote:
Changelog:
- Inependent tests are always better and more scalable.
Hi Nikolay,
This one seems (there were more for monthcal.c) to have introduced 2
test failures on a
On Sat, 26 Sep 2009, Paul Chitescu wrote:
[...]
> What you're proposing here is essentially an overlay file system.
[...]
> You should also know that any such simplistic approach can fail in
> interesting
> and hardly to debug ways unless the user's prefix is wiped (which you already
> noted) wh
extrac32 is not a console program; on Windows it doesn't create a
console and doesn't write anything to stdout or stderr regardless of
command line. I agree those FIXMEs you pointed out are not FIXMEs really
- some of them are errors and some should be warnings. I'll fix them.
Kirill K. Smirno
Hi,
+int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline,
int show )
+{
extrac32 is a console application, isn't it? Why not wmain() instead? And get
rid of rather complex ParseCmdLine().
+if (!SetupIterateCabinetW( pszCabFile, 0, (PSP_FILE_CALLBACK)
ExtCabCallback, 0
26 matches
Mail list logo
