Re: [3/4] user32/cursoricon.c: Multiple Fixes/Improvements for DrawIconEx

2009-09-26 Thread Vitaliy Margolen
Wilfried Pasquazzo wrote: > Best regards, > > Subject: Make DrawIconEx 2 additional tests (now passes all tests) > Subject: Make DrawIconEx pass a test You should really combine these 2 patches. You are modifying the same exact code and breaking it between patches (for some programs). Vitaliy.

Appinstall now supports standalone testing

2009-09-26 Thread Austin English
Howdy all, I've tweaked appinstall slightly so that anyone can run it without needing an ssh webserver to host the files. Simply do: $ wget http://winezeug.googlecode.com/svn/trunk/appinstall/appinstall.sh $ sh appinstall.sh That will download all the programs and run the tests. The results will

Re: [3/4] user32/cursoricon.c: Multiple Fixes/Improvements for DrawIconEx

2009-09-26 Thread Juan Lang
Hi Wilfried, minor comment on this patch: hBitTemp = SelectObject( hMemDC, hXorBits ); + +UINT bltFlag = 0; C89 doesn't allow you to mix code and declarations like this. You'll have to declare bltFlag at the top of the block. --Juan

Re: kernel32: check parameter of CheckRemoteDebuggerPresent with tests

2009-09-26 Thread Alexandre Julliard
Stefan Leichter writes: > +SetLastError(0xdeadbeef); > +bret = pCheckRemoteDebuggerPresent(INVALID_HANDLE_VALUE,NULL); > +ok(!bret , "expected CheckRemoteDebuggerPresent to fail\n"); > +ok(ERROR_INVALID_PARAMETER == GetLastError(), > + "expected error ERROR_INVALID_PARAMETER

Re: [PATCH 2/4] mshtml: Add test suite for IHTMLLocation

2009-09-26 Thread Detlef Riekenberg
On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: > +todo_wine ok(SUCCEEDED(hres), "get_hash failed: 0x%08x\n", > hres); > +if(SUCCEEDED(hres)){ > +if(str_pass) > +ok(strcmp_wa_null(str, exp) == 0, "expected retrieved > hash to be L\"%s\", was: %s\n", exp, wine_d

Re: sti: test behavior of creation with the A/W functions versus STI_VERSION_FLAG_UNICODE

2009-09-26 Thread Detlef Riekenberg
On Fr, 2009-09-25 at 16:35 +0200, Damjan Jovanovic wrote: > * sti: test behavior of creation with the A/W functions versus > STI_VERSION_FLAG_UNICODE Using the name "sti_tests" is bad. The short "sti" is enough. You forgot the license notice We usually cast the result of GetProcAddress() as (void

Re: RFC: Sharing a wineprefix

2009-09-26 Thread Vit Hrachovy
Hi Paul, as usual admin of home PC server with few users sharing installed games, I'm really missing feature similar to this in Wine. You've got my vote and should you need testing, I'm glad to help. Regards Hark

Running 13 months locales

2009-09-26 Thread Nikolay Sivov
Hi. Working on monthcal control I've realized that some locales could have 13 months calendars. How could I guess that I'm running such locale? After a brief look I didn't find anything useful in GetLocaleInfo().

Re: [PATCH 3/4] mshtml: Add helper function get_url_components

2009-09-26 Thread Detlef Riekenberg
On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: > +static HRESULT get_url_components(HTMLLocation *This, URL_COMPONENTSW > *url) > +{ > +const WCHAR *doc_url; > +if(!InternetCrackUrlW(doc_url, 0, 0, url)) { > +FIXME("InternetCrackUrlW failed\n"); Such a FIXME does not help t

Re: cppcheck sept 18 redux

2009-09-26 Thread Detlef Riekenberg
On Di, 2009-09-22 at 07:46 -0700, Chris Robinson wrote: > so dmW->dmFormName is the same as &(*dmW).dmFormName, When the target is an array, the address of the first member is returned: dmW->fmFormName is: &(dmW->dmFormName[0]) similar: char buffer[32]; printf("buffer at %p\n", buffer); which

Re: user32: Add check for the need to redraw static control after STM_SETIMAGE and STM_SETICON

2009-09-26 Thread Nikolay Sivov
Ilya Shpigor wrote: Hi, This patch fix the redrawing static controls after the processing STM_SETIMAGE and STM_SETICON messages with errors. --- + if ((style & SS_TYPEMASK) != SS_ICON) return (HICON)-1; ... + if ((style & SS_TYPEMASK) != SS_BITMAP) return (HBITMAP)-1; ... + if ((style & SS_

Re: RFC: Sharing a wineprefix

2009-09-26 Thread Paul Chitescu
On Saturday 26 September 2009 02:19:53 Avery Pennarun wrote: > On Fri, Sep 25, 2009 at 3:35 PM, Paul Chitescu wrote: > > Required changes I've identified so far: > >        - The R/W lock to the prefix > >        - wineserver -k as admin should terminate all users' instances > >        - wineserve