Ignore EINTR poll result code in WS_select

2009-09-24 Thread Dmitriy Anisimkov
Dear Wine Developers, Looks like such ignorance is usual practice in wine. I just need to ignore EINTR in one more place. Otherwise our client application is bad working in Wine. >From 45c8b9f64ff4bb961a34182a5051aaf082c127cd Mon Sep 17 00:00:00 2001 From: Dmitriy Anisimkov Date: Sun, 1 Feb 200

Re: newbie question

2009-09-24 Thread Dmitry Timoshkov
"James Mckenzie" wrote: can somebody tell weather it is possible to run NT service on Wine, especially written in Delphi VCL(TService) Just run it and see how it goes. If you face some bugs - open a bug report in the Wine bugzilla, preferably with a test case, since you can replicate one usin

Re: [4/7] comctl32/updown: Show that UDS_SETBUDDYINT switching doesn't affect behaviour for already created control

2009-09-24 Thread Paul Vriens
On 09/20/2009 10:02 PM, Nikolay Sivov wrote: From 8981901ce08501229487a1fcd2d430490cb66823 Mon Sep 17 00:00:00 2001 From: Nikolay Sivov Date: Sun, 20 Sep 2009 02:52:39 +0400 Subject: Tests to show that UDS_SETBUDDYINT switching doesn't affect behaviour for already created control --- dlls/co

Re: Wine-Tango Updates

2009-09-24 Thread Francois Gouget
Thanks. The dxdiag icon is much better. -- Francois Gouget http://fgouget.free.fr/ Indifference will certainly be the downfall of mankind, but who cares?

Re: [bugzilla] donate to sponsoring bug

2009-09-24 Thread Francois Gouget
On Fri, 25 Sep 2009, Ben Klein wrote: [...] > "I pledged $200 to get the DIB Engine fixed two weeks ago an it still > hasn't been done. What's going on?" That's just an argument for closing Bugzilla. Otherwise you're going to offend all those who took the time to enter a bug (time=money) whose bu

firefox build success on visual c++ 2005 on wine!

2009-09-24 Thread Dan Kegel
Moo hoo ha ha ha! Now that AJ fixed http://bugs.winehq.org/show_bug.cgi?id=19783, the firefox build procedure runs all the way through to the end (at least in release mode; debug builds still fail). Here's a log showing the whole build: http://kegel.com/wine/log.txt And, if AJ likes my hidden att

Re: [bugzilla] donate to sponsoring bug

2009-09-24 Thread Ben Klein
2009/9/24 Francois Gouget : > On Tue, 22 Sep 2009, Ben Klein wrote: > [...] >> The real issue is that anything that *looks* (to a normal user) like >> "give money and get your bug fixed" is not going to be good for the >> Wine project. That includes pledges. > > That's just your opinion (both that

Re: dlls/user32/edit.c -- remove superflous check

2009-09-24 Thread Austin English
On Thu, Sep 24, 2009 at 3:15 PM, todd baker wrote: You forgot the patch. -- -Austin

Re: Fix for Bug 19851 (try 3) - Interlocked instruction support for ARM

2009-09-24 Thread Colin Fowler
I've only tested on ARM and wasn't comfortable enabling it for all other architectures (although I too see no reason why it wouldn't work). Colin Alexandre Julliard wrote: Colin Fowler writes: @@ -396,6 +396,88 @@ "beq $1,L0xchg_add\n\t" "mb") + +#

Re: richedit: Silence fixme for WM_STYLECHANGING & WM_STYLECHANGED.

2009-09-24 Thread Dylan Smith
On Thu, Sep 24, 2009 at 2:25 PM, James Mckenzie wrote: > >From: Dylan Smith > >Sent: Sep 24, 2009 6:02 AM > >To: wine-patches > >Subject: richedit: Silence fixme for WM_STYLECHANGING & WM_STYLECHANGED. > > > >I have tried changing the different styles, and have noticed that they > >don't have an

Re: shell32: stub ShellHookProc for the Aion launcher

2009-09-24 Thread Juan Lang
> Doesn't CALLBACK signify cdecl, not stdcall? Nope, it's stdcall. --Juan

Re: shell32: stub ShellHookProc for the Aion launcher

2009-09-24 Thread Chris Robinson
On Thursday 24 September 2009 11:54:33 am Aric Stewart wrote: > +@ stdcall ShellHookProc(long long long) ... > +LRESULT CALLBACK ShellHookProc(DWORD a, DWORD b, DWORD c) Doesn't CALLBACK signify cdecl, not stdcall?

Re: comctl32: initial theming tests

2009-09-24 Thread André Hentschel
Nikolay Sivov schrieb: > Why not reuse this > > +static const CHAR manifest[] = > > from v6util.h. > > Also it's better to introduce new create/delete manifest helpers in this > header and use them. > > It's better to use already defined classnames here: > --- > + struct classlist {WCHAR class[

Re: richedit: Silence fixme for WM_STYLECHANGING & WM_STYLECHANGED.

2009-09-24 Thread James Mckenzie
>From: Dylan Smith >Sent: Sep 24, 2009 6:02 AM >To: wine-patches >Subject: richedit: Silence fixme for WM_STYLECHANGING & WM_STYLECHANGED. > >I have tried changing the different styles, and have noticed that they >don't have any effect. The initial styles are the ones actually used, >which is wh

Re: Fix for Bug 19851 (try 4) - Interlocked instruction support for ARM

2009-09-24 Thread André Hentschel
On Thu, Sep 24, 2009 at 12:19 PM, Colin Fowler wrote: > Removed trailing white-spaces. I think this is good to go now :) every "else" still has trailing white-spaces and the first comment line("\* "). BTW i like that someone works on the ARM port. thats great! -- Best Regards, André Hentschel

Re: newbie question

2009-09-24 Thread James Mckenzie
>Hello All, > >can somebody tell weather it is possible to run NT service on Wine, >especially written in Delphi VCL(TService) > Services do not natively run on Wine startup. You have to start them and then leave at least one window open. If your service depends on direct hardware access or the

Re: [kernel32/tests] Fix some test failures on WinMe

2009-09-24 Thread Paul Vriens
On 09/24/2009 03:22 PM, Alexandre Julliard wrote: Paul Vriens writes: @@ -1894,10 +1895,18 @@ static void test_FindFirstFileExA(void) ok(FindNextFile(handle,&search_results), "Fetching third file failed\n"); ok(CHECK_NAME(search_results.cFileName), "Invalid third entry - %s\n", se

Re: Fix for Bug 19851 (try 4) - Interlocked instruction support for ARM

2009-09-24 Thread Austin English
On Thu, Sep 24, 2009 at 12:19 PM, Colin Fowler wrote: > Removed trailing white-spaces. I think this is good to go now :) Close ;-). > +#elif defined(__arm__) Like AJ said, if it's generic enough to be used on most archs, it should be the fall back. So instead of '+#elif defined(__arm__)', use '

Re: Fix for Bug 19851 (try 3) - Interlocked instruction support for ARM

2009-09-24 Thread André Hentschel
You have some trailing whitespaces in your patch. As far as i had a look it is mostly the intendation from an empty line. -- Best Regards, André Hentschel

Re: comctl32: initial theming tests

2009-09-24 Thread Roderick Colenbrander
> BTW. Do you plan to reregister all user32 classes on comctl32 load? How > could this be done at user32 side - testing for something like > IsThemeActive() while loading user32? > I have been toying with this a bit and trying to figure out how it works. From MSDN info and info from a site which h

newbie question

2009-09-24 Thread Dmitry Konnov
Hello All, can somebody tell weather it is possible to run NT service on Wine, especially written in Delphi VCL(TService) tx. dima

Re: [bugzilla] donate to sponsoring bug

2009-09-24 Thread Austin English
On Thu, Sep 24, 2009 at 8:16 AM, Francois Gouget wrote: > That said I really don't care much because the Wine project would not > know what to do with the money anyway. It's not that sponsoring > developers to go to the Wine conference is not good but it does not > scale. > > So if we raised 1

Re: Fix for Bug 19851 (try 3) - Interlocked instruction support for ARM

2009-09-24 Thread Alexandre Julliard
Colin Fowler writes: > @@ -396,6 +396,88 @@ >"beq $1,L0xchg_add\n\t" >"mb") > > + > +#elif defined(__arm__) > + > +/* > + * Similar to the Sparc, many ARM CPUs lack the necessary > + * atomic instructions. Fall back in a similar way, but instead > + *

Re: [kernel32/tests] Fix some test failures on WinMe

2009-09-24 Thread Paul Vriens
On 09/24/2009 03:22 PM, Alexandre Julliard wrote: Paul Vriens writes: @@ -1894,10 +1895,18 @@ static void test_FindFirstFileExA(void) ok(FindNextFile(handle,&search_results), "Fetching third file failed\n"); ok(CHECK_NAME(search_results.cFileName), "Invalid third entry - %s\n", se

Re: [1/4] ntdll: add initial test for NtQueryDirectoryFile(), improve test for NtQueryInformationFile() (take 3)

2009-09-24 Thread Alexandre Julliard
Dan Kegel writes: > Change since last try: > - let NtQueryInformationFile() return STATUS_NOT_IMPLEMENTED > (seems to on Vista Home Basic), don't fail if other attributes set Please send unrelated changes as separate patches. -- Alexandre Julliard julli...@winehq.org

Re: [kernel32/tests] Fix some test failures on WinMe

2009-09-24 Thread Alexandre Julliard
Paul Vriens writes: > @@ -1894,10 +1895,18 @@ static void test_FindFirstFileExA(void) > ok(FindNextFile(handle, &search_results), "Fetching third file > failed\n"); > ok(CHECK_NAME(search_results.cFileName), "Invalid third entry - %s\n", > search_results.cFileName); > > -ok(Find

Re: advapi32: implement LsaLookupSids

2009-09-24 Thread Alexandre Julliard
Aric Stewart writes: > +{ > +name_size = domain_size = 0; > +(*Names)[i].Use = SidTypeUnknown; > +(*Names)[i].DomainIndex = -1; > +(*Names)[i].Name.Length = 0; > +(*Names)[i].Name.MaximumLength = 0; > +(*Names)[i].Name.Buffer = NULL; > +

Re: [bugzilla] donate to sponsoring bug

2009-09-24 Thread Francois Gouget
On Tue, 22 Sep 2009, Ben Klein wrote: [...] > The real issue is that anything that *looks* (to a normal user) like > "give money and get your bug fixed" is not going to be good for the > Wine project. That includes pledges. That's just your opinion (both that pledges == donations and that they

Re: (try 3) shlwapi: implement StrChrNW

2009-09-24 Thread Aric Stewart
Ah that is what i get for trying to rush to get this written before breakfast. try 4 coming. -aric Paul Vriens wrote: On 09/24/2009 02:19 PM, Aric Stewart wrote: includes test to show that MSDN is wrong and the search IS case-sensitive. thanks for all the comments. --- dlls/shlwapi/shlwa

Re: (try 3) shlwapi: implement StrChrNW

2009-09-24 Thread Paul Vriens
On 09/24/2009 02:19 PM, Aric Stewart wrote: includes test to show that MSDN is wrong and the search IS case-sensitive. thanks for all the comments. --- dlls/shlwapi/shlwapi.spec | 1 + dlls/shlwapi/string.c | 22 ++ dlls/shlwapi/tests/string.c | 22 ++ 3 fil

Re: (resend) shlwapi: implement StrChrNW

2009-09-24 Thread Aric Stewart
I will write up a conformance test to check. It should not be too hard. thanks, -aric Alexandre Julliard wrote: Aric Stewart writes: MSDN states that "The comparison is not case-sensitive" Considering that there is also a StrChrNIW, it's a pretty safe bet that MSDN is once again on crack.

Re: (resend) shlwapi: implement StrChrNW

2009-09-24 Thread Alexandre Julliard
Aric Stewart writes: > MSDN states that "The comparison is not case-sensitive" Considering that there is also a StrChrNIW, it's a pretty safe bet that MSDN is once again on crack. -- Alexandre Julliard julli...@winehq.org

Re: shlwapi: implement StrChrNW

2009-09-24 Thread Bruno Jesus
On Thu, Sep 24, 2009 at 00:32, Dmitry Timoshkov wrote: > "Aric Stewart" wrote: > >> +LPWSTR WINAPI StrChrNW(LPCWSTR lpszStr, WCHAR ch, UINT cchMax) >> +{ >> +  TRACE("(%s(%i),%i)\n", debugstr_wn(lpszStr,cchMax), cchMax, ch); >> + >> +  if (lpszStr) >> +  { >> +    ch = toupperW(ch); >> +    while

Re: ole32/tests: Test for nested storage reference counting

2009-09-24 Thread Henri Verbeet
2009/9/24 James McKenzie : > Please resend in git format.  AJ will reject this patch outright. > I don't see what's wrong with the patch format, although git is certainly a more convenient way to generate patches, for the sender. The patch does have some trailing spaces.