Re: (resend) shlwapi: implement StrChrNW

2009-09-23 Thread Paul Vriens
On 09/24/2009 04:04 AM, Aric Stewart wrote: MSDN states that "The comparison is not case-sensitive" -aric Jacek Caban wrote: Hi Aric, Aric Stewart wrote: --- dlls/shlwapi/shlwapi.spec | 1 + dlls/shlwapi/string.c | 23 +++ 2 files changed, 24 insertions(+), 0 deletions(-)

Re: shlwapi: implement StrChrNW

2009-09-23 Thread Dmitry Timoshkov
"Aric Stewart" wrote: +LPWSTR WINAPI StrChrNW(LPCWSTR lpszStr, WCHAR ch, UINT cchMax) +{ + TRACE("(%s(%i),%i)\n", debugstr_wn(lpszStr,cchMax), cchMax, ch); + + if (lpszStr) + { +ch = toupperW(ch); +while (*lpszStr && cchMax > 0) +{ + if (toupperW(*lpszStr) == ch) +re

Re: ole32/tests: Test for nested storage reference counting

2009-09-23 Thread James McKenzie
Markus Stockhausen wrote: > Hi, > > as Nikolay had some tipps for the patch (layout of header and coding) I > attach a new version of the testcase for IStorage reference counters. > Please resend in git format. AJ will reject this patch outright. James McKenzie

Re: (resend) shlwapi: implement StrChrNW

2009-09-23 Thread Aric Stewart
MSDN states that "The comparison is not case-sensitive" -aric Jacek Caban wrote: Hi Aric, Aric Stewart wrote: --- dlls/shlwapi/shlwapi.spec |1 + dlls/shlwapi/string.c | 23 +++ 2 files changed, 24 insertions(+), 0 deletions(-) I didn't test it myself, but St

Re: Submitted Bug Link accepted but not showing up

2009-09-23 Thread Rosanne DiMesio
On Wed, 23 Sep 2009 10:47:50 -0600 Erich Hoover wrote: > I received an email that a "Bug Link" I requested was accepted, but it's not > showing up: > http://appdb.winehq.org/objectManager.php?sClass=version&iId=11395 > > Relevant text: > The bug link you submitted between Bug 7929 and Command &

Coverity access

2009-09-23 Thread John Klehm
Is there a local list of coverity defects for people like me with a spare moment here and there? Or if not is it possible to get me signed up? Thanks, --John Klehm

jscript: Update French translation

2009-09-23 Thread Frédéric Delanoy
From 0534d28b42cd412ddf299720d5a3e26a1d52e49b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Delanoy?= Date: Wed, 23 Sep 2009 22:22:41 +0200 Subject: jscript: Update French translation --- dlls/jscript/jscript_Fr.rc |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) di

Re: (resend) shlwapi: implement StrChrNW

2009-09-23 Thread Jacek Caban
Hi Aric, Aric Stewart wrote: --- dlls/shlwapi/shlwapi.spec |1 + dlls/shlwapi/string.c | 23 +++ 2 files changed, 24 insertions(+), 0 deletions(-) I didn't test it myself, but StrChrNW name suggests, that the search shouldn't be case insensitive. Jacek

Re: shlwapi: implement StrChrNW

2009-09-23 Thread Nikolay Sivov
Aric Stewart wrote: --- dlls/shlwapi/shlwapi.spec |1 + dlls/shlwapi/string.c | 23 +++ 2 files changed, 24 insertions(+), 0 deletions(-) Maybe it's better to move this --- +@ stdcall StrChrNW(wstr long long) --- closer to context: --- @ stdcall StrChrA (str long)

Re: comctl32: initial theming tests

2009-09-23 Thread Nikolay Sivov
André Hentschel wrote: tests class redirection and "load"-order atm --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/theming.c | 301 +++ 2 files changed, 302 insertions(+), 0 deletions(-) create mode 100644 dlls/comctl32/tests/theming.c

Submitted Bug Link accepted but not showing up

2009-09-23 Thread Erich Hoover
I received an email that a "Bug Link" I requested was accepted, but it's not showing up: http://appdb.winehq.org/objectManager.php?sClass=version&iId=11395 Relevant text: The bug link you submitted between Bug 7929 and Command & Conquer 3: Tiberium Wars Kane's Wrath: 1.0 has been accepted. ... An

Re: [4/4] user32: Prevent clipboard viewers that change the clipboard from going into an infinite loop.

2009-09-23 Thread Alexandre Julliard
Alexander Scott-Johns writes: > @@ -287,6 +287,7 @@ BOOL WINAPI OpenClipboard( HWND hWnd ) > */ > BOOL WINAPI CloseClipboard(void) > { > +static BOOL bRecursion = FALSE; > BOOL bRet = FALSE; You shouldn't use a static variable, this would have to be per-thread. But it's probably bet