Re: cppcheck sept 18 redux

2009-09-21 Thread Mike Kaplinskiy
On Tue, Sep 22, 2009 at 1:09 AM, Vitaliy Margolen wrote: > Ben Klein wrote: >> The question remains, how exactly does >> FIELD_OFFSET work, and does it end up dereferencing ca[5]? > It does pointer arithmetic and does not dereference anything. "ca[5]" is the > same as "(ca + 5)" or on lower level

Re: tools/winegcc: fix linker for Haiku

2009-09-21 Thread Austin English
On Mon, Sep 21, 2009 at 11:39 PM, Detlef Riekenberg wrote: > On Mo, 2009-09-21 at 01:52 -0500, Austin English wrote: >> +#ifdef __HAIKU__ >> +       strarray_add(link_args, "-lroot"); >> +#else >> +       strarray_add(link_args, "-lm"); >> +       strarray_add(link_args, "-lc"); >> +#endif >> +  

Re: cppcheck sept 18 redux

2009-09-21 Thread Vitaliy Margolen
Ben Klein wrote: > The question remains, how exactly does > FIELD_OFFSET work, and does it end up dereferencing ca[5]? It does pointer arithmetic and does not dereference anything. "ca[5]" is the same as "(ca + 5)" or on lower level "((char*)ca + 5*sizeof(ca[0]))" and does not require any dereferen

Re: tools/winegcc: fix linker for Haiku

2009-09-21 Thread Detlef Riekenberg
On Mo, 2009-09-21 at 01:52 -0500, Austin English wrote: > +#ifdef __HAIKU__ > + strarray_add(link_args, "-lroot"); > +#else > + strarray_add(link_args, "-lm"); > + strarray_add(link_args, "-lc"); > +#endif > + } "autoconf.ac" was designed to avoid OS dependant "#ifdef". Test

Re: [bugzilla] donate to sponsoring bug

2009-09-21 Thread Ben Klein
2009/9/22 Tom Wickline : > What about a hybrid Donate/Pledge box? I'm aware there is a Donate section > on the main site. But could this somehow be Incorporated into the rest of > the site? > Bugs and Apps DB or would it just be tacky :) The real issue is that anything that *looks* (to a normal us

Re: user32/tests: Add tests for STM_SETIMAGE and STM_SETICON messageprocessing

2009-09-21 Thread Dmitry Timoshkov
"Ilya Shpigor" wrote: +SendMessageW(hStatic, STM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)hbm); +res = SendMessageW(hStatic, STM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)hbm); +ok(!res, "expected NULL got 0x%lx\n", res); + +SendMessageW(hStatic, STM_SETIMAGE, (WPARAM)IMAGE_ICON,

Re: [bugzilla] donate to sponsoring bug

2009-09-21 Thread Tom Wickline
What about a hybrid Donate/Pledge box? I'm aware there is a Donate section on the main site. But could this somehow be Incorporated into the rest of the site? Bugs and Apps DB or would it just be tacky :) Cheers, Tom On Mon, Sep 21, 2009 at 10:07 AM, Francois Gouget wrote: > On Wed, 16 Sep 200

Re: Wine-Tango Updates

2009-09-21 Thread Scott Ritchie
Joel Holdsworth wrote: > Hi All, > > Thanks to those of you who made comments about my Tango icon set. I've > thought carefully about all the comments I've received, and I'm most of > the way through the issues raised. I've revised idb_std_large.bmp, > idb_std_small.bmp, floppy.ico, mycomputer.ico

Request to re-open C&C3 networking bug

2009-09-21 Thread Erich Hoover
I made this request in the bug, but I figured it would be good to post here as well. I've posted a patch to Bug 7929 (C&C 3 network does not work) that I believe addresses the concerns people have addressed over previous attempts to fix the issue. So, I would like to request that the bug be re-op

Re: SPAM-LOW: Re: Wine in Tango

2009-09-21 Thread King InuYasha
As far as I know, shellstyles do not contain icons, but rather resource data for theming, such as how the start menu will be displayed. For example, a XP theme I used quite a few years ago removed the Start text from the start menu and replaced the green button with the image of Sonic. Icons have a

Re: SPAM-LOW: Re: Wine in Tango

2009-09-21 Thread Roderick Colenbrander
As shown on the screenshots here from windowblinds it is able to override shell icons. I have no idea how it is doing that though. http://frogboy.joeuser.com/article/150608 Roderick On Tue, Sep 22, 2009 at 12:35 AM, Roderick Colenbrander wrote: > I think I read somewhere that shellstyle.dll (tha

Re: SPAM-LOW: Re: Wine in Tango

2009-09-21 Thread Roderick Colenbrander
I think I read somewhere that shellstyle.dll (that's the name) can contain icons (and I guess effects as well) but I'm not 100% sure. I would guess that we need to download some themes which have a shellstyle and see what's in it. Roderick On Tue, Sep 22, 2009 at 12:27 AM, Joel Holdsworth wrote:

Re: Wine-Tango Updates

2009-09-21 Thread Nikolay Sivov
Joel Holdsworth wrote: Hi All, Thanks to those of you who made comments about my Tango icon set. I've thought carefully about all the comments I've received, and I'm most of the way through the issues raised. I've revised idb_std_large.bmp, idb_std_small.bmp, floppy.ico, mycomputer.ico, netdrive

Re: SPAM-LOW: Re: Wine in Tango

2009-09-21 Thread Joel Holdsworth
On Mon, 2009-09-21 at 16:02 +0200, Roderick Colenbrander wrote: > As of XP themes can specify their own icons. For some dlls I believe > shell32 they need to provide their own shellapi.dll or whatever it is > called. I think that would be the way to proceed. I would suggest to > make Tango the base

Wine-Tango Updates

2009-09-21 Thread Joel Holdsworth
Hi All, Thanks to those of you who made comments about my Tango icon set. I've thought carefully about all the comments I've received, and I'm most of the way through the issues raised. I've revised idb_std_large.bmp, idb_std_small.bmp, floppy.ico, mycomputer.ico, netdrive.ico, netdrive2.ico, shor

Re: Fix for Bug 19851 - Interlocked instruction support for ARM

2009-09-21 Thread Austin English
2009/9/21 André Hentschel : >> >> This patch fixes bug 19851 http://bugs.winehq.org/show_bug.cgi?id=19851 >> One more step towards winelib on ARM :) >> >> Apologies if this comes through as a double post. I inadvertently sent the >> mail >> before my subscription to the list went through properly.

Re: Fix for Bug 19851 - Interlocked instruction support for ARM

2009-09-21 Thread André Hentschel
> > This patch fixes bug 19851 http://bugs.winehq.org/show_bug.cgi?id=19851 > One more step towards winelib on ARM :) > > Apologies if this comes through as a double post. I inadvertently sent the > mail > before my subscription to the list went through properly. > > Colin > Hi, there is a typ

Re: [try 3] comctl32: Implement highlighting (marquee) selection support in listview

2009-09-21 Thread Owen Rudge
:). Now we have 3 different names for a single thing. D'oh! Let's try this one last time... ;) -- Owen Rudge http://www.owenrudge.net/

Re: Wine in Tango

2009-09-21 Thread King InuYasha
On Mon, Sep 21, 2009 at 9:02 AM, Roderick Colenbrander < thunderbir...@gmail.com> wrote: > As of XP themes can specify their own icons. For some dlls I believe > shell32 they need to provide their own shellapi.dll or whatever it is > called. I think that would be the way to proceed. I would sugges

Re: [try 3] comctl32: Implement highlighting (marquee) selection support in listview

2009-09-21 Thread Nikolay Sivov
Owen Rudge wrote: Minor update, rename some potentially confusing comments/variables. --- dlls/comctl32/listview.c | 135 - 1 files changed, 120 insertions(+), 15 deletions(-) +/* Draw focus rect if highlighting */ +if (infoPtr->bHighlight

Re: mshtml / shdocv / urlmon tests hanging?

2009-09-21 Thread Dan Kegel
Without. Thanks, I'll rerun tonight. On Sep 21, 2009 8:05 AM, "Paul Vriens" wrote: On 09/21/2009 04:32 PM, Dan Kegel wrote: > > Doing a full test with my xattr patches, I saw hangs > ... With or without Gecko installed? -- Cheers, Paul.

Re: [try 2] comctl32: Implement highlighting (marquee) selection support in listview

2009-09-21 Thread Owen Rudge
Hi Nikolay, Focus rectangle is an item focus bounds in current naming, so comment is a bit confusing here. Ah, yes, that seems sensible - I named it "focus rectangle" as that's what the API function was called, but of course the way it's used would lend itself better to different nomenclatur

Re: [try 2] comctl32: Implement highlighting (marquee) selection support in listview

2009-09-21 Thread Nikolay Sivov
Owen Rudge wrote: This patch adds support for selecting multiple items in a multi-selection listview using the mouse (by dragging and highlighting). It has been reimplemented in a more efficient manner compared to the previous patches. --- dlls/comctl32/listview.c | 135 +++

Re: mshtml / shdocv / urlmon tests hanging?

2009-09-21 Thread Paul Vriens
On 09/21/2009 04:32 PM, Dan Kegel wrote: Doing a full test with my xattr patches, I saw hangs on about seven tests, all in mshtml , shdocv, and urlmon. While doing a baseline test run without my xattr patches, I noticed that mshtml / dom tests were still hanging. Has anybody else seen these test

mshtml / shdocv / urlmon tests hanging?

2009-09-21 Thread Dan Kegel
Doing a full test with my xattr patches, I saw hangs on about seven tests, all in mshtml , shdocv, and urlmon. While doing a baseline test run without my xattr patches, I noticed that mshtml / dom tests were still hanging. Has anybody else seen these tests hang lately?

Re: [bugzilla] donate to sponsoring bug

2009-09-21 Thread Francois Gouget
On Wed, 16 Sep 2009, Tom Wickline wrote: [...] > But the problem is if say I donate $50.00 who's to say the bug I > donate to will be resolved any time soon? Paypal only allows refunds > up to 60 days, so how would you go about a refund if the bug wasn't > fixed in say a year or more? The solut

Re: Wine in Tango

2009-09-21 Thread Roderick Colenbrander
As of XP themes can specify their own icons. For some dlls I believe shell32 they need to provide their own shellapi.dll or whatever it is called. I think that would be the way to proceed. I would suggest to make Tango the base theme as it integrates well with KDE/Gnome and also OSX. Using themes (

Re: Wine in Tango

2009-09-21 Thread Francois Gouget
On Mon, 21 Sep 2009, Ralf Jung wrote: [...] > If wine should integrate well with the surrounding Linux desktop, why > don't you use the desktop icon set where possible? Because on Windows the icons are stored as resources in the dlls. So Windows applications and dlls use the same generic API for

Re: oledb32: Implement CanConvert.

2009-09-21 Thread Paul Chitescu
On Monday 21 September 2009 16:46:25 Huw Davies wrote: > On Mon, Sep 21, 2009 at 03:36:21PM +0200, Marcus Meissner wrote: > > On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > > > +if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return > > > S_FALSE; > > > > I think this ne

Re: oledb32: Implement CanConvert.

2009-09-21 Thread Marcus Meissner
On Mon, Sep 21, 2009 at 02:46:25PM +0100, Huw Davies wrote: > On Mon, Sep 21, 2009 at 03:36:21PM +0200, Marcus Meissner wrote: > > On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > > > +if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return > > > S_FALSE; > > > > I think

Re: oledb32: Implement CanConvert.

2009-09-21 Thread Huw Davies
On Mon, Sep 21, 2009 at 03:36:21PM +0200, Marcus Meissner wrote: > On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > > +if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return > > S_FALSE; > > I think this needs brackets... Why? It's equivalent to: if((src_type & DBTYP

Re: oledb32: Implement CanConvert.

2009-09-21 Thread Marcus Meissner
On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > --- > dlls/oledb32/convert.c | 231 > +- > dlls/oledb32/tests/convert.c | 10 -- > 2 files changed, 228 insertions(+), 13 deletions(-) > diff --git a/dlls/oledb32/convert.c b/dlls/oledb3

Re: Wine in Tango

2009-09-21 Thread Ralf Jung
Hi, > It's true, not everyone is using Tango, but it's the closest thing we > have to a standard. It certainly wouldn't hurt to make Wine compatible > with multiple icon sets and then let packagers choose which one to use, > so I could provide a Gnome-wine and a KDE-wine and so on. > > Starting

Re: cppcheck sept 18 redux

2009-09-21 Thread Ben Klein
2009/9/21 chris ahrendt : > False positive ticket created for: > > [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible > null pointer dereference: dmW - otherwise it is redundant to check if > dmW is null at line 272 > > what about the others? or the suggestion of adding an addit

cppcheck sept 18 redux

2009-09-21 Thread chris ahrendt
False positive ticket created for: [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 what about the others? or the suggestion of adding an additional int to the array? chris

Re: Wine in Tango

2009-09-21 Thread Scott Ritchie
Ralf Jung wrote: > Hi everyone, > >> I don't know if we can say this. Only when our Wine-supplied icons are >> appearing near application-supplied icons do we gain some consistency by >> mimicing Windows style, but that consistency is confined to that >> particular app. Most icons the user sees

Re: Wine in Tango

2009-09-21 Thread Ralf Jung
Hi everyone, > I don't know if we can say this. Only when our Wine-supplied icons are > appearing near application-supplied icons do we gain some consistency by > mimicing Windows style, but that consistency is confined to that > particular app. Most icons the user sees are instead going to be >

Re: Wine in Tango

2009-09-21 Thread Francois Gouget
On Sat, 19 Sep 2009, Joel Holdsworth wrote: [...] > > shortcut.ico - the icon is oriented improperly. It needs to be > > bottom-left and oriented so the arrow points towards the center. > > This is the orientation from Gnome. If you object this can be changed > easily. Do it the way Windows does i

Re: Wine in Tango

2009-09-21 Thread Francois Gouget
On Sat, 19 Sep 2009, Joel Holdsworth wrote: [...] > 16-bit works fine - X renders the icons in true color then downsamples. > greyscale/monochrome will be similar, not that the end result would be > pretty. A more realistic case is 8-bit, and the only way I can think to > set that up is with ssh+X1