cppcheck Sept 18

2009-09-18 Thread chris ahrendt
[/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [/home/cahrendt/wine-git/dlls/wineps.

Re: [bugzilla] donate to sponsoring bug

2009-09-18 Thread Ben Klein
2009/9/19 sacchi antonio : > This idea was born because I'm not a developer but I want to help Wine, > this is not a perfect idea, help me to make it better! > Maybe this button will appear only on very few bugs/projects (2-3 > max?) and money could go directly to Wine and after bug/project will >

Re: winex11: add alternative header

2009-09-18 Thread Steven Edwards
2009/9/18 André Hentschel : > this is my first patch to autoconf-stuff, please tell me if i did something > wrong > see also Bug 20070 I expect It should actually not look like the following >  #ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H >  #include > +#elif defined (HAVE_X11_EXTENSIONS_XF86VMPROTO_

Re: Add dxdiag help message box

2009-09-18 Thread Brian Nguyen
Here's an updated patch that stores the string in an En.rc resource file and loads it using a wrapper for LoadString. How does this look? On Fri, Sep 18, 2009 at 1:36 AM, Henri Verbeet wrote: > 2009/9/18 Brian Nguyen : > > Hm, okay. I just wanted to test the waters here; I'll rework this to use

Re: clock: fix license in Swedish resources

2009-09-18 Thread Austin English
2009/9/15 Austin English : > Wine is LGPL, not GPL. Also, convert to UTF-8. > > -- > -Austin Something wrong with these two patches? -- -Austin

WineHQ Scheduled Downtime

2009-09-18 Thread Jeremy Newman
WineHQ.org will be going off-line today starting at 14:30 US Central time. At this time we are performing hardware upgrades and maintenance. The system will be off-line from 20 minutes up to an hour. Services Affected: * WineHQ.org website * Bugzilla * Forums * AppDB * mailing lists * GIT and

[bugzilla] donate to sponsoring bug

2009-09-18 Thread sacchi antonio
This idea was born because I'm not a developer but I want to help Wine, this is not a perfect idea, help me to make it better! Maybe this button will appear only on very few bugs/projects (2-3 max?) and money could go directly to Wine and after bug/project will be released/fixed money could go to p

Re: [PATCH 1/3] winex11.drv: Check the current context in X11DRV_wglMakeCurrent().

2009-09-18 Thread Roderick Colenbrander
Hi, I'm not sure if we should skip the glXMakeCurrent(null, null) call in GLX as in case of GLX it doesn't hurt. Second I'm not sure if we need to put the SetLastError code in winex11 or in gdi32/opengl.c. I think it should be in there as we don't need any X11 info. Roderick 2009/9/18 Rico Schül

Re: [PATCH 1/3] winex11.drv: Check the current context in X11DRV_wglMakeCurrent().

2009-09-18 Thread Rico Schüller
Am 18.09.2009 15:54, schrieb Roderick Colenbrander: Hi, I'm not sure if we should skip the glXMakeCurrent(null, null) call in GLX as in case of GLX it doesn't hurt. Second I'm not sure if we need to put the SetLastError code in winex11 or in gdi32/opengl.c. I think it should be in there as we do

Re: gdi32/bitblt: GdiAlphaBlend - Check for NULL Pointer (incl. testcase)

2009-09-18 Thread Paul Vriens
On 09/18/2009 02:50 PM, Paul Vriens wrote: On 09/18/2009 02:31 PM, Markus Stockhausen wrote: Am Freitag, den 18.09.2009, 14:09 +0200 schrieb Paul Vriens: On 09/18/2009 01:42 PM, Markus Stockhausen wrote: Hi, as I was encouraged to resent the patch from last week in git format I hope it will b

Re: gdi32/bitblt: GdiAlphaBlend - Check for NULL Pointer (incl. testcase)

2009-09-18 Thread Paul Vriens
On 09/18/2009 02:31 PM, Markus Stockhausen wrote: Am Freitag, den 18.09.2009, 14:09 +0200 schrieb Paul Vriens: On 09/18/2009 01:42 PM, Markus Stockhausen wrote: Hi, as I was encouraged to resent the patch from last week in git format I hope it will be better this time. Best regards

Re: gdi32/bitblt: GdiAlphaBlend - Check for NULL Pointer (incl. testcase)

2009-09-18 Thread Markus Stockhausen
Am Freitag, den 18.09.2009, 14:09 +0200 schrieb Paul Vriens: > On 09/18/2009 01:42 PM, Markus Stockhausen wrote: > > Hi, > > > > as I was encouraged to resent the patch from last week in git format I > > hope it will be better this time. > > > > Best regards > > > > > >

Re: gdi32/bitblt: GdiAlphaBlend - Check for NULL Pointer (incl. testcase)

2009-09-18 Thread Paul Vriens
On 09/18/2009 01:42 PM, Markus Stockhausen wrote: Hi, as I was encouraged to resent the patch from last week in git format I hope it will be better this time. Best regards Hi Markus, After reading this patch again, i

Re: New testcase for creating nested storage objects

2009-09-18 Thread Nikolay Sivov
Markus Stockhausen wrote: Am Freitag, den 18.09.2009, 14:20 +0400 schrieb Nikolay Sivov: BTW: I'm still missing your (and/or my) patches and testcases for the bitblt errors in Teamviewer. Is there any issue with it? Best regards. You were close enough with it. Just try to resent on wine-patc

Re: glean and Piglit -- OpenGL driver testing

2009-09-18 Thread Francois Gouget
On Thu, 17 Sep 2009, Saulius Krasuckas wrote: [...] > Could these be of any use for our graphic guys -- Stefan and co.? It might be the other way around; that is maybe our graphics guys can help the Glean and Piglit developpers. Quite often they discover some bug in OpenGL. But if neither Glean

Re: New testcase for creating nested storage objects

2009-09-18 Thread Markus Stockhausen
Am Freitag, den 18.09.2009, 14:20 +0400 schrieb Nikolay Sivov: > Markus Stockhausen wrote: > > Hi, > > > > attached you will find a new testcase that checks for differences > > between Wine and Windows when handling reference counters for nested > > storage objects. > > > > Best regards. > > > > M

Re: New testcase for creating nested storage objects

2009-09-18 Thread Nikolay Sivov
Markus Stockhausen wrote: Hi, attached you will find a new testcase that checks for differences between Wine and Windows when handling reference counters for nested storage objects. Best regards. Markus Hi, Markus. Tests passes on XP, fails on current Wine. You should mark failing test

Re: oledb32/tests: Add CanConvert tests.

2009-09-18 Thread Paul Vriens
On 09/17/2009 03:35 PM, Huw Davies wrote: --- dlls/oledb32/tests/Makefile.in |2 +- dlls/oledb32/tests/convert.c | 76 2 files changed, 77 insertions(+), 1 deletions(-)

Re: Add dxdiag help message box

2009-09-18 Thread Henri Verbeet
2009/9/18 Brian Nguyen : > Hm, okay. I just wanted to test the waters here; I'll rework this to use a > function that loads > a string from a resource file. Does the help message itself look okay? I > just used the message > provided by the native dxdiag app, but I could rework it if there are issu

Re: glean and Piglit -- OpenGL driver testing

2009-09-18 Thread Henri Verbeet
2009/9/18 Austin English : > On Thu, Sep 17, 2009 at 3:16 PM, Henri Verbeet wrote: >> Possibly, but it would have to be in the context of a larger framework >> like e.g. CxTest or Appinstall. > > Would it actually be useful? I can take a look, but not if it's going > to be a lot of effort for litt

Re: Add dxdiag help message box

2009-09-18 Thread Brian Nguyen
Hm, okay. I just wanted to test the waters here; I'll rework this to use a function that loads a string from a resource file. Does the help message itself look okay? I just used the message provided by the native dxdiag app, but I could rework it if there are issues with copyright or wine conventio