RE: CertGetPublicKeyLength() test failures on Win7

2009-09-15 Thread Greg Geldorp
> From: Juan Lang [mailto:juan.l...@gmail.com] > > > No, it's not. Return value is TRUE, buf is allocated and contains a > > PUBKEYSTRUC followed by a RSAPUBKEY with len 56 while size contains 0x1b. > > So Win7 is capable of decoding the key. > > Thanks for checking that. That appears to be a bug

Re: CertGetPublicKeyLength() test failures on Win7

2009-09-15 Thread Juan Lang
> No, it's not. Return value is TRUE, buf is allocated and contains a > PUBKEYSTRUC followed by a RSAPUBKEY with len 56 while size contains 0x1b. > So Win7 is capable of decoding the key. Thanks for checking that. That appears to be a bug to me, then, although it could be that it's failing for so

RE: CertGetPublicKeyLength() test failures on Win7

2009-09-15 Thread Greg Geldorp
> From: Juan Lang > > I see 3 test failures related to CertGetPublicKeyLength() on Win7, > > crypt32/tests/cert.c lines 3146/3160/3165. All 3 failures are the > > same, CertGetPublicKeyLength() returns 0 with last error 0x80090004 > > (NTE_BAD_LEN). After looking at it for a while, I'm inclined to

Re: Wine at Ohloh

2009-09-15 Thread Austin English
On Mon, Sep 14, 2009 at 12:28 PM, Paul Vriens wrote: > On 09/14/2009 07:17 PM, Austin English wrote: >> >> On Mon, Sep 14, 2009 at 12:08 PM, Saulius Krasuckas >>  wrote: >>> >>> FYI, http://www.ohloh.net/p/wine/analyses/latest >>> >>> I wonder how do they find 27k lines of C++ code in Wine tree...

Re: [PATCH 2/2] dpwsockx: Implementation of Open callback

2009-09-15 Thread Ismael Barros²
On Mon, Sep 14, 2009 at 12:46 AM, Vitaliy Margolen wrote: >> It's a way to tell between abruptly ending the thread due to an error, >> and ending the thread gracefully. > That makes no sense to me. You have no other point of exit from the loop. > Using goto for no good reason is always a bad thing

Re: CertGetPublicKeyLength() test failures on Win7

2009-09-15 Thread Juan Lang
Hi Ge, > I see 3 test failures related to CertGetPublicKeyLength() on Win7, > crypt32/tests/cert.c lines 3146/3160/3165. All 3 failures are the same, > CertGetPublicKeyLength() returns 0 with last error 0x80090004 (NTE_BAD_LEN). > After looking at it for a while, I'm inclined to change the cond

Re: [3/4] msi: GetDriveType and GetVolumeInformation require a path terminated by a slash.

2009-09-15 Thread Hans Leidekker
On Tuesday 15 September 2009 12:42:35 pm Dan Kegel wrote: > Don't changes like this need corresponding conformance tests? > Likewise with "[4/4] msi: Don't append the cabinet file name in > find_published_source." They seemed pretty obvious fixes to me and they fix existing installers. A test cas

re: [3/4] msi: GetDriveType and GetVolumeInformation require a path terminated by a slash.

2009-09-15 Thread Dan Kegel
Don't changes like this need corresponding conformance tests? Likewise with "[4/4] msi: Don't append the cabinet file name in find_published_source."

CertGetPublicKeyLength() test failures on Win7

2009-09-15 Thread Greg Geldorp
Hi Juan, I see 3 test failures related to CertGetPublicKeyLength() on Win7, crypt32/tests/cert.c lines 3146/3160/3165. All 3 failures are the same, CertGetPublicKeyLength() returns 0 with last error 0x80090004 (NTE_BAD_LEN). After looking at it for a while, I'm inclined to change the condition

Re: How I create wine app launcher icons on the Mac

2009-09-15 Thread Steven Edwards
On Mon, Sep 14, 2009 at 5:33 PM, Steven Edwards wrote: > Right but what happened to the png image? OK so I looked at it a bit more in depth and understand what your going for now. So you are embedding the png as a resource fork of the png image but then using the png as a script. You kind of lost