Vitaliy Margolen wrote:
> Forgot this part:
>
>> Ismael Barros wrote:
>> +static DWORD WINAPI tcp_listener_thread( LPVOID lpParameter )
>> +{
>> +for ( ;; )
>> +{
>> +if ( clientSock == INVALID_SOCKET )
>> +{
>> +goto end;
>> +}
>> +}
>> +
>> +end:
Ismael Barros² wrote:
> On Sun, Sep 13, 2009 at 11:46 PM, Vitaliy Margolen
> wrote:
>> Forgot this part:
>>> Ismael Barros wrote:
>>> +static DWORD WINAPI tcp_listener_thread( LPVOID lpParameter )
>>> +{
>>> +for ( ;; )
>>> +{
>>> +if ( clientSock == INVALID_SOCKET )
>>> +{
Ismael Barros² wrote:
> On Sun, Sep 13, 2009 at 11:39 PM, Vitaliy Margolen
> wrote:
>> You do not have exit from the loop.
>>
>> I haven't found the place where you closing this handle.
>>
>> Same here.
>
> The code to close those threads and their listener sockets is meant to
> go in DPWSCB_Clos
On Sun, Sep 13, 2009 at 11:46 PM, Vitaliy Margolen
wrote:
> Forgot this part:
>> Ismael Barros wrote:
>> +static DWORD WINAPI tcp_listener_thread( LPVOID lpParameter )
>> +{
>> + for ( ;; )
>> + {
>> + if ( clientSock == INVALID_SOCKET )
>> + {
>> + goto end;
>> +
On Sun, Sep 13, 2009 at 11:39 PM, Vitaliy Margolen
wrote:
> You do not have exit from the loop.
>
> I haven't found the place where you closing this handle.
>
> Same here.
The code to close those threads and their listener sockets is meant to
go in DPWSCB_CloseEx(), but I still haven't worked on
Forgot this part:
> Ismael Barros wrote:
> +static DWORD WINAPI tcp_listener_thread( LPVOID lpParameter )
> +{
> +for ( ;; )
> +{
> +if ( clientSock == INVALID_SOCKET )
> +{
> +goto end;
> +}
> +}
> +
> +end:
> +}
It's more cleaner to use "break;" ins
Peter Dons Tychsen wrote:
> OK. The "bad handle" is tested by the "deadbeef" handle.
> Where is the best place to get a really good "wrong class" handle?
Create it. Event handle will do for example.
Vitaliy.
Ismael Barros wrote:
> ---
> +static DWORD WINAPI udp_listener_thread( LPVOID lpParameter )
> +{
> +for ( ;; )
> +{
.
> +}
> +}
You do not have exit from the loop.
> +/* Launch thread */
> +listener->handle = CreateThread( NULL, 0, udp_listener_thread,
> +
Nikolay Sivov wrote:
> Changelog:
> - Implement DPA_SaveStream() with tests
>
> +streamData.dwSize = curr_pos.QuadPart - initial_pos.QuadPart;
> +streamData.dwData2 = 1;
> +streamData.dwItems = streamInfo.iPos;// + 1;
c++ comment.
> +#if 0
> +/* crashes on XP */
> +hRes =
Hi Thomas,
> I've created a small test program that includes the Linux Irda headers which
> works fine for Linux but I have no idea about the Mac...
There's no IRDA support on the Mac, hence no header conflict to worry about.
--Juan
Mike Kaplinskiy writes:
> As for the context note, it is perfectly valid code (segfault-less,
> that is) as it stands, but we should either remove the null check on
> the next line or assign the value later.
No, the code is fine as it is. The bug is in cppcheck.
--
Alexandre Julliard
julli...@
Thomas Trummer writes:
> Thanks for looking at the patch.
>
> 1) Is there a way to ensure that it doesn't conflict with other symbols?
> I've created a small test program that includes the Linux Irda headers which
> works fine for Linux but I have no idea about the Mac...
Grep for each symbol in
OK. The "bad handle" is tested by the "deadbeef" handle.
Where is the best place to get a really good "wrong class" handle?
Thanks,
/pedro
- Original meddelelse -
> Fra: Alexandre Julliard
> Til: Peter Dons Tychsen
> Cc: wine-devel@winehq.org
> Dato: Tor, 10. sep 2009 22:20
> Emne: Re
Am Sunday 13 September 2009 08:15:19 schrieb Jaime Rave:
> More information about Intel cards:
> http://en.wikipedia.org/wiki/Intel_GMA#Table_of_GMA_graphics_cores_and_chip
>sets
+|| strstr(gl_renderer, "Intel®"))
I don't know if it is safe check for the ®. I think its not part of the
2009/9/13 Henri Verbeet :
> 2009/9/13 Mike Kaplinskiy :
>> Actually it does dereference something, if you think of dmFormName
>> being an int (not a pointer), then you would be subtracting an address
>> from a random value.
>
> If it were an int, sure, but "dmFormName" is a WCHAR array.
>
My point
2009/9/13 Mike Kaplinskiy :
> Actually it does dereference something, if you think of dmFormName
> being an int (not a pointer), then you would be subtracting an address
> from a random value.
If it were an int, sure, but "dmFormName" is a WCHAR array.
Just one minor thing make sure the right email address is configured
in your git repository, so that the correct email address is set in
the patch
Roderick
On Sun, Sep 13, 2009 at 8:15 AM, Jaime Rave wrote:
> More information about Intel
> cards: http://en.wikipedia.org/wiki/Intel_GMA#Table_of_G
2009/9/13 Mike Kaplinskiy :
> But as Ben noted, the cleaner way would be to use FIELD_OFFSET, which
> does exactly the above.
As much as I'd love to take the credit for suggesting FIELD_OFFSET, it
was Henri :)
18 matches
Mail list logo
