Re: Sept 11 with tools and tests removed

2009-09-12 Thread Mike Kaplinskiy
On Sat, Sep 12, 2009 at 7:08 PM, Henri Verbeet wrote: > 2009/9/13 Ben Klein : >> 2009/9/13 Nicolas Le Cam : >>> Last one is also a false positive, it's just two pointers being >>> subtracted to retrieve an offset. >> >> That's not the reason why it's a false positive. Without context that >> line

Re: [ntdll] Add test for NtQueryDirectoryFile [try 2]

2009-09-12 Thread Dan Kegel
On Sat, Sep 12, 2009 at 4:51 PM, James McKenzie wrote: > Dan Kegel wrote: >> Here's the next broken-out test patch from the series that >> implements support for hidden and system attributes. >> This one just adds a test for NtQueryDirectoryFile(). > > It looks like your original patch was approve

Re: [ntdll] Add test for NtQueryDirectoryFile [try 2]

2009-09-12 Thread James McKenzie
Dan Kegel wrote: > Here's the next broken-out test patch from the series that > implements support for hidden and system attributes. > This one just adds a test for NtQueryDirectoryFile(). > It passes for me on Wine and Vista Home Basic. > > Changes since first try: > 1) fixed issues Paul found (wa

Re: DDraw: Add a few missing WINAPIs

2009-09-12 Thread Stefan Dösinger
Am Saturday 12 September 2009 23:50:47 schrieb Henri Verbeet: > 2009/9/12 Stefan Dösinger : > > I wonder how this worked in the past, and why the compiler didn't > > complain. > > It's pretty simple really, these functions don't need WINAPI because > they're ddraw internal functions "cleverly" disg

Re: fixing ReadDirectoryChangesW()

2009-09-12 Thread James McKenzie
Mike Kaplinskiy wrote: > On Fri, Sep 11, 2009 at 5:42 PM, Dan Kegel wrote: > >> Michael Pujos wrote: >> >>> I'm willing to resubmit this patch with updated tests >>> against current Wine, but before I procceed >>> I need to be sure it won't be rejected simply because it changes the >>> pr

Re: DDraw: Add a few missing WINAPIs

2009-09-12 Thread Stefan Dösinger
Am Saturday 12 September 2009 23:41:00 schrieb Stefan Dösinger: > Am Saturday 12 September 2009 23:25:56 schrieb Stefan Dösinger: > > Oops: forgot the patch: Er, never mind that patch - those functions aren't used directly in the vtable. There are the FPUSetup and FPUPreserve wrappers around them

Re: include: Add missing definitions in af_irda.h. (try 2)

2009-09-12 Thread James McKenzie
Thomas Trummer wrote: > Thanks for looking at the patch. > > 1) Is there a way to ensure that it doesn't conflict with other > symbols? I've created a small test program that includes the Linux > Irda headers which works fine for Linux but I have no idea about the > Mac... > > 2) About the AF_IRDA

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Henri Verbeet
2009/9/13 Ben Klein : > 2009/9/13 Nicolas Le Cam : >> Last one is also a false positive, it's just two pointers being >> subtracted to retrieve an offset. > > That's not the reason why it's a false positive. Without context that > line does look like a NULL-dereference (dmW is dereferenced to get t

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Ben Klein
2009/9/13 Nicolas Le Cam : > Last one is also a false positive, it's just two pointers being > subtracted to retrieve an offset. That's not the reason why it's a false positive. Without context that line does look like a NULL-dereference (dmW is dereferenced to get the first pointer before any NUL

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Nicolas Le Cam
2009/9/12 Mike Kaplinskiy : > On Sat, Sep 12, 2009 at 11:24 AM, Mike Kaplinskiy > wrote: >> On Sat, Sep 12, 2009 at 11:19 AM, Nicolas Le Cam >> wrote: >>> 2009/9/12 chris ahrendt : Here is the run for Friday Sept. 11 with the tools and the tests directory results removed. >>>

Re: DDraw: Add a few missing WINAPIs

2009-09-12 Thread Henri Verbeet
2009/9/12 Stefan Dösinger : > I wonder how this worked in the past, and why the compiler didn't complain. It's pretty simple really, these functions don't need WINAPI because they're ddraw internal functions "cleverly" disguised as vtable methods. IIRC it's actually harmful to add WINAPI to these

Re: bug #9575 - better this time - testcase help needed

2009-09-12 Thread Paul Vriens
On 09/12/2009 04:56 PM, Markus Stockhausen wrote: Am Samstag, den 12.09.2009, 16:50 +0200 schrieb Paul Vriens: On 09/12/2009 04:13 PM, Markus Stockhausen wrote: Am Samstag, den 12.09.2009, 15:52 +0200 schrieb Markus Stockhausen: Hi, hopefully the right explanation for the error can be found h

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Mike Kaplinskiy
On Sat, Sep 12, 2009 at 11:24 AM, Mike Kaplinskiy wrote: > On Sat, Sep 12, 2009 at 11:19 AM, Nicolas Le Cam wrote: >> 2009/9/12 chris ahrendt : >>> >>> Here is the run for Friday Sept. 11 with the tools and the tests >>> directory results removed. >>> >>> >>> [/home/cahrendt/wine-git/dlls/ntdll/s

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Mike Kaplinskiy
On Sat, Sep 12, 2009 at 11:19 AM, Nicolas Le Cam wrote: > 2009/9/12 chris ahrendt : >> >> Here is the run for Friday Sept. 11 with the tools and the tests >> directory results removed. >> >> >> [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd >> [/home/cahrendt/wine-git

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Nicolas Le Cam
2009/9/12 chris ahrendt : > > Here is the run for Friday Sept. 11 with the tools and the tests > directory results removed. > > > [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd > [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource > leak: fd_cwd > [/hom

Sept 11 with tools and tests removed

2009-09-12 Thread chris ahrendt
Here is the run for Friday Sept. 11 with the tools and the tests directory results removed. [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/wineps.drv/ini

Re: bug #9575 - better this time - testcase help needed

2009-09-12 Thread Markus Stockhausen
Am Samstag, den 12.09.2009, 16:50 +0200 schrieb Paul Vriens: > On 09/12/2009 04:13 PM, Markus Stockhausen wrote: > > Am Samstag, den 12.09.2009, 15:52 +0200 schrieb Markus Stockhausen: > >> Hi, > >> > >> hopefully the right explanation for the error can be found here > >> http://bugs.winehq.org/sho

Re: bug #9575 - better this time - testcase help needed

2009-09-12 Thread Paul Vriens
On 09/12/2009 04:13 PM, Markus Stockhausen wrote: Am Samstag, den 12.09.2009, 15:52 +0200 schrieb Markus Stockhausen: Hi, hopefully the right explanation for the error can be found here http://bugs.winehq.org/show_bug.cgi?id=9575 . Once again I need someone with a Windows machine who can provid

Re: bug #9575 - better this time - testcase help needed

2009-09-12 Thread Markus Stockhausen
Am Samstag, den 12.09.2009, 15:52 +0200 schrieb Markus Stockhausen: > Hi, > > hopefully the right explanation for the error can be found here > http://bugs.winehq.org/show_bug.cgi?id=9575 . Once again I need someone > with a Windows machine who can provide the following: > > ... > HRESULT = StgOp

Re: include: Add missing definitions in af_irda.h. (try 2)

2009-09-12 Thread Thomas Trummer
Thanks for looking at the patch. 1) Is there a way to ensure that it doesn't conflict with other symbols? I've created a small test program that includes the Linux Irda headers which works fine for Linux but I have no idea about the Mac... 2) About the AF_IRDA et al. symbols: These are already de

bug #9575 - better this time - testcase help needed

2009-09-12 Thread Markus Stockhausen
Hi, hopefully the right explanation for the error can be found here http://bugs.winehq.org/show_bug.cgi?id=9575 . Once again I need someone with a Windows machine who can provide the following: ... HRESULT = StgOpenStorage( 'testfile.txt', ... , ppstgOpen1 ); HRESULT = StgOpenStorage( 'testfile.t

RE: Help with a native Windows test program needed (CreateFileW).

2009-09-12 Thread Markus Stockhausen
Sorry for the the wrong feedback. As I have limited possibilites creating executables on Windows I relied on Thomas executable for the tests. Maybe you can post a corrected version. It is not my intention to confuse someone. Im just trying to narrow down my initial analysis. The last write access

Re: [ntdll] Add test for NtQueryDirectoryFile

2009-09-12 Thread Paul Vriens
On 09/12/2009 09:51 AM, Paul Vriens wrote: On 09/12/2009 09:40 AM, Paul Vriens wrote: On 09/12/2009 02:18 AM, Dan Kegel wrote: Here's the next broken-out test patch from the series that implements support for hidden and system attributes. This one just adds a test for NtQueryDirectoryFile(). It

Re: [ntdll] Add test for NtQueryDirectoryFile

2009-09-12 Thread Paul Vriens
On 09/12/2009 09:40 AM, Paul Vriens wrote: On 09/12/2009 02:18 AM, Dan Kegel wrote: Here's the next broken-out test patch from the series that implements support for hidden and system attributes. This one just adds a test for NtQueryDirectoryFile(). It passes for me on Wine and Vista Home Basic.

Re: [ntdll] Add test for NtQueryDirectoryFile

2009-09-12 Thread Paul Vriens
On 09/12/2009 02:18 AM, Dan Kegel wrote: Here's the next broken-out test patch from the series that implements support for hidden and system attributes. This one just adds a test for NtQueryDirectoryFile(). It passes for me on Wine and Vista Home Basic. [Paul, could you test it on your box to ma