Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer

2009-09-10 Thread Markus Stockhausen
Am Freitag, den 11.09.2009, 01:56 +0400 schrieb Nikolay Sivov: > Just correct your patch (as you mentioned before), include simple > testcase and resend. > So nothing to wait for. > > Basic test shows it doesn't crash on Windows and doesn't change last > error - I already > check this on XP and

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer

2009-09-10 Thread Markus Stockhausen
Am Freitag, den 11.09.2009, 01:17 +0400 schrieb Nikolay Sivov: > Roderick Colenbrander wrote: > > Recently Nikolay Sivov wrote some tests for this call. His tests > > didn't make it in yet but I think those should enter and then based on > > those results changes should be made. > > > > Roderick >

Re: ntdll: Do not accept device control requests with invalid and/or incompa tible handles

2009-09-10 Thread Peter Dons Tychsen
Thanks for the comments. Not sure i understand them though. The whole point of the test was to test what happens when you use a wrong handle. The actual bug i fixed was that it was possible to for programs to send invalid handles to IoControl. Cygwin was infact sending handles to ntdll.dll which o

Re: Status of LoadLibrary and .so

2009-09-10 Thread Nicholas LaRoche
Paul Chitescu wrote: On Thursday 10 September 2009 22:10:37 Joe Dluzen wrote: Hi all, back a few years ago it didn't: http://www.winehq.org/pipermail/wine-devel/2003-July/018498.html Does anyone know of the status of LoadLibrary and a .so? Can it load directly or is there a workaround that doe

Re: Wineconf drumbeat - don't sleep on the streets!

2009-09-10 Thread Jeremy White
> Just how does one switch the PayPal interface to Euro I wonder ;) Actually, Paypal takes Euros just fine (we use it at CodeWeavers), but it was rather remiss of me to not set that up *first* :-(. I need to connect with the SFC guys to get that set, so bear with me for a few days while I iron t

Re: [2/4] WineD3D: Make context_attach_surface_fbo srgb aware

2009-09-10 Thread Stefan Dösinger
Am Friday 11 September 2009 00:05:02 schrieb Henri Verbeet: > I don't think SRGB_ANY is correct here. context_apply_fbo_entry() very > much cares about which texture is attached to the FBO. If rendering to > sRGB textures was supported properly this would depend on the sRGB > write state, but since

Re: [3/4] WineD3D: Perform the srgb copy with fbo_blit if possible

2009-09-10 Thread Henri Verbeet
2009/9/10 Stefan Dösinger : > +if (context->current_fbo) { > +context_bind_fbo(context, GL_FRAMEBUFFER_EXT, > &context->current_fbo->id); > +} else { > +context_bind_fbo(context, GL_FRAMEBUFFER_EXT, NULL); > +} This shouldn't be needed. > +/* Need FBOs obviously */

Re: [2/4] WineD3D: Make context_attach_surface_fbo srgb aware

2009-09-10 Thread Henri Verbeet
2009/9/10 Stefan Dösinger : > @@ -402,7 +433,7 @@ static void context_apply_fbo_entry(struct > wined3d_context *context, struct fbo_ > for (i = 0; i < GL_LIMITS(buffers); ++i) > { > IWineD3DSurface *render_target = device->render_targets[i]; > -context_at

Re: Wineconf drumbeat - don't sleep on the streets!

2009-09-10 Thread Marcus Meissner
On Thu, Sep 10, 2009 at 04:48:24PM -0500, Jeremy White wrote: > Hi Folks, > > It's now close enough to November that you can't blow > this email off . > > We've got all the info here: > http://wiki.winehq.org/WineConf2009 > > Our challenge this year is that we're managing the booking, > so we

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer

2009-09-10 Thread Nikolay Sivov
Markus Stockhausen wrote: Am Freitag, den 11.09.2009, 01:17 +0400 schrieb Nikolay Sivov: Phew, in 3 days from 0 to 100. Too much for me. If I get it right, there are two things to do. 1. I should optimize my patch and remove unnecessary dcSrc checks. Actually, yes. After your patch th

Wineconf drumbeat - don't sleep on the streets!

2009-09-10 Thread Jeremy White
Hi Folks, It's now close enough to November that you can't blow this email off . We've got all the info here: http://wiki.winehq.org/WineConf2009 Our challenge this year is that we're managing the booking, so we need a firm head count ahead of time. Again, if money is an issue, and you haven'

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer

2009-09-10 Thread Nikolay Sivov
Roderick Colenbrander wrote: Recently Nikolay Sivov wrote some tests for this call. His tests didn't make it in yet but I think those should enter and then based on those results changes should be made. Roderick On Thu, Sep 10, 2009 at 10:56 PM, Markus Stockhausen wrote: Hi, http://bugs.w

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer

2009-09-10 Thread Paul Vriens
On 09/10/2009 10:56 PM, Markus Stockhausen wrote: Hi, http://bugs.winehq.org/show_bug.cgi?id=18041 reveals a bug where GdiAlphaBlend will crash in Teamviewer application when a NULL pointer is handed over. The attached check fixes that behaviour. Tanks in advance. Markus ---

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer

2009-09-10 Thread Roderick Colenbrander
Recently Nikolay Sivov wrote some tests for this call. His tests didn't make it in yet but I think those should enter and then based on those results changes should be made. Roderick On Thu, Sep 10, 2009 at 10:56 PM, Markus Stockhausen wrote: > Hi, > > http://bugs.winehq.org/show_bug.cgi?id=1804

Re: [ntdll] Add tests for NtQueryInformationFile

2009-09-10 Thread Dan Kegel
On Thu, Sep 10, 2009 at 1:35 PM, Paul Vriens wrote: >> Passes on both Wine and Vista. > > This patch introduces some issues on NT4 and higher. Attached patch fixes it > but I'm not sure if you are already chasing these failures. Weird that it > doesn't fail on your Vista box. Must have been user e

Re: [ntdll] Add tests for NtQueryInformationFile

2009-09-10 Thread Paul Vriens
On 09/10/2009 10:35 PM, Paul Vriens wrote: On 09/09/2009 02:41 PM, Dan Kegel wrote: Alexandre said I should break up the big xattr patch, so here are just the NtQueryInformationFile tests, improved a bit. Once these are in I'll submit the NtQueryDirectoryFile tests. Passes on both Wine and Vist

Re: [ntdll] Add tests for NtQueryInformationFile

2009-09-10 Thread Paul Vriens
On 09/09/2009 02:41 PM, Dan Kegel wrote: Alexandre said I should break up the big xattr patch, so here are just the NtQueryInformationFile tests, improved a bit. Once these are in I'll submit the NtQueryDirectoryFile tests. Passes on both Wine and Vista. --

Re: winehq: Fix some HTML markup

2009-09-10 Thread Jeremy Newman
Reece Dunn wrote: 2009/9/10 David Gerard : 2009/9/10 Jeremy Newman : The reason I left the XHTML markup in was eventually the goal was to convert the entire website to XHTML. The only issue with leaving them in while still in HTML4/Transitional is that the pages do not pass W3C validation. I a

Re: ntdll: Do not accept device control requests with invalid and/or incompa tible handles

2009-09-10 Thread Alexandre Julliard
Peter Dons Tychsen writes: > Thanks for the comments. > Not sure i understand them though. > > The whole point of the test was to test what happens when you use a wrong > handle. The actual bug i fixed was that it was possible to for programs > to send invalid handles to IoControl. Cygwin was inf

Re: Status of LoadLibrary and .so

2009-09-10 Thread Paul Chitescu
On Thursday 10 September 2009 22:10:37 Joe Dluzen wrote: > Hi all, > > back a few years ago it didn't: > http://www.winehq.org/pipermail/wine-devel/2003-July/018498.html > > Does anyone know of the status of LoadLibrary and a .so? Can it load > directly or is there a workaround that does not involv

Re: winehq: Fix some HTML markup

2009-09-10 Thread Reece Dunn
2009/9/10 David Gerard : > 2009/9/10 Jeremy Newman : > >> The reason I left the XHTML markup in was eventually the goal was to convert >> the entire website to XHTML. The only issue with leaving them in while still >> in HTML4/Transitional is that the pages do not pass W3C validation. I am >> still

Re: winehq: Fix some HTML markup

2009-09-10 Thread David Gerard
2009/9/10 Jeremy Newman : > The reason I left the XHTML markup in was eventually the goal was to convert > the entire website to XHTML. The only issue with leaving them in while still > in HTML4/Transitional is that the pages do not pass W3C validation. I am > still willing to live with non-valid

Re: Asynchronus serial port

2009-09-10 Thread Alexander Varnin
Thanks, I'll check it, when i have time. Wolfgang Walter пишет: > Am Donnerstag, 3. September 2009 schrieb Mike Kaplinskiy: > >> On Wed, Sep 2, 2009 at 7:31 PM, Fenixk19 wrote: >> >>> Hello! I've already post the >>> bug(http://bugs.winehq.org/show_bug.cgi?id=19713) on this subject, but i

Re: [PATCH 12/12] openal32: fixed ctx null ptr debug (Coverity)

2009-09-10 Thread Chris Robinson
I have a different patch that will fix this, that also fixes a problem with error states.

Status of LoadLibrary and .so

2009-09-10 Thread Joe Dluzen
Hi all, back a few years ago it didn't: http://www.winehq.org/pipermail/wine-devel/2003-July/018498.html Does anyone know of the status of LoadLibrary and a .so? Can it load directly or is there a workaround that does not involve multiple processes and some sort of IPC? thanks, Joe

Re: winehq: Fix some HTML markup

2009-09-10 Thread Jeremy Newman
The reason I left the XHTML markup in was eventually the goal was to convert the entire website to XHTML. The only issue with leaving them in while still in HTML4/Transitional is that the pages do not pass W3C validation. I am still willing to live with non-valid working HTML to save some work

Re: server: Use kernel support for thread affinity when available

2009-09-10 Thread Chris Robinson
On Thursday 10 September 2009 9:43:02 am Juan Lang wrote: > +/* Define to 1 if you have the `sched_getaffinity' function. */ > +#undef HAVE_SCHED_GETAFFINITY > + ... > +#ifdef HAVE_SCHED_GET_AFFINITY > +#define __USE_GNU > +#include > +#endif Looks like a typo there.

Re: winex11: Make X11DRV_PALETTE_ComputeColorShifts() static.

2009-09-10 Thread Roderick Colenbrander
In a next patch ComputeChannelShift will be called from outside palette.c and for this reason I made it non-static. Roderick On Thu, Sep 10, 2009 at 5:58 PM, Francois Gouget wrote: > --- >  dlls/winex11.drv/palette.c |  115 > ++-- >  dlls/winex11.drv/x11d

Re: mshtml: Add support for Reference BSTR when setting styles.

2009-09-10 Thread Paul Vriens
On 09/10/2009 12:11 PM, Paul Vriens wrote: On 09/10/2009 12:00 PM, Alistair Leslie-Hughes wrote: Hi, Changelog: mshtml: Add support for Reference BSTR when setting styles. Best Regards Alistair Leslie-Hughes Hi Alis

Re: mshtml: Add support for Reference BSTR when setting styles.

2009-09-10 Thread Paul Vriens
On 09/10/2009 12:00 PM, Alistair Leslie-Hughes wrote: Hi, Changelog: mshtml: Add support for Reference BSTR when setting styles. Best Regards Alistair Leslie-Hughes Hi Alistair, Now VT_BSTR is used in two case-state

Re: msi: Ignore CoInitialize failure in ACTION_CreateShortcuts.

2009-09-10 Thread Hans Leidekker
> Fixes http://bugs.winehq.org/show_bug.cgi?id=19636 Or it doesn't: err:ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded err:shell:ShellLink_QueryInterface -- Interface: E_NOINTERFACE Because IShellLink is apartment-threaded only?