Performance tag for Bugzilla?

2009-09-09 Thread Scott Ritchie
We have a wiki page functioning as sort of a wannabe performance tag here: http://wiki.winehq.org/Performance-related_bugs Is this a reasonable tag to have? Thanks, Scott Ritchie

Re: http://bugs.winehq.org/show_bug.cgi?id=18337

2009-09-09 Thread Frank Gruman
On Tue, 2009-09-08 at 16:33 -0700, Juan Lang wrote: > Hi Frank, > > On Tue, Sep 8, 2009 at 4:15 PM, Frank Gruman wrote: > > Looking at chain.c, line 1886-1902 I can see the switch-case statement > > where this would have been handled. The problem I ran into while trying > > to keep up with the c

Re: ddraw: Added support for WINED3DFMT_X8L8V8U8, WINED3DFMT_R8G8B8A8_SNORM and WINED3DFMT_R16G16_SNORM to PixelFormat_WineD3DtoDD

2009-09-09 Thread Stephan Rose
On Mon, 2009-09-07 at 13:16 +0200, joerg-cyril.hoe...@t-systems.com wrote: > Stephan, > > All the patches proposed to bug #16559 forget one thing: > > it cannot be right to patch only PixelFormat_WineD3DtoDD without patching its > converse function in the same file, PixelFormat_DD2WineD3D. Good

Re: gdi32: Handle OEM_CHARSET

2009-09-09 Thread Vladimir Pankratov
"Vladimir Pankratov" wrote: --- a/dlls/gdi32/freetype.c 2009-08-08 13:27:23.0 +0500 +++ b/dlls/gdi32/freetype.c 2009-09-07 19:58:58.0 +0500 @@ -3576,6 +3576,7 @@ if(!TranslateCharsetInfo((DWORD*)(INT_PTR)lf.lfCharSet, &csi, TCI_SRCCHARSET)) { switch(lf.lfCharSet) {

Re: CPPCheck for Sept 8th

2009-09-09 Thread Nicolas Le Cam
2009/9/9 chris ahrendt : > Nicolas Le Cam wrote: >> 2009/9/9 Alexandre Julliard : >>> chris ahrendt writes: >>> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd >>> This is the only one that looks a real bug, all the rest are false >>> positives. Ple

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-09 Thread Henri Verbeet
2009/9/9 Ismael Barros² : > - > > #ifdef WORDS_BIGENDIAN > > static inline u_short __dpws_ushort_swap(u_short s) > { >    return (s >> 8) | (s << 8); > } > static inline u_long __dpws_ulong_swap(u_long l) > { >    return ((u_long)__dpws_ushort_swap((u_short)l) << 16) | > __dpws_ushort_s

Re: CPPCheck for Sept 8th

2009-09-09 Thread chris ahrendt
Nicolas Le Cam wrote: > 2009/9/9 Alexandre Julliard : >> chris ahrendt writes: >> >>> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource >>> leak: old_cwd >> This is the only one that looks a real bug, all the rest are false >> positives. Please filter them out from future re

Re: CPPCheck for Sept 8th

2009-09-09 Thread Nicolas Le Cam
2009/9/9 Alexandre Julliard : > chris ahrendt writes: > >> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource >> leak: old_cwd > > This is the only one that looks a real bug, all the rest are false > positives. Please filter them out from future reports. > > -- > Alexandre Ju

Re: CPPCheck for Sept 8th

2009-09-09 Thread chris ahrendt
Alexandre Julliard wrote: > chris ahrendt writes: > >> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource >> leak: old_cwd > > This is the only one that looks a real bug, all the rest are false > positives. Please filter them out from future reports. > Is there any others?

Re: CPPCheck for Sept 8th

2009-09-09 Thread chris ahrendt
Alexandre Julliard wrote: > chris ahrendt writes: > >> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource >> leak: old_cwd > > This is the only one that looks a real bug, all the rest are false > positives. Please filter them out from future reports. > Alexandre, I will f

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-09 Thread Ismael Barros²
On Fri, Sep 4, 2009 at 12:12 PM, Henri Verbeet wrote: > 2009/9/4 Ismael Barros² : >> I've been looking into iphlpapi/ip.h (just learned bit fields >> exist...); would this implementation be fine? >> >> #include "pshpack1.h" >> >> typedef struct tagDPSP_MSG_HEADER >> { >> #ifdef WORDS_BIGENDIAN >>  

Re: CPPCheck for Sept 8th

2009-09-09 Thread Alexandre Julliard
chris ahrendt writes: > [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: > old_cwd This is the only one that looks a real bug, all the rest are false positives. Please filter them out from future reports. -- Alexandre Julliard julli...@winehq.org

CPPCheck for Sept 8th

2009-09-09 Thread chris ahrendt
[/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [/home/cahrend

Re: [PATCH 2/4] mshtml: Added http loading test.

2009-09-09 Thread Paul Vriens
On 09/02/2009 12:27 PM, Jacek Caban wrote: --- dlls/mshtml/tests/htmldoc.c | 270 +-- 1 files changed, 182 insertions(+), 88 deletions(-) Hi Jacek, Looks like this one introduced

Re: CPP Run for Sept 8

2009-09-09 Thread Stefan Dösinger
hi, I think its better to send these reports to wine-devel instead of wine-patches

Re: gdi32/tests: Some GdiAlphaBlend tests

2009-09-09 Thread Nikolay Sivov
Roderick Colenbrander wrote: Regarding the zero source DC, what happens visually? On Wed, Sep 9, 2009 at 1:30 PM, Nikolay Sivov wrote: Bug http://bugs.winehq.org/show_bug.cgi?id=18041 shows this commented crash. I'm not sure how to fix it, but I think this call can't do anything without sour

Re: gdi32/tests: Some GdiAlphaBlend tests

2009-09-09 Thread Roderick Colenbrander
Regarding the zero source DC, what happens visually? On Wed, Sep 9, 2009 at 1:30 PM, Nikolay Sivov wrote: > Bug http://bugs.winehq.org/show_bug.cgi?id=18041 shows this commented crash. > I'm not sure how to fix it, but I think this call can't do anything > without source context. > > Another quest

Recommending fixes (was: mfc42: Stub implementation with the message where to get it from)

2009-09-09 Thread Paul Chitescu
On Wednesday 09 September 2009 15:25:56 Alexandre Julliard wrote: > Vitaliy Margolen writes: > > This is more of the testing waters type of patch. If this approach is > > fine then we can do the same for all other dlls that are shipped with > > Windows but not really a part of an O/S. > > I don't

Re: mfc42: Stub implementation with the message where to get it from

2009-09-09 Thread Alexandre Julliard
Vitaliy Margolen writes: > This is more of the testing waters type of patch. If this approach is > fine then we can do the same for all other dlls that are shipped with > Windows but not really a part of an O/S. I don't think you can put up a message box on attach, that could potentially become

Re: [PATCH 02/10] d3d10: Implement annotation parsing.

2009-09-09 Thread Rico Schüller
Am 09.09.2009 12:47, schrieb Henri Verbeet: 2009/9/9 Rico Schüller: -static void parse_fx10_annotation(const char **ptr) +static HRESULT parse_fx10_annotation(struct d3d10_effect_variable *a, const char **ptr, const char *data) { -skip_dword_unknown(ptr, 3); +DWORD offset; + +

Re: gdi32: Handle OEM_CHARSET

2009-09-09 Thread Dmitry Timoshkov
"Vladimir Pankratov" wrote: --- a/dlls/gdi32/freetype.c 2009-08-08 13:27:23.0 +0500 +++ b/dlls/gdi32/freetype.c 2009-09-07 19:58:58.0 +0500 @@ -3576,6 +3576,7 @@ if(!TranslateCharsetInfo((DWORD*)(INT_PTR)lf.lfCharSet, &csi, TCI_SRCCHARSET)) { switch(lf.lfCharSet) {

Re: msxml3: Add IDispatchEx support to IXMLDOMElement (resend 2)

2009-09-09 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > Hi, > Feedback if something is wrong would be great. domdoc.c:601: warning: ISO C90 forbids mixed declarations and code -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 02/10] d3d10: Implement annotation parsing.

2009-09-09 Thread Henri Verbeet
2009/9/9 Rico Schüller : > -static void parse_fx10_annotation(const char **ptr) > +static HRESULT parse_fx10_annotation(struct d3d10_effect_variable *a, const > char **ptr, const char *data) > { > -skip_dword_unknown(ptr, 3); > +DWORD offset; > + > +read_dword(ptr, &offset); > +TR

Re: Asynchronus serial port

2009-09-09 Thread Wolfgang Walter
Am Donnerstag, 3. September 2009 schrieb Mike Kaplinskiy: > On Wed, Sep 2, 2009 at 7:31 PM, Fenixk19 wrote: > > Hello! I've already post the > > bug(http://bugs.winehq.org/show_bug.cgi?id=19713) on this subject, but i > > need more help. So I've decided to write here. > > There is a problem in wine

Google Summer of Code mentor summit Oct 24th-25th

2009-09-09 Thread Kai Blin
Hi folks, Wine gets to send two delegates to the Google Summer of Code mentor summit in Mountain View, CA, this October. Is anybody who mentored interested in going? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Sa