Re: cpp check run monday Aug 31

ok will report a false positive thanks chris - Original Message From: Vincent Povirk To: chris ahrendt Cc: wine-devel@winehq.org Sent: Tuesday, September 1, 2009 9:30:46 AM Subject: Re: cpp check run monday Aug 31 > [/home/cahrendt/wine-git/dlls/windowscodecs/bmpencode.c:336]: (erro

Re: Mirror Space

Ben Klein wrote: > 2009/9/2 Scott Ritchie : >> Ben Klein wrote: >>> 2009/9/2 Scott Ritchie : Austin English wrote: > Since when is a mirror a bad thing? > It isn't, of course, however it can't replace the role of apt server (which would require users to manually alter their s

Re: Mirror Space

2009/9/2 Scott Ritchie : > Ben Klein wrote: >> 2009/9/2 Scott Ritchie : >>> Austin English wrote: Since when is a mirror a bad thing? >>> It isn't, of course, however it can't replace the role of apt server >>> (which would require users to manually alter their sources.list file). >> >> J

Re: Mirror Space

Ben Klein wrote: > 2009/9/2 Scott Ritchie : >> Austin English wrote: >>> Since when is a mirror a bad thing? >>> >> It isn't, of course, however it can't replace the role of apt server >> (which would require users to manually alter their sources.list file). > > Just like how they have to alter th

Re: Mirror Space

2009/9/2 Scott Ritchie : > Austin English wrote: >> Since when is a mirror a bad thing? >> > > It isn't, of course, however it can't replace the role of apt server > (which would require users to manually alter their sources.list file). Just like how they have to alter their sources.list to get to

Re: Mirror Space

Vitaliy Margolen wrote: > Scott Ritchie wrote: >> Marty Cannon wrote: >>> Hey guys, >>> Since the wine.budgetdedicated.com >>> server was down all weekend, I thought I'd offer an additional mirror >>> location. >> It should be up for good now, so this won't be nece

Re: Mirror Space

Austin English wrote: > On Tue, Sep 1, 2009 at 2:52 PM, Scott Ritchie wrote: >> Marty Cannon wrote: >>> Hey guys, >>> Since the wine.budgetdedicated.com >>> server was down all weekend, I thought I'd offer an additional mirror >>> location. I currently mirror sever

Re: Mirror Space

Scott Ritchie wrote: > Marty Cannon wrote: >> Hey guys, >> Since the wine.budgetdedicated.com >> server was down all weekend, I thought I'd offer an additional mirror >> location. > > It should be up for good now, so this won't be necessary. Isn't that what you s

Re: [PATCH] [WineDbg]: fix backend prototypes for PowerPC and Alpha

On Tue, Sep 1, 2009 at 3:23 PM, Eric Pouech wrote: > > > > A+ > --- > >  programs/winedbg/be_alpha.c |    8 >  programs/winedbg/be_ppc.c   |    8 >  2 files changed, 8 insertions(+), 8 deletions(-) > > > diff --git a/programs/winedbg/be_alpha.c b/programs/winedbg/be_alpha.c > inde

Re: Mirror Space

On Tue, Sep 1, 2009 at 2:52 PM, Scott Ritchie wrote: > Marty Cannon wrote: >> Hey guys, >> Since the wine.budgetdedicated.com >> server was down all weekend, I thought I'd offer an additional mirror >> location. I currently mirror several major linux distributions,

Re: [PATCH 09/10] mshtml: Added function object tests.

Hi Paul, Paul Vriens wrote: Hi Jacek, Looks like this patch introduced test failures on IE6 and IE7 (only? as a box with IE5 succeeded and IE8 seems ok as well). Could you have a look? It strange, it works for me on IE6. IE7 is clearly broken. I've sent patches fixing it, thanks for notif

Re: Mirror Space

Marty Cannon wrote: > Hey guys, > Since the wine.budgetdedicated.com > server was down all weekend, I thought I'd offer an additional mirror > location. I currently mirror several major linux distributions, and > would love to contribute to something as valuable to

Re: [PATCH 09/10] mshtml: Added function object tests.

Jacek Caban wrote: --- dlls/mshtml/tests/script.c | 99 +++- 1 files changed, 98 insertions(+), 1 deletions(-) Hi Jacek, Looks like this patch introduced test failures on I

Mirror Space

Hey guys, Since the wine.budgetdedicated.com server was down all weekend, I thought I'd offer an additional mirror location. I currently mirror several major linux distributions, and would love to contribute to something as valuable to the community as the wine project is. My site currently runs ar

Re: [1/3] riched20: Implement handling of WM_KEYDOWN VK_RETURN in a dialog mode.

> 3. Is there any need for storing the hwndParent in editor.  Couldn't > the value be obtained by using GetWindowLongW using GWL_HWNDPARENT > after making sure that editor->hWnd is non-NULL (i.e. windowed mode). > Scratch that point, I see that it is tested for using SetParent in the tests after cr

Re: cpp check run monday Aug 31

> [/home/cahrendt/wine-git/dlls/windowscodecs/bmpencode.c:336]: (error) > Division by zero > [/home/cahrendt/wine-git/dlls/windowscodecs/bmpencode.c:337]: (error) > Division by zero http://source.winehq.org/git/wine.git/?a=blob;f=dlls/windowscodecs/bmpencode.c;h=11c39e898675122eb24df6a3a0ba9a911c9

Re: [1/3] riched20: Implement handling of WM_KEYDOWN VK_RETURN in a dialog mode.

On Tue, Sep 1, 2009 at 4:18 AM, Sergey Khodych wrote: > @@ -2145,6 +2145,31 @@ ME_KeyDown(ME_TextEditor *editor, WORD nKey) >       ME_SendRequestResize(editor, FALSE); >       return TRUE; >     case VK_RETURN: > +      if (editor->bDialogMode) > +      { > +        DWORD dwStyle; > + > +        

Re: cpp check run monday Aug 31

2009/9/1 chris ahrendt : > [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:320]: (error) Division > by zero > [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:336]: (error) Division > by zero > [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:340]: (error) Division > by zero ... > [/home/cahrendt/win

cpp check run monday Aug 31

I ran CPP check against the monday git tree using the latest CPP check off their git tree. here is the result : [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:320]: (error) Division by zero [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:336]: (error) Division by zero [/home/cahrendt/wine-gi

Re: urlmon: Add test for IsValidURL

Hi Vladimir, Vladimir Pankratov wrote: Hello all. Added test for IsValidURL. changed files: dlls/urlmon/tests/misc.c +{ +hr = IsValidURL(NULL, bad_urls[i], 0); +ok(hr != S_OK, "URL %s must be invalid\n", wine_dbgstr_w(bad_urls[i])); It would be better to test the exact

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009/9/1 Ismael Barros² : > On Tue, Sep 1, 2009 at 11:00 AM, Henri Verbeet wrote: >> 2009/9/1 Ismael Barros : >>> +typedef struct tagDPSP_MSG_HEADER >>> +{ >>> +    DWORD       size;           /* size & 0x000F, token & 0xFFF0 */ >>> +    SOCKADDR_IN SockAddr; >>> +} DPSP_MSG_HEADER, *LPDPSP

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

On Tue, Sep 1, 2009 at 11:00 AM, Henri Verbeet wrote: > 2009/9/1 Ismael Barros : >> +typedef struct tagDPSP_MSG_HEADER >> +{ >> +    DWORD       size;           /* size & 0x000F, token & 0xFFF0 */ >> +    SOCKADDR_IN SockAddr; >> +} DPSP_MSG_HEADER, *LPDPSP_MSG_HEADER; >> +typedef const DPS

Re: [PATCH 1/7] dpwsockx: Stub implementation

dpwsockx is not used by any application, only by us in dplayx, so it's pretty safe to assume we won't pass any invalid parameter, as all the parameters passed by applications are already checked for validity in dplayx. On Tue, Sep 1, 2009 at 11:00 AM, Henri Verbeet wrote: > 2009/9/1 Ismael Barros

Re: [PATCH 4/4] openal32: Add thunks for EFX functions

On Tuesday 01 September 2009 1:59:54 am Henri Verbeet wrote: > I suppose 32-bit reads are atomic on x86, provided the variable is > aligned correctly, but shouldn't access to CurrentCtx technically be > synchronized? Probably, but I'm not sure it would be beneficial. If the thread can be interrup

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009/9/1 Ismael Barros : > +typedef struct tagDPSP_MSG_HEADER > +{ > +    DWORD       size;           /* size & 0x000F, token & 0xFFF0 */ > +    SOCKADDR_IN SockAddr; > +} DPSP_MSG_HEADER, *LPDPSP_MSG_HEADER; > +typedef const DPSP_MSG_HEADER* LPCDPSP_MSG_HEADER; > + It seems you're sending

Re: [PATCH 1/7] dpwsockx: Stub implementation

2009/9/1 Ismael Barros : > --- >  dlls/dpwsockx/Makefile.in     |    2 +- >  dlls/dpwsockx/dpwsockx_main.c |  164 > - >  2 files changed, 163 insertions(+), 3 deletions(-) > This patch seems to assume the application will never pass NULL for "data", is that

Re: [PATCH 4/4] openal32: Add thunks for EFX functions

I suppose 32-bit reads are atomic on x86, provided the variable is aligned correctly, but shouldn't access to CurrentCtx technically be synchronized?