Re: configure: Detect and use tools executable extensions for makefiles. (try2)

2009-08-28 Thread Dylan Smith
On Fri, Aug 28, 2009 at 5:57 PM, John Klehm wrote: > > On Fri, Aug 28, 2009 at 3:13 PM, Dylan Smith wrote: > > (used sed to get the EXEEXT from the wine-tools/Make.rules file) > > > > When compiling Wine on windows, the non-script tools will have an .exe > > extension, but the makefile rules assum

Re: progress of sound update -- REVISED

2009-08-28 Thread Ben Klein
2009/8/29 Susan Cragin : >>>Why do you need to install esound? > >>ALSA has shipped with "dmix" by default since shortly after 1.0 was >>released, though I think Ubuntu's pulse config can screw with it even >>after pulseaudio is removed. > > I'd forgotten about dmix, it's been so long. Good old dmi

Re: configure: Detect and use tools executable extensions for makefiles. (try2)

2009-08-28 Thread John Klehm
On Fri, Aug 28, 2009 at 3:13 PM, Dylan Smith wrote: > (used sed to get the EXEEXT from the wine-tools/Make.rules file) > > When compiling Wine on windows, the non-script tools will have an .exe > extension, but the makefile rules assumed that the tools never have an > extention, so try to incorrect

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread Mike Kaplinskiy
On Fri, Aug 28, 2009 at 5:22 PM, Marcus Meissner wrote: > On Fri, Aug 28, 2009 at 02:16:40PM -0700, chris ahrendt wrote: >> Ok CPPCheck guys have repired the false positive but now get this: >> >> $ ./cppcheck -q -a ../wine/wine/dlls/wineoss.drv/mixer.c >> ../wine/wine/dlls/wineoss.drv/mixer.c:576:

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread Marcus Meissner
On Fri, Aug 28, 2009 at 02:16:40PM -0700, chris ahrendt wrote: > Ok CPPCheck guys have repired the false positive but now get this: > > $ ./cppcheck -q -a ../wine/wine/dlls/wineoss.drv/mixer.c > ../wine/wine/dlls/wineoss.drv/mixer.c:576: (error) Resource leak: mixer > ../wine/wine/dlls/wineoss.dr

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread chris ahrendt
Ok CPPCheck guys have repired the false positive but now get this: $ ./cppcheck -q -a ../wine/wine/dlls/wineoss.drv/mixer.c ../wine/wine/dlls/wineoss.drv/mixer.c:576: (error) Resource leak: mixer ../wine/wine/dlls/wineoss.drv/mixer.c:600: (error) Resource leak: mixer ../wine/wine/dlls/wineoss.drv

Recent ntdll performance information patches

2009-08-28 Thread Steven Edwards
Since the last few rounds of patches to NtQuerySystemInformation I am now getting this error when trying to build with llvm-gcc from the latest Xcode nt.c: In function ‘NtQuerySystemInformation’: nt.c:1012: error: ‘struct _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION’ has no member named ‘liIdleTime’

Re: [PATCH 6/7] ws2_32: implement AcceptEx

2009-08-28 Thread Mike Kaplinskiy
On Fri, Aug 28, 2009 at 2:01 PM, Juan Lang wrote: > Hi Mike, I have one minor nit on this patch: > > +    if (wsa->read) HeapFree( GetProcessHeap(), 0, wsa->read ); > Please don't check if (wsa->read) is NULL before calling HeapFree. > HeapFree already does the correct thing given NULL, and we had

Re: [PATCH 6/7] ws2_32: implement AcceptEx

2009-08-28 Thread Juan Lang
Hi Mike, I have one minor nit on this patch: +if (wsa->read) HeapFree( GetProcessHeap(), 0, wsa->read ); Please don't check if (wsa->read) is NULL before calling HeapFree. HeapFree already does the correct thing given NULL, and we had a bunch of patches to remove checks like this. --Juan

Re: progress of sound update -- REVISED

2009-08-28 Thread Susan Cragin
>>Why do you need to install esound? >ALSA has shipped with "dmix" by default since shortly after 1.0 was >released, though I think Ubuntu's pulse config can screw with it even >after pulseaudio is removed. I'd forgotten about dmix, it's been so long. Good old dmix and dsnoop (which is what I ne

WINE and the LSB, or installations Picasa style

2009-08-28 Thread Joe Dluzen
Hello all, any updates on the progress of compiling WINE against the LSB? I know Dan was attempting to here http://www.mail-archive.com/wine-devel@winehq.org/msg47916.html but there's been no recent updates. Or, does anyone have any tips or tutorials or best practices to deploy a self contained W

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread Juan Lang
>> Changing these to single constant values would make it >> much harder for the casual observer to read. > > That's what comments are for. Actually, comments are for code that's not understandable without them. The code is more readable as it is, IMHO, than it would be by replacing the expressio

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread Austin English
On Fri, Aug 28, 2009 at 4:06 AM, Ben Klein wrote: > Changing these to single constant values would make it > much harder for the casual observer to read. That's what comments are for. -- -Austin

Re: progress of sound update -- REVISED

2009-08-28 Thread Ben Klein
2009/8/28 Susan Cragin : >> Why do you need to install esound? > > I don't know. I've taken it for granted that some kind of mixer is needed. > Perhaps because I don't use the default sound card, the on-board card. Maybe > I don't need esound at all. Or maybe if I could permanently make my Creati

Re: progress of sound update -- REVISED

2009-08-28 Thread Susan Cragin
Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and suddenly alsa works with wine, without stumbling. Today's secret to making it work: In System/Preferences/Startup applications, uncheck pulseaudio sudo apt-get install esound Why do you need to install esound? I don't

RE: netapi32/tests: Add acceptable error codes for Win7

2009-08-28 Thread Greg Geldorp
From: André Hentschel [mailto:n...@dawncrow.de] > adding "|| RPC_S_SERVER_UNAVAILABLE" is surely not what you wanted, i > think you mean "|| rc == RPC_S_SERVER_UNAVAILABLE" You're right of course. Resent. Thanks, Ge.

Re: netapi32/tests: Add acceptable error codes for Win7

2009-08-28 Thread André Hentschel
adding "|| RPC_S_SERVER_UNAVAILABLE" is surely not what you wanted, i think you mean "|| rc == RPC_S_SERVER_UNAVAILABLE" -- Best Regards, André Hentschel

Re: progress of sound update -- REVISED

2009-08-28 Thread Ben Klein
2009/8/28 Susan Cragin : > Change -- The program I test with is Dragon NaturallySpeaking. > > Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and > suddenly alsa works with wine, without stumbling. > Today's secret to making it work: > In System/Preferences/Startup applications,

Re: progress of sound update -- REVISED

2009-08-28 Thread Susan Cragin
Change -- The program I test with is Dragon NaturallySpeaking. Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and suddenly alsa works with wine, without stumbling. Today's secret to making it work: In System/Preferences/Startup applications, uncheck pulseaudio sudo apt-get in

progress of sound update

2009-08-28 Thread Susan Cragin
Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and suddenly alsa works with wine, without stumbling. Today's secret to making it work: In System/Preferences/Startup applications, uncheck pulseaudio sudo apt-get install esound sudo nano /etc/pulse/client.conf autospawn = no Then

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread Ben Klein
2009/8/28 Dmitry Timoshkov : > "James McKenzie" wrote: > >>> False positive, apparently the numbers are hardcoded as: >>> 72     char        msg[128]; >>> 88         msg[10 + 3 * 16] = ' '; // = 58<127 >>> >> >> Why not just say 58 instead of the complex math? >>> >>> 89         msg[10 + 3 * 16 +

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread Dmitry Timoshkov
"James McKenzie" wrote: False positive, apparently the numbers are hardcoded as: 72 charmsg[128]; 88 msg[10 + 3 * 16] = ' '; // = 58<127 Why not just say 58 instead of the complex math? 89 msg[10 + 3 * 16 + 1 + 16] = '\0'; // = 75<127 Same here. Why not 7