Re: CPPCheck Run for Friday August 21

2009-08-21 Thread chris ahrendt
Mike Kaplinskiy wrote: > On Fri, Aug 21, 2009 at 9:21 PM, chris ahrendt wrote: > >> [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 >> [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a >> deallocated pointer: stream2 >> [../wine-git/dlls/msvcrt/tests/f

Re: CPPCheck Run for Friday August 21

2009-08-21 Thread Mike Kaplinskiy
On Fri, Aug 21, 2009 at 9:21 PM, chris ahrendt wrote: > [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 > [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a > deallocated pointer: stream2 > [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak:

Appinstall strikes again!

2009-08-21 Thread Austin English
So, I've been on vacation this past week. Before leaving, I ran 'daily ; daily ; daily ; daily ; daily' to make sure they daily build scripts still ran while I was gone. Looking at the logs, I found something interesting: wordviewer03-result.txt:wordview_en-us.exe didn't crash. Bug 19185 TODO_FIXE

CPPCheck Run for Friday August 21

2009-08-21 Thread chris ahrendt
[../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [../wine-git/dlls/msvcrt/tests/file.c:973]: (error)

Re: oleaut32: Dynamic invocation for x86

2009-08-21 Thread Steven Edwards
On Fri, Aug 21, 2009 at 1:42 PM, Juan Lang wrote: > Ah, fair enough, and clearly oleaut32 belongs in that category.  Thanks. I should have said Windows as technically mingw is still __GNUC__ but you got the idea. -- Steven Edwards "There is one thing stronger than all the armies in the world, a

Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc.

2009-08-21 Thread James Mckenzie
Rico: Which patch is the correct one? Please send it in with (try 3). James McKenzie -Original Message- >From: Rico Schüller >Sent: Aug 21, 2009 9:16 AM >To: wine-patc...@winehq.org >Subject: Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc. > >Am 21.08.2009 17:46, s

Re: oleaut32: Dynamic invocation for x86

2009-08-21 Thread Juan Lang
> There are a few instances of it, at least in code we care about > sharing with a mingw build Ah, fair enough, and clearly oleaut32 belongs in that category. Thanks. --Juan

Re: oleaut32: Dynamic invocation for x86

2009-08-21 Thread Steven Edwards
On Fri, Aug 21, 2009 at 12:31 PM, Juan Lang wrote: > We don't protect by __GNUC__ for any of our other assembly either, > even though it all uses GNU assembly syntax.  So personally I think > that part's okay. There are a few instances of it, at least in code we care about sharing with a mingw bui

Re: oleaut32: Dynamic invocation for x86

2009-08-21 Thread Juan Lang
Thanks for the review, Henri. > I don't know if there's a reason the general approach couldn't work, > but the code in the patch is gcc specific, so I think it should at > least be protected by __GNUC__ in addition to __i386__. We don't protect by __GNUC__ for any of our other assembly either, ev

Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc.

2009-08-21 Thread Rico Schüller
Am 21.08.2009 17:46, schrieb Rico Schüller: --- dlls/d3d10/d3d10_private.h |3 ++- dlls/d3d10/effect.c| 25 ++--- 2 files changed, 20 insertions(+), 8 deletions(-) Hi, the previou

Re: Bug for beginners

2009-08-21 Thread Stephen Eilert
On Fri, Aug 21, 2009 at 12:25 PM, Juan Lang wrote: > > As I understand from Wine's policies, functions should only be > implemented > > if an application requires them. If that's correct, a random search for > > stubs isn't a good idea, because the follow up question would be "which > > applicati

Re: Bug for beginners

2009-08-21 Thread James Mckenzie
>On Fri, Aug 21, 2009 at 12:58 AM, Andrew Eikum >wrote: > >> Alexandros Dermenakis wrote: >> >>> Hi all, >>> >>> I studied the wine developer's guide and went a bit through the code. I >>> would like a suggestion, a bug to start understanding better the structure >>> of wine and familiarize myself

Re: Bug for beginners

2009-08-21 Thread Juan Lang
> As I understand from Wine's policies, functions should only be implemented > if an application requires them. If that's correct, a random search for > stubs isn't a good idea, because the follow up question would be "which > application requires this function?". We certainly prioritize functions

Re: Bug for beginners

2009-08-21 Thread Stephen Eilert
On Fri, Aug 21, 2009 at 12:58 AM, Andrew Eikum wrote: > Alexandros Dermenakis wrote: > >> Hi all, >> >> I studied the wine developer's guide and went a bit through the code. I >> would like a suggestion, a bug to start understanding better the structure >> of wine and familiarize myself with it in

Re: (resend) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [3rd]

2009-08-21 Thread Stefan Leichter
Am Friday 21 August 2009 14:22:14 schrieb Alexandre Julliard: > Stefan Leichter writes: > > Am Friday 21 August 2009 11:37:56 schrieb Alexandre Julliard: > >> Stefan Leichter writes: > >> > @@ -1711,32 +1713,35 @@ > >> > } > >> > else > >> > { > >> > -/* If

Re: (resend) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [3rd]

2009-08-21 Thread Alexandre Julliard
Stefan Leichter writes: > Am Friday 21 August 2009 11:37:56 schrieb Alexandre Julliard: >> Stefan Leichter writes: >> > @@ -1711,32 +1713,35 @@ >> >} >> >else >> >{ >> > - /* If the executable name is not quoted, we have to use this search >> > loop here, +/* FIXME:

Re: Bug for beginners

2009-08-21 Thread Alex Dermenakis
Thanks to both of you Andrew and Juan. I think though I'll with Andrew's suggestion. ;-) On Thu, Aug 20, 2009 at 11:58 PM, Andrew Eikum wrote: > Alexandros Dermenakis wrote: > >> Hi all, >> >> I studied the wine developer's guide and went a bit through the code. I >> would like a suggestion, a bu

Re: (resend) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [3rd]

2009-08-21 Thread Stefan Leichter
Am Friday 21 August 2009 11:37:56 schrieb Alexandre Julliard: > Stefan Leichter writes: > > @@ -1711,32 +1713,35 @@ > > } > > else > > { > > - /* If the executable name is not quoted, we have to use this search > > loop here, +/* FIXME: what versions support this? Fai

Re: mshtml: Implement IHTMLStyle get/put wordSpacing

2009-08-21 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: Hi, Changelog: mshtml: Implement IHTMLStyle get/put wordSpacing static HRESULT WINAPI HTMLStyle_put_wordSpacing(IHTMLStyle *iface, VARIANT v) { -HTMLStyle *This = HTMLSTYLE_THIS(iface); -FIXME("(%p)->(v%d)\n", This, V_VT(&v)); -retur

Re: (resend) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [3rd]

2009-08-21 Thread Alexandre Julliard
Stefan Leichter writes: > @@ -1711,32 +1713,35 @@ > } > else > { > - /* If the executable name is not quoted, we have to use this search > loop here, > +/* FIXME: what versions support this? Fails on 2000/XP > + If the executable name is not qu

Re: kernel32: test GetPrivateProfileString with empty string as key and section

2009-08-21 Thread Michael Stefaniuc
Hello Stefan, Stefan Leichter wrote: > Problem spotted from Claudio Fontana on wine-devel > > tested on Win2K > diff -ruw wine-git/dlls/kernel32/tests/profile.c > wine-build/dlls/kernel32/tests/profile.c > --- wine-git/dlls/kernel32/tests/profile.c2009-06-04 19:00:09.0 > +0200 > ++

Re: oleaut32: Dynamic invocation for x86

2009-08-21 Thread Henri Verbeet
2009/8/21 Juan Lang : > Personally, I don't think the cut-and-paste approach we've been taking > to fix this works all that well for a 126-argument function, so it > seems like an assembly approach is the only tenable method.  I'm not > certain whether Jon's approach is the correct one, but since i