Re: Towards leveraging app build and unit tests as a way to test wine

2009-08-18 Thread Dan Kegel
On Mon, Aug 10, 2009 at 1:42 AM, Dan Kegel wrote: > Wine is far enough along that it ought to be > able to build and run unit test suites from > apps like Inkscape, Firefox, and OpenOffice ... > Next step: grabbing firefox source and building. > > I'm also filing bugs as I go; > 19673   Microsoft P

RE: about video memory detection in wine

2009-08-18 Thread Sun, Sunny
Hi Verbeet The spec will be fixed, but it will take some time. But I think we can use it now because it is implemented and will not change. Hi Dösinger Have you done that? Regards Sunny -Original Message- From: Henri Verbeet [mailto:hverb...@gmail.com] Sent: Sunday, August 16, 2009 9:52

Re: [1/18] d3dx9: Add shader assembler private definitions

2009-08-18 Thread Matteo Bruni
2009/8/18 Henri Verbeet : > 2009/8/18 Matteo Bruni : >> constructs, single instructions, ...) but it seems to be quite a work >> and in any case the resulting patch needs to have a working lexer, >> parser, bytecode writer and the glue among them, so it can't be made >> smaller than so much, I beli

Re: [1/18] d3dx9: Add shader assembler private definitions

2009-08-18 Thread Henri Verbeet
2009/8/18 Matteo Bruni : > constructs, single instructions, ...) but it seems to be quite a work > and in any case the resulting patch needs to have a working lexer, > parser, bytecode writer and the glue among them, so it can't be made > smaller than so much, I believe. I don't think that's reall

Re: [1/18] d3dx9: Add shader assembler private definitions

2009-08-18 Thread Juan Lang
> The assembler requires quite some code to be at least minimally > working (i.e. to implement a somewhat working D3DXAssembleShader > function). Is it not possible to implement enough to support some small subset of the language? If it's not at all possible, then we'll just have to live with it.

Re: [PATCH 1/3] tools/widl: A structure containing a BOGUS_ARRAY should be a BOGUS_STRUCT.

2009-08-18 Thread Alexandre Julliard
Huw Davies writes: > @@ -280,9 +282,10 @@ unsigned char get_struct_fc(const type_t *type) > if (get_enum_fc(t) == RPC_FC_ENUM16) > return RPC_FC_BOGUS_STRUCT; > break; > -case TGT_POINTER: > case TGT_ARRAY: > -if (get_pointer_fc(t, field->attrs, FAL

Re: [1/18] d3dx9: Add shader assembler private definitions

2009-08-18 Thread Matteo Bruni
> Step 4) really comprises many small patches, and will often comprise > the bulk of the patchset.  It's important to make each commit atomic > and useful.  So, for example, adding a bunch of declarations that > aren't used to a private header isn't useful, though it is atomic. Hi Juan, while in p

Re: winelib include problem

2009-08-18 Thread Maarten Lankhorst
Hi Jesse, 2009/8/12 Jesse Allen : > Oh that may have been the correct way for vmrender.idl, but the patch > you proposed of protecting with a struct does compile.  My app does > not use a VMRGUID, so I don't know if it really works :) Commit a664043e1d1e93bcbe2 fixes this in the cleanest way for

Re: advapi32: SetEntriesInAclW() should accept account name "CURRENT_USER".

2009-08-18 Thread Rob Shearman
2009/8/16 Rein Klazes : > @@ -3510,7 +3511,8 @@ DWORD WINAPI SetEntriesInAclW( ULONG count, > PEXPLICIT_ACCESSW pEntries, >             DWORD sid_size = FIELD_OFFSET(SID, > SubAuthority[SID_MAX_SUB_AUTHORITIES]); >             DWORD domain_size = MAX_COMPUTERNAME_LENGTH + 1; >             SID_NAM

Re: msxml3: Support loading windows file path under wine (try 2 - Resend)

2009-08-18 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > Hi, > Stopped converting the filename to Unicode. Obviously you still need to convert for opening it. -- Alexandre Julliard julli...@winehq.org

Re: mp3 update

2009-08-18 Thread Aric Stewart
Sorry, I was out Friday and Monday so I am just getting back here. Am i reading that the general opinion is that I should rework winemp3.acm to load the external libmpg123 and just abandon the builtin mp3 support? Or was there still something else of issue with my work? thanks, -aric Marcus