Re: Regression Testing 0.9.60/0.9.61

2009-08-16 Thread James McKenzie
Erich Hoover wrote: > On Sun, Aug 16, 2009 at 1:10 PM, James McKenzie > mailto:jjmckenzi...@earthlink.net>> wrote: > > Looks like a patch to 0.9.61 broke the EM_FORMATRANGE patch that I was > working on. I've received guidance from Dylan Smith on how to > redo the > patch and I wil

Re: [PATCH 6/6] wined3d: Make RTL_READTEX the default rendertarget locking method.

2009-08-16 Thread Roderick Colenbrander
The best test case I think for that is ddraw-gl. A lot of 2D games use partial locking. Roderick On Sun, Aug 16, 2009 at 10:43 PM, Henri Verbeet wrote: > Actually, do you have an application that needs partial texture > updates? I implemented it, but I need something to test against. > > >

Re: [PATCH 6/6] wined3d: Make RTL_READTEX the default rendertarget locking method.

2009-08-16 Thread Henri Verbeet
Actually, do you have an application that needs partial texture updates? I implemented it, but I need something to test against.

Re: winecfg: Let the user specify the drive letter of a to be added drive.

2009-08-16 Thread Vitaliy Margolen
Rein Klazes wrote: > On Sun, 16 Aug 2009 13:18:56 -0500, you wrote: > >> Howdy Rein, >> >> I don't believe you're supposed to add English resources to >> non-English rc files. The dialog will automatically fall back to >> English if not present. It messes up the translation stats.. > > Is that so

Re: Regression Testing 0.9.60/0.9.61

2009-08-16 Thread Austin English
On Sun, Aug 16, 2009 at 2:10 PM, James McKenzie wrote: > Looks like a patch to 0.9.61 broke the EM_FORMATRANGE patch that I was > working on.  I've received guidance from Dylan Smith on how to redo the > patch and I will once I get the old patch working with 1.0. > > Guidance on how to use git to r

Re: Regression Testing 0.9.60/0.9.61

2009-08-16 Thread Erich Hoover
On Sun, Aug 16, 2009 at 1:10 PM, James McKenzie wrote: > Looks like a patch to 0.9.61 broke the EM_FORMATRANGE patch that I was > working on. I've received guidance from Dylan Smith on how to redo the > patch and I will once I get the old patch working with 1.0. > > Guidance on how to use git to

Re: [1/18] d3dx9: Add shader assembler private definitions

2009-08-16 Thread Matteo Bruni
2009/8/16 Vincent Povirk : > Don't send patches that only add unused code. > Well, to be true all the first 12 patches add code which is effectively used only from patch 13 onwards. But I couldn't find a better way to split the patches in manageable pieces while avoiding these kind of issues.

Regression Testing 0.9.60/0.9.61

2009-08-16 Thread James McKenzie
Looks like a patch to 0.9.61 broke the EM_FORMATRANGE patch that I was working on. I've received guidance from Dylan Smith on how to redo the patch and I will once I get the old patch working with 1.0. Guidance on how to use git to run bisect tests would be appreciated. Do I get the commit numbe

Re: winecfg: Let the user specify the drive letter of a to be added drive.

2009-08-16 Thread Rein Klazes
On Sun, 16 Aug 2009 13:18:56 -0500, you wrote: >Howdy Rein, > >I don't believe you're supposed to add English resources to >non-English rc files. The dialog will automatically fall back to >English if not present. It messes up the translation stats.. Is that so? I looked through the changelog for

Re: winecfg: Let the user specify the drive letter of a to be added drive.

2009-08-16 Thread Austin English
On Sun, Aug 16, 2009 at 1:12 PM, Rein Klazes wrote: > fixes bug#14728 > --- >  programs/winecfg/Bg.rc      |   10 + >  programs/winecfg/Cs.rc      |   10 + >  programs/winecfg/Da.rc      |   10 + >  programs/winecfg/De.rc      |   10 + >  programs/winecfg/En.rc      

Re: [1/18] d3dx9: Add shader assembler private definitions

2009-08-16 Thread Vincent Povirk
Don't send patches that only add unused code. On Sun, Aug 16, 2009 at 12:50 PM, Matteo Bruni wrote: > This is a long patch series that implements the D3D shader assembler > and D3DXAssembleShader function. The first part has already passed a > couple of rounds of review in wine-devel. > > > > -

Re: AF_Irda.h header file

2009-08-16 Thread Juan Lang
Hi Thomas, > Nonetheless, I attached my version, it contains all definitons of the > Windows SDK 7 header though is not WS_tified. Thanks! Could you prepare a patch that adds your definitions and send it to wine-patches? Thanks, --Juan

Re: When do regressions become high priority for developers?

2009-08-16 Thread Scott Ritchie
Rein Klazes wrote: > On Sat, 15 Aug 2009 10:46:19 -0700, you wrote: > >> 14 months seems to be more than reasonable to repair a regression. I'm >> worried about having to forever maintain a separate installation of >> Wine just to use this program. I'll be happy to test further if >> someone is go

Re: When do regressions become high priority for developers?

2009-08-16 Thread Rein Klazes
On Sat, 15 Aug 2009 10:46:19 -0700, you wrote: > >14 months seems to be more than reasonable to repair a regression. I'm >worried about having to forever maintain a separate installation of >Wine just to use this program. I'll be happy to test further if >someone is going to work on this bug but r

Re: Appinstall testing guide up on the wiki

2009-08-16 Thread Austin English
On Sat, Aug 15, 2009 at 5:47 PM, Matt Perry wrote: > On Sat, Aug 15, 2009 at 11:58 AM, Austin English > wrote: >> James asked me to put up a guide for testing applications with >> Appinstall. > > The guide looks great. Will there be any service to facilitate sharing > of scripts between users? Wi

Re: Appinstall testing guide up on the wiki

2009-08-16 Thread Austin English
2009/8/16 Nicklas Börjesson : > This looks way cool. If no one else have already started, I'll have a go with > PS CS4. Excellent. You may want to start with something simpler. CS4 is a beast, and probably has a lot of hidden bugs. Start with something that works well, to get used to coding up te

RE: Appinstall testing guide up on the wiki

2009-08-16 Thread Nicklas Börjesson
This looks way cool. If no one else have already started, I'll have a go with PS CS4. So I looked through the CS2 script and I have two questions: 1. CS4, and many other, currently need some winetricks to install and work. Can I use winetricks or do I have to break out the downloading and install