Re: Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-11 Thread Dmitry Timoshkov
"Andrew Eikum" wrote: The root cause of this is X's XKeysymToKeycode returning the keycode for the phantom key instead of the keycode for the comma key when passed the keysym for '<' (XK_less). This isn't incorrect on X's part, but inconvenient for Wine as most US keyboards don't have the <>

Re: winelib include problem

2009-08-11 Thread Jesse Allen
On Tue, Aug 11, 2009 at 7:30 AM, Maarten Lankhorst wrote: > Hi Jesse, > > Judging by that link you sent me, shouldn't it be: > > typedef struct tagVMRGUID > { > #if defined(__cplusplus) > ::GUID *pGUID, GUID; > #else > GUID *pGUID, GUID; > #endif > } VMRGUID; > > Or am i reading that link wrong

Re: Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]

2009-08-11 Thread Stefan Dösinger
Am Tuesday 11 August 2009 23:43:33 schrieb Johan Gill: > There is IWineD3DDeviceImpl_SetupFullscreenWindow, but that one is not > > exported so it can't be called from ddraw as it is. > > Calling it from within IWineD3DDevice_SetDisplayMode seems troublesome > since the hwnd to use is not always av

Re: includes: Make vmrender.idl C++ friendly

2009-08-11 Thread Maarten Lankhorst
Hi Austin, Austin English schreef: On Tue, Aug 11, 2009 at 12:56 PM, Maarten Lankhorst wrote: C++ doesn't like: GUID GUID; which is valid in C, so replace with struct _GUID GUID; FYI, you're e-mail is messed up in the patch: From: Maarten Lankhorst I think AJ's scripts may prefer t

Re: winetricks, dotnet3 and winsxs

2009-08-11 Thread Hin-Tak Leung
--- On Tue, 11/8/09, Austin English wrote: > On Mon, Aug 10, 2009 at 9:37 AM, > Hin-Tak Leung > wrote: > > Hiya, > > > > I have tried playing with the new dotnet3 > functionality. Actually even with a clean new wineprefix I > haven't been able to get dotnet3 finishing installing - it > hangs fo

Re: Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]

2009-08-11 Thread Johan Gill
On Wed, Aug 5, 2009 at 7:51 PM, Stefan Dösinger wrote: > Am Wednesday 05 August 2009 18:58:42 schrieb Johan Gill: > > On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill > wrote: > > > This patch fixes bug 17215. Since the patch was seemingly dropped, I > made > > > some test improvements and resubmit i

convert a testcase into a unittest (bug #19666)

2009-08-11 Thread Stefan Leichter
Hi, i got a testcase that exhibits bug #19666. Now i'm looking for a way to integrate the testcase into the testsuite. The testcase needs a program (currently c:\ShellExecuteClient.exe) that must be called without parameters. Therefore i can not use eg. shell32_test.exe itself. I'm searching f

Re: Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-11 Thread Andrew Eikum
Andrew Eikum wrote: A bug made itself present in VkKeyScan's handling of the less-than character on US (and other) keyboard layouts. VkKeyScan('<') in Windows returns 0x1bc, which is VK_OEM_COMMA with the shift key flag set. In Wine, VkKeyScan('<') returns 0xe2, which is VK_OEM_102, or the VK

Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-11 Thread Andrew Eikum
A bug made itself present in VkKeyScan's handling of the less-than character on US (and other) keyboard layouts. VkKeyScan('<') in Windows returns 0x1bc, which is VK_OEM_COMMA with the shift key flag set. In Wine, VkKeyScan('<') returns 0xe2, which is VK_OEM_102, or the VK for the "infamous p

Re: [7/10] [try 2] comctl32: Add basic structure for IImageList interface

2009-08-11 Thread Henri Verbeet
2009/8/11 Owen Rudge : >> You can't do that, you need to at least implement stubs for the other >> methods. > > This is something I did in the following patch, mainly to reduce the size of > the individual patches (based on the assumption all the patches would be > committed at once anyway). I will

Re: [7/10] [try 2] comctl32: Add basic structure for IImageList interface

2009-08-11 Thread Owen Rudge
You can't do that, you need to at least implement stubs for the other methods. This is something I did in the following patch, mainly to reduce the size of the individual patches (based on the assumption all the patches would be committed at once anyway). I will recombine the patches into a s

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA (try 2)

2009-08-11 Thread Juan Lang
> don't you miss a break statement (or a more likely a return 0) at the end of > the block ? Oh, indeed. Silly me. Thanks. --Juan

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA (try 2)

2009-08-11 Thread Eric Pouech
Juan Lang a écrit : Uses %u rather than %d, based on Henri's feedback. --Juan Hi Juan don't you miss a break statement (or a more likely a return 0) at the end of the block ? A+ -- Eric Pouech "The problem with de

Re: [7/10] [try 2] comctl32: Add basic structure for IImageList interface

2009-08-11 Thread Henri Verbeet
2009/8/11 Owen Rudge : > +static const IImageListVtbl ImageListImpl_Vtbl = { > +ImageListImpl_QueryInterface, > +ImageListImpl_AddRef, > +ImageListImpl_Release > +}; You can't do that, you need to at least implement stubs for the other methods.

Re: ws2_32(8/8): Implement getsockopt(SOL_IRLMP, IRLMP_ENUMDEVICES)

2009-08-11 Thread Juan Lang
> Isn't getsockopt() supposed to write the size of the data actually > written to optlen? Indeed. Thanks. --Juan

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA

2009-08-11 Thread Juan Lang
>> +            sprintf( win->irdaServiceName, "LSAP-SEL%d", uin->sir_lsap_sel >> ); > I have no idea if this can even be an issue in practice, but > "uin->sir_lsap_sel" is unsigned. It can't be an issue in practice since LSAP selectors are limited to 0-9, but I can change that. Thanks for the r

Re: ws2_32(8/8): Implement getsockopt(SOL_IRLMP, IRLMP_ENUMDEVICES)

2009-08-11 Thread Henri Verbeet
Isn't getsockopt() supposed to write the size of the data actually written to optlen?

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA

2009-08-11 Thread Henri Verbeet
2009/8/11 Juan Lang : > +sprintf( win->irdaServiceName, "LSAP-SEL%d", uin->sir_lsap_sel ); I have no idea if this can even be an issue in practice, but "uin->sir_lsap_sel" is unsigned.

Re: Assigning a bug to myself

2009-08-11 Thread James Mckenzie
>--- On Mon, 10/8/09, Ben Klein wrote: > >> 2009/8/10 Alexandros Dermenakis >> : >> > Hi, >> > >> > I 'm now ready to start debugging wine so I'd like to >> try solving a bug. Do I >> > need to assign a bug to myself or I just start solving >> it? If I have to assign >> > it how can I do that? >>

Re: winelib include problem

2009-08-11 Thread Maarten Lankhorst
Hi Jesse, Jesse Allen schreef: Maartan, In a patch committed on 10 Jul 2008, includes: Add video mixing renderer header, it included a construct that autogenerates this piece of code for strmif.h " typedef struct tagVMRGUID { GUID *pGUID; GUID GUID; } VMRGUID; " Unfortunately any C++

Help with test

2009-08-11 Thread Alistair Leslie-Hughes
Hi, I been trying to fix this bug, and have patch that works. http://bugs.winehq.org/show_bug.cgi?id=11325 The only thing is that the test case I've written fails under wine but work under Windows XP. The issue is, when using a stylesheet we can do something like . which attempts to load a docu

Re: hhctrl.ocx: Handle NULL param

2009-08-11 Thread Paul Chitescu
On Tuesday 11 August 2009 13:38:24 Paul Chitescu wrote: > This is a quite ugly patch, adds unnecessary wstring copying. > > Why not: > > wsprintfW(buf, url_format, full_path, (index && index[0] == '/') ? empty : > slash, index); Oops, the other way around: (!index || index[0] == '/')

Re: hhctrl.ocx: Handle NULL param

2009-08-11 Thread Paul Chitescu
This is a quite ugly patch, adds unnecessary wstring copying. Why not: wsprintfW(buf, url_format, full_path, (index && index[0] == '/') ? empty : slash, index);

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Owen Rudge
Not sure for the reason. But one thing I don't like is that this comctl32/msg.c (with no actual tests itself) is also shown on test.winehq.org. That is something that unfortunately does happen with v6util, too (v6util shows itself as another test in the test list). However, I thought it bette

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Nikolay Sivov
Paul Vriens wrote: Reece Dunn wrote: 2009/8/11 Paul Vriens : Henri Verbeet wrote: 2009/8/11 Nikolay Sivov : Henri Verbeet wrote: I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained within their own file, to

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Paul Vriens
Reece Dunn wrote: 2009/8/11 Paul Vriens : Henri Verbeet wrote: 2009/8/11 Nikolay Sivov : Henri Verbeet wrote: I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained within their own file, to allow for easy compila

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Reece Dunn
2009/8/11 Paul Vriens : > Henri Verbeet wrote: >> >> 2009/8/11 Nikolay Sivov : >>> >>> Henri Verbeet wrote: I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained within their own file, to allow for

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Henri Verbeet
2009/8/11 Paul Vriens : > FWIW, these comctl32 tests also already rely on msg.c for all the message > related tests. > It's probably not much of an issue here then.

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Paul Vriens
Henri Verbeet wrote: 2009/8/11 Nikolay Sivov : Henri Verbeet wrote: I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained within their own file, to allow for easy compilation. He didn't move any tests but only in

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Henri Verbeet
2009/8/11 Nikolay Sivov : > Henri Verbeet wrote: >> I don't know if there's any reason these tests should be an exception, >> but the general rule is that tests are supposed to be contained within >> their own file, to allow for easy compilation. >> > > He didn't move any tests but only initializat

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Nikolay Sivov
Henri Verbeet wrote: 2009/8/10 Owen Rudge : This is the first of a series of patches to implement the IImageList interface into comctl32, introduced in comctl32 v6. This first patch splits the routines for loading v6 of comctl32 (requiring a side-by-side manifest) out of the listview tests a

Re: [2/6] include: Define interface for comctl32 v6 (IImageList)

2009-08-11 Thread Henri Verbeet
2009/8/10 Owen Rudge : > +cpp_quote("#define ILIF_ALPHA 0x0001") > You don't need cpp_quote here, you can just do something like "const UINT ILIF_ALPHA = 1;" > +interface IImageList : IUnknown ... > +}; While valid, you don't need the ; here.

Re: removes 1024 mb from geforce gtx 260 and adds 896mb instead directx patch

2009-08-11 Thread Henri Verbeet
2009/8/10 James Carthew : > From 3fc1812db11e6468b9774f597993c292f36873b7 Mon Sep 17 00:00:00 2001 > From: Your Name > Date: Mon, 10 Aug 2009 12:11:31 +0930 > Subject: [PATCH] removes 1024mb from geforce 260 gtx and adds 896mb instead > to directx.c > to match real geforce 260gtx cards. Please

Re: [6/6] comctl32: Add stubs for image list functions introduced in Vista

2009-08-11 Thread Henri Verbeet
2009/8/10 Owen Rudge : > +@ stdcall HIMAGELIST_QueryInterface(long long long) ... > +@ stdcall ImageList_CoCreateInstance(long long long long) These should all be pointers. > +FIXME("STUB: %s %p %s %p\n",debugstr_guid(rclsid), punkOuter, > debugstr_guid(riid), ppv); > +return E_NOINTERFAC

Re: [5/6] comctl32/tests: Add basic test for IImageList using SHGetImageList

2009-08-11 Thread Henri Verbeet
2009/8/10 Owen Rudge : > +static BOOL test_shell_imagelist(void) ... > +test_shell_imagelist(); It's a bit pointless to add a return value if it's always going to be TRUE, and you're ignoring it anyway.

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Henri Verbeet
2009/8/10 Owen Rudge : > This is the first of a series of patches to implement the IImageList > interface into comctl32, introduced in comctl32 v6. > > This first patch splits the routines for loading v6 of comctl32 > (requiring a side-by-side manifest) out of the listview tests and into a > genera

Re: Wine and XShm support

2009-08-11 Thread Roderick Colenbrander
On Mon, Aug 10, 2009 at 11:17 PM, Yuriy Kaminskiy wrote: > On 10.08.2009 12:24, Henri Verbeet wrote: >>> at least add a registry key for it and disable it perhaps on 'modern >>> drivers'). What do you guys think? >> Could you do some benchmarking? You can disable XShm support by >> passing "--witho