Re: [lostwages] Set about page to use h3 instead of h2 as text is too large

2009-08-06 Thread Yuri Khan
On Thu, Aug 6, 2009 at 19:50, Scott Ritchie wrote: > -Open Source and User Driven > +Open Source and User Driven Font size is not a valid excuse for skipping heading levels. Presentation issues should be handled in CSS.

Re: profile.c (kernel32): API broken

2009-08-06 Thread Claudio Fontana
On Thu, Aug 6, 2009 at 9:38 AM, Paul Vriens wrote: > Claudio Fontana wrote: >> >> Just a reminder to everyone involved with profile.c: >> >> I have watched the git log of the somewhat recent changes to >> kernel32/profile.c. >> >> The profile API does not work that way. >> >> The current situation

Building inkscape for Windows using mingw under wine

2009-08-06 Thread Dan Kegel
http://bugs.winehq.org/show_bug.cgi?id=19615 shows that wine is very nearly in good enough shape to run the fetch-all-the-libs-and-sources script with cygwin, and run the inkscape win32 build system, and pop out a working inkscape.exe. We're just one little leak away from full success, I think. I

Re: DxDiag Demo Patch

2009-08-06 Thread Henri Verbeet
2009/8/7 Austin English : >>> +void D3DTest_initD3D(); >> This needs to be "void D3DTest_initD3D(void);" in C. The same goes for >> a couple of other functions. > > I received mixed feedback on #winehackers about this. So currently > left as is...is there a CFLAG/gcc switch to detect this, without

Re: [3/3] user32/tests: Add tests for SendInput with unicode

2009-08-06 Thread Dmitry Timoshkov
"Andrew Eikum" wrote: --- dlls/user32/tests/input.c | 210 + 1 files changed, 210 insertions(+), 0 deletions(-) It would be more natural and would simplify the code to add these tests to msg.c. Also, please try to avoid names like g_keyStatus,

Re: kernel32/nls/winerr: Add Russian translation [try 2]

2009-08-06 Thread Dmitry Timoshkov
"Vladimir Pankratov" wrote: Thanks for suggestions. Added Russian translation. Changed files: dlls/kernel32/nls/winerr_rus.mc Please stop. This is not a translation. I'd suggest to stop accepting your other "translations" and patches as well. -- Dmitry.

Request for vista testing

2009-08-06 Thread Mike Kaplinskiy
Can someone test this on vista? It tests NtCancelIoFileEx. The goal is to find out the order of arguments. Thanks, Mike. diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 164c2da..174daa5 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -54,6 +54,7 @@ static

Re: DxDiag Demo Patch

2009-08-06 Thread Austin English
On Fri, Mar 27, 2009 at 6:33 AM, Henri Verbeet wrote: > 2009/3/25 Allen Hair : >> Attached is a patch that will add our code to the source tree. This >> patch is not meant to be >> committed, but should provide a demonstration of the application so >> far. Any feedback would be >> appreciated, I wi

Re: [1/2] shdocvw: Added support for IAdviseSink (resend)

2009-08-06 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: Hi, Could I get some feedback on this patch please? +HRESULT hr = E_INVALIDARG; + +TRACE("(%p)->(%p, %p)\n", This, pAdvSink, pdwConnection); + +if(!pdwConnection || !pAdvSink) +return hr; + +if(!This->holder) +{ +h

Re: [1/2] shdocvw: Added support for IAdviseSink (resend)

2009-08-06 Thread Alistair Leslie-Hughes
Hi, Could I get some feedback on this patch please? Best Regards Alistair Leslie-Hughes Alistair Leslie-Hughes wrote: Hi, Changelog: shdocvw: Added support for IAdviseSink Best Regards Alistair Leslie-Hughes >From 9925900c771af32a1dfb2567d8354e888949c352 Mon Sep 17 00:00:00 200

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Stefan Dösinger
Am Thursday 06 August 2009 14:08:20 schrieb Henri Verbeet: > 2009/8/6 Stefan Dösinger : > > That's why I still think we should use behavior flags as a last resort, > > and use other problem specific ways where possible and reasonable. (an > > example for what's not reasonable: Clone the entire priv

Re: kernel32/nls/winerror: Add Russian translation

2009-08-06 Thread Frédéric Delanoy
2009/8/6 Frédéric Delanoy : > 2009/8/6 Vladimir Pankratov : >> Hello all. >> >> Added Russian translation. >> >> Changed files: >> >> dlls/kernel32/nls/winerror_rus.mc >> dlls/kernel32/Makefile.in >> >> Thanks. > > Message id 1221 is missing. > File changed/created is winerr_rus.mc, not winerror_ru

Re: kernel32/nls/winerror: Add Russian translation

2009-08-06 Thread Frédéric Delanoy
2009/8/6 Vladimir Pankratov : > Hello all. > > Added Russian translation. > > Changed files: > > dlls/kernel32/nls/winerror_rus.mc > dlls/kernel32/Makefile.in > > Thanks. Message id 1221 is missing. File changed/created is winerr_rus.mc, not winerror_rus.mc BTW

Re: kernel32: Revise SetThreadIdealProcessor to return success.

2009-08-06 Thread Alexandre Julliard
Andrew Nguyen writes: > The image deblurring tool in bug 19548 tries to use > SetThreadIdealProcessor on multi-core systems and checks the result of > the call, which causes the application to fail. Simply reporting > success in this case allows the application to run, and is perfectly > harmless

Re: kernel32/nls/winerror: Add Russian translation

2009-08-06 Thread Dmitry Timoshkov
"Vladimir Pankratov" wrote: Added Russian translation. Changed files: dlls/kernel32/nls/winerror_rus.mc dlls/kernel32/Makefile.in What's the point in resending the same version of the patch again and again without even answering the questions, or addressing the pointed out problems? Again,

Re: configure can't find libgsm development files, but they are installed

2009-08-06 Thread Nikolay Sivov
Rosanne DiMesio wrote: On Wed, 05 Aug 2009 19:52:15 +0400 Nikolay Sivov wrote: Rosanne DiMesio wrote: Since yesterday, configure has been giving me a "libgsm development files not found" warning even though they are installed on my system. This is on openSUSE 11.1, 32 bit. Is anyon

Re: configure can't find libgsm development files, but they are installed

2009-08-06 Thread Rosanne DiMesio
On Wed, 05 Aug 2009 19:52:15 +0400 Nikolay Sivov wrote: > Rosanne DiMesio wrote: > > Since yesterday, configure has been giving me a "libgsm development files > > not found" warning even though they are installed on my system. This is on > > openSUSE 11.1, 32 bit. > > > > Is anyone else seeing

Re: comctl32: Changed the assembly and manifest file names to mixed-case as in Windows

2009-08-06 Thread Alexandre Julliard
Paul Chitescu writes: > Changelog: > comctl32: Changed the assembly and manifest file names to mixed-case as > in > Windows > > The MSDN says that several tools handle assembly names as case sensitive. > > Furthermore, trying to open the manifest file with wrong case can fail or > take

Re: Begin Wine Development

2009-08-06 Thread Scott Ritchie
Alexandros Dermenakis wrote: > Hi to everyone, > > I'm a software developer interested in contributing to wine. Can you > guide a bit with the process? > How do you become a member and get a account to submit code to the git > repository? > How do you get tickets with your tasks? > > Thanks > H

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Henri Verbeet
2009/8/6 Stefan Dösinger : > That's why I still think we should use behavior flags as a last resort, and > use other problem specific ways where possible and reasonable. (an example > for what's not reasonable: Clone the entire private data code in ddraw to > avoid the AddRef - I clearly prefer a b

Re: [3/3] advapi32: Add tests for LsaLookupNames2.

2009-08-06 Thread Alexandre Julliard
Hans Leidekker writes: > diff --git a/dlls/advapi32/tests/lsa.c b/dlls/advapi32/tests/lsa.c > index e69e4e1..991b06b 100644 > --- a/dlls/advapi32/tests/lsa.c > +++ b/dlls/advapi32/tests/lsa.c It doesn't work here: ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.e

Re: wine.inf: Add the HKCU\Volatile Environment\APPDATA value.

2009-08-06 Thread Alexandre Julliard
Andrew Nguyen writes: > The VirtuaGirl installer explicitly queries for the APPDATA value > under HKCU\Volatile Environment. This most likely needs to be a volatile key created at startup. -- Alexandre Julliard julli...@winehq.org

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Stefan Dösinger
Am Thursday 06 August 2009 12:26:20 schrieb Henri Verbeet: > > Not really, we have a number of cases in ddraw already where the default > > value is overwritten(e.g. depth test at device creation), and there are > > many other differences beyond defaults. > > I'm not sure we should take ddraw as an

Re: Latency as of yesterday

2009-08-06 Thread Susan Cragin
Current Ubuntu sound bugs relating to wine OSS 409395. ALSA 407970 -I got this response on the Ubuntu list-- This is probably due to a libasound2-plugins and pulseaudio/rtkit skew; the latest libasound2-plugins needs at least pulseaudio 1:0.9.16~test3 and rtkit 0.3. Karmic has an older v

Re: mshtml: Implement IHTMLStyle4 get/put textOverflow

2009-08-06 Thread Alistair Leslie-Hughes
Forget this patch, missed the todo_wine "Alistair Leslie-Hughes" wrote in message news:4a7aa9a2.9060...@hotmail.com... Hi, Changelog: mshtml: Implement IHTMLStyle4 get/put textOverflow Best Regards Alistair Leslie-Hughes ---

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Henri Verbeet
2009/8/6 Stefan Dösinger : > Am Thursday 06 August 2009 11:54:58 schrieb Henri Verbeet: >> Another advantage of the flags is that you have a reasonably >> centralised overview of differences between the different wined3d >> client libraries. > Not really, we have a number of cases in ddraw already

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Stefan Dösinger
Am Thursday 06 August 2009 11:54:58 schrieb Henri Verbeet: > If done properly, miracles have nothing to do with it... The problem > with patch 4 is that you really want the initial value to change, but > instead you change it afterwards, and hope you caught all the cases. > Fortunately the tests s

Re: [7/8] WineD3D: Catch invalid getDC calls in d3d9

2009-08-06 Thread Henri Verbeet
2009/8/6 Stefan Dösinger : > Am Thursday 06 August 2009 09:35:23 schrieb Henri Verbeet: >> I don't feel very strong about this, but perhaps this should be >> handled by the format info table (in combination with the create >> flag). > I don > Which format info table? This is d3d9, not wined3d - it

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Henri Verbeet
2009/8/6 Stefan Dösinger : > Am Thursday 06 August 2009 09:35:12 schrieb Henri Verbeet: >> Aside from the fact that you can't know WineDirect3DCreate() failed >> because of a lack of OpenGL without looking at its implementation, I >> liked the create flags approach better. > Well, the WINED3DOK_NO3

Re: gdi32: Fix the type of a few return values.

2009-08-06 Thread Michael Stefaniuc
Hello Andrew, Andrew Nguyen wrote: > It does not make sense to return a boolean for a pointer type. > diff --git a/dlls/gdi32/opengl.c b/dlls/gdi32/opengl.c > index 022fc2c..204fc2b 100644 > --- a/dlls/gdi32/opengl.c > +++ b/dlls/gdi32/opengl.c > @@ -168,7 +168,7 @@ static HDC WINAPI wglGetPbuffer

Re: profile.c (kernel32): API broken

2009-08-06 Thread Paul Vriens
Claudio Fontana wrote: On Thu, Aug 6, 2009 at 9:38 AM, Paul Vriens wrote: Claudio Fontana wrote: Just a reminder to everyone involved with profile.c: I have watched the git log of the somewhat recent changes to kernel32/profile.c. The profile API does not work that way. The current situation

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Stefan Dösinger
Am Thursday 06 August 2009 09:35:12 schrieb Henri Verbeet: > Aside from the fact that you can't know WineDirect3DCreate() failed > because of a lack of OpenGL without looking at its implementation, I > liked the create flags approach better. Well, the WINED3DOK_NO3D is intended to say "you got your

Re: [7/8] WineD3D: Catch invalid getDC calls in d3d9

2009-08-06 Thread Stefan Dösinger
Am Thursday 06 August 2009 09:35:23 schrieb Henri Verbeet: > I don't feel very strong about this, but perhaps this should be > handled by the format info table (in combination with the create > flag). I don Which format info table? This is d3d9, not wined3d - it only has a d3dformat_from_wined3dfo

Re: [Bug 19522] Team Fortress 2 (TF2) missing menu fonts

2009-08-06 Thread Alexandre Julliard
Vitaliy Margolen writes: >> --- Comment #3 from Alexandre Julliard 2009-08-04 >> 13:19:16 --- >> Please don't suggest that people use the --enable-maintainer-mode flag, >> that's >> not meant for normal users. >> > Then how can we be sure user have all requirements installed? --verbose > doe

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Henri Verbeet
Aside from the fact that you can't know WineDirect3DCreate() failed because of a lack of OpenGL without looking at its implementation, I liked the create flags approach better.

Re: profile.c (kernel32): API broken

2009-08-06 Thread Paul Vriens
Claudio Fontana wrote: Just a reminder to everyone involved with profile.c: I have watched the git log of the somewhat recent changes to kernel32/profile.c. The profile API does not work that way. The current situation is even worse than before, when the undocumented empty string section and e

Re: [4/8] WineD3D: Set the default psizemin in d3d8, avoid the version check

2009-08-06 Thread Henri Verbeet
I think the create flags would be more robust here.

Re: [7/8] WineD3D: Catch invalid getDC calls in d3d9

2009-08-06 Thread Henri Verbeet
I don't feel very strong about this, but perhaps this should be handled by the format info table (in combination with the create flag).

Re: [3/8] WineD3D: Get rid of a version check

2009-08-06 Thread Henri Verbeet
2009/8/5 Stefan Dösinger : > +void fixup_caps(WINED3DCAPS *pWineCaps) > +{ > +/* D3D8 doesn't support SM 2.0 or higher, so clamp to 1.x */ > +if(pWineCaps->PixelShaderVersion > D3DPS_VERSION(1,4)){ > +pWineCaps->PixelShaderVersion = D3DPS_VERSION(1,4); > +} > +if(pWineCaps->