Re: [2/2] comdlg32/tests: Fix a failing test on Win2k and above.

2009-08-03 Thread Nicolas Le Cam
2009/8/4 Paul Vriens : > Nicolas Le Cam wrote: >> >> Hi, >> >> Following Rein's commit 1f825a3631c78ac08383dd6062005526fc9c483d I've >> got a new failure on my Win2k box. >> >> I did a first patch to filter Win2k failure that happens on >> GetSaveFileNameW case only but, according to test.winehq.or

How should we handle Mac users visiting winehq.org?

2009-08-03 Thread Scott Ritchie
Something interesting I noticed today: our wiki page on Mac OSX is ranked 7th when doing a simple search for "Wine" (the main page and the download page of winehq are 1st and 2nd). This means that a _large_ number of people are linking directly to the wiki page from external sites. Presumably, th

Re: [2/2] comdlg32/tests: Fix a failing test on Win2k and above.

2009-08-03 Thread Paul Vriens
Nicolas Le Cam wrote: Hi, Following Rein's commit 1f825a3631c78ac08383dd6062005526fc9c483d I've got a new failure on my Win2k box. I did a first patch to filter Win2k failure that happens on GetSaveFileNameW case only but, according to test.winehq.org, Win9x boxes are failing on more cases so I

More winehq.org improvements and issues: About page now links to articles in the wiki

2009-08-03 Thread Scott Ritchie
I have begun some cleanup of the website, starting with the most popular pages. In particular, the about page: http://www.winehq.org/about/ The text is much easier to read for a newcomer to get a general overview of the project. On a wide browser window, however, it looks very horizontal -- this

Re: [2/2] comdlg32/tests: Fix a failing test on Win2k and above.

2009-08-03 Thread Rein Klazes
On Mon, 03 Aug 2009 21:02:30 +0200, you wrote: > > >Following Rein's commit 1f825a3631c78ac08383dd6062005526fc9c483d I've >got a new failure on my Win2k box. > >I did a first patch to filter Win2k failure that happens on >GetSaveFileNameW case only but, according to test.winehq.org, Win9x >boxes a

Re: programs/start: handle /B & /I options

2009-08-03 Thread Austin English
2009/8/3 Frédéric Delanoy : > Well, IMHO bug 10912 should stay open since /B option is not really > supported, but rather silently ignored. > > Frédéric > Please bottom post on wine mailing lists. Of course implementing these (and other) options would be good. But for the purposes of that bug rep

Re: ws2_32: Add debug support for IPv6 addresses

2009-08-03 Thread Alexandre Julliard
Juan Lang writes: > +case WS_AF_INET: > +return wine_dbg_sprintf("{ family %d, address %s, port %d }", > +((const struct sockaddr_in *)a)->sin_family, > +inet_ntoa(((const struct sockaddr_in > *)a)->sin_addr), > +

Re: ntdll: Prevent page faults from ATL thunk check to reach debuggers

2009-08-03 Thread Alexandre Julliard
Michael Karcher writes: > send_debug_event will not send the "first chance exception" message (or > any other) when Peb->BeingDebugged is zero. Of course you can't do that, BeingDebugged is global not per-thread. -- Alexandre Julliard julli...@winehq.org

Re: 2/4 winex11: make sure r8g8b8 is used when using get_xrender_color

2009-08-03 Thread Alexandre Julliard
Roderick Colenbrander writes: > The text color of a physdev is in 24-bit r8g8b8 independent of the > depth, so make sure the picture format passed to get_xrender_color is > also in this format. This prepares for dibsections with support in > depths other than the screen depth. This is wrong, the

Re: New Wine Gecko 1.0.0 RC

2009-08-03 Thread Alexandre Julliard
Jacek Caban writes: > It's time for the new Wine Gecko package release. I've prepared a new > package based on Mozilla code a bit newer than Firefox 3.5 and my > fixes (most of them are on their way to mainstream Mozilla > repository). This release fixes a few known bugs. It's not as big > change

Re: [1/3] WineD3D: Test SetRenderTarget-Stateblock recording interaction

2009-08-03 Thread Stefan Dösinger
Am Monday 03 August 2009 14:00:54 schrieb Henri Verbeet: > I actually meant integrating it with the existing stateblock tests, > i.e. test_state_management(), but I can also do that myself > afterwards. Please add a test for d3d8 as well though, both render > targets and stateblocks are slightly di

Re: [2/3] WineD3D: SetRenderTarget sets the scissor rect

2009-08-03 Thread Stefan Dösinger
Am Monday 03 August 2009 14:01:04 schrieb Henri Verbeet: > 2009/8/3 Stefan Dösinger : > >-ok(hr == D3D_OK, "IDirect3DDevice9_BeginStateBlock failed, hr = > > %08x\n", hr); +ok(hr == D3D_OK, "IDirect3DDevice9_EndStateBlock > > failed, hr = %08x\n", hr); > > This should have been part of the

Re: [2/3] WineD3D: SetRenderTarget sets the scissor rect

2009-08-03 Thread Henri Verbeet
2009/8/3 Stefan Dösinger : >-ok(hr == D3D_OK, "IDirect3DDevice9_BeginStateBlock failed, hr = %08x\n", >hr); >+ok(hr == D3D_OK, "IDirect3DDevice9_EndStateBlock failed, hr = %08x\n", >hr); This should have been part of the first patch.

Re: [1/3] WineD3D: Test SetRenderTarget-Stateblock recording interaction

2009-08-03 Thread Henri Verbeet
I actually meant integrating it with the existing stateblock tests, i.e. test_state_management(), but I can also do that myself afterwards. Please add a test for d3d8 as well though, both render targets and stateblocks are slightly different there.

Re: New Wine Gecko 1.0.0 RC

2009-08-03 Thread André Hentschel
Jacek Caban schrieb: Hi André, André Hentschel wrote: Works great as fire as i tested it. Great, thanks for testing. Nice to see HTML5 in wines iexplore, really great and crazy! So we can call next release of Wine HTML5-ready :) I'd file a bug report: "Wine treats HTML5 differently than I

Re: Cursor & Icon patches

2009-08-03 Thread Henri Verbeet
I only looked at the first couple of patches, but this probably needs more work. E.g. in the first patch you white space changes and changes to apparently unrelated code. It also helps to be a bit more descriptive about what you're testing, instead of something like "Add more tests for SetCursor &

Re: programs/start: handle /B & /I options

2009-08-03 Thread Frédéric Delanoy
Well, IMHO bug 10912 should stay open since /B option is not really supported, but rather silently ignored. Frédéric On Mon, Aug 3, 2009 at 2:34 AM, Austin English wrote: > Fixes bug 10912. > > -- > -Austin

Re: 2/4 winex11: make sure r8g8b8 is used when using get_xrender_color

2009-08-03 Thread Henri Verbeet
2009/8/3 Roderick Colenbrander : > XRender colors have 4 16-bit components and in that way are generic. > We use r8g8b8 all the time for colors (palette.c if I remember > correctly always scales the text color to r8g8b8). Without this patch > wrong colors are used in a japanese game someone mention

Re: 2/4 winex11: make sure r8g8b8 is used when using get_xrender_color

2009-08-03 Thread Roderick Colenbrander
XRender colors have 4 16-bit components and in that way are generic. We use r8g8b8 all the time for colors (palette.c if I remember correctly always scales the text color to r8g8b8). Without this patch wrong colors are used in a japanese game someone mentioned in the xrender thread. The app in ques