Re: A tiny GetSystemMetrics question

2009-07-03 Thread Rein Klazes
On Sat, 04 Jul 2009 00:10:02 +0400, you wrote: >Hi. > >Trying to fix some ListView bugs I've found that on native (XP SP2) >system this call: >--- >GetSystemMetrics(SM_CXICONSPACING) >--- >doesn't return the value specified in appearance -> advanced settings of >Display properties sheet. > >I've

Re: [PATCH 3/5] d3d9/tests: Add a small test for having multiple device active at the same time.

2009-07-03 Thread Henri Verbeet
2009/7/3 Paul Vriens : > Is D3DERR_NOTAVAILABLE an acceptable error? If so than the ok() message can > be easily extended (maybe with an extra skip() message?). > Probably, although you can also just remove the test if it causes a lot of failures. I added it because this situation exposed a bug in

[rfc] lstrcmpi: order still wrong (was "Re: Regression in lstrcmpiA (occurred in late June, NLS related)" from 2003 year)

2009-07-03 Thread Yuriy Kaminskiy
Hello! Previous thread on this topic: http://www.mail-archive.com/wine-devel@winehq.org/msg01080.html I've stumbled over problem with lstrcmpi sorting is still wrong. Some japanese game engine uses binary search on presorted array, and fails with a-la "object not found" errors. Judging by

Re: user32: Windows test request (cursors/icons)

2009-07-03 Thread Paul Vriens
Daniel Santos wrote: I don't have access to a working windows machine right now and would appreciate if somebody can run these tests against XP, vista and/or 9x. Thanks! Daniel Hi Daniel, Tested on XP Professional SP3: cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), expected 14

Re: [PATCH 3/5] d3d9/tests: Add a small test for having multiple device active at the same time.

2009-07-03 Thread Paul Vriens
Henri Verbeet wrote: This is essentially the situation that caused problems with reusing the initial GL context. --- dlls/d3d9/tests/device.c | 65 ++ 1 files changed, 65 insertions(+), 0 deletions(-) Hi Henri, +hr = IDirect3D9_CreateDevice(

A tiny GetSystemMetrics question

2009-07-03 Thread Nikolay Sivov
Hi. Trying to fix some ListView bugs I've found that on native (XP SP2) system this call: --- GetSystemMetrics(SM_CXICONSPACING) --- doesn't return the value specified in appearance -> advanced settings of Display properties sheet. I've got 75 value for both cx and cy while I have set it to 43

user32: Windows test request (cursors/icons)

2009-07-03 Thread Daniel Santos
I don't have access to a working windows machine right now and would appreciate if somebody can run these tests against XP, vista and/or 9x. Thanks! Daniel From 55d99a143c3787f4e387a0b6f6866ad467df9d9b Mon Sep 17 00:00:00 2001 From: Daniel Santos Date: Fri, 3 Jul 2009 13:44:15 -0500 Subj

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer

2009-07-03 Thread Vincent Povirk
I don't think it's a good idea to rely on gdiplus functions being called from only one thread. Most of gdiplus currently is not thread-safe (maybe it should be), but it will work as long as a single object is only used from a single thread at a time. Adding global state makes things more complex,

Re: kernel32: Compile .mc files to resources as independent files.

2009-07-03 Thread Alexandre Julliard
Paul Vriens writes: > kernel32 translations don't show up at the translation page > anymore. Do we need to teach wrc to deal with rc files being one level > lower (nls directory?) or what is needed to correct this? It should be fixed now, thanks for catching this. -- Alexandre Julliard julli..

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer

2009-07-03 Thread Andrew Eikum
Andrew Eikum wrote: Nikolay Sivov wrote: Vincent Povirk wrote: On Fri, Jul 3, 2009 at 10:00 AM, Andrew Eikum wrote: I agree that the behavior of the container IDs doesn't match native. However, do we really care to duplicate that behavior? I can't see any documentation in MSDN that says c

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer

2009-07-03 Thread Andrew Eikum
Nikolay Sivov wrote: Vincent Povirk wrote: On Fri, Jul 3, 2009 at 10:00 AM, Andrew Eikum wrote: I agree that the behavior of the container IDs doesn't match native. However, do we really care to duplicate that behavior? I can't see any documentation in MSDN that says container IDs must be

Re: kernel32: Compile .mc files to resources as independent files.

2009-07-03 Thread Paul Vriens
Hi, kernel32 translations don't show up at the translation page anymore. Do we need to teach wrc to deal with rc files being one level lower (nls directory?) or what is needed to correct this? (Before this patch the page basically showed if there was a translation or not and not whether the

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer

2009-07-03 Thread Nikolay Sivov
Vincent Povirk wrote: On Fri, Jul 3, 2009 at 10:00 AM, Andrew Eikum wrote: I agree that the behavior of the container IDs doesn't match native. However, do we really care to duplicate that behavior? I can't see any documentation in MSDN that says container IDs must be unique across either g

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer

2009-07-03 Thread Nikolay Sivov
Andrew Eikum wrote: Nikolay Sivov wrote: Andrew Eikum wrote: --- dlls/gdiplus/gdiplus_private.h |3 + dlls/gdiplus/graphics.c| 154 ++-- include/gdiplusflat.h |1 + 3 files changed, 152 insertions(+), 6 deletions(-) This looks

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer

2009-07-03 Thread Vincent Povirk
On Fri, Jul 3, 2009 at 10:00 AM, Andrew Eikum wrote: > I agree that the behavior of the container IDs doesn't match native. >  However, do we really care to duplicate that behavior?  I can't see any > documentation in MSDN that says container IDs must be unique across either > graphics objects or w

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer

2009-07-03 Thread Andrew Eikum
Nikolay Sivov wrote: Andrew Eikum wrote: --- dlls/gdiplus/gdiplus_private.h |3 + dlls/gdiplus/graphics.c| 154 ++-- include/gdiplusflat.h |1 + 3 files changed, 152 insertions(+), 6 deletions(-) This looks wrong for me cause I

Re: Patch feedback (GetProductInfo)

2009-07-03 Thread Alexander Nicolaysen Sørnes
Fredag 03 juli 2009 11:10:01 skrev Nikolay Sivov: > Alexander Nicolaysen Sørnes wrote: > > Hello, > > > > Could someone give me a hint as to what is wrong with the following > > patches? > > > > http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html > > http://www.winehq.org/pipermail/w

Re: comdlg32: Fix a problem with the returned value of a CDN_FILEOK notification.

2009-07-03 Thread Rein Klazes
On Fri, 03 Jul 2009 07:49:33 +0200, you wrote: >Hi Rein, > >This one introduced extra test failures on Vista. On 1 Vista box and >W2K8 the test times out (crashes?). > >Could you have a look. I have submitted a fix. Works for me on Vista, XP (real) and W2k, W2k8 (vmware). Rein.

Re: Patch feedback (GetProductInfo)

2009-07-03 Thread Nikolay Sivov
Alexander Nicolaysen Sørnes wrote: Hello, Could someone give me a hint as to what is wrong with the following patches? http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html http://www.winehq.org/pipermail/wine-patches/2009-June/074909.html They only adds some defines plus a stub,

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer

2009-07-03 Thread Nikolay Sivov
Andrew Eikum wrote: --- dlls/gdiplus/gdiplus_private.h |3 + dlls/gdiplus/graphics.c| 154 ++-- include/gdiplusflat.h |1 + 3 files changed, 152 insertions(+), 6 deletions(-) This looks wrong for me cause I don't think you could pa

Re: comdlg32: Fix a problem with the returned value of a CDN_FILEOK notification.

2009-07-03 Thread Rein Klazes
On Fri, 03 Jul 2009 07:49:33 +0200, you wrote: >Hi Rein, > >This one introduced extra test failures on Vista. On 1 Vista box and >W2K8 the test times out (crashes?). > >Could you have a look. No time outs here, but I see the failures. The PostMessage( ..., WM_COMMAND, IDOK, ...) seems not enoug