Re: comdlg32: Fix a problem with the returned value of a CDN_FILEOK notification.

2009-07-02 Thread Paul Vriens
Rein Klazes wrote: fixes bug #19079 The application of this bug report subclasses the window proc of the file dialog. It does not return the result in the DWLP_MSGRESULT dialog property but the return code of the window proc. Tests are provided to show correct behaviour in all cases, subclassed

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer

2009-07-02 Thread Vincent Povirk
>+static GpStatus init_container(GraphicsContainerItem** container, >+GDIPCONST GpGraphics* graphics){ >+GpStatus sts; >+ >+if(!container || !graphics) >+return InvalidParameter; Since this is an internal function and you know container and graphics will always be non-

Re: [1/2] gdiplus/tests: Test cases for GdipBeginContainer2

2009-07-02 Thread Vincent Povirk
+GdipGetClipBounds(graphics, &clip); +win_skip(/*fabs(defClip[0] - clip.X) < 0.0001 && +fabs(defClip[1] - clip.Y) < 0.0001 && +fabs(defClip[2] - clip.Width) < 0.0001 && +fabs(defClip[3] - clip.Height) < 0.0001,*/ +"Expected Clipping Recta

AcceptEx Proposal

2009-07-02 Thread Mike Kaplinskiy
I have been thinking about the correct way to implement AcceptEx, and I was looking for comments about the approach. Note I know all of these cases will require tests, I'm just listing them for problems someone might see. Wineserver changes: - add an async* to the socket structure to track this s

Patch feedback (GetProductInfo)

2009-07-02 Thread Alexander Nicolaysen Sørnes
Hello, Could someone give me a hint as to what is wrong with the following patches? http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html http://www.winehq.org/pipermail/wine-patches/2009-June/074909.html They only adds some defines plus a stub, so hopefully there isn't that much I

Re: Appdb flight simulation sub category

2009-07-02 Thread Alexander Nicolaysen Sørnes
Added Torsdag 02 juli 2009 17:35:12 skrev Alexander Nicolaysen Sørnes: > I guess we could have a sub-category for flight simulators and racing games > > > > > Alexander N. Sørnes > > Torsdag 02 juli 2009 16:26:45 skrev David Lee Lambert: > > To me, "Flight simulation" (like MS flight simulator, T

Re: regedit: Implement open last key at startup [try 2]

2009-07-02 Thread Michael Karcher
Am Donnerstag, den 02.07.2009, 09:02 +0200 schrieb Paul Vriens: > There is no need for the RegCloseKey as you are opening a predefined one. Are you sure? He opens "HKCU\Software\Microsoft\Windows\CurrentVersion \Applets\Regedit" Regards, Michael Karcher signature.asc Description: Dies ist ein

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte

2009-07-02 Thread Detlef Riekenberg
On Mo, 2009-06-29 at 16:49 +0900, Dmitry Timoshkov wrote: > "Christoph von Wittich" wrote: > > > + if (*pcbProvName > INT_MAX) > > + *pcbProvName = INT_MAX; > > In which way WideCharToMultiByte is broken? It always helps to provide > an explanation and if possible a test case. While working on

Re: user32: Add a test for BM_SETSTYLE, make it pass under Wine.

2009-07-02 Thread Paul Vriens
Dmitry Timoshkov wrote: --- dlls/user32/button.c| 14 ++- dlls/user32/tests/msg.c | 86 ++ 2 files changed, 83 insertions(+), 17 deletions(-) Hi Dmitry, These new tests introduce some failure on Win98/WinMe. Could you have a look? --

Wine64: Down to 68 test failures!

2009-07-02 Thread Austin English
For those of you that don't follow http://test.winehq.org/, AJ and others 64-bit work has brought down the failures to 68: http://test.winehq.org/data/fb0275dd3148a098967f5959adb57ebe41a4383e/index_Wine.html Down quite a bit from over 100 about 6 months ago. There's still a lot of work to do, of

Re: Appdb flight simulation sub category

2009-07-02 Thread Alexander Nicolaysen Sørnes
I guess we could have a sub-category for flight simulators and racing games Alexander N. Sørnes Torsdag 02 juli 2009 16:26:45 skrev David Lee Lambert: > To me, "Flight simulation" (like MS flight simulator, Top Gun, ...) seems > like a totally different category that Simulation Games (SimCity

Re: tools/widl: Split expr_int_const off from expr

2009-07-02 Thread Rob Shearman
2009/6/28 Gerald Pfeifer : > diff --git a/tools/widl/parser.y b/tools/widl/parser.y > index c2f1abc..01aa060 100644 > --- a/tools/widl/parser.y > +++ b/tools/widl/parser.y > @@ -622,56 +633,54 @@ m_expr:                                           { $$ > = make_expr(EXPR_VOID); } >        | expr >  

Re: Appdb flight simulation sub category

2009-07-02 Thread David Lee Lambert
To me, "Flight simulation" (like MS flight simulator, Top Gun, ...) seems like a totally different category that Simulation Games (SimCity, SimTower, Mall Tycoon, ...), so it should be a different category direcly under Games. -- DLL 2009/7/2 Ken Sharp > Simulation Games is already in there. Be

Re: regedit: Implement open last key at startup [try 3]

2009-07-02 Thread Paul Vriens
Paul Vriens wrote: Michael Karcher wrote: Am Donnerstag, den 02.07.2009, 17:42 +0500 schrieb Vladimir Pankratov: Implement open last key at startup. Why do you use wszKey in the get code path, but wszVal in the set code path? But before you change that, read on: +static void get_set_last_key

Re: regedit: Implement open last key at startup [try 3]

2009-07-02 Thread Paul Vriens
Michael Karcher wrote: Am Donnerstag, den 02.07.2009, 17:42 +0500 schrieb Vladimir Pankratov: Implement open last key at startup. Why do you use wszKey in the get code path, but wszVal in the set code path? But before you change that, read on: +static void get_set_last_key(HWND hwndTV, BOOL b

Re: regedit: Implement open last key at startup [try 3]

2009-07-02 Thread Michael Karcher
Am Donnerstag, den 02.07.2009, 17:42 +0500 schrieb Vladimir Pankratov: > Implement open last key at startup. Why do you use wszKey in the get code path, but wszVal in the set code path? But before you change that, read on: +static void get_set_last_key(HWND hwndTV, BOOL bget) This looks to me li

Re: Appdb flight simulation sub category

2009-07-02 Thread Ken Sharp
Simulation Games is already in there. Besides, I don't think the categories are actually all that useful. Keith Muir wrote: Hi, Any chance of a games> simulation> flight simulation sub category? Regards, Keith

Re: Minor fix for include/bits1_5.idl

2009-07-02 Thread Rob Shearman
2009/6/28 Gerald Pfeifer : > Strike that, I must have misread the documentation. > > Only thing I am wondering is do we really need the (unsigned long) here? Yes, as conformance/variance is restricted by NDR to 32-bit quantities. The IDL compiler should warn/error without the cast as it would be s

Re: AppDB test results in Spanish

2009-07-02 Thread Rosanne DiMesio
On Thu, 2 Jul 2009 21:35:59 +1000 Ben Klein wrote: > > Hmm, is this really worth while keeping on AppDB then? It doesn't seem > to say much. > > >From what I've seen, half the tests in the AppDB fit that description. -- Rosanne DiMesio

Re: AppDB test results in Spanish

2009-07-02 Thread Ben Klein
2009/7/2 Susan Cragin : Who feels like translating some test results? http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingId=38908 > >>I mean someone actually replace that entry with a translated version. >>I could do it via Google Translate, but I'd rather some

Re: AppDB test results in Spanish

2009-07-02 Thread Susan Cragin
>>> Who feels like translating some test results? >>> >>> http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingId=38908 >I mean someone actually replace that entry with a translated version. >I could do it via Google Translate, but I'd rather someone who *knows* >Spanish repla

Re: kernel32: Add a trailing '\n' to a MESSAGE trace

2009-07-02 Thread Frédéric Delanoy
2009/7/2 Alexandre Julliard : > Frédéric Delanoy writes: > >> Last time I submitted this (pretty trivial) patch, it got ignored. > > What makes you think this is necessary? Well, every other MESSAGE trace I found (even in this very file) contained a terminal '\n' (eg on line 1093), and it was fol

Re: AppDB test results in Spanish

2009-07-02 Thread Ricardo Filipe
2009/7/2 Ben Klein > 2009/7/2 Paul Vriens : > > Ben Klein wrote: > >> > >> Who feels like translating some test results? > >> > >> > http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingId=38908 > >> > >> > > > http://translate.google.com/translate?js=n&prev=_t&hl=en&ie=UTF-8

Re: kernel32: Add a trailing '\n' to a MESSAGE trace

2009-07-02 Thread Nicolas Le Cam
Le 2 juillet 2009 09:29, Frédéric Delanoy a écrit : > Last time I submitted this (pretty trivial) patch, it got ignored. > If it's in a bad format, please let me know! > > Frédéric Hi Frédéric, System messages already contain a new line, you don't need to add a second one. -- Nicolas Le Cam

Re: winex11.drv: Move clipboard handling to a separate thread

2009-07-02 Thread Yuri Khan
On Wed, Jul 1, 2009 at 21:07, Alexandre Julliard wrote: >> This patch achieves this by creating an auxiliary thread that will run >> in the same process that puts data on the clipboard and handle X >> selection messages. > That looks quite inefficient, especially since you create a new thread > e

Re: kernel32: Add a trailing '\n' to a MESSAGE trace

2009-07-02 Thread Alexandre Julliard
Frédéric Delanoy writes: > Last time I submitted this (pretty trivial) patch, it got ignored. What makes you think this is necessary? Did you test it? -- Alexandre Julliard julli...@winehq.org

Re: AppDB test results in Spanish

2009-07-02 Thread Ben Klein
2009/7/2 Paul Vriens : > Ben Klein wrote: >> >> Who feels like translating some test results? >> >> http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingId=38908 >> >> > http://translate.google.com/translate?js=n&prev=_t&hl=en&ie=UTF-8&u=http%3A%2F%2Fappdb.winehq.org%2FobjectMa

Re: AppDB test results in Spanish

2009-07-02 Thread Paul Vriens
Ben Klein wrote: Who feels like translating some test results? http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingId=38908 http://translate.google.com/translate?js=n&prev=_t&hl=en&ie=UTF-8&u=http%3A%2F%2Fappdb.winehq.org%2FobjectManager.php%3FsClass%3Dversion%26iId%3D871

AppDB test results in Spanish

2009-07-02 Thread Ben Klein
Who feels like translating some test results? http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingId=38908

Re: regedit: Implement open last key at startup [try 2]

2009-07-02 Thread Paul Vriens
Vladimir Pankratov wrote: Hello. Open last key at startup. Changed files: regedit/childwin.c Thanks. Hi Vladimir, Please use a constant instead of hardcoded 260 as suggested by Andre'. You also should be using the