Re: [PATCH 5/6] urlmon: Added user agent tests.

2009-06-30 Thread Paul Vriens
Jacek Caban wrote: --- dlls/urlmon/tests/misc.c | 84 - 1 files changed, 82 insertions(+), 2 deletions(-) Hi Jacek, The addition of these new tests led to a Coverity wa

Re: Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer

2009-06-30 Thread Vincent Povirk
Comments that become irrelevant when you do this right are helpfully enclosed in (parentheses). > First, where should the utility functions and variables go?  Right > now, they're just thrown in above the functions I'm working on.  It > seems messy to me to have, for example, low and high (which n

re: Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer

2009-06-30 Thread Dan Kegel
Andrew asked: > I would imagine that there's some standard way of doing stacks See http://source.winehq.org/source/include/wine/list.h > Finally, while the code's still rough and needs cleaning up, > correctness checking, using Windows types and const properly, etc., am > I doing anything glarin

Re: Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer

2009-06-30 Thread Mike Kaplinskiy
On Tue, Jun 30, 2009 at 11:48 PM, Andrew Eikum wrote: > Attached to this email is a rough implementation of the main GDI+ > containers functions.  It performs correctly in a few simple tests I > ran on it, but it's not quite ready to send off to wine-patches.  I'd > like to get some feedback here,

Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer

2009-06-30 Thread Andrew Eikum
Attached to this email is a rough implementation of the main GDI+ containers functions. It performs correctly in a few simple tests I ran on it, but it's not quite ready to send off to wine-patches. I'd like to get some feedback here, since I'm certain that I'm doing some things wrong. I'm wonde

Re: why is Kronenberg's Wine/Mac work blacklisted on winehq?

2009-06-30 Thread Brian Vincent
On Fri, Jun 26, 2009 at 2:42 PM, Mike Kronenberg < mike.kronenb...@kronenberg.org> wrote: > OS X > My main concern is to have usable builds. Ie, usable without the need of a > terminal. People on OS X don't care about how stuff works, it just has to > work. > > Vanilla build > I totally agree that

Re: [3/7] [wined3d] add NP2 fixup code to shader_arb_generate_pshader (resend)

2009-06-30 Thread Tobias Jakobi
Won't work since the GL_LIMITS macro is defined in this way: #define GL_LIMITS(ExtName)(GLINFO_LOCATION.max_##ExtName) I don't think changing the variable name is an option, since keeping consistency there should be priority: ps_arb_max_local_constants -> ??? (I don't think it's wise

Re: [4/7] [wined3d] add NP2 fixup code to shader_hw_sample (ARB) (resend)

2009-06-30 Thread Tobias Jakobi
It's very easy. Only ordinary sampling is supported, because I have no application which I can use to test the others variants (only support the features you can actually test).

Re: [2/7] [wined3d] add arb_ps_np2fixup_info structure (resend)

2009-06-30 Thread Tobias Jakobi
*hint* *hint* See the commit message!

Appdb flight simulation sub category

2009-06-30 Thread Keith Muir
Hi, Any chance of a games> simulation> flight simulation sub category? Regards, Keith

Re: server/fd.c: Prevent using uninitialized pointers

2009-06-30 Thread Henri Verbeet
2009/6/30 Daniel Santos : > Some pointers are getting used prior to initialization.  It would appear that > the current compilers are initializing them to zero or we've been lucky. > No, the C standard specifies that these are initialized to NULL, since they have static storage duration.

Re: server/fd.c: Prevent using uninitialized pointers

2009-06-30 Thread Matteo Bruni
I'm quite sure that C standards guarantee global variables are initialized to 0. 2009/6/30 Daniel Santos : > Some pointers are getting used prior to initialization.  It would appear that > the current compilers are initializing them to zero or we've been lucky. > > > > > >

Re: Fw: Re: Removing active maintainers

2009-06-30 Thread Austin English
On Tue, Jun 30, 2009 at 10:21 AM, James Mckenzie wrote: > Sent to Rosanne only, meant to send it to the list as a comment to this > thread. > > James McKenzie > > -Forwarded Message- >>From: James Mckenzie >>Sent: Jun 29, 2009 6:36 PM >>To: Rosanne DiMesio >>Subject: Re: Removing active

Fw: Re: Removing active maintainers

2009-06-30 Thread James Mckenzie
Sent to Rosanne only, meant to send it to the list as a comment to this thread. James McKenzie -Forwarded Message- >From: James Mckenzie >Sent: Jun 29, 2009 6:36 PM >To: Rosanne DiMesio >Subject: Re: Removing active maintainers > >Rosanne DiMesio Subject: Re: Removing active >maintain

Re: configure.ac: make sure we can run cmdlgtst and view from outside wine tree

2009-06-30 Thread Austin English
On Tue, Jun 30, 2009 at 6:17 AM, Michael Stefaniuc wrote: > Austin English wrote: >> On Mon, Jun 29, 2009 at 10:37 PM, Detlef Riekenberg wrote: >>> On Mo, 2009-06-29 at 12:50 -0500, Austin English wrote: With this patch, they are treated like other programs, e.g., winhlp32, and installed,

Re: [3/7] [wined3d] add NP2 fixup code to shader_arb_generate_pshader (resend)

2009-06-30 Thread Stefan Dösinger
Am Monday 29 June 2009 21:41:58 schrieb Tobias Jakobi: +const UINT max_lconsts = gl_info->ps_arb_max_local_constants; Please use the GL_LIMITS macro for consistency

Re: [2/7] [wined3d] add arb_ps_np2fixup_info structure (resend)

2009-06-30 Thread Henri Verbeet
2009/6/30 Stefan Dösinger : > Am Monday 29 June 2009 21:41:33 schrieb Tobias Jakobi: > > Is there a particular reason why you reordered many elements in struct > arb_ps_np2fixup_info? > > > I'd guess for alignment.

Re: [4/7] [wined3d] add NP2 fixup code to shader_hw_sample (ARB) (resend)

2009-06-30 Thread Stefan Dösinger
Am Monday 29 June 2009 21:42:20 schrieb Tobias Jakobi: > +if (flags) FIXME("Only ordinary sampling from NP2 textures is supported.\n"); Why does projected sampling not work? Is this a limit of Tex_rect or the NP2 fixup code? TXB certainly does not work because tex_rect doesn'

Re: [2/7] [wined3d] add arb_ps_np2fixup_info structure (resend)

2009-06-30 Thread Stefan Dösinger
Am Monday 29 June 2009 21:41:33 schrieb Tobias Jakobi: Is there a particular reason why you reordered many elements in struct arb_ps_np2fixup_info?

Re: configure.ac: make sure we can run cmdlgtst and view from outside wine tree

2009-06-30 Thread Michael Stefaniuc
Austin English wrote: > On Mon, Jun 29, 2009 at 10:37 PM, Detlef Riekenberg wrote: >> On Mo, 2009-06-29 at 12:50 -0500, Austin English wrote: >>> With this patch, they are treated like other programs, e.g., winhlp32, >>> and installed, so one can use: >>> $ wine view >>> and get the same effect. >>

Re: oleaut32: Build language resource files separately

2009-06-30 Thread Michael Stefaniuc
Alexandre Julliard wrote: > Michael Stefaniuc writes: > >> Well, Alexandre did the first patch for programs/clock >> http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a9342107ee76173a2b97 >> so it must be right ;). It increases the resilience as errors in one >> language rc fi

Re: oleaut32: Build language resource files separately

2009-06-30 Thread Michael Stefaniuc
Paul Vriens wrote: > Michael Stefaniuc wrote: >> Hello Nikolay, >> >> Nikolay Sivov wrote: >>> Michael Stefaniuc wrote: instead of including them from an other rc file. --- >>> What is the purpose of these changes? I'm not talking it's wring :), >>> just interested. >> Well, Alexa

Re: oleaut32: Build language resource files separately

2009-06-30 Thread Alexandre Julliard
Michael Stefaniuc writes: > Well, Alexandre did the first patch for programs/clock > http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a9342107ee76173a2b97 > so it must be right ;). It increases the resilience as errors in one > language rc file do not propagate to the other l

Re: [PATCH 4/4] gdi32: Add tests for the GetWinMetaFileBits MFCOMMENT record.

2009-06-30 Thread Huw Davies
On Tue, Jun 30, 2009 at 12:40:54PM +0200, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/gdi32/tests/metafile.c | 80 >> +++ >> 1 files changed, 80 insertions(+), 0 deletions(-) >> >> >> -

Re: oleaut32: Build language resource files separately

2009-06-30 Thread Paul Vriens
Michael Stefaniuc wrote: Hello Nikolay, Nikolay Sivov wrote: Michael Stefaniuc wrote: instead of including them from an other rc file. --- What is the purpose of these changes? I'm not talking it's wring :), just interested. Well, Alexandre did the first patch for programs/clock http://so

Re: oleaut32: Build language resource files separately

2009-06-30 Thread Nikolay Sivov
Michael Stefaniuc wrote: Hello Nikolay, Nikolay Sivov wrote: Michael Stefaniuc wrote: instead of including them from an other rc file. --- What is the purpose of these changes? I'm not talking it's wring :), just interested. Well, Alexandre did the first patch for prog

Re: [PATCH 4/4] gdi32: Add tests for the GetWinMetaFileBits MFCOMMENT record.

2009-06-30 Thread Paul Vriens
Huw Davies wrote: --- dlls/gdi32/tests/metafile.c | 80 +++ 1 files changed, 80 insertions(+), 0 deletions(-) Hi Huw, Could you use CreateEnhMetaFileA here: +SetRect(&rc,

Re: oleaut32: Build language resource files separately

2009-06-30 Thread Michael Stefaniuc
Hello Nikolay, Nikolay Sivov wrote: > Michael Stefaniuc wrote: >> instead of including them from an other rc file. >> --- >> > What is the purpose of these changes? I'm not talking it's wring :), > just interested. Well, Alexandre did the first patch for programs/clock http://source.winehq.org/

Re: why is Kronenberg's Wine/Mac work blacklisted on winehq?

2009-06-30 Thread Maik Schulz
On 29 Jun 2009, at 14:10, > wrote: If there were a plain vanilla wine built on OS X IMHO, Mac Users can expect from a binary distribution something Mac- like, e.g. some kind of GUI. Another OSS project I've worked on for over a decade used to embed NeXtStep specific GUI source code. Th

Removing active maintainers

2009-06-30 Thread Joerg-Cyril.Hoehle
Hi, so far I found that Remco made the best suggestions. >From a quality of service point of view, unmaintained apps provide a more pleasing experience to the test data submiter: data is generally accepted within a fraction of a day. Not so for maintained apps. Why? Simple: there's a (large?) po