Re: [5/6] WineD3D: Write the vshader footer in a separate function

2009-06-27 Thread Ivan Gyurdiev
> Re: [5/6] WineD3D: Write the vshader footer in a separate function I like this patch - would be great to have more of these: Lines that fit on the screen in my gnome-terminal: < 50 Average size of six large ARB shader functions, before this patch: 205 (generate pshad

Re: [4/6] WineD3D: Implement function calls with NV exts

2009-06-27 Thread Henri Verbeet
2009/6/27 Stefan Dösinger : > Am Saturday 27 June 2009 22:19:27 schrieb Henri Verbeet: >> 2009/6/27 Stefan Dösinger : >> > -                || ins.handler_idx == WINED3DSIH_PHASE >> > -                || ins.handler_idx == WINED3DSIH_RET) >> > +                || ins.handler_idx == WINED3DSIH_PHASE

Re: [4/6] WineD3D: Implement function calls with NV exts

2009-06-27 Thread Stefan Dösinger
Am Saturday 27 June 2009 22:19:27 schrieb Henri Verbeet: > 2009/6/27 Stefan Dösinger : > > -|| ins.handler_idx == WINED3DSIH_PHASE > > -|| ins.handler_idx == WINED3DSIH_RET) > > +|| ins.handler_idx == WINED3DSIH_PHASE) > > Did you test this change wit

Re: [4/6] WineD3D: Implement function calls with NV exts

2009-06-27 Thread Henri Verbeet
2009/6/27 Stefan Dösinger : > -|| ins.handler_idx == WINED3DSIH_PHASE > -|| ins.handler_idx == WINED3DSIH_RET) > +|| ins.handler_idx == WINED3DSIH_PHASE) Did you test this change with GLSL?

Re: Removing active maintainers

2009-06-27 Thread Remco
On Sat, Jun 27, 2009 at 2:12 PM, Susan Cragin wrote: >>A basic level of courtesy shouldn't be too hard. >>Dogfights where two maintainers are asking to have each other thrown >>out are a good sign that both of said developers need to chill. > > We need more women. > Susan "Recruit Women"... sounds

Re: Fixing EOL in logging messages

2009-06-27 Thread Ricardo Filipe
2009/6/27 Frédéric Delanoy > Hi, > > I'm intending to fix some non-\n-terminated strings for different logging > classes (MESSAGE, TRACE, ...) > > For each class, should I send (1) a patch for *each* affected module or (2) > just a "generic" one ? > > Solution (1) seems a bit like overkill for me

re: Removing active maintainers

2009-06-27 Thread Susan Cragin
>A basic level of courtesy shouldn't be too hard. >Dogfights where two maintainers are asking to have each other thrown >out are a good sign that both of said developers need to chill. We need more women. Susan

Fixing EOL in logging messages

2009-06-27 Thread Frédéric Delanoy
Hi, I'm intending to fix some non-\n-terminated strings for different logging classes (MESSAGE, TRACE, ...) For each class, should I send (1) a patch for *each* affected module or (2) just a "generic" one ? Solution (1) seems a bit like overkill for me... Frédéric

Re: Removing active maintainers

2009-06-27 Thread Ben Klein
2009/6/27 Gert van den Berg : > On Sat, Jun 27, 2009 at 02:32, Dan Kegel wrote: >> (What's missing is the ability to add howto's and notes at the >> application level, i.e. one level higher than the version level where >> they all go right now, but that's not usually a dealbreaker.) > > The usefuln

Re: Removing active maintainers

2009-06-27 Thread Gert van den Berg
On Sat, Jun 27, 2009 at 02:32, Dan Kegel wrote: > (What's missing is the ability to add howto's and notes at the > application level, i.e. one level higher than the version level where > they all go right now, but that's not usually a dealbreaker.) The usefulness of app-level howo's depend a lot o