Re: Alexandre Julliard : configure: Don't accept mingw32 as target name, we need an explicit CPU specification.

2009-06-19 Thread Steven Edwards
On Fri, Jun 19, 2009 at 4:21 PM, Chris Robinson wrote: >> This is not a configure option, it's the name of the installed mingw32 >> binaries. They are supposed to follow the GNU naming convention for >> cross-compilers, and they do on all sane distros AFAIK. > > Gentoo names them with the mingw32-

Re: Use GCC's -Wlogical-op if possible

2009-06-19 Thread Gerald Pfeifer
On Fri, 19 Jun 2009, Rein Klazes wrote: >> cert.c:1627: warning: logical ?||? with non-zero constant will always >> evaluate as true > That (in dlls/crypt32/tests) looks like a real bug to me. Indeed. And Alexandre committed a fix of mine in the last 24 hours. ;-) Gerald

Re: Use GCC's -Wlogical-op if possible

2009-06-19 Thread Gerald Pfeifer
On Fri, 19 Jun 2009, Paul Vriens wrote: > I have about 70 warnings with 4.3.2. > > I already sent two patches and found a few more bugs. If you want I can > start sending in patches for those as well (don't want to duplicate work > of course). Thanks for checking to help avoid duplicate work, P

Re: Alexandre Julliard : configure: Don't accept mingw32 as target name, we need an explicit CPU specification.

2009-06-19 Thread Chris Robinson
On Friday 19 June 2009 10:21:33 am Alexandre Julliard wrote: > Steven Edwards writes: > > I don't think this change is right. It is a very common convention to > > use mingw32 as a generic convention for 32bit x86. It seems the best > > practice would be if mingw32 is passed then to assume a sensi

Re: Alexandre Julliard : configure: Don't accept mingw32 as target name, we need an explicit CPU specification.

2009-06-19 Thread King InuYasha
On Fri, Jun 19, 2009 at 12:43 PM, Steven Edwards wrote: > On Fri, Jun 19, 2009 at 1:21 PM, Alexandre Julliard > wrote: > > This is not a configure option, it's the name of the installed mingw32 > > binaries. They are supposed to follow the GNU naming convention for > > cross-compilers, and they do

Re: Alexandre Julliard : configure: Don't accept mingw32 as target name, we need an explicit CPU specification.

2009-06-19 Thread Steven Edwards
On Fri, Jun 19, 2009 at 1:21 PM, Alexandre Julliard wrote: > This is not a configure option, it's the name of the installed mingw32 > binaries. They are supposed to follow the GNU naming convention for > cross-compilers, and they do on all sane distros AFAIK. Right I get that. I just mean that its

Re: winex11: Get rid of glext.h in remaining locations [try 2]

2009-06-19 Thread James Mckenzie
Austin English wrote about Re: winex11: Get rid of glext.h in remaining locations [try 2] > >On Fri, Jun 19, 2009 at 9:02 AM, Detlef Riekenberg wrote: >> Already removed from dlls/opengl/* by Roderick. >> winex11 on linux works without GL/glext.h (OSX untested) >> >> Now with configure.ac > >Work

Re: Alexandre Julliard : configure: Don't accept mingw32 as target name, we need an explicit CPU specification.

2009-06-19 Thread Alexandre Julliard
Steven Edwards writes: > I don't think this change is right. It is a very common convention to > use mingw32 as a generic convention for 32bit x86. It seems the best > practice would be if mingw32 is passed then to assume a sensible > lowest common default. This is not a configure option, it's t

Re: Alexandre Julliard : configure: Don't accept mingw32 as target name, we need an explicit CPU specification.

2009-06-19 Thread Steven Edwards
On Fri, Jun 19, 2009 at 9:27 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: ccbf959969e32c9d71d2b4c46dbfe4db1ad2ab3f > URL:     > http://source.winehq.org/git/wine.git/?a=commit;h=ccbf959969e32c9d71d2b4c46dbfe4db1ad2ab3f > > Author: Alexandre Julliard > Date:   Thu Jun 18

Re: winex11: Get rid of glext.h in remaining locations [try 2]

2009-06-19 Thread Austin English
On Fri, Jun 19, 2009 at 9:02 AM, Detlef Riekenberg wrote: > Already removed from dlls/opengl/* by Roderick. > winex11 on linux works without GL/glext.h (OSX untested) > > Now with configure.ac Works fine on OS X. Sorry I forgot to do this myself. -- -Austin

Re: advpack: Implement ExtractFilesW [try 2]

2009-06-19 Thread Detlef Riekenberg
On Do, 2009-06-11 at 15:04 -0700, James Hawkins wrote: > 2009/6/11 Vladimir Pankratov : > > Hello all. > > > > Implemented ExtractFilesW > > > > Changed files: > > advpack/files.c > You're converting A -> W -> A. > This happens because cabinet.Extract is (as far as we know) ansi-only. > In this

Re: W-related helper functions for our tests

2009-06-19 Thread lats
On 19/06/09 20:44, Paul Vriens wrote: Another one used quite often in the tests is something like wine_dbgstr_w. This one seems to be very useful.

Re: W-related helper functions for our tests

2009-06-19 Thread Paul Vriens
lats wrote: On 19/06/09 20:44, Paul Vriens wrote: Another one used quite often in the tests is something like wine_dbgstr_w. This one seems to be very useful. I think that this one can also be fixed by teaching Wine to deal with '%S'. -- Cheers, Paul.

Re: Looking for a fast way to clean up AppDB comments

2009-06-19 Thread Rosanne DiMesio
On Fri, 19 Jun 2009 20:01:15 +1000 Ben Klein wrote: > > What I'd like to see is an option to delete an entire thread of > comments (ideally from an arbitrary point in the thread) in one hit. > Usually, the comments that follow a post are meaningless without that > post. > That was was fixed ba

Re: Looking for a fast way to clean up AppDB comments

2009-06-19 Thread Ben Klein
2009/6/19 Ken Sharp : > > > Ben Klein wrote: > >> What I'd like to see is an option to delete an entire thread of >> comments (ideally from an arbitrary point in the thread) in one hit. >> Usually, the comments that follow a post are meaningless without that >> post. > > This is the default action

Re: Looking for a fast way to clean up AppDB comments

2009-06-19 Thread Ken Sharp
Ben Klein wrote: What I'd like to see is an option to delete an entire thread of comments (ideally from an arbitrary point in the thread) in one hit. Usually, the comments that follow a post are meaningless without that post. This is the default action (changed in the last few months). O

W-related helper functions for our tests

2009-06-19 Thread Paul Vriens
Hi, I was wondering if it would make sense to introduce several helper functions that could be used by all our tests. The main ones needed are the ones to cope with Win9x missing several W-functions. Another one used quite often in the tests is something like wine_dbgstr_w. Yet another one

Re: Looking for a fast way to clean up AppDB comments

2009-06-19 Thread Ben Klein
2009/6/19 Florian Köberle : > Hi, > > I now became one of the application maintainers of Warcraft 3 The Frozen > Throne and got asked to cleanup the comments. I started to do so, but > there are just to much comments. I stopped deleting with 459 comments > remaining. > See: (http://appdb.winehq.org

Looking for a fast way to clean up AppDB comments

2009-06-19 Thread Florian Köberle
Hi, I now became one of the application maintainers of Warcraft 3 The Frozen Throne and got asked to cleanup the comments. I started to do so, but there are just to much comments. I stopped deleting with 459 comments remaining. See: (http://appdb.winehq.org/objectManager.php?sClass=version&iId=312

Re: NT4 passing

2009-06-19 Thread Paul Vriens
Austin English wrote: On Wed, Jun 17, 2009 at 1:40 PM, Paul Vriens wrote: Nicolas Le Cam wrote: 2009/6/17 Austin English : 2009/6/17 Paul Vriens : André Hentschel wrote: WinNT4 is passing now for the first time since a long time(maybe since ever?). So special congratulations to Paul Vriens,

Re: Use GCC's -Wlogical-op if possible

2009-06-19 Thread Paul Vriens
Gerald Pfeifer wrote: On Thu, 18 Jun 2009, Austin English wrote: Causes 106 more warnings on 4.3.3 of this sort: tab.c:693: warning: logical ?&&? with non-zero constant will always evaluate as true cert.c:1627: warning: logical ?||? with non-zero constant will always evaluate as true This is s

Re: Use GCC's -Wlogical-op if possible

2009-06-19 Thread Gerald Pfeifer
On Fri, 19 Jun 2009, Ben Klein wrote: >>> diff --git a/configure.ac b/configure.ac >>> index bef311e..3f7a657 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -1385,8 +1385,9 @@ then >>>   WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) >>>   WINE_TRY_CFLAGS([-fno-

Re: Use GCC's -Wlogical-op if possible

2009-06-19 Thread Gerald Pfeifer
On Thu, 18 Jun 2009, Austin English wrote: > Causes 106 more warnings on 4.3.3 of this sort: > tab.c:693: warning: logical ?&&? with non-zero constant will always > evaluate as true > cert.c:1627: warning: logical ?||? with non-zero constant will always > evaluate as true This is strange. In that