Re: Use GCC's -Wlogical-op if possible

2009-06-18 Thread Rein Klazes
On Thu, 18 Jun 2009 16:01:20 -0500, you wrote: >cert.c:1627: warning: logical ‘||’ with non-zero constant will always >evaluate as true That (in dlls/crypt32/tests) looks like a real bug to me. Rein.

Re: Use GCC's -Wlogical-op if possible

2009-06-18 Thread Ben Klein
2009/6/19 Austin English : > On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeifer wrote: >> I verified this does not cause any extra warnings with GCC 4.4, whereas >> GCC 4.5 will become quite a bit more useful in that regard and thus help >> spot any issues. >> >> As with -Wtype-limits that I suggeste

Re: Use GCC's -Wlogical-op if possible

2009-06-18 Thread Austin English
On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeifer wrote: > I verified this does not cause any extra warnings with GCC 4.4, whereas > GCC 4.5 will become quite a bit more useful in that regard and thus help > spot any issues. > > As with -Wtype-limits that I suggested last year, I pledge to keep clos

Re: Wine MIME handling

2009-06-18 Thread Roderick Colenbrander
Just for the record winebrowser already seems to support what is needed without any changes, so need for winemime. The following does the trick for pdf: REGEDIT4 [HKEY_CLASSES_ROOT\.pdf] @="pdffile" "Content Type"="application/pdf" [HKEY_CLASSES_ROOT\pdffile] [HKEY_CLASSES_ROOT\pdffile\s

Re: Is there any way to debug driver?

2009-06-18 Thread Ken Thomases
On Jun 17, 2009, at 10:49 AM, Wang, Robin wrote: We also have tried using winedbg, but it cannot break into our driver either. The only way we can break into our driver before is using "gdb wine- pthread", but now it is not available. Do you have some suggestion on winedbg configuration to

Re: user32/tests: Added tests for DrawIcon and DrawIconEx (try 6)

2009-06-18 Thread Alexandre Julliard
Joel Holdsworth writes: > Taking this into account would yield: > > ok ((result & 0x00F8F8F8) == (modern_expected & 0x00F8F8F8) || /* > Windows 2000 and up */ > broken((result & 0x00F8F8F8) == (legacy_expected & 0x00F8F8F8)) || /* > Windows NT 4.0, 9X and below */ > broken(Get

Re: user32/tests: Added tests for DrawIcon and DrawIconEx (try 6)

2009-06-18 Thread Joel Holdsworth
> I don't think you need such a complex test, we don't really care about > the exact reason why it's broken. Agreed. Fielding all the different deviations is getting quite convoluted. The modern/legacy stuff will need to remain because in some of these tests windows has made step changes - e.g. a

Re: Sugestion to Wine

2009-06-18 Thread Paul Chitescu
On Thursday 18 June 2009 04:35:27 Sérgio R. da Silva wrote: > Hello to all developers of wine. > My name is Sergio R. da Silva, and I sent some suggestions to improve the > wine. > First of all I apologize for any errors in spelling, because I am Brazilian > and I do not know very well and I write

Re: user32/tests: Added tests for DrawIcon and DrawIconEx (try 6)

2009-06-18 Thread Alexandre Julliard
Joel Holdsworth writes: > The most obvious solution would be something like this as a color test: > > const int screen_bpp = GetDeviceCaps(hdc, BITSPIXEL); > > ok (result == modern_expected || /* Windows 2000 and up */ > broken(result == legacy_expected) || /* Windows NT 4.0, 9X and

Sugestion to Wine

2009-06-18 Thread Sérgio R . da Silva
Hello to all developers of wine. My name is Sergio R. da Silva, and I sent some suggestions to improve the wine. First of all I apologize for any errors in spelling, because I am Brazilian and I do not know very well and I write in English using Google Translator to send these suggestions and also