Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 8:33 PM, Ben Klein wrote: > 2009/6/15 Mike Kaplinskiy : >> On Sun, Jun 14, 2009 at 5:33 PM, Stefan Dösinger >> wrote: >>> *) If  we create a stub / thunk driver for each known windows display >>> driver, >>> we potentially have  all those thunks around. E.g. an app might c

Re: Request for comments on patch

2009-06-14 Thread Ben Klein
2009/6/15 Mike Kaplinskiy : > On Sun, Jun 14, 2009 at 5:33 PM, Stefan Dösinger > wrote: >> *) If  we create a stub / thunk driver for each known windows display driver, >> we potentially have  all those thunks around. E.g. an app might complain that >> it finds BOTH nv4_disp.dll AND atiumdag.dll.

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 5:33 PM, Stefan Dösinger wrote: > *) If we create a stub / thunk driver for each known windows display driver, > we potentially have all those thunks around. E.g. an app might complain that > it finds BOTH nv4_disp.dll AND atiumdag.dll. > > *) Providing these vendor specif

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
Does the attached sound more like what people are looking for (with driver_filename_table filled in a bit more, of course)? Erich Hoover ehoo...@mines.edu From f731547eed5aef1cfcddc58a4da1e714ddd47d1f Mon Sep 17 00:00:00 2001 From: Erich Hoover Date: Sun, 14 Jun 2009 17:04:59 -0600 Subject: Repor

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 3:33 PM, Stefan Dösinger wrote: > Am Sonntag, 14. Juni 2009 23:11:42 schrieb Erich Hoover: > >> So, a patch similar to the one Mike pointed out* but able to report >> different drivers for different OSes would prove acceptable (possibly >> w/ a second patch for overrides)?  

Re: Request for comments on patch

2009-06-14 Thread Roderick Colenbrander
On Sun, Jun 14, 2009 at 11:44 PM, Erich Hoover wrote: > On Sun, Jun 14, 2009 at 3:33 PM, Mike > Kaplinskiy wrote: >> ... >> >> I didn't mean symlinking to the /lib/wine directory, but rather, >> symlinking to prefix/windows/system32/ from /lib/wine/ . But since >> that isn't done either, just copyi

Unused code in dmime.dll

2009-06-14 Thread Francois Gouget
So DMUSIC_CreateDirectMusicobjImpl() is unused. What's troubling about that is that, if my analysis is correct, it means that none of the code in dlls/dmime/tool.c is used. It seems like all that's missing is something that would let applications actually get at the IDirectMusicTool8 implement

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 3:33 PM, Mike Kaplinskiy wrote: > ... > > I didn't mean symlinking to the /lib/wine directory, but rather, > symlinking to prefix/windows/system32/ from /lib/wine/ . But since > that isn't done either, just copying to a new filename also seems > reasonable. Sadly if we do ha

Re: Request for comments on patch

2009-06-14 Thread Stefan Dösinger
Am Sonntag, 14. Juni 2009 23:11:42 schrieb Erich Hoover: > So, a patch similar to the one Mike pointed out* but able to report > different drivers for different OSes would prove acceptable (possibly > w/ a second patch for overrides)? The email was some time ago, but I > thought someone was prett

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 5:20 PM, Erich Hoover wrote: > On Sun, Jun 14, 2009 at 3:13 PM, Mike > Kaplinskiy wrote: >> ... >> >> Then perhaps when this mechanism is in place, we can add a way to have >> 1 general "funnel" dll and symlink it on prefix creation (if it's not >> already there). This way w

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 3:13 PM, Mike Kaplinskiy wrote: > ... > > Then perhaps when this mechanism is in place, we can add a way to have > 1 general "funnel" dll and symlink it on prefix creation (if it's not > already there). This way we don't have to worry about newer graphics > cards as much, an

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 4:55 PM, Roderick Colenbrander wrote: > On Sun, Jun 14, 2009 at 10:52 PM, Roderick > Colenbrander wrote: >> On Sun, Jun 14, 2009 at 10:45 PM, Erich Hoover wrote: >>> On Sun, Jun 14, 2009 at 2:26 PM, Mike >>> Kaplinskiy wrote: I don't know about stubbing drivers, but I r

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 2:55 PM, Roderick Colenbrander wrote: > ... > > I forgot to mention the reason why previous registry key options > didn't enter Wine. The reason was that we had to have a good default > mechanism (e.g. returning nv4_disp.dll for nvidia by default on 2k/xp) > before adding ov

Re: Request for comments on patch

2009-06-14 Thread Roderick Colenbrander
On Sun, Jun 14, 2009 at 10:52 PM, Roderick Colenbrander wrote: > On Sun, Jun 14, 2009 at 10:45 PM, Erich Hoover wrote: >> On Sun, Jun 14, 2009 at 2:26 PM, Mike >> Kaplinskiy wrote: >>> I don't know about stubbing drivers, but I remember that >>> autodetection/registry wasn't accepted on the fallout

Re: Request for comments on patch

2009-06-14 Thread Roderick Colenbrander
On Sun, Jun 14, 2009 at 10:45 PM, Erich Hoover wrote: > On Sun, Jun 14, 2009 at 2:26 PM, Mike > Kaplinskiy wrote: >> I don't know about stubbing drivers, but I remember that >> autodetection/registry wasn't accepted on the fallout 3 patch. I think >> AJ would prefer something like >> http://source.

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 2:26 PM, Mike Kaplinskiy wrote: > I don't know about stubbing drivers, but I remember that > autodetection/registry wasn't accepted on the fallout 3 patch. I think > AJ would prefer something like > http://source.winehq.org/git/wine.git/?a=commit;h=f2e2e3e49947490368900ef06a

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
I don't know about stubbing drivers, but I remember that autodetection/registry wasn't accepted on the fallout 3 patch. I think AJ would prefer something like http://source.winehq.org/git/wine.git/?a=commit;h=f2e2e3e49947490368900ef06a92e1df1bc52820 but for driver dll strings. But take my comments

Request for comments on patch

2009-06-14 Thread Erich Hoover
In an effort to come up with a (hopefully palatable) solution to a couple of bugs I've put together the attached patch.  Only the first of the two issues is currently handled, though the patch paves the way for the second issue. 1) Bug #15839: (not this title) Wine does not report the manufacturer

Re: Command for creating git patches - possible discrepancy in Wine doc pages

2009-06-14 Thread Austin English
2009/6/14 Frédéric Delanoy : > Hi, > > I'm about to generate my first wine patches and saw 2 pages in the Wine wiki > giving two different commands : > - on http://wiki.winehq.org/GitWine , section 3.6. Generating a patchset to > submit, it says >   git format-patch --stdout --keep-subject origin

Re: dotests script

2009-06-14 Thread Austin English
2009/6/14 André Hentschel : > chris ahrendt schrieb: >> >> Does anyone have the dotests script they could send me ... I moved to a >> new machine and lost the script. >> Went to the wiki and it fails to find it when I click on the link. I get >> an error stating that I am unable to add >> an attach

Re: [5/5] WineD3D: Use flags instead of bools to control shader_hw_sample

2009-06-14 Thread Stefan Dösinger
Am Sonntag, 14. Juni 2009 18:34:13 schrieb Tobias Jakobi: > Why not use an enum instead of the defines? Because as far as I can see the other places that deal with flags use defines to define them, not an enum type. Specifically, I looked at the WINED3D_GLSL_SAMPLE_* flags, which have the equiva

Re: [PATCH] wined3d: mirror d3dresourcetype

2009-06-14 Thread Stefan Dösinger
Am Sonntag, 14. Juni 2009 17:40:39 schrieb Henri Verbeet: > 2009/6/14 Stefan Dösinger : > >> Here: > >> /home/marcus/projects/wine/dlls/d3d9/device.c: In > >> Funktion »reset_enum_callback«: > > > > Does the attached patch fix the issue? > > I have a patch touching that code, could you wait with se

Command for creating git patches - possible discrepancy in Wine doc pages

2009-06-14 Thread Frédéric Delanoy
Hi, I'm about to generate my first wine patches and saw 2 pages in the Wine wiki giving two different commands : - on http://wiki.winehq.org/GitWine , section 3.6. Generating a patchset to submit, it says git format-patch --stdout --keep-subject origin - on http://www.winehq.org/site/sending_

Re: [PATCH] wined3d: mirror d3dresourcetype

2009-06-14 Thread Henri Verbeet
2009/6/14 Stefan Dösinger : >> Here: >> /home/marcus/projects/wine/dlls/d3d9/device.c: In >> Funktion »reset_enum_callback«: > Does the attached patch fix the issue? > I have a patch touching that code, could you wait with sending it in a bit? (I could also rebase it and send it in.)

Re: [PATCH] wined3d: mirror d3dresourcetype

2009-06-14 Thread Marcus Meissner
On Sun, Jun 14, 2009 at 05:29:39PM +0200, Stefan Dösinger wrote: > > Here: > > /home/marcus/projects/wine/dlls/d3d9/device.c: In > > Funktion »reset_enum_callback«: > Does the attached patch fix the issue? Yes it does. Ciao, Marcus

Re: [PATCH] wined3d: mirror d3dresourcetype

2009-06-14 Thread Stefan Dösinger
> Here: > /home/marcus/projects/wine/dlls/d3d9/device.c: In > Funktion »reset_enum_callback«: Does the attached patch fix the issue? diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index 9d02539..578d783 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -424,7 +424,8 @@ static BOOL

Re: [PATCH] wined3d: mirror d3dresourcetype

2009-06-14 Thread Marcus Meissner
On Sun, Jun 14, 2009 at 04:30:30PM +0200, Stefan Dösinger wrote: > Am Sonntag, 14. Juni 2009 14:26:53 schrieb Marcus Meissner: > > Hi, > > > > gcc 4.5trunk warned that we do not handle case 7 (D3DRTYPE_INDEXBUFFER), > > so add it here too. > There's a reason why this doesn't exist - WineD3D has ind

Re: [PATCH] wined3d: mirror d3dresourcetype

2009-06-14 Thread Stefan Dösinger
Am Sonntag, 14. Juni 2009 14:26:53 schrieb Marcus Meissner: > Hi, > > gcc 4.5trunk warned that we do not handle case 7 (D3DRTYPE_INDEXBUFFER), > so add it here too. There's a reason why this doesn't exist - WineD3D has index and vertex buffers merged, so there is no such thing as a specialized ind

Re: winetest data generation

2009-06-14 Thread Ricardo Filipe
2009/6/14 André Hentschel > I need to have a look into the sourcecode of the scripts behind " > test.winehq.org". > Where can i find it? > http://source.winehq.org/git/tools.git/?a=tree

winetest data generation

2009-06-14 Thread André Hentschel
I need to have a look into the sourcecode of the scripts behind "test.winehq.org". Where can i find it?

Re: dotests script

2009-06-14 Thread André Hentschel
chris ahrendt schrieb: Does anyone have the dotests script they could send me ... I moved to a new machine and lost the script. Went to the wiki and it fails to find it when I click on the link. I get an error stating that I am unable to add an attachment (even after logging in). Chris I got