Re: gdiplus: add support for string alignment to GdipDrawString

2009-06-01 Thread Paul Vriens
Stephan Rose wrote: Adds support for aligning a string inside the given bounding rectangle for GdipDrawString. Both vertical and horizontal alignments implemented. Hi Stephan, No remarks about the real contents of the

Re: Implications for Wine from the Ubuntu Developer Summit

2009-06-01 Thread Daniel Devine
On Tuesday 02 June 2009 11:26:36 Scott Ritchie wrote: > Hello everyone, > > I've just returned from the Ubuntu Developer Summit in Barcelona last > week. A lot of interesting stuff that concerns Wine happened there, and > a lot of applies to every distro. I'll give a brief summary in this email.

Re: gdiplus: GdipDrawString

2009-06-01 Thread Austin English
On Mon, Jun 1, 2009 at 11:23 PM, Stephan Rose wrote: > On Mon, 2009-06-01 at 13:03 -0400, Stephan Rose wrote: >> >I don't know why gdiplus does its own linebreaks. I haven't really >> >done any work in that area. >> > >> >If I had to guess, I'd say it's because StringFormatFlagsNoWrap has no >> >e

Re: gdiplus: GdipDrawString

2009-06-01 Thread Stephan Rose
On Mon, 2009-06-01 at 13:03 -0400, Stephan Rose wrote: > >I don't know why gdiplus does its own linebreaks. I haven't really > >done any work in that area. > > > >If I had to guess, I'd say it's because StringFormatFlagsNoWrap has no > >equivalent flag for DrawText. That probably means you can't pa

Re: Implications for Wine from the Ubuntu Developer Summit

2009-06-01 Thread Scott Ritchie
Ben Klein wrote: > 2009/6/2 Scott Ritchie : >> First, I talked with a Pulseaudio expert about what we can do to make >> things work better. He said that if we want good compatibility we will >> need our ALSA stack to use the Pulseaudio safe subset: >> http://0pointer.de/blog/projects/guide-to-soun

[Fwd: Re: DIB engine]

2009-06-01 Thread James McKenzie
To the list as well. Original Message Subject:Re: DIB engine Date: Mon, 01 Jun 2009 19:09:15 -0700 From: James McKenzie To: Andrew Eikum References: <1243755935.4535.1.ca...@stephan-desktop> <4a22ad55.5020...@brightnightgames.com> <4a22d65a.3030...@brightnight

Re: Implications for Wine from the Ubuntu Developer Summit

2009-06-01 Thread Ben Klein
2009/6/2 Scott Ritchie : > First, I talked with a Pulseaudio expert about what we can do to make > things work better.  He said that if we want good compatibility we will > need our ALSA stack to use the Pulseaudio safe subset: > http://0pointer.de/blog/projects/guide-to-sound-apis.html. I've filed

Implications for Wine from the Ubuntu Developer Summit

2009-06-01 Thread Scott Ritchie
Hello everyone, I've just returned from the Ubuntu Developer Summit in Barcelona last week. A lot of interesting stuff that concerns Wine happened there, and a lot of applies to every distro. I'll give a brief summary in this email. Audio: First, I talked with a Pulseaudio expert about what we

Re: gdiplus: Stub for GdipCloneBitmapArea

2009-06-01 Thread Vincent Povirk
Don't bother adding "stub" to existing FIXME's. If it's a FIXME with arguments, we know it's a stub. Vincent Povirk On Mon, Jun 1, 2009 at 8:01 PM, Andrew Eikum wrote: > Stubbing GDI+: > Add stub function for GdipCloneBitmapArea.  Also add missing > prototype for GdipCloneBitmapAreaI, and add s

Re: gdi32: Stub for GdiEntry13()

2009-06-01 Thread Vincent Povirk
> I think you should add @ stdcall DdQueryDisplaySettingsUniqueness() line > to gdi32.spec file, otherwise you will get message like this: > err:module:find_forwarded_export function not found for forward > 'gdi32.DdQueryDisplaySettingsUniqueness' used by L"C:\\windows\\system32 > \\gdi32.dll". If

Re: gdi32: Stub for GdiEntry13()

2009-06-01 Thread Kovács András
Hi, I think you should add @ stdcall DdQueryDisplaySettingsUniqueness() line to gdi32.spec file, otherwise you will get message like this: err:module:find_forwarded_export function not found for forward 'gdi32.DdQueryDisplaySettingsUniqueness' used by L"C:\\windows\\system32 \\gdi32.dll". If you a

Re: [PATCH 5/5] wininet: Test gzip encoded read.

2009-06-01 Thread Jacek Caban
Hi Paul, Paul Vriens wrote: Jacek Caban wrote: --- dlls/wininet/tests/http.c | 107 ++-- 1 files changed, 82 insertions(+), 25 deletions(-) Hi Jacek, This patch introduces

Re: [PATCH 5/5] wininet: Test gzip encoded read.

2009-06-01 Thread Paul Vriens
Jacek Caban wrote: --- dlls/wininet/tests/http.c | 107 ++-- 1 files changed, 82 insertions(+), 25 deletions(-) Hi Jacek, This patch introduces test failures on all platform

Re: Patchwatcher not reporting failures?

2009-06-01 Thread André Hentschel
Zachary Goldberg schrieb: On Mon, Jun 1, 2009 at 5:34 AM, Austin English wrote: Testing patchwatcher with a patch that simply removes two todo_wine's should've caused some failures. Indeed, looking at the log: cred.c:315: Test failed: expected CredentialBlobSize of 0 but got 20 cred.c:315: Test

Re: Patchwatcher not reporting failures?

2009-06-01 Thread Zachary Goldberg
On Mon, Jun 1, 2009 at 5:34 AM, Austin English wrote: > Testing patchwatcher with a patch that simply removes two todo_wine's > should've caused some failures. Indeed, looking at the log: > cred.c:315: Test failed: expected CredentialBlobSize of 0 but got 20 > cred.c:315: Test failed: expected NUL

Re: gdiplus: GdipDrawString

2009-06-01 Thread Stephan Rose
>I don't know why gdiplus does its own linebreaks. I haven't really >done any work in that area. > >If I had to guess, I'd say it's because StringFormatFlagsNoWrap has no >equivalent flag for DrawText. That probably means you can't pass it >off to DrawText. > >Since they'll probably have to be done

Re: gdiplus: GdipDrawString

2009-06-01 Thread Vincent Povirk
I don't know why gdiplus does its own linebreaks. I haven't really done any work in that area. If I had to guess, I'd say it's because StringFormatFlagsNoWrap has no equivalent flag for DrawText. That probably means you can't pass it off to DrawText. Since they'll probably have to be done differe

Re: Fw: Need a temporary list moderator

2009-06-01 Thread John Klehm
On Mon, Jun 1, 2009 at 9:42 AM, Stefan Leichter wrote: > Am Monday 01 June 2009 16:13:43 schrieb Luke Bratch: >> --- On Thu, 28/5/09, Luke Bratch wrote: >> > In a couple of weeks I'm going to be travelling around >> > India for about a month, from 14th June - 17th July, so I'll >> > need somebody

gdiplus: GdipDrawString

2009-06-01 Thread Stephan Rose
Ok was playing a bit with DrawString on sunday trying to get string alignments to work. I've got horizontal alignments working by simply setting drawcoord.right which currently is left uninitialized and then passing DT_CENTER and DT_RIGHT as needed to DrawTextW. So far, that worked. However, I

Re: Regular users right on bugzilla

2009-06-01 Thread Austin English
On Mon, Jun 1, 2009 at 3:22 AM, Jerome Leclanche wrote: > Since there's been some discussion about bugzilla recently... > > Is there any reason regular users aren't allowed to change keywords, > component and dependencies on bugs they don't own on Bugzilla? > Maybe marking as duplicate as well. I

Re: Fw: Need a temporary list moderator

2009-06-01 Thread Austin English
On Mon, Jun 1, 2009 at 9:13 AM, Luke Bratch wrote: > > --- On Thu, 28/5/09, Luke Bratch wrote: >> In a couple of weeks I'm going to be travelling around >> India for about a month, from 14th June - 17th July, so I'll >> need somebody to cover list moderation during that period. >> >> It's a simpl

Re: Fw: Need a temporary list moderator

2009-06-01 Thread Stefan Leichter
Am Monday 01 June 2009 16:13:43 schrieb Luke Bratch: > --- On Thu, 28/5/09, Luke Bratch wrote: > > In a couple of weeks I'm going to be travelling around > > India for about a month, from 14th June - 17th July, so I'll > > need somebody to cover list moderation during that period. > > > > It's a s

Fw: Need a temporary list moderator

2009-06-01 Thread Luke Bratch
--- On Thu, 28/5/09, Luke Bratch wrote: > In a couple of weeks I'm going to be travelling around > India for about a month, from 14th June - 17th July, so I'll > need somebody to cover list moderation during that period. > > It's a simple task; you just need to bring up a web page > for each lis

Re: Regular users right on bugzilla

2009-06-01 Thread Rosanne DiMesio
On Mon, 01 Jun 2009 12:03:21 +0100 Ken Sharp wrote: > > > Most developers already have that access, and if they don't, they can > just ask for it. > > I think the reason all users can't do it, is because most users don't > know what they're doing. It's bad enough correcting all the mistakes

Re: Regular users right on bugzilla

2009-06-01 Thread Ken Sharp
Top posting is the devil. Jerome Leclanche wrote: Fair enough for duplicates. Still, component and keywords can't do any harm, can they? I often see a bug with attached patch, or a regression, not properly marked as such, and want to fix it but I'm unable to; and it's usually not worth the extra

Re: [2/3] kernel32: fix QueryFullProcessImageNameW for output buffer being null

2009-06-01 Thread Alexandre Julliard
Stefan Leichter writes: > @@ -3155,6 +3155,12 @@ > NTSTATUS status; > DWORD needed; > > +if(!lpExeName) > +{ > +SetLastError(ERROR_INVALID_PARAMETER); > +return FALSE; > +} > + This is not correct: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../.

Re: Regular users right on bugzilla

2009-06-01 Thread Jerome Leclanche
Fair enough for duplicates. Still, component and keywords can't do any harm, can they? I often see a bug with attached patch, or a regression, not properly marked as such, and want to fix it but I'm unable to; and it's usually not worth the extra spam and bothering someone else. On Mon, Jun 1, 200

Re: Regular users right on bugzilla

2009-06-01 Thread Ben Klein
2009/6/1 Ken Sharp : > > > André Hentschel wrote: >> >> Jerome Leclanche schrieb: >>> >>> Since there's been some discussion about bugzilla recently... >>> >>> Is there any reason regular users aren't allowed to change keywords, >>> component and dependencies on bugs they don't own on Bugzilla? >>>

Re: Regular users right on bugzilla

2009-06-01 Thread Ken Sharp
André Hentschel wrote: Jerome Leclanche schrieb: Since there's been some discussion about bugzilla recently... Is there any reason regular users aren't allowed to change keywords, component and dependencies on bugs they don't own on Bugzilla? Maybe marking as duplicate as well. I don't think

Re: Regular users right on bugzilla

2009-06-01 Thread André Hentschel
Jerome Leclanche schrieb: Since there's been some discussion about bugzilla recently... Is there any reason regular users aren't allowed to change keywords, component and dependencies on bugs they don't own on Bugzilla? Maybe marking as duplicate as well. I don't think it'd do any harm to allow

Patchwatcher not reporting failures?

2009-06-01 Thread Austin English
Testing patchwatcher with a patch that simply removes two todo_wine's should've caused some failures. Indeed, looking at the log: cred.c:315: Test failed: expected CredentialBlobSize of 0 but got 20 cred.c:315: Test failed: expected NULL credentials but got 0x11d4ec cred.c:328: Test failed: expecte

Re: Its Alive! Patchwatcher is reborn.

2009-06-01 Thread Francois Gouget
On Sun, 31 May 2009, Lei Zhang wrote: [...] > Speaking of pre-commit checking, the Wine wiki page for patchwatcher > page [1] currently list the following todo items: > > Check for C++ comments. Currently we don't have a good way of detecting these. winapi_check attempts to detect them but it ge

Regular users right on bugzilla

2009-06-01 Thread Jerome Leclanche
Since there's been some discussion about bugzilla recently... Is there any reason regular users aren't allowed to change keywords, component and dependencies on bugs they don't own on Bugzilla? Maybe marking as duplicate as well. I don't think it'd do any harm to allow those rights to every regist