Re: patch wined3d

2009-05-28 Thread James McKenzie
Pavel Prochazka wrote: >static HRESULT WINAPI IWineGDISwapChainImpl_Present(IWineD3DSwapChain *iface, >CONST RECT *pSourceRect, CONST RECT *pDestRect, HWND hDestWindowOverride, >CONST >RGNDATA *pDirtyRegion, DWORD dwFlags) { > IWineD3DSwapChainImpl *This = (IWineD3DSwapChainImpl *) iface; >-

Re: [PATCH] _Present

2009-05-28 Thread Stefan Dösinger
Am Donnerstag, 28. Mai 2009 13:01:23 schrieb Pavel Prochazka: Don't send patches on top of unapplied patches - just always send the a patch against the current wine git code. Besides that, Henri and I pointed out a few other problems in the first version of the patch. Things won't get better if

Re: DIB Engine : passing all tests

2009-05-28 Thread Mike Kaplinskiy
On Thu, May 28, 2009 at 6:58 PM, Jerome Leclanche wrote: > Hi Max, > > From what I understand, the problem is not your design. I don't want > to put words in anyone's mouth, but to me it seems you and AJ agree on > the final goal; Alexandre just doesn't want the "intermediary step" in > the master

Re: DIB Engine : passing all tests

2009-05-28 Thread Jerome Leclanche
Hi Max, >From what I understand, the problem is not your design. I don't want to put words in anyone's mouth, but to me it seems you and AJ agree on the final goal; Alexandre just doesn't want the "intermediary step" in the master tree (there could be many reasons for this). As you said, starting

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-28 Thread Nikolay Sivov
Sergey Khodych wrote: Nikolay Sivov пишет: If a band has an empty string, wine allocates a padding space in lpBand->rcCapText that causes an offset in a band. It looks like a workaround, if get/set text behaves ok now (no tests exist I suppose) then the only place to be changed is this rectan

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-28 Thread Sergey Khodych
Nikolay Sivov пишет: If a band has an empty string, wine allocates a padding space in lpBand->rcCapText that causes an offset in a band. It looks like a workaround, if get/set text behaves ok now (no tests exist I suppose) then the only place to be changed is this rectangle dimensions. Why do

Re: Changing default severity in Bugzilla to Normal

2009-05-28 Thread John Klehm
>>On Thu, May 28, 2009 at 1:40 PM, Ken Sharp wrote: >>> "It seems the default severity, enhancement, invites people to select a >>> REALLY >>> SEVERE sounding level instead.  I suggest changing the default severity to >>> normal in the hopes of cutting down on the yelling." >>> http://bugs.winehq.

Re: DIB Engine : passing all tests

2009-05-28 Thread Steven Edwards
On Thu, May 28, 2009 at 2:20 PM, Massimo Del Fedele wrote: > IMHO, and really "in my opinion", loosing time to integrate it inside gdi32 > whithout proper guidelines would be crazy. I mean, I'd never do it :-) > The intermediate step was made (among other reasons) to check if the > upcoming driver

Need a temporary list moderator

2009-05-28 Thread Luke Bratch
Hi all In a couple of weeks I'm going to be travelling around India for about a month, from 14th June - 17th July, so I'll need somebody to cover list moderation during that period. It's a simple task; you just need to bring up a web page for each list a couple of times per day, and single ou

Re: [1/2] comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. (try 2)

2009-05-28 Thread Nikolay Sivov
Sergey Khodych wrote: From 37cd774e71f8d260d94bd672715b1eab879c4b2d Mon Sep 17 00:00:00 2001 From: Sergey Khodych Date: Thu, 28 May 2009 04:52:45 +0300 Subject: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. --- dlls/comctl32/rebar.c | 12 dlls/comctl32

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-28 Thread Nikolay Sivov
Sergey Khodych wrote: Nikolay Sivov пишет: It looks like you need to add a simple test like that: - add band with empty string and RBBIM_TEXT mask of course; - query band data back with RB_GETBANDINFO and check this lpText field. If it's really NULL (e.g. your buffer didn't change) instead of

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-28 Thread Sergey Khodych
Nikolay Sivov пишет: It looks like you need to add a simple test like that: - add band with empty string and RBBIM_TEXT mask of course; - query band data back with RB_GETBANDINFO and check this lpText field. If it's really NULL (e.g. your buffer didn't change) instead of empty string you shou

Re: Changing default severity in Bugzilla to Normal

2009-05-28 Thread James Mckenzie
Austin English wrote about Re: Changing default severity in Bugzilla to Normal > >On Thu, May 28, 2009 at 1:40 PM, Ken Sharp wrote: >> "It seems the default severity, enhancement, invites people to select a >> REALLY >> SEVERE sounding level instead.  I suggest changing the default severity to >>

Re: Changing default severity in Bugzilla to Normal

2009-05-28 Thread Austin English
On Thu, May 28, 2009 at 1:40 PM, Ken Sharp wrote: > "It seems the default severity, enhancement, invites people to select a > REALLY > SEVERE sounding level instead.  I suggest changing the default severity to > normal in the hopes of cutting down on the yelling." > http://bugs.winehq.org/show_bug

Changing default severity in Bugzilla to Normal

2009-05-28 Thread Ken Sharp
"It seems the default severity, enhancement, invites people to select a REALLY SEVERE sounding level instead. I suggest changing the default severity to normal in the hopes of cutting down on the yelling." http://bugs.winehq.org/show_bug.cgi?id=13363 Any thoughts on this?

Re: DIB Engine : passing all tests

2009-05-28 Thread Massimo Del Fedele
HI Ben, Ben Klein ha scritto: Of course, it also makes it more difficult to maintain, with any change in gdi32 needing to be mirrored in the forked DIB engine, but that's where git cherry-picking can come in handy :) Done for about 3 monthes, no more time for it :-) What I was trying to sa

Re: [PATCH] _Present

2009-05-28 Thread Francois Gouget
On Thu, 28 May 2009, Pavel Prochazka wrote: > > +IWineD3DSurfaceImpl *front,*hlp1,*hlp2; > + IWineD3DSurfaceImpl back; //must be copy of struct C++ comments are not allowed in Wine. There are a few others further down. -- Francois Gouget http://fgouget.free.fr/

How to fix some oleaut32:vartest tests?

2009-05-28 Thread Paul Vriens
Hi, It looks like I have two boxes (W98 and NT4) that produce test failures every now and then for the mentioned tests: vartest.c:5514: Test failed: VarCat: VT_BSTR concat with VT_DATE returned inncorrect result vartest.c:5530: Test failed: VarCat: VT_DATE concat with VT_BSTR returned inncorrect

Re: winehq.org page importance / website statistics

2009-05-28 Thread André Hentschel
Austin English schrieb: On Thu, May 28, 2009 at 11:19 AM, Maik Schulz wrote: Does that make it safe to assume that winehq.org should concentrate on users and wiki.winehq.org on (potential) developers? If that's the direction then it's more clear which content to translate. Sounds reasonable.

Re: winehq.org page importance / website statistics

2009-05-28 Thread Austin English
On Thu, May 28, 2009 at 11:19 AM, Maik Schulz wrote: > Does that make it safe to assume that winehq.org should concentrate on users > and wiki.winehq.org on (potential) developers? If that's the direction then > it's more clear which content to translate. Sounds reasonable. -- -Austin

Re: winehq.org page importance / website statistics

2009-05-28 Thread Maik Schulz
On 28 May 2009, at 17:10, Austin English wrote: On Thu, May 28, 2009 at 10:06 AM, Maik Schulz wrote: Hi Paul, it's a good pointer to start, thanks. For the other two points: Does anybody have an opinion on the importance of pages as well as which ones should be moved to the Wiki? Pleas

valgrind mac now on trunk!

2009-05-28 Thread Dan Kegel
http://blog.mozilla.com/nnethercote/2009/05/28/mac-os-x-now-supported-on-the-valgrind-trunk/ So for those of you developing wine on the mac, now you have one fewer excuse not to run your changes through valgrind before sending patches :-)

Re: winehq.org page importance / website statistics

2009-05-28 Thread Austin English
On Thu, May 28, 2009 at 10:06 AM, Maik Schulz wrote: > Hi Paul, > > it's a good pointer to start, thanks. > > For the other two points: Does anybody have an opinion on the importance of > pages as well as which ones should be moved to the Wiki? Please bottom post on wine mailing lists. As for yo

Re: winehq.org page importance / website statistics

2009-05-28 Thread Maik Schulz
Hi Paul, it's a good pointer to start, thanks. For the other two points: Does anybody have an opinion on the importance of pages as well as which ones should be moved to the Wiki? Cheers, -Maik On 28 May 2009, at 10:13, Paul Vriens wrote: Maik Schulz wrote: Hi, for translation (to German

Re: winebrowser: Fix unicode recognition

2009-05-28 Thread Dmitry Timoshkov
"Jeff Latimer" wrote: I put tests for the mixed conditions in test/dde.c quite a while ago: Then it should be obvious where the fix should be added, with removing todo_wine in appropriate places. -- Dmitry.

Re: winebrowser: Fix unicode recognition

2009-05-28 Thread Jeff Latimer
Dmitry Timoshkov wrote: "André Hentschel" wrote: Please add a test case which uses mixed ansi/unicode DDE client/server and only then start fixing the code. For winebrowser? Do we test any of our programs? Or for DDE? Quoting above: "mixed ansi/unicode DDE client/server". I put tests for

Problem with async. comm from Wine to a USB->Serial-converter

2009-05-28 Thread Henrik Jacobsson
Hi. I just got myself a USB-GPS (GlobalSat BU-353) and wanted to run SeaClearII, a navigation-program with it. Turns out that Wine got confused when the USB->Serial-driver wasn't acting like a real serial-device though. The app does what it's supposed to do, but Wine consumes 100% of the availabl

Re: Does wine handle virtual midi ports correct on OSX?

2009-05-28 Thread Emmanuel Maillard
I think Doom use the MIDI Synth not an external MIDI instrument. so no log about MOD_MIDIPORT but eventually MOD_MIDISYNTH (or something like that) Emmanuel Le 26 mai 09 à 02:08, James McKenzie a écrit : Emmanuel Maillard wrote: Does notes play well when playing ? Correct duration, correct

Re: Does wine handle virtual midi ports correct on OSX?

2009-05-28 Thread Emmanuel Maillard
Le 25 mai 09 à 20:54, Steve Schow a écrit : it seems like what happens is that i select an IAC or virtual midi port from some windows host inside Wine and everything looks ok, but no events are sent. Nothing. But sometimes it works and sometimes it doesn't. Once it is working it work

Re: winebrowser: Fix unicode recognition

2009-05-28 Thread Dmitry Timoshkov
"André Hentschel" wrote: Please add a test case which uses mixed ansi/unicode DDE client/server and only then start fixing the code. For winebrowser? Do we test any of our programs? Or for DDE? Quoting above: "mixed ansi/unicode DDE client/server". -- Dmitry.

Re: winebrowser: Fix unicode recognition

2009-05-28 Thread André Hentschel
Dmitry Timoshkov schrieb: "André Hentschel" wrote: This converts the DDE-Callbackfunction to Unicode. After days of winebrowser-hacking i turned it down to this clean code. It uses the function IsTextUnicode instead of guessing.(IsTextUnicode is guessing too, but in a cleaner way) Please ad

Re: winehq.org page importance / website statistics

2009-05-28 Thread Paul Vriens
Maik Schulz wrote: Hi, for translation (to German) purposes I wonder which pages of the winehq.org website are most frequented (are there HTTP request statistics?) and which are deemed most important so I can focus on them in order. It would also be interesting to know which pages are going

winehq.org page importance / website statistics

2009-05-28 Thread Maik Schulz
Hi, for translation (to German) purposes I wonder which pages of the winehq.org website are most frequented (are there HTTP request statistics?) and which are deemed most important so I can focus on them in order. It would also be interesting to know which pages are going to be moved to

Re: DIB Engine : passing all tests

2009-05-28 Thread Ben Klein
2009/5/27 Massimo Del Fedele : > 1) Huw's starting engine *was* a driver's one, and many people told it was > the right way. Worse, it forked driver from inside gdi32, which was awful > to maintain. I can understand AJ preferring a fork of gdi32 to the intermediary driver given what he's said on t

Re: DIB Engine : passing all tests

2009-05-28 Thread Reece Dunn
2009/5/28 John Klehm : > On Wed, May 27, 2009 at 8:47 PM, James McKenzie > wrote: >> So what say all, shall we try to make coding better and as Max stated, >> fun.  Most of the folks here do not support this project for a living >> and we should not restrict this project to those who do.  However,