Bugzilla upgrade - opening attachments in browser

2009-05-19 Thread Austin English
It seems the bugzilla upgrade stopped allowing opening attachments in browser. Not sure if that's by choice or just an unchanged setting, but having to open .txt/.jpeg/.png files in outside applications is a bit annoying...Any possibility of fixing that? -- -Austin

user32: improvements

2009-05-19 Thread Daniel Santos
In the process of working on this bug (http://bugs.winehq.org/show_bug.cgi?id=18371), I have discovered that user32's SetCursor function does not ensure that the the handle passed is valid or that it is even a handle to a cursor object (and it seems that the lingo for user32 objects is "resourc

Re: DIB Engine - Mostly fixed against test suite

2009-05-19 Thread Massimo Del Fedele
Well, it seems that the engine fixes some unrelated bugs too :-) Bugs 15146 and 10408, as reported by a tester. BTW In a couple of weeks all (few) remaining failing tests should be fixed. Then I'll try to optimize somehow the mixed blitting, which is the only stuff that remains slower than origin

Re: Detecting an invalid handle in setupapi

2009-05-19 Thread Daniel Santos
oops, I meant to reply-all on this. --- On Mon, 5/18/09, Daniel Santos wrote: From: Daniel Santos Subject: Re: Detecting an invalid handle in setupapi To: "Paul Vriens" Date: Monday, May 18, 2009, 5:43 PM I'm so very glad you brought this up Paul.  I'm new to wine development and I've been wo

Re: [PATCH 7/8] urlmon: Added MIME filter handling in BindProtocol tests.

2009-05-19 Thread Paul Vriens
Jacek Caban wrote: --- dlls/urlmon/tests/protocol.c | 723 +++--- 1 files changed, 608 insertions(+), 115 deletions(-) Hi Jacek, This introduces extra failures on what seems to

Re: winemaker: add include-directory parsing

2009-05-19 Thread Paul Vriens
André Hentschel wrote: --- tools/winemaker |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) Hi André, Not a comment on the patch itself but this is the third time you tried with the same patch. We

Re: Gecko installation broken?

2009-05-19 Thread Austin English
On Tue, May 19, 2009 at 4:52 AM, Stefan Dösinger wrote: > Am Montag, 18. Mai 2009 22:46:59 schrieb Lei Zhang: >> It didn't think so either, so I even double checked. Upon further >> investigation, it seems the problem is simply the gecko cab download >> is failing. Either one of the Sourceforge se

Re: [Article] WINE and the importance of application compatibility

2009-05-19 Thread Austin English
On Tue, May 19, 2009 at 2:47 AM, Kai Blin wrote: > That depends on being able to test a lot of applications, though. I'm working on it :-) -- -Austin

Re: ntdll/tests: Mark return value of RtlUnicodeStringToInteger("", 16) as broken for nt4.

2009-05-19 Thread Huw Davies
On Tue, May 19, 2009 at 03:39:07PM +0200, Alexandre Julliard wrote: > Paul Vriens writes: > > > I don't think this is correct. This test has always succeeded until > > March 9th. There haven't been any changes to the test in that period, > > but I remember an upgrade of winehq in that weekend. >

Re: ntdll/tests: Mark return value of RtlUnicodeStringToInteger("", 16) as broken for nt4.

2009-05-19 Thread Alexandre Julliard
Paul Vriens writes: > I don't think this is correct. This test has always succeeded until > March 9th. There haven't been any changes to the test in that period, > but I remember an upgrade of winehq in that weekend. > > In other words, there is more to it. Testing a simple cross compiled > versi

Re: gdiplus: implement GdipTransformPoints

2009-05-19 Thread Alexandre Julliard
Vincent Povirk writes: > It's odd, but it seems like the simplest way to write this. > > I've tried what I think was your suggestion, and that's attached. I > don't think it's an improvement. You should short-circuit the src_space == dst_space case, that would simplify things a lot. Then you can

Re: [PATCH] winhttp: avoid NULL ptr dereference (Coverity 927)

2009-05-19 Thread Paul Vriens
Marcus Meissner wrote: Hi, Not sure if we need to set these values in all error paths, but definitely not in the NULL lpwhr. (lpwhdr?) Ciao, Marcus --- dlls/wininet/http.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c inde

Re: ntdll/tests: Mark return value of RtlUnicodeStringToInteger("", 16) as broken for nt4.

2009-05-19 Thread Paul Vriens
Huw Davies wrote: --- dlls/ntdll/tests/rtlstr.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Hi, I don't think this is correct. This test has always succeeded until March 9th. There haven't been any c

Re: [PATCH 2/2] ole32/tests: Add tests to show the WdtpInterfacePointer marshal data looks like the result of CoMarshalInterface.

2009-05-19 Thread Paul Vriens
Paul Vriens wrote: Huw Davies wrote: --- dlls/ole32/tests/usrmarshal.c | 38 +- 1 files changed, 21 insertions(+), 17 deletions(-) Hi Huw, Could you have a look at the test res

Re: [PATCH 8/8] urlmon: Added binding with MIME filter tests.

2009-05-19 Thread Alexandre Julliard
Jacek Caban writes: > --- > dlls/urlmon/tests/url.c | 782 > ++- > 1 files changed, 636 insertions(+), 146 deletions(-) This is failing here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok ur

Re: Gecko installation broken?

2009-05-19 Thread Stefan Dösinger
Am Montag, 18. Mai 2009 22:46:59 schrieb Lei Zhang: > It didn't think so either, so I even double checked. Upon further > investigation, it seems the problem is simply the gecko cab download > is failing. Either one of the Sourceforge servers is down/flaky, or > source.winehq.org is taking too long

Re: [Article] WINE and the importance of application compatibility

2009-05-19 Thread Kai Blin
On Tuesday 19 May 2009 01:45:14 Scott Ritchie wrote: > I don't think we'll get much traction with this unless we can reasonably > tell them they only need to test the stable Wine release. But 1.0 is > pretty old these days, so they probably won't bother. > > I'll add it to my list of evangelism t