Re: [wintrust/tests] Add some basic CryptCATOpen tests

2009-05-18 Thread Paul Vriens
Detlef Riekenberg wrote: On Mo, 2009-05-18 at 16:07 +0200, Paul Vriens wrote: +hcat = pCryptCATOpen(emptyW, 0, 0, 0, 0); +todo_wine +{ +ok(hcat != NULL && hcat != INVALID_HANDLE_VALUE, "Expected a correct handle\n"); +ok(GetLastError() == ERROR_SUCCESS, + "Expected ERRO

Re: [Article] WINE and the importance of application compatibility

2009-05-18 Thread Ben Klein
2009/5/19 Austin English : > On Mon, May 18, 2009 at 3:48 PM, David Gerard wrote: >> 1. Find apps that work pretty much perfectly in Wine. >> 2. Ask them to declare Wine officially supported. >> 3. Add them to http://wiki.winehq.org/AppsThatSupportWine >> 4. Use 3. to add more to 2. > > You forgot

Re: [Article] WINE and the importance of application compatibility

2009-05-18 Thread Scott Ritchie
David Gerard wrote: 2009/5/18 Brian Vincent : Which leads me to my $.02: I wonder if there's a sweet spot for Wine adoption somewhere in the middle-tier of the software application popularity contest. For instance, rather than going after Photoshop or Photoshop Elements (which is still a noble

Re: gdiplus: implement GdipTransformPoints

2009-05-18 Thread Nikolay Sivov
Vincent Povirk wrote: It's odd, but it seems like the simplest way to write this. I've tried what I think was your suggestion, and that's attached. I don't think it's an improvement. Vincent Povirk Could be a single switch maybe. Don't know, looks better for me. Comparisons were really ugl

Re: gdiplus: implement GdipTransformPoints

2009-05-18 Thread Vincent Povirk
It's odd, but it seems like the simplest way to write this. I've tried what I think was your suggestion, and that's attached. I don't think it's an improvement. Vincent Povirk On Mon, May 18, 2009 at 5:17 PM, Nikolay Sivov wrote: > Vincent Povirk wrote: > > From 1de9b2291bf9a5617ca1e3b0cba5f1

Re: gdiplus: implement GdipTransformPoints

2009-05-18 Thread Nikolay Sivov
Vincent Povirk wrote: From 1de9b2291bf9a5617ca1e3b0cba5f1260889c259 Mon Sep 17 00:00:00 2001 From: Vincent Povirk Date: Mon, 23 Mar 2009 16:34:12 -0500 Subject: [PATCH] gdiplus: implement GdipTransformPoints It's a strange way to check enumeration with integer comparison, isn't it? And not c

Re: [wintrust/tests] Add some basic CryptCATOpen tests

2009-05-18 Thread Detlef Riekenberg
On Mo, 2009-05-18 at 16:07 +0200, Paul Vriens wrote: > +hcat = pCryptCATOpen(emptyW, 0, 0, 0, 0); > +todo_wine > +{ > +ok(hcat != NULL && hcat != INVALID_HANDLE_VALUE, "Expected a > correct handle\n"); > +ok(GetLastError() == ERROR_SUCCESS, > + "Expected ERROR_SUCCESS, got

Re: [Article] WINE and the importance of application compatibility

2009-05-18 Thread Austin English
On Mon, May 18, 2009 at 3:48 PM, David Gerard wrote: > 1. Find apps that work pretty much perfectly in Wine. > 2. Ask them to declare Wine officially supported. > 3. Add them to http://wiki.winehq.org/AppsThatSupportWine > 4. Use 3. to add more to 2. You forgot: 5. 6. Profit! :-) -- -Aust

Re: [Article] WINE and the importance of application compatibility

2009-05-18 Thread David Gerard
2009/5/18 Brian Vincent : > Which leads me to my $.02: I wonder if there's a sweet spot for Wine > adoption somewhere in the middle-tier of the software application popularity > contest.  For instance, rather than going after Photoshop or Photoshop > Elements (which is still a noble goal), what ab

Re: Gecko installation broken?

2009-05-18 Thread Lei Zhang
On Mon, May 18, 2009 at 12:29 PM, Nikolay Sivov wrote: > Lei Zhang wrote: >> >> On Mon, May 18, 2009 at 11:20 AM, Lei Zhang wrote: >> >>> >>> On Mon, May 18, 2009 at 10:57 AM, Stefan Dösinger >>> wrote: >>> Hi, Is my setup broken, or does the gecko installation fail? In a new wine

Re: [Article] WINE and the importance of application compatibility

2009-05-18 Thread Brian Vincent
On Sun, May 17, 2009 at 6:55 PM, Steven Edwards wrote: > doubt it. The situation I face with my day job, is that we can't even > get support for certain applications in VMware. As soon as we say "we > have a virtualized cluster" they balk. And we are talking about > situations where we are spendin

Re: winspool.drv: implement semi-stub of EnumJobsW

2009-05-18 Thread Detlef Riekenberg
On Mo, 2009-05-18 at 19:30 +0400, Vitaly Perov wrote: > --- > dlls/winspool.drv/info.c | 36 +++- > 1 files changed, 35 insertions(+), 1 deletions(-) The correct location for an implementation is localspl.dll For which Application did you changed the stub? The

Re: Gecko installation broken?

2009-05-18 Thread Nikolay Sivov
Lei Zhang wrote: On Mon, May 18, 2009 at 11:20 AM, Lei Zhang wrote: On Mon, May 18, 2009 at 10:57 AM, Stefan Dösinger wrote: Hi, Is my setup broken, or does the gecko installation fail? In a new wine prefix, when I open builtin iexplore, I get the installation dialog. The download run

Re: Gecko installation broken?

2009-05-18 Thread Lei Zhang
On Mon, May 18, 2009 at 11:20 AM, Lei Zhang wrote: > On Mon, May 18, 2009 at 10:57 AM, Stefan Dösinger > wrote: >> Hi, >> Is my setup broken, or does the gecko installation fail? In a new wine >> prefix, >> when I open builtin iexplore, I get the installation dialog. The download >> runs success

Re: Gecko installation broken?

2009-05-18 Thread Lei Zhang
On Mon, May 18, 2009 at 10:57 AM, Stefan Dösinger wrote: > Hi, > Is my setup broken, or does the gecko installation fail? In a new wine prefix, > when I open builtin iexplore, I get the installation dialog. The download > runs successfully, but after installation iexplore still says that HTML > re

Gecko installation broken?

2009-05-18 Thread Stefan Dösinger
Hi, Is my setup broken, or does the gecko installation fail? In a new wine prefix, when I open builtin iexplore, I get the installation dialog. The download runs successfully, but after installation iexplore still says that HTML rendering is currently disabled. When I run iexplore again, I again

Re: [2/3] d3dx9: Add utility functions for loading files and resources into memory

2009-05-18 Thread Stefan Dösinger
Am Montag, 18. Mai 2009 17:44:17 schrieb Tony Wasserka: > +HRESULT LoadFileIntoMemoryA(LPCSTR filename, LPVOID *buffer, DWORD *length) Do you need this function? Woudn't it be better to wrap A->W at the API level and have all internal functions W only? > +handle = CreateFileW(filename, GENER

Re: [PATCH 2/2] ole32/tests: Add tests to show the WdtpInterfacePointer marshal data looks like the result of CoMarshalInterface.

2009-05-18 Thread Paul Vriens
Huw Davies wrote: --- dlls/ole32/tests/usrmarshal.c | 38 +- 1 files changed, 21 insertions(+), 17 deletions(-) Hi Huw, Could you have a look at the test results are test.winehq.o

Re: [shell32] Improve the Dutch 'about' message box

2009-05-18 Thread Reece Dunn
2009/5/18 Francois Gouget : > On Mon, 18 May 2009, Reece Dunn wrote: > [...] >> I was thinking of some sort of auto-layout logic, using bounding box >> calculations and metric information fed from Windows guidelines. The >> idea here is to give a consistent layout and make it easier to add new >> c

Re: DIB Engine - Mostly fixed against test suite

2009-05-18 Thread Michael Karcher
Am Montag, den 18.05.2009, 13:41 +0200 schrieb Massimo Del Fedele: > > Be careful with such statements. Look at bug 6519 for example. > Yep, I've seen the bug :-) > Anyways, most failures are fixed by now, also for monochrome bitmaps. > Did you test it on bug's 6519 app ? No, I don't really care.

Re: [4/4]msctf: starting implementation of ITfContext::RequestEditSession and ITextStoreACPSink::OnLockGranted

2009-05-18 Thread Alexandre Julliard
Aric Stewart writes: > --- > dlls/msctf/context.c | 68 > ++-- > dlls/msctf/tests/inputprocessor.c | 29 +++- > include/textstor.idl |2 + > 3 files changed, 86 insertions(+), 13 deletions(-) It doesn't work here: ..

Re: DIB Engine - Mostly fixed against test suite

2009-05-18 Thread Massimo Del Fedele
Michael Karcher ha scritto: Am Sonntag, den 17.05.2009, 17:35 +0200 schrieb Massimo Del Fedele: 1) Some color on monochrome bitmaps here I guess nobody knows how to do it right. I fixed some todo wine (most) but have 2 failures which wine does right. Seldom used anyways, and happens only on

Re: DIB Engine - Mostly fixed against test suite

2009-05-18 Thread Massimo Del Fedele
Austin English ha scritto: On Sun, May 17, 2009 at 10:35 AM, Massimo Del Fedele wrote: Austin, could you please retest it against test suite ? I've ran it, but it doesn't appear to be showing up on test.winehq.org. I'll investigate why when I get a bit more time. P.S., there's now a crash in

Re: [PATCH] winhttp: avoid NULL ptr dereference (Coverity 927)

2009-05-18 Thread Alexandre Julliard
Marcus Meissner writes: > Not sure if we need to set these values in all error paths, > but definitely not in the NULL lpwhr. (lpwhdr?) There's no reason to have NULL checks in internal functions. -- Alexandre Julliard julli...@winehq.org

Re: [shell32] Improve the Dutch 'about' message box

2009-05-18 Thread Francois Gouget
On Mon, 18 May 2009, Reece Dunn wrote: [...] > I was thinking of some sort of auto-layout logic, using bounding box > calculations and metric information fed from Windows guidelines. The > idea here is to give a consistent layout and make it easier to add new > controls. > > I am aware that this i

Re: [shell32] Improve the Dutch 'about' message box

2009-05-18 Thread Reece Dunn
2009/5/16 Francois Gouget : > On Tue, 12 May 2009, Reece Dunn wrote: > [...] >> What I would like to do is get an automated (or semi-automated) tool, >> ideally with a GUI interface to it. That would ultimately put the >> designer in charge. Hopefully, this would also mean that you have a >> base r

Re: [shell32] Improve the Dutch 'about' message box

2009-05-18 Thread Michael Stefaniuc
Mikołaj Zalewski wrote: > >> Yes, handling the translation of Wine's resource files would be really >> nice. It would let us leverage a lot of the po tools, especially the >> website based ones. This would make it much easier for users to >> contribute to the translations (right now it's pretty in

Re: DIB Engine - Mostly fixed against test suite

2009-05-18 Thread Michael Karcher
Am Sonntag, den 17.05.2009, 17:35 +0200 schrieb Massimo Del Fedele: > 1) Some color on monochrome bitmaps here I guess nobody knows how to do > it right. I fixed some todo wine (most) but have 2 failures which wine does > right. > Seldom used anyways, and happens only on weird palettes. I gue