Re: Add tests for DirectDraw surface reference counting

2009-05-15 Thread James McKenzie
Luke Benstead wrote: > 2009/5/15 Stefan Dösinger : > >> Am Freitag, 15. Mai 2009 13:52:23 schrieb Luke Benstead: >> >>> Reference counts are wrong in Wine which causes some games to fail. >>> I'm working patches to make these tests pass so we can remove the >>> todo_wine's. >>> >>> Luke. >>

Re: [shell32] Improve the Dutch 'about' message box

2009-05-15 Thread Francois Gouget
On Tue, 12 May 2009, Reece Dunn wrote: [...] > What I would like to do is get an automated (or semi-automated) tool, > ideally with a GUI interface to it. That would ultimately put the > designer in charge. Hopefully, this would also mean that you have a > base resource file that produces the Engli

Re: wine-devel Digest, Vol 46, Issue 55

2009-05-15 Thread Steve Dodier
Hello, If it's clear the distro list is quite messed, I think the distinction between Ubuntu Kubuntu and Xubuntu must be kept, because for install, Ubuntu ships with PulseAudio and Compiz by default, which cause a lot of problems, while Xubuntu is free of that and has its compositor shutdown by de

Re: (try3)Fix ATI HD4800 being reported as ATI 9500

2009-05-15 Thread Ricardo Filipe
2009/5/15 Robert Key > Same patch but with the 2048MB X2 comment removed, thanks > Roderick. > > the previous try has been commited today... so if you want to fix the comment you have to send another patch, or leave it like it is.

AppDB and Distributions

2009-05-15 Thread André Hentschel
Hi, It's getting more and more strange in our AppDB. If a user is running Ubuntu 9.04, he has 14 options which distribution called Ubuntu 9.04 to choose. 14? There only should be two, the 32-Bit and the 64-Bit Version. If we don't stop that we get more and more chaos in our DB. So why this mess?

Re: Add tests for DirectDraw surface reference counting

2009-05-15 Thread Luke Benstead
2009/5/15 Stefan Dösinger : > Am Freitag, 15. Mai 2009 13:52:23 schrieb Luke Benstead: >> Reference counts are wrong in Wine which causes some games to fail. >> I'm working patches to make these tests pass so we can remove the >> todo_wine's. >> >> Luke. > > The patch adds trailing whitespeaces in

Re: Add tests for DirectDraw surface reference counting

2009-05-15 Thread Stefan Dösinger
Am Freitag, 15. Mai 2009 13:52:23 schrieb Luke Benstead: > Reference counts are wrong in Wine which causes some games to fail. > I'm working patches to make these tests pass so we can remove the > todo_wine's. > > Luke. The patch adds trailing whitespeaces in a few lines. Please remove them. Othe

Re: [1/2] winetest: malloc() & co are encapsulated, so encapsulate free() too.

2009-05-15 Thread Alexandre Julliard
Francois Gouget writes: > It's not very clean to encapsulate malloc() & co with xmalloc(), etc, > but to then call free() directly. It means if the implementation of > xmalloc() is changed to call HeapAlloc() all the free() have to be > changed. So encapsulate free() too. xmalloc() is clearly

Re: Fiddling with EnumServicesStatusExW

2009-05-15 Thread Paul Vriens
Rolf Kalbermatter wrote: From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] How can I make sure the pointers to the strings are correctly passed back as well? Should the RPC stuff take care of these pointers and 'translate' them? Those pointers are not really pointers but byte offsets fro

Re: (try2)Fix ATI HD4800 being reported as ATI 9500

2009-05-15 Thread Roderick Colenbrander
The patch itself is correct but the comment regarding the X2 4800 is incorrect. Those cards indeed have 2GB of video memory (and the PR people mention that to you) but the boards contain two GPUs and both need a have a copy of textures and other resources (though the GPUs can communicate using a hi