Re: Redirector code in Wine?

2009-04-23 Thread Vitaliy Margolen
Kai Blin wrote: > Hi folks, > > I'm trying to figure out where the wine server actually decides if a file > actually is a file on disk, a local or a remote pipe. Any pointers? You mean during CreateFile -> NtCreateFile? It's using object manager in wineserver to find the object associated with th

re: Redirector code in Wine?

2009-04-23 Thread Dan Kegel
Kai wrote: > I'm trying to figure out where the wine server actually decides if a file > actually is a file on disk, a local or a remote pipe. Any pointers? Search for FileFsDeviceInformation in ntdll/file.c, maybe.

Redirector code in Wine?

2009-04-23 Thread Kai Blin
Hi folks, I'm trying to figure out where the wine server actually decides if a file actually is a file on disk, a local or a remote pipe. Any pointers? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team membe

Re: NetBSD compiler warnings patches - review request

2009-04-23 Thread Hans Leidekker
On Thursday 23 April 2009 18:46:38 Austin English wrote: > diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c > index 79e6789..3c68ee0 100644 > --- a/dlls/winhttp/net.c > +++ b/dlls/winhttp/net.c > @@ -82,7 +82,7 @@ static CRITICAL_SECTION cs_gethostbyname = { > &critsect_debug, -1, 0, 0, 0, 0

Re: [1/5] WineD3D: Support the full amount of constants in GLSL

2009-04-23 Thread Stefan Dösinger
Am Donnerstag, 23. April 2009 16:33:10 schrieb Stefan Dösinger: > Am Donnerstag, 23. April 2009 15:44:44 schrieb Alexandre Julliard: > > Stefan Dösinger writes: > > > Am Mittwoch, 22. April 2009 21:03:41 schrieb Stefan Dösinger: > > > Use this patch instead. Henri spotted some missing parentheses

NetBSD compiler warnings patches - review request

2009-04-23 Thread Austin English
Howdy, I recently started retesting NetBSD (5.0 this time), and have filed bugs for most of the warnings. A few of them I have patches ready for, but figured I should probably get reviewed first: First up, bug 18161: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_RE

Re: ole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for the requested CLSID

2009-04-23 Thread Aric Stewart
Good point, actually it should not be leaving the clsid alone it should be duplicating the requested GUID into it. (wine already does this part) I will update the test to properly show that. -aric Paul Vriens wrote: Aric Stewart wrote: Fixes issues with IE7 involving constant prompting to cl

Re: ole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for the requested CLSID

2009-04-23 Thread Paul Vriens
Aric Stewart wrote: Fixes issues with IE7 involving constant prompting to click to run ActiveX controls when none are present Includes test --- dlls/ole32/compobj.c |3 +++ dlls/ole32/tests/compobj.c | 18 ++ 2 files changed, 21 insertions(+), 0 deletions(-) ---

Re: kernel32/tests: Added last error tests for GetPrivateProfileString

2009-04-23 Thread Paul Vriens
Dmitry Kislyuk wrote: I don't have a particular app for you, however, there can easily be apps that would behave differently from how they would on Windows due to these last errors not being set to what the app expects. Do you have a reason why Wine behavior should not match the Windows behavi

Re: wined3d: Avoid using an implicit value to set fogcoord to 0.0.

2009-04-23 Thread Stefan Dösinger
This patch looks ok. I have the same patch in my send queue, but it seems Francois was quicker with sending it

Re: [1/5] WineD3D: Support the full amount of constants in GLSL

2009-04-23 Thread Stefan Dösinger
Am Donnerstag, 23. April 2009 15:44:44 schrieb Alexandre Julliard: > Stefan Dösinger writes: > > Am Mittwoch, 22. April 2009 21:03:41 schrieb Stefan Dösinger: > > Use this patch instead. Henri spotted some missing parentheses in the > > code > > It doesn't work here: Can you send me a +glsl_shade

Re: [PATCH 1/2] ole32: Register the clipboard formats at load time.

2009-04-23 Thread Huw Davies
On Thu, Apr 23, 2009 at 03:40:11PM +0200, Alexandre Julliard wrote: > Huw Davies writes: > > > --- > > dlls/ole32/clipboard.c | 54 > > + > > dlls/ole32/compobj.c |2 + > > dlls/ole32/compobj_private.h | 14 +++ > > 3 files c

Re: [1/5] WineD3D: Support the full amount of constants in GLSL

2009-04-23 Thread Alexandre Julliard
Stefan Dösinger writes: > Am Mittwoch, 22. April 2009 21:03:41 schrieb Stefan Dösinger: > Use this patch instead. Henri spotted some missing parentheses in the code It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok v

Re: [PATCH 1/2] ole32: Register the clipboard formats at load time.

2009-04-23 Thread Alexandre Julliard
Huw Davies writes: > --- > dlls/ole32/clipboard.c | 54 + > dlls/ole32/compobj.c |2 + > dlls/ole32/compobj_private.h | 14 +++ > 3 files changed, 54 insertions(+), 16 deletions(-) It would be nicer to do this when needed, so

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Giuseppe Bilotta
2009/4/23 Mikołaj Zalewski : >  Hi, >  I think it would be interesting to test what TB_GETBUTTONINFO returns as > iString for such a separator. That way we will know if the value is simply > ignored, or it's something more complicated. Forget what I said in my previous email. I was running the GET

RE: [mshtml] Fix the size passed to MultiByteToWideChar for real

2009-04-23 Thread Colin Finck
Dmitry Timoshkov wrote: > returned_size must be intialized first. That's what I've already fixed in an updated patch yesterday: http://www.winehq.org/pipermail/wine-patches/2009-April/072175.html Best regards, Colin

Re: [1/7] [wined3d] move creation of NP2 fixup uniforms into separate loop (retry)

2009-04-23 Thread Tobias Jakobi
> NAK Suggestions? Explanations? Like explained putting this into prog_link won't work. It doesn't make sense in the first place. Using a separate struct for GLSL and ARB isn't also making sense, since the data stored in the struct is independant of GLSL and ARB.

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Paul Vriens
Giuseppe Bilotta wrote: 2009/4/23 Mikołaj Zalewski : Hi, I think it would be interesting to test what TB_GETBUTTONINFO returns as iString for such a separator. That way we will know if the value is simply ignored, or it's something more complicated. You're definitely on to something here. In

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Giuseppe Bilotta
2009/4/23 Mikołaj Zalewski : >  Hi, >  I think it would be interesting to test what TB_GETBUTTONINFO returns as > iString for such a separator. That way we will know if the value is simply > ignored, or it's something more complicated. You're definitely on to something here. Indeed, trying to get

Re: [1/7] [wined3d] move creation of NP2 fixup uniforms into separate loop (retry)

2009-04-23 Thread Henri Verbeet
2009/4/23 Tobias Jakobi : > ps_np2fixup_t is still stored in ps_compiled_shader and I have no intention > to change this, since the ARB code is going to use the exact same structure. NAK

Ubuntu no longer works correctly without pulseaudio

2009-04-23 Thread Susan Cragin
I just thought I would alert the list. I had a problem with sound oddities a few days ago, and filed bug 1813. The possible culprits were wine's daily build, my experimental alsa-driver, and standard Ubuntu updates. The Ubuntu updates won. Ubuntu no longer works correctly with pulseaudio purged

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Paul Vriens
Giuseppe Bilotta wrote: On Thu, Apr 23, 2009 at 8:00 AM, Paul Vriens wrote: Giuseppe Bilotta wrote: Trying to add a separator with an invalid pointer in iString to a toolbar works in Windows, showing that the field is ignored. Patches should only go to wine-patches unless you'd like them to b

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Giuseppe Bilotta
On Thu, Apr 23, 2009 at 8:00 AM, Paul Vriens wrote: > Giuseppe Bilotta wrote: >> >> Trying to add a separator with an invalid pointer in iString to a >> toolbar works in Windows, showing that the field is ignored. > > Patches should only go to wine-patches unless you'd like them to be reviewed > f

Re: [mshtml] Fix the size passed to MultiByteToWideChar for real

2009-04-23 Thread Dmitry Timoshkov
"Colin Finck" wrote: wrote: @@ -425,6 +425,7 @@ static LPWSTR get_url(void) HKEY hkey; DWORD res, type; DWORD size = INTERNET_MAX_URL_LENGTH*sizeof(WCHAR); +DWORD returned_size; LPWSTR url; static const WCHAR wszGeckoUrl[] = {'G','e','c','k','o','U','r','l',0}; @

Re: kernel32/tests: Added last error tests for GetPrivateProfileString

2009-04-23 Thread Paul Vriens
Dmitry Kislyuk wrote: Any particular reason for adding these tests? Is there an app depending on the last error? -- Cheers, Paul.

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Mikołaj Zalewski
Hi, I think it would be interesting to test what TB_GETBUTTONINFO returns as iString for such a separator. That way we will know if the value is simply ignored, or it's something more complicated. +static void test_deadbeef(void) I think you should find a better name. Maybe test_addbutt