Re: msvcrt/tests : add some tests for strtok()

2009-04-21 Thread Rein Klazes
On Tue, 21 Apr 2009 17:48:44 +0200, you wrote: >> +skip("memcpy not found\n"); > >I doubt any version of the dll is missing memcpy, and even so that >should be a separate patch. Yes, I was not paying attention. The problem was the handle to the msvcrt.dll. When compiled with Visual Studi

Re: comctl32: TOOLBAR_SetImageList should recalulate toolbar only if it is necessary

2009-04-21 Thread Igor Tarasov
2009/4/21 Alexandre Julliard : > It doesn't work here: > > ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p > comctl32_test.exe.so toolbar.c && touch toolbar.ok Thank you for taking time to reply. That was my fault. Going to fix it add testcase and resend. -- Igor

Re: [4/4] msi/tests: Fix package test when run on a different drive than C:\.

2009-04-21 Thread James Hawkins
On Tue, Apr 21, 2009 at 2:51 PM, Nicolas Le Cam wrote: > 2009/4/21 James Hawkins : >> On Tue, Apr 21, 2009 at 2:30 PM, Nicolas Le Cam wrote: >>> This one finally fixes current relative path test to expect correct >>> value. >>> >> >> +    drives = GetLogicalDrives(); >> +    lstrcpyA(path, "A:\\"

Re: [4/4] msi/tests: Fix package test when run on a different drive than C:\.

2009-04-21 Thread Nicolas Le Cam
2009/4/21 James Hawkins : > On Tue, Apr 21, 2009 at 2:30 PM, Nicolas Le Cam wrote: >> This one finally fixes current relative path test to expect correct >> value. >> > > +    drives = GetLogicalDrives(); > +    lstrcpyA(path, "A:\\"); > +    for (i = 0; i < 26; path[0] = '\0', i++) > +    { > +  

Re: [4/4] msi/tests: Fix package test when run on a different drive than C:\.

2009-04-21 Thread James Hawkins
On Tue, Apr 21, 2009 at 2:30 PM, Nicolas Le Cam wrote: > This one finally fixes current relative path test to expect correct > value. > +drives = GetLogicalDrives(); +lstrcpyA(path, "A:\\"); +for (i = 0; i < 26; path[0] = '\0', i++) +{ +if (!(drives & (1 << i))) +

Re: Changing the language that wine runs in (testing language versions of dialogs)

2009-04-21 Thread Detlef Riekenberg
On Di, 2009-04-21 at 21:06 +0100, Reece Dunn wrote: > >> LANG=es_ES.UTF-8 ./wine winecfg > >> works for me. The language code is "es_ES" and not just "es". > That works. I have started a page on the wiki > (http://wiki.winehq.org/TestingLanguages) to document how to launch > Wine in the different

Re: [2/4] msi/tests: Add empty dir test for the DrLocator part of the AppSearch action.

2009-04-21 Thread James Hawkins
On Tue, Apr 21, 2009 at 2:30 PM, Nicolas Le Cam wrote: > This patch adds a test to demonstrate current wrong behaviour in case of > an empty path, it is basically there to validate last patch of the > series that change relative path test behaviour (i.e. expected values), > as it seems it was reje

Re: dsound: Allow a special cbSize case in CreateSoundBuffer (updated)

2009-04-21 Thread Detlef Riekenberg
On Mo, 2009-04-20 at 21:51 -0700, Jesse Allen wrote: > In CreateSoundBuffer, some apps pass sizeof(WAVEFORMATEXTENSIBLE) for > the cbSize and we have to allow it, but only when the SubFormat is > KSDATAFORMAT_SUBTYPE_PCM. > > This updated patch is simpler... at the expense of being less clear ;) >

Re: Changing the language that wine runs in (testing language versions of dialogs)

2009-04-21 Thread Reece Dunn
2009/4/21 Reece Dunn : > 2009/4/21 Michael Stefaniuc : >> Reece Dunn wrote: >>> Hi, >>> >>> Looking at http://bugs.winehq.org/show_bug.cgi?id=18125, it has >>> winecfg from wine 1.1.19 running in Spanish. The screenshot shows that >>> the static text is wrapped over 4 lines, but the text is clipped

Re: Win64 keyword?

2009-04-21 Thread André Hentschel
Austin English schrieb: Howdy, Seems quite a few bugs have been filed recently about our win64 support. While setting the hardware to PC-X86-64 describes the hardware accurately, it doesn't really tell us if the user is running 32 bit wine or 64 bit wine on their 64 bit OS. We've already got a

Win64 keyword?

2009-04-21 Thread Austin English
Howdy, Seems quite a few bugs have been filed recently about our win64 support. While setting the hardware to PC-X86-64 describes the hardware accurately, it doesn't really tell us if the user is running 32 bit wine or 64 bit wine on their 64 bit OS. We've already got a win16 keyword, so how abou

Re: DIB Engine - New approach

2009-04-21 Thread Massimo Del Fedele
Jesse Allen ha scritto: I'm trying to understand what the problem is to make you think there needs to be a change. Are most of the problems with Blt related functions? No It is my understanding the DIB engine should actually be able to call the display driver and vice-versa. So I think we

Re: DIB Engine - New approach

2009-04-21 Thread Jesse Allen
On Tue, Apr 14, 2009 at 1:22 AM, Massimo Del Fedele wrote: > The approach taken so far consisted in having 2 device pointers inside > GDI32, one for dib engine and > the other for normal display driver. > This way had the disadvantage of having to keep in sync the DC with the > right driver depend

Re: msvcrt/tests : add some tests for strtok()

2009-04-21 Thread Alexandre Julliard
Rein Klazes writes: > -pmemcpy(mem+5, mem,nLen+1); > -ok(pmemcmp(mem+5,xilstring, nLen) == 0, > - "Got result %s\n",mem+5); > +if( pmemcpy) { > +pmemcpy(mem+5, mem,nLen+1); > +ok(pmemcmp(mem+5,xilstring, nLen) == 0, > + "Got result %s\n",mem+5); > +

Re: [1/5]msctf/test: setup test framework for ITfThreadMgrEventSink

2009-04-21 Thread Alexandre Julliard
Aric Stewart writes: > +static HRESULT WINAPI > ThreadMgrEventSink_OnInitDocumentMgr(ITfThreadMgrEventSink *iface, > +ITfDocumentMgr *pdim) > +{ > +trace("%s\n",__FUNCTION__); > +return S_OK; > +} trace() already includes the file and line, and __FUNCTION__ is not portable, please avoid

Re: comctl32: TOOLBAR_SetImageList should recalulate toolbar only if it is necessary

2009-04-21 Thread Alexandre Julliard
Igor Tarasov writes: > Forgot the patch :) > > 2009/4/19 Igor Tarasov : >> Currently TOOLBAR_SetImageList recalculates toolbar and button sizes >> even if there is no need in this (when new image list bitmap sizes are >> equal to toolbar bitmap sizes). This overwrites button sizes that >> might h

Re: Wine patch code review or what to do if patches get stuck?

2009-04-21 Thread Reece Dunn
2009/4/21 Paul Vriens : > Reece Dunn wrote: >> >> 2009/4/21 Jeremy White : Sometimes "no feedback" means that you just dont know - is there something wrong? Or maybe your patch wos not understood correctly? Or there are doubts that what you did is right? Or what? It would be >>>

Re: Wine patch code review or what to do if patches get stuck?

2009-04-21 Thread Igor Tarasov
2009/4/21 Paul Vriens : > http://winehq.org/wwn/353#News:%20WineConf%202008 The best point: "Are the planets aligned in just the right way and none of the above reject? Yes : ACCEPT". I guess there were some problems with this point yesterday :) -- Igor

Re: XI2 DirectInput mouse implementation RFC (Tarballed)

2009-04-21 Thread Paul TBBle Hampson
On Tue, Apr 21, 2009 at 08:16:14AM -0600, Vitaliy Margolen wrote: > Paul TBBle Hampson wrote: >> On Sun, Apr 19, 2009 at 02:39:43PM -0600, Vitaliy Margolen wrote: >>> Paul TBBle Hampson wrote: >> I think I understand now. >> >> So we really don't want to touch dinput at all, but instead just use X

Re: Wine patch code review or what to do if patches get stuck?

2009-04-21 Thread Paul Vriens
Reece Dunn wrote: 2009/4/21 Jeremy White : Sometimes "no feedback" means that you just dont know - is there something wrong? Or maybe your patch wos not understood correctly? Or there are doubts that what you did is right? Or what? It would be better to have feedback like "are you serious?" than

Re: Wine patch code review or what to do if patches get stuck?

2009-04-21 Thread Reece Dunn
2009/4/21 Jeremy White : >> Sometimes "no feedback" means that you just dont know - is there >> something wrong? Or maybe your patch wos not understood correctly? Or >> there are doubts that what you did is right? Or what? It would be >> better to have feedback like "are you serious?" than nothing

Re: [1/2](try 2)msctf: helper functions for generating DWORD cookies

2009-04-21 Thread Alexandre Julliard
Aric Stewart writes: > +else if (id_last == array_size) > +{ > +CookieInternal **new_cookies = NULL; > +new_cookies = > HeapReAlloc(GetProcessHeap(),0,cookies,sizeof(CookieInternal*) * (array_size > * 2)); > +if (!new_cookies) > +{ > +array_si

Re: [kernel32] add unittests for registry keys of serial ports

2009-04-21 Thread Alexandre Julliard
Stefan Leichter writes: > +RegOpenKeyA(HKEY_LOCAL_MACHINE, "Hardware\\Description\\System", > &desc_sys); > +RegOpenKeyA(HKEY_LOCAL_MACHINE, "Hardware\\Devicemap\\Serialcomm", > &sercom); > +RegOpenKeyA(HKEY_LOCAL_MACHINE, "Software\\Microsoft\\Windows > NT\\CurrentVersion\\Ports",

Re: Wine patch code review or what to do if patches get stuck?

2009-04-21 Thread Jeremy White
> Sometimes "no feedback" means that you just dont know - is there > something wrong? Or maybe your patch wos not understood correctly? Or > there are doubts that what you did is right? Or what? It would be > better to have feedback like "are you serious?" than nothing at all :) I've tried to upda

Re: XI2 DirectInput mouse implementation RFC (Tarballed)

2009-04-21 Thread Vitaliy Margolen
Paul TBBle Hampson wrote: > On Sun, Apr 19, 2009 at 02:39:43PM -0600, Vitaliy Margolen wrote: >> Paul TBBle Hampson wrote: >>> On Sun, Apr 19, 2009 at 10:48:11AM -0600, Vitaliy Margolen wrote: Paul TBBle Hampson wrote: > On Sun, Apr 19, 2009 at 12:46:20PM +0200, Stefan Dösinger wrote:

Re: Possible regression today's git wine-1.1.19-153-g55ad3fd

2009-04-21 Thread Susan Cragin
>Ohhh... got a nice crash after a re-boot. Never mind that. This looks more promising. At least, to me it does. The actctx error I get all the time, but I've never seen the other, and it happend right as the system froze up. fixme:actctx:parse_depend_manifests Co

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.

2009-04-21 Thread Paul Vriens
Huw Davies wrote: On Tue, Apr 21, 2009 at 11:34:04AM +0200, Paul Vriens wrote: Huw Davies wrote: On Tue, Apr 21, 2009 at 11:22:29AM +0200, Paul Vriens wrote: Huw Davies wrote: --- dlls/user32/tests/clipboard.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) ---

Re: Article on wine development strategy

2009-04-21 Thread SorinN
You can identify this first user group by searching on secular requests - Novel showed us the first line is around Adobe clients. Dreamweaver ( which work OK now ), Photoshop, Flash, InDesign maybe - so webdesigners + DTP peoples can be 'the first' client. They are many millions now - no doubt the

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.

2009-04-21 Thread Huw Davies
On Tue, Apr 21, 2009 at 11:34:04AM +0200, Paul Vriens wrote: > Huw Davies wrote: >> On Tue, Apr 21, 2009 at 11:22:29AM +0200, Paul Vriens wrote: >>> Huw Davies wrote: --- dlls/user32/tests/clipboard.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) --

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.

2009-04-21 Thread Paul Vriens
Huw Davies wrote: On Tue, Apr 21, 2009 at 11:22:29AM +0200, Paul Vriens wrote: Huw Davies wrote: --- dlls/user32/tests/clipboard.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) Was just about to se

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.

2009-04-21 Thread Huw Davies
On Tue, Apr 21, 2009 at 11:22:29AM +0200, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/user32/tests/clipboard.c |7 +-- >> 1 files changed, 5 insertions(+), 2 deletions(-) >> >> >> >> >> > Was just about to s

Re: Changing the language that wine runs in (testing language versions of dialogs)

2009-04-21 Thread Reece Dunn
2009/4/21 Michael Stefaniuc : > Reece Dunn wrote: >> Hi, >> >> Looking at http://bugs.winehq.org/show_bug.cgi?id=18125, it has >> winecfg from wine 1.1.19 running in Spanish. The screenshot shows that >> the static text is wrapped over 4 lines, but the text is clipped >> (should be 8x4 dlus high).

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.

2009-04-21 Thread Paul Vriens
Huw Davies wrote: --- dlls/user32/tests/clipboard.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) Was just about to sent a patch along those lines. Isn't it better to mark that win9x (and winME as w

Re: Changing the language that wine runs in (testing language versions of dialogs)

2009-04-21 Thread Paul TBBle Hampson
On Tue, Apr 21, 2009 at 08:26:53AM +0100, Reece Dunn wrote: > Hi, > Looking at http://bugs.winehq.org/show_bug.cgi?id=18125, it has > winecfg from wine 1.1.19 running in Spanish. The screenshot shows that > the static text is wrapped over 4 lines, but the text is clipped > (should be 8x4 dlus high

Re: Changing the language that wine runs in (testing language versions of dialogs)

2009-04-21 Thread Michael Stefaniuc
Reece Dunn wrote: > Hi, > > Looking at http://bugs.winehq.org/show_bug.cgi?id=18125, it has > winecfg from wine 1.1.19 running in Spanish. The screenshot shows that > the static text is wrapped over 4 lines, but the text is clipped > (should be 8x4 dlus high). This is not the issue reported there,

Re: Changing the language that wine runs in (testing language versions of dialogs)

2009-04-21 Thread Igor Tarasov
2009/4/21 Reece Dunn : > So, how do I change locale? Especially from a just-built version of Wine. You have to make sure that the locale you are trying to use is there in your system (see locale -a). My corrent lcale is ru_RU.UTF-8 and wine runs correspondingly. When I run LC_ALL=C wine regedit L

Re: Wine patch code review or what to do if patches get stuck?

2009-04-21 Thread Austin English
On Tue, Apr 21, 2009 at 2:44 AM, Igor Tarasov wrote: > Hi! > > The reason of why I write this to you is simple: my patches have stuck > again and I don't know what to do. But since this happening not with > me only and not this happens regularly, I have thought about looking > at the problem a bit

Wine patch code review or what to do if patches get stuck?

2009-04-21 Thread Igor Tarasov
Hi! The reason of why I write this to you is simple: my patches have stuck again and I don't know what to do. But since this happening not with me only and not this happens regularly, I have thought about looking at the problem a bit wider. Is there any code review system for patches that are sen

Re: Maybe already known stuff, but.....

2009-04-21 Thread Massimo Del Fedele
Ben Klein ha scritto: Are there any cases like that where the sourcecode of the app is available? I see it much more useful to track the call stack inside wine, not in the app. In my app there's a crash that's triggered after many wine calls, and this was useful to track them down up to cal

Changing the language that wine runs in (testing language versions of dialogs)

2009-04-21 Thread Reece Dunn
Hi, Looking at http://bugs.winehq.org/show_bug.cgi?id=18125, it has winecfg from wine 1.1.19 running in Spanish. The screenshot shows that the static text is wrapped over 4 lines, but the text is clipped (should be 8x4 dlus high). This is not the issue reported there, but I would like to fix it an

NetBSD compile error

2009-04-21 Thread Austin English
I just installed NetBSD 5.0RC4 on a spare hard drive, and tried compiling Wine. I hadn't seen this error before, but I'm not sure if the regression is on NetBSD or Wine's end. Google doesn't show too much for this error, other than that apparently NetBSD's libexec requires execname to not be NULL: