Re: try4 [2/3] kernel32: Fix GetVolumeInformation[AW] to require trailing \

2009-04-15 Thread Austin English
On Wed, Apr 15, 2009 at 10:51 PM, Guy Albertelli wrote: > On Wed, 2009-04-15 at 10:58 -0500, Austin English wrote: >> On Tue, Apr 14, 2009 at 11:17 PM, Guy Albertelli wrote: >> > MSDN and test verify the valid "root dirs" for GetVolumeInformation[AW] >> > must end in trailing '\' and if not then

Re: DIB Engine - New approach

2009-04-15 Thread Dmitry Timoshkov
"Massimo Del Fedele" wrote: The approach taken so far consisted in having 2 device pointers inside GDI32, one for dib engine and the other for normal display driver. Please don't post huge attachments to the mailing list in future, post url for them instead. -- Dmitry.

Re: try4 [2/3] kernel32: Fix GetVolumeInformation[AW] to require trailing \

2009-04-15 Thread Guy Albertelli
On Wed, 2009-04-15 at 10:58 -0500, Austin English wrote: > On Tue, Apr 14, 2009 at 11:17 PM, Guy Albertelli wrote: > > MSDN and test verify the valid "root dirs" for GetVolumeInformation[AW] > > must end in trailing '\' and if not then return ERROR_INVALID_NAME > > > > Changelog > > - Return corr

Re: try4 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice

2009-04-15 Thread Guy Albertelli
On Wed, 2009-04-15 at 08:18 +0200, Paul Vriens wrote: > Guy Albertelli wrote: > > Fixed memory leak and changed skip to win_skip in this patch. > > > > Changelog: > > - Enhance QueryDosDevice test for attempting to return all devices. > > - Add tests for GetVolumeInformationA testing the diffe

Re: DIB Engine - New approach

2009-04-15 Thread Jesse Allen
On Tue, Apr 14, 2009 at 1:22 AM, Massimo Del Fedele wrote: > The approach taken so far consisted in having 2 device pointers inside > GDI32, one for dib engine and > the other for normal display driver. > This way had the disadvantage of having to keep in sync the DC with the > right driver depend

Re: [1/2] msi/tests: Test MsiRecordGetString on null and empty strings.

2009-04-15 Thread Nicolas Le Cam
2009/4/16 James Hawkins : > On Wed, Apr 15, 2009 at 5:21 PM, Nicolas Le Cam wrote: >> 2009/4/16 James Hawkins : >>> On Wed, Apr 15, 2009 at 4:34 PM, Nicolas Le Cam >>> wrote: While trying to solve ACTION_AppSearchDr problem revealed by my previous patch, I discovered that MSI_RecordGet

Re: RFC: Resource editing and validation

2009-04-15 Thread Francois Gouget
On Tue, 7 Apr 2009, Vincent Povirk wrote: [...] > I don't think a dependency on po/gettext and the resulting two > translation systems instead of one is a good idea. I think it is best > to use the existing rc system to translate all text. The problem is there is no translation tool that knows how

Re: [1/2] msi/tests: Test MsiRecordGetString on null and empty strings.

2009-04-15 Thread James Hawkins
On Wed, Apr 15, 2009 at 5:21 PM, Nicolas Le Cam wrote: > 2009/4/16 James Hawkins : >> On Wed, Apr 15, 2009 at 4:34 PM, Nicolas Le Cam wrote: >>> While trying to solve ACTION_AppSearchDr problem revealed by my previous >>> patch, I discovered that MSI_RecordGetStringW was returning a buffer >>> le

Re: [1/2] msi/tests: Test MsiRecordGetString on null and empty strings.

2009-04-15 Thread Austin English
On Wed, Apr 15, 2009 at 7:21 PM, Nicolas Le Cam wrote: > Even if I was tempted to changed it, I tried to follow original code > style, as stated multiple times on wine-devel. While that's encouraged, it's sometimes more of a suggestion than a rule. If you're changing a lot of the code and it help

Re: [1/2] msi/tests: Test MsiRecordGetString on null and empty strings.

2009-04-15 Thread Nicolas Le Cam
2009/4/16 James Hawkins : > On Wed, Apr 15, 2009 at 4:34 PM, Nicolas Le Cam wrote: >> While trying to solve ACTION_AppSearchDr problem revealed by my previous >> patch, I discovered that MSI_RecordGetStringW was returning a buffer >> length of 1 on null and empty strings. >> >> Here is the test, t

Re: [1/2] msi/tests: Test MsiRecordGetString on null and empty strings.

2009-04-15 Thread James Hawkins
On Wed, Apr 15, 2009 at 4:34 PM, Nicolas Le Cam wrote: > While trying to solve ACTION_AppSearchDr problem revealed by my previous > patch, I discovered that MSI_RecordGetStringW was returning a buffer > length of 1 on null and empty strings. > > Here is the test, the fix follows. > > Tested on Win

Re: start: correct German translation

2009-04-15 Thread Stefan Leichter
Am Tuesday 14 April 2009 19:43:13 schrieb Dawncrow: > --- > programs/start/De.rc |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Please send patches with your real name. -- Stefan

Re: Fwd: [Wine] The easiest way to convert Mod/Tod video from JVC and any vi

2009-04-15 Thread Austin English
On Wed, Apr 15, 2009 at 3:55 PM, Jeremy Newman wrote: > I changed the text question on the signup page. That should help a little. Thanks! > Where it will not help is mail coming from the mailing list. If you notice a > spam from the list, let me know the email and I will will add that email > a

Re: Fwd: [Wine] The easiest way to convert Mod/Tod video from JVC and any vi

2009-04-15 Thread Jeremy Newman
I changed the text question on the signup page. That should help a little. Where it will not help is mail coming from the mailing list. If you notice a spam from the list, let me know the email and I will will add that email address and/or domain to the blockers list in the mailman mailing lis

Re: do ERR messages imply bugs?

2009-04-15 Thread chris ahrendt
Ben Klein wrote: 2009/4/13 chris ahrendt : Is there a guide documenting what each test is supposed to do etc? Source code. Before you say that's an unacceptable answer, the sheer number of test cases (especially considering those that keep getting added) would make it impractical to t

Re: do ERR messages imply bugs?

2009-04-15 Thread chris ahrendt
An Excellent point was mad in one of the bugs I reported : Comment #25 from Austin English The problem is that this isn't a 'normal' application doing weird things. It's our testsuite, which does some _really_ strange stuff, e.g., lots of corner case testing. Our implementation code, however,

Re: do ERR messages imply bugs?

2009-04-15 Thread chris ahrendt
Ben Klein wrote: 2009/4/13 chris ahrendt : So basically it, in your opinion, comes down to ERR's and the debug output from running tests or anything else should be ignored by anyone but developers? No, that the tests as a WHOLE should be ignored by everyone except developers. Is t

Re: do ERR messages imply bugs?

2009-04-15 Thread chris ahrendt
Ben Klein wrote: 2009/4/13 James McKenzie : Ben Klein wrote: 2009/4/13 chris ahrendt : Vincent Povirk wrote: On Sun, Apr 12, 2009 at 5:24 PM, Ben Klein wrote: 2009/4/13 Vincent Povirk : But the description doesn't say "invalid conditions"

Re: do ERR messages imply bugs?

2009-04-15 Thread chris ahrendt
Vincent Povirk wrote: On Sun, Apr 12, 2009 at 5:24 PM, Ben Klein wrote: 2009/4/13 Vincent Povirk : But the description doesn't say "invalid conditions". It says "serious errors in Wine". That's something that should never happen in tests, as it would imply that the state of the libraries we're

Re: do ERR messages imply bugs?

2009-04-15 Thread chris ahrendt
Vitaliy Margolen wrote: chris ahrendt wrote: 17997 Gecko is installed and reran test... same result... valid bug 17998 is the locking issue... and it occurs not just in the rest but in another application as well.. What errors? What exactly isn't working for you? You have failed to ex

Re: do ERR messages imply bugs?

2009-04-15 Thread chris ahrendt
Vitaliy Margolen wrote: Vincent Povirk wrote: Chris Ahrendt filed a few bugs recently for "err" messages encountered during test runs (17997 and 17998 at least). 17997 is a bogus report - Gecko is not intalled. Nothing actually failed. 17998 is the same. Only I let our resident 3D gur

Fwd: [Wine] The easiest way to convert Mod/Tod video from JVC and any vi

2009-04-15 Thread Austin English
There's been a lot of this spam recently (below). Can you take a look Jeremy? Perhaps banning that IP range if it's in the same block? Thanks! -- -Austin -- Forwarded message -- From: ll0 Date: Wed, Apr 15, 2009 at 3:51 AM Subject: [Wine] The easiest way to convert Mod/Tod v

Re: ntdll: Improve stubs for NtGet/SetInformationToken(TokenDefaultDacl).

2009-04-15 Thread Rob Shearman
2009/4/15 Hans Leidekker : > @@ -441,6 +441,23 @@ NTSTATUS WINAPI NtQueryInformationToken( >         } >         SERVER_END_REQ; >         break; > +    case TokenDefaultDacl: > +        if (tokeninfo) > +        { > +            TOKEN_DEFAULT_DACL *token = (TOKEN_DEFAULT_DACL *)tokeninfo; > +    

Re: try4 [2/3] kernel32: Fix GetVolumeInformation[AW] to require trailing \

2009-04-15 Thread Austin English
On Tue, Apr 14, 2009 at 11:17 PM, Guy Albertelli wrote: > MSDN and test verify the valid "root dirs" for GetVolumeInformation[AW] > must end in trailing '\' and if not then return ERROR_INVALID_NAME > > Changelog >  - Return correct error if GetVolumeInformation[AW] "root dir" does not end > with

Re: Compile error in taskmgr before 1.1.14

2009-04-15 Thread Austin English
On Wed, Apr 15, 2009 at 5:32 AM, David Lee Lambert wrote: > I'm trying to use a git tree to do a regression-test for something that seems > to have gotten broken somewhere between 1.0 and 1.1.19; but when I do a > full "git reset _version_ ; git checkout -f ; ./configure CC='ccache > gcc-3.4' ; ma

Re: gdi32: Don't add duplicate system_links entries

2009-04-15 Thread Paul TBBle Hampson
On Wed, Apr 15, 2009 at 01:59:50PM +0900, Dmitry Timoshkov wrote: > "Paul TBBle Hampson" wrote: > >+/* Make sure we haven't already got an entry for this due to > >substitution */ > >+duplicate = FALSE; > >+LIST_FOR_EACH_ENTRY(system_font_link, &system_links,

Re: msvcrt: Implement ___lc_codepage_func, ___lc_collate_cp_func and ___lc_handle_func.

2009-04-15 Thread Dmitry Timoshkov
"Hans Leidekker" wrote: +/* + * ___lc_handle_func (MSVCRT.@) + */ +HANDLE * ___lc_handle_func(void) +{ +return MSVCRT___lc_handle; +} + +/* + * _

Re: Fixing the last remaining failure on W2K (rpcrt4:server)

2009-04-15 Thread Paul Vriens
Rob Shearman wrote: 2009/4/15 Paul Vriens : In an effort to fix that last failure on my box I found the culprit. I'm not comfortable enough with just excluding (yet another) that test just for the sake of having zero failures though. What exception is being raised? I think perhaps s_context_h

Re: Fixing the last remaining failure on W2K (rpcrt4:server)

2009-04-15 Thread Rob Shearman
2009/4/15 Paul Vriens : > In an effort to fix that last failure on my box I found the culprit. I'm not > comfortable enough with just excluding (yet another) that test just for the > sake of having zero failures though. What exception is being raised? I think perhaps s_context_handle_test should

Re: oleaut32: [Patch 1/2] VarCat must use localized names for VT_BOOL

2009-04-15 Thread Paul Vriens
Detlef Riekenberg wrote: http://test.winehq.org/data/f212579ae9a1b770ebd34cec20f95e1977bb57f0/xp_dr-asus/oleaut32:vartest.html While reading the code for a test failure on all of my Windows installations, the current code was already strange: 5436 ok(hres == VARCMP_EQ || 5437broken(

Re: [5/6] WineD3D: Support the full amount of constants in GLSL

2009-04-15 Thread Henri Verbeet
2009/4/15 Stefan Dösinger : > Am Mittwoch, 15. April 2009 09:36:46 schrieb Henri Verbeet: >> 2009/4/15 Stefan Dösinger : >> > +void record_const_read(DWORD reg, unsigned int *array, int *num) { >> > +    int r; >> > +    BOOL inc = TRUE; >> > +    for(r = 0; r < *num; r++) { >> > +        if(array[

Re: [5/6] WineD3D: Support the full amount of constants in GLSL

2009-04-15 Thread Stefan Dösinger
Am Mittwoch, 15. April 2009 09:36:46 schrieb Henri Verbeet: > 2009/4/15 Stefan Dösinger : > > +void record_const_read(DWORD reg, unsigned int *array, int *num) { > > +int r; > > +BOOL inc = TRUE; > > +for(r = 0; r < *num; r++) { > > +if(array[r] == reg) { > > +inc =

Re: Compile error in taskmgr before 1.1.14

2009-04-15 Thread Ben Klein
2009/4/15 David Lee Lambert : > I'm trying to use a git tree to do a regression-test for something that seems > to have gotten broken somewhere between 1.0 and 1.1.19; but when I do a > full "git reset _version_ ; git checkout -f ; ./configure CC='ccache > gcc-3.4' ; make depend ; make" I get the f

Re: [PATCH 1/2] comctl32/tests: Test expanding of a invisible sub tree.

2009-04-15 Thread Florian Köberle
Nikolay Sivov wrote: > Florian Köberle wrote: >> --- >> dlls/comctl32/tests/treeview.c | 80 >> >> 1 files changed, 80 insertions(+), 0 deletions(-) >> >> diff --git a/dlls/comctl32/tests/treeview.c >> b/dlls/comctl32/tests/treeview.c >> index 5f310b5..7d

Fixing the last remaining failure on W2K (rpcrt4:server)

2009-04-15 Thread Paul Vriens
Hi, In an effort to fix that last failure on my box I found the culprit. I'm not comfortable enough with just excluding (yet another) that test just for the sake of having zero failures though. Any idea? -- Cheers, Paul. diff --git a/dlls/rpcrt4/tests/server.c b/dlls/rpcrt4/tests/server.c i

Compile error in taskmgr before 1.1.14

2009-04-15 Thread David Lee Lambert
I'm trying to use a git tree to do a regression-test for something that seems to have gotten broken somewhere between 1.0 and 1.1.19; but when I do a full "git reset _version_ ; git checkout -f ; ./configure CC='ccache gcc-3.4' ; make depend ; make" I get the following error before about 1.1.14:

Re: [PATCH 1/2] comctl32/tests: Test expanding of a invisible sub tree.

2009-04-15 Thread Nicolas Le Cam
2009/4/15 Florian Köberle : > --- >  dlls/comctl32/tests/treeview.c |   80 > >  1 files changed, 80 insertions(+), 0 deletions(-) > > diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c > index 5f310b5..7d9fcfa 100644 > --- a/dlls/c

Re: [5/6] WineD3D: Support the full amount of constants in GLSL

2009-04-15 Thread Henri Verbeet
2009/4/15 Stefan Dösinger : > +void record_const_read(DWORD reg, unsigned int *array, int *num) { > +int r; > +BOOL inc = TRUE; > +for(r = 0; r < *num; r++) { > +if(array[r] == reg) { > +inc = FALSE; > +break; > +} > +} > + > +if(inc) { >

Winprinfo tool

2009-04-15 Thread Saulius Krasuckas
(Excuse me for the flowed format in my previous msg) I just have struck one tool related to Windows printer drivers [*]: | In the process of developing a Windows printer driver, we created this | winprinfo tool to allow us to query the printer system from the point of | view of an application:

Winprinfo tool

2009-04-15 Thread Saulius Krasuckas
I just have struck one tool related to Windows printer drivers [*]: | In the process of developing a Windows printer driver, we created this | winprinfo tool to allow us to query the printer system from the point of | view of an application: there are several APIs that permit a wide range | of