Re: [mountmgr.sys] add unittests for registry keys of serial ports

2009-04-13 Thread Dmitry Timoshkov
"Stefan Leichter" wrote: [mountmgr.sys] add unittests for registry keys of serial ports The closest match these tests belong to is dlls/kernel32/tests/comm.c Is there any app that checks for a registry key instead of using an API? -- Dmitry.

Re: do ERR messages imply bugs?

2009-04-13 Thread Vitaliy Margolen
James McKenzie wrote: > We are not 'wasting time.' This issue needs to be addressed by the > development community so that errors, warnings and fixmes are properly > reported. This is semantics. FIXME/WARN/ERR - who cares? They are all just hints if something goes wrong where to look. Each develo

Re: tools/wine.inf: create Microsoft Shared/TextConv directory

2009-04-13 Thread Austin English
On Sun, Mar 22, 2009 at 11:40 AM, Austin English wrote: > Needed by a few different installers. Now comes by default in XP SP3 > and up (verified name on a German locale, doesn't seem to be English > specific). > > Fixes bug 17257. > > -- > -Austin > Anything wrong with this one? -- -Austin

Re: [1/1]msctf/test: test Enableing and Disabling Language Profiles

2009-04-13 Thread Detlef Riekenberg
On Fr, 2009-04-10 at 07:55 -0500, Aric Stewart wrote: > +static void test_Disable(void) ... > +trace("Disabling\n"); ... > +ok(SUCCEEDED(hr),"Failed to enable text service\n"); With greetings from Copy & Paste -- By by ... Detlef

Re: do ERR messages imply bugs?

2009-04-13 Thread Ben Klein
2009/4/13 chris ahrendt : > Ben Klein wrote: >> Most users DON'T RUN THE TEST SUITE. It's not useful for users, it's >> ONLY useful for developers, and developers know how to interpret these >> ERRs correctly. You don't. >> > > Thanks for the attack ben... again you miss the point.. alot more users

Re: [1/5] resend include: bring in6_addr into line with the MS definition

2009-04-13 Thread Jeff Latimer
Alexandre Julliard wrote: You need the WS prefix on all definitions that can potentially conflict with Unix. Fixed it up and resubmitted.

Re: do ERR messages imply bugs?

2009-04-13 Thread Ben Klein
2009/4/13 chris ahrendt : > Is there a guide documenting what each test is supposed to do etc? Source code. Before you say that's an unacceptable answer, the sheer number of test cases (especially considering those that keep getting added) would make it impractical to the point of impossibility t

Re: do ERR messages imply bugs?

2009-04-13 Thread Ben Klein
2009/4/13 chris ahrendt : > So basically it, in your opinion, comes down to ERR's and the debug output > from running > tests or anything else should be ignored by anyone but developers? No, that the tests as a WHOLE should be ignored by everyone except developers. > That does not make any sense.

Re: do ERR messages imply bugs?

2009-04-13 Thread Ben Klein
2009/4/13 James McKenzie : > Ben Klein wrote: >> 2009/4/13 chris ahrendt : >> >>> Vincent Povirk wrote: >>> On Sun, Apr 12, 2009 at 5:24 PM, Ben Klein wrote: > 2009/4/13 Vincent Povirk : > >> But the description doesn't say "invalid conditions". It says "serious >> errors