Hi Hans,
Your patch makes the test timeout on my machine
(http://test.winehq.org/data/f212579ae9a1b770ebd34cec20f95e1977bb57f0/2000_w2k-sp4-fr/wininet:http.html).
Timeout occurs in HttpSendRequestEx_test on HttpEndRequest call which
hang. Disabling test_async_HttpSendRequestEx makes it pass again
On Fri, 2009-04-10 at 08:31 +0200, Paul Vriens wrote:
> Guy Albertelli wrote:
> > Enhance QueryDosDevice test for attempting to return all devices.
> > Add tests for GetVolumeInformationA testing the different root dir formats.
> > ---
> > dlls/kernel32/tests/volume.c | 134
> > +
2009/4/11 Ben Klein :
> 2009/4/11 Nicolas Le Cam :
>> 2009/4/11 James Hawkins :
>> Let met explain :
>>
>> Running test on wine in folder C:\test : works (expected "C:\test" got
>> "C:\test")
>> Running test on wine in folder C:\ : works (expected "C:\" got "C:\")
>> Running test on wine in folder
2009/4/11 Nicolas Le Cam :
> 2009/4/11 James Hawkins :
> Let met explain :
>
> Running test on wine in folder C:\test : works (expected "C:\test" got
> "C:\test")
> Running test on wine in folder C:\ : works (expected "C:\" got "C:\")
> Running test on wine in folder
> Z:\home\nlecam\Projects\wine\
2009/4/11 James Hawkins :
> On Fri, Apr 10, 2009 at 2:36 PM, Nicolas Le Cam wrote:
>> 2009/4/10, James Hawkins :
>>> On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam
>>> wrote:
Try2: This time with the patch.
Tested on Win2k/WinXP. Marked two tests as todo_wine.
>>>
>>> I was s
On Fri, Apr 10, 2009 at 2:36 PM, Nicolas Le Cam wrote:
> 2009/4/10, James Hawkins :
>> On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam
>> wrote:
>>> Try2: This time with the patch.
>>>
>>> Tested on Win2k/WinXP. Marked two tests as todo_wine.
>>>
>>
>> I was serious before. You can't change the
2009/4/11 Warren Dumortier :
> 2009/4/10 Ben Klein :
>> 2009/4/9 EA Durbin :
>>> After all we don't want to vastly increase our potential customer base and
>>> potentially get several $70 per crossover professional license or $40 per
>>> standard license fees, but rather wait until someone writes a
On Fri, Apr 10, 2009 at 4:30 PM, Warren Dumortier wrote:
> 2009/4/10 Ben Klein :
>> 2009/4/9 EA Durbin :
>>> After all we don't want to vastly increase our potential customer base and
>>> potentially get several $70 per crossover professional license or $40 per
>>> standard license fees, but rathe
2009/4/10 Ben Klein :
> 2009/4/9 EA Durbin :
>> After all we don't want to vastly increase our potential customer base and
>> potentially get several $70 per crossover professional license or $40 per
>> standard license fees, but rather wait until someone writes a hefty check to
>> port it up front
2009/4/10, James Hawkins :
> On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam
> wrote:
>> Try2: This time with the patch.
>>
>> Tested on Win2k/WinXP. Marked two tests as todo_wine.
>>
>
> I was serious before. You can't change the old tests. Please add new
> tests for the exposed bugs. Same goe
On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam wrote:
> Try2: This time with the patch.
>
> Tested on Win2k/WinXP. Marked two tests as todo_wine.
>
I was serious before. You can't change the old tests. Please add new
tests for the exposed bugs. Same goes for patch 3/4.
--
James Hawkins
"Igor Tarasov" wrote:
So, does that mean that I have to add new flag to the structure that
would be set only if that field is changed, or there is another way to
do that?
First thing to do (as usually) is write a bunch of tests and get them
committed.
--
Dmitry.
2009/4/8 Vincent Povirk :
> This should fix bug 15789.
>
> Stefan tells me that we're supposed to update the screen when the front
> buffer is unlocked, as that means it could have changed. Instead, we do it
> when any buffer in the swapchain is unlocked. This makes for a lot of
> unnecessary co
I had a patch that did this, it never got through. Let me see if i can
polish it off and make it acceptable.
-aric
Alexandre Julliard wrote:
Hans Leidekker writes:
@@ -546,6 +546,7 @@ HKLM,System\CurrentControlSet\Control\Session Manager,,,""
HKLM,System\CurrentControlSet\Control\VMM32Fi
Hans Leidekker writes:
> @@ -546,6 +546,7 @@ HKLM,System\CurrentControlSet\Control\Session Manager,,,""
> HKLM,System\CurrentControlSet\Control\VMM32Files,,,""
> HKCU,Software\Microsoft\Protected Storage System Provider,,,""
>
> HKCU,Software\Wine\MSHTML,"GeckoUrl",,"http://source.winehq.org/
2009/4/10 Alexandre Julliard :
> Nicolas Le Cam writes:
>
>> @@ -2308,7 +2308,7 @@ static void test_setpropertyfolder(void)
>>
>> r = MsiInstallProductA(msifile, NULL);
>> ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r);
>> - if (GetFileAttributesA(path) == FILE_ATTRIBUT
2009/4/10 James Hawkins :
> On Thu, Apr 9, 2009 at 7:43 PM, Nicolas Le Cam wrote:
>> Try2: This time with the patch.
>>
>> Tested on Win2k/WinXP. Marked two tests as todo_wine.
>>
>
> If you're having to add todo_wine, then you're changing the current
> tests, which is bad if all you're trying to
2009/4/10 Nikolay Sivov :
> So (-1) for iButton is reserved for not using imagelist bitmap at all and in
> some places this value checked for <0 instead of
> == -1, right? Does it apply for separators only?
Yes, separators only. If you set it to ANYTHING (even 0 and -1) it
affects the way toolbar
Am Freitag, 10. April 2009 11:52:31 schrieb Henri Verbeet:
> 2009/4/9 Stefan Dösinger :
> > if(pshader) {
> > -max_constantsF = GL_LIMITS(pshader_constantsF) -
> > (MAX_CONST_B / 4) - MAX_CONST_I - 2; -max_constantsF =
> > min(This->baseShader.limits.constant_float,
Igor Tarasov wrote:
2009/4/10 Nikolay Sivov :
Igor Tarasov wrote:
Hi there!
I try to implement as precise as possible one undocumented feature in
comctl32, this all deals with one structure field. After lots of
testing I know the following:
1. Default value for that field returned by
2009/4/9 Stefan Dösinger :
> if(pshader) {
> -max_constantsF = GL_LIMITS(pshader_constantsF) - (MAX_CONST_B /
> 4) - MAX_CONST_I - 2;
> -max_constantsF = min(This->baseShader.limits.constant_float,
> max_constantsF);
> +/* No indirect addressing here *
At 05.04.2009 23:54, James McKenzie wrote:
Hans Breuer wrote:
From b89af7d06fc8cbf5210c61fd58ed62caeddad968 Mon Sep 17 00:00:00 2001
From: Hans Breuer
Date: Sun, 29 Mar 2009 18:27:29 +0200
Subject: implement PS_USERSTYLE handling, tested with Dia(win32) - see
http://hans.breuer.org/dia/dia-win
Hi Daminan,
thanks for looking into this.
At 06.04.2009 15:03, Damian Dixon wrote:
Hi Hans,
I have run the patch against my application and the line-styles draw as far
as I can tell are the same as on Windows when a single line segment where
the pixel width of one is used.
However when a polyli
2009/4/10 Nikolay Sivov :
> Igor Tarasov wrote:
>>
>> Hi there!
>>
>> I try to implement as precise as possible one undocumented feature in
>> comctl32, this all deals with one structure field. After lots of
>> testing I know the following:
>>
>> 1. Default value for that field returned by getter i
Igor Tarasov wrote:
Hi there!
I try to implement as precise as possible one undocumented feature in
comctl32, this all deals with one structure field. After lots of
testing I know the following:
1. Default value for that field returned by getter is 0.
2. By default it is ignored in behavior.
3.
Nicolas Le Cam writes:
> @@ -2308,7 +2308,7 @@ static void test_setpropertyfolder(void)
>
> r = MsiInstallProductA(msifile, NULL);
> ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r);
> -if (GetFileAttributesA(path) == FILE_ATTRIBUTE_DIRECTORY)
> +if (GetFileAttrib
Hi there!
I try to implement as precise as possible one undocumented feature in
comctl32, this all deals with one structure field. After lots of
testing I know the following:
1. Default value for that field returned by getter is 0.
2. By default it is ignored in behavior.
3. If you change value b
2009/4/9 Stefan Dösinger :
> +unsigned max_constantsF;
This is valid C, of course, but would the extra 4 characters for "int
" really hurt?
2009/4/9 Stefan Dösinger :
> Please do not apply this patch without patches 5, 6, 7 and 8. In some
> circumstances, this patch can step on the toes of inefficient MacOS drivers
> or old fglrx versions. The additional patches give wined3d knowledge of these
> driver problems to prevent this.
>
If th
There are a couple of things I don't like about this patch.
- I don't like how much information specific to constant fixups the
table contains.
- The "apple" field is weird. If you're going to have a callback
function you might as well match that information there, if
appropriate. On the other hand
30 matches
Mail list logo
