Re: [PATCH 00/10] Support for dumb picture keychain

2009-03-27 Thread Guy Albertelli
On Thu, 2009-03-26 at 10:08 +0100, Alexandre Julliard wrote: > Guy Albertelli writes: > > > 1. The initial problem was that the CreateFile above would not > > successfully translate the volume id to the associated Unix file. #3/10 > > fixed that. > > That should go in mountmgr, it already creat

Re: [1/5] resend include: bring in6_addr into line with the MS definition

2009-03-27 Thread Jeff Latimer
Alexandre Julliard wrote: Jeff Latimer writes: diff --git a/include/ws2tcpip.h b/include/ws2tcpip.h index a38ccda..9ddb3d1 100644 --- a/include/ws2tcpip.h +++ b/include/ws2tcpip.h @@ -85,26 +85,41 @@ struct WS(ip_msfilter) { struct WS(in_addr) imsf_slist[1]; }; -typedef struct WS(in

Re: comctl32: Fix bitmap size calculation

2009-03-27 Thread Aleksey Bragin
On Mar 27, 2009, at 6:47 PM, Vitaliy Margolen wrote: Anyway, e.g. Sib Icon Edit required ~ 30 Mb (something like 27 images * 13440 width * 24 height * sizeof(each pixel)) of memory for every instance to run (due to this bug). Now it requires only about 300kb Fixing one app doesn't mean it'

Re: comctl32: Fix bitmap size calculation

2009-03-27 Thread Aleksey Bragin
On Mar 27, 2009, at 3:39 AM, Vitaliy Margolen wrote: Aleksey Bragin wrote: Fix bitmap size calculation in IMAGELIST_InternalExpandBitmaps and remove unneded parameter. Memory requirements are greatly reduced after this fix. The bug was an ambiguous meaning of a cx parameter, which was sup

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A

2009-03-27 Thread Paul Vriens
Andreas Rosenberg wrote: There is no need for that GetVersionExA call/test. Just do an if (0) and leave that comment about NT4 crashing in. -- Cheers, Paul.

Re: X11DRV_AlphaBlend: FIXME not a DIB section

2009-03-27 Thread Aric Stewart
Hi there, As the author of one of the patches that was not approved, Alexandre told me that he felt that the whole X11DRV_AlphaBlend needed to be rewritten, maybe not even found in that module. If i recall correctly there was worries about how it was starting to duplicate code from the DIB

Re: comctl32: Fix bitmap size calculation

2009-03-27 Thread Mikołaj Zalewski
Anyway, e.g. Sib Icon Edit required ~ 30 Mb (something like 27 images * 13440 width * 24 height * sizeof(each pixel)) of memory for every instance to run (due to this bug). Now it requires only about 300kb Fixing one app doesn't mean it's correct. Yes, there is an obvious error in the ima

X11DRV_AlphaBlend: FIXME not a DIB section

2009-03-27 Thread Damian Dixon
Hi, I'm trying to get an application running as best as possible under Wine and have found that X11DRV_AlphaBlend does not handle Bitmaps which are not a DIB Section. I have also found that a number of people have submitted some fixes to X11DRV_AlphaBlend: 1. http://www.nabble.com/(re-resend)-x1

Re: comctl32: Fix bitmap size calculation

2009-03-27 Thread Vitaliy Margolen
Aleksey Bragin wrote: > On Mar 27, 2009, at 3:39 AM, Vitaliy Margolen wrote: > Yes exactly, however I didn't provide any testcase, because I just > removed non-used parameter and fixed existing code. If someone wants to > implement image list having variable width of each image - he's free to > pro

shell32: Implement IDD_MAKENEWFOLDER

2009-03-27 Thread Jonathan Armond
Hi This implements the make new folder button for the SHBrowseForFolders dialog. It's my first patch, so I'm asking for comments. Note, renaming of the new folder is still not supported. Jon --- dlls/shell32/brsfolder.c | 46 +++--- 1 files changed,

Re: [2/11] wined3d: Create a separate function for checking a format's FBO compatibility.

2009-03-27 Thread Henri Verbeet
2009/3/27 Allan Tong : >> +            if (check_fbo_compat(gl_info, >> gl_formats_template[src].glInternal)) >> +            { >> +                TRACE("Internal format of %s not supported as FBO target, >> using render target internal instead\n", >> +                        debug_d3dformat(gl_

Re: [2/11] wined3d: Create a separate function for checking a format's FBO compatibility.

2009-03-27 Thread Allan Tong
> +            if (check_fbo_compat(gl_info, > gl_formats_template[src].glInternal)) > +            { > +                TRACE("Internal format of %s not supported as FBO target, > using render target internal instead\n", > +                        debug_d3dformat(gl_formats_template[src].fmt));

Re: [10/10] bcrypt: Add a mostly empty bcrypt.dll.

2009-03-27 Thread Alexandre Julliard
Henri Verbeet writes: > diff --git a/dlls/bcrypt/bcrypt.spec b/dlls/bcrypt/bcrypt.spec > new file mode 100644 > index 000..e69de29 Please add stubs for the exported functions. -- Alexandre Julliard julli...@winehq.org

Re: DxDiag Demo Patch

2009-03-27 Thread Henri Verbeet
2009/3/25 Allen Hair : > Attached is a patch that will add our code to the source tree. This > patch is not meant to be > committed, but should provide a demonstration of the application so > far. Any feedback would be > appreciated, I will try to incorporate any suggestions as I work on > releasin

Re: libwine: Only partially reserve memory beyond 0x80000000 on FreeBSD.

2009-03-27 Thread Alexandre Julliard
Tijl Coosemans writes: > On Tuesday 24 March 2009 12:36:05 Francois Gouget wrote: >> Tijl Coosemans a écrit : >> [...] >>> Wine wants to allocate a few things in reserved areas, and because >>> there were no reserved areas at all on FreeBSD it failed. That's bug >>> 16023. My patch leaves enough

Re: libwine: Only partially reserve memory beyond 0x80000000 on FreeBSD.

2009-03-27 Thread Tijl Coosemans
On Tuesday 24 March 2009 12:36:05 Francois Gouget wrote: > Tijl Coosemans a écrit : > [...] >> Wine wants to allocate a few things in reserved areas, and because >> there were no reserved areas at all on FreeBSD it failed. That's bug >> 16023. My patch leaves enough reserved area for Wine to alloca

how/where to implement case-insensitive fourcc check?

2009-03-27 Thread Joerg-Cyril.Hoehle
Hi, I'm looking for advice about how to properly implement the case-insensitive fourcc check of video formats required by the conformance test msvfw32, i.e. how to eliminate the 2 todo_wine in http://test.winehq.org/data/tests/msvfw32:msvfw.html This would allow the AppDB rating of the applicatio

google summer of code applicant

2009-03-27 Thread wwinthan
hi i'm Win Than Aung from Purdue university. I have found your project listed on google summer of code website. I would like to ask for a chance to present myself. would you please tell me to whom should i contact for further information? PS: i have been full-time interning at the local companies